====== Checking before the patch ====== ====== Checking the tree with the patch ====== tools/testing/selftests/drivers/net/netcons_race_userdata.sh is a new file, but not shellcheck compliant New errors added --- /tmp/tmp.FTnMEmY1RL 2025-10-20 15:09:50.185035693 -0700 +++ /tmp/tmp.ha9ssg4PHU 2025-10-20 15:09:51.195026883 -0700 @@ -0,0 +1,62 @@ + +In netcons_race_userdata.sh line 38: + kill $child1 $child2 2> /dev/null || true + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + kill "$child1" "$child2" 2> /dev/null || true + + +In netcons_race_userdata.sh line 39: + wait $child1 $child2 2> /dev/null || true + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + wait "$child1" "$child2" 2> /dev/null || true + + +In netcons_race_userdata.sh line 54: +set_network +^---------^ SC2119 (info): Use set_network "$@" if function's $1 should mean script's $1. + + +In netcons_race_userdata.sh line 56: +create_dynamic_target +^-------------------^ SC2119 (info): Use create_dynamic_target "$@" if function's $1 should mean script's $1. + + +In netcons_race_userdata.sh line 71: +while read line; do + ^--^ SC2162 (info): read without -r will mangle backslashes. + + +In netcons_race_userdata.sh line 74: + exit ${ksft_pass} + ^----------^ SC2154 (warning): ksft_pass is referenced but not assigned. + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + exit "${ksft_pass}" + + +In netcons_race_userdata.sh line 80: + exit ${ksft_fail} + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + exit "${ksft_fail}" + + +In netcons_race_userdata.sh line 87: +exit ${ksft_skip} + ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: +exit "${ksft_skip}" + +For more information: + https://www.shellcheck.net/wiki/SC2154 -- ksft_pass is referenced but not a... + https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... + https://www.shellcheck.net/wiki/SC2119 -- Use create_dynamic_target "$@" if...