WARNING: Consider removing the code enclosed by this #if 0 and its #endif #59: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:19: +#if 0 WARNING: line length of 82 exceeds 80 columns #60: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:20: +static void __test_run(struct bpf_program *prog, void *ctx_in, size_t ctx_size_in) CHECK: Alignment should match open parenthesis #63: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:23: + LIBBPF_OPTS(bpf_test_run_opts, topts, + .ctx_in = ctx_in, WARNING: line length of 86 exceeds 80 columns #101: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:61: +/* validate that for two loads of the same jump table libbpf generates only one map */ WARNING: line length of 86 exceeds 80 columns #139: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:99: + if (!ASSERT_EQ(seen, false, "more than one INSN_ARRAY map")) { ERROR: space prohibited before that ',' (ctx:WxW) #160: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:120: + __u64 out4[] = {12, 15, 7 , 15, 12, 15, 15}; ^ ERROR: trailing statements should be on next line #171: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:131: + if (0) for (i = 0; i < ARRAY_SIZE(in); i++) ERROR: trailing statements should be on next line #174: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:134: + if (0) for (i = 0; i < ARRAY_SIZE(in); i++) WARNING: line length of 83 exceeds 80 columns #175: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:135: + check_simple(skel, skel->progs.one_jump_two_maps, in4[i], out4[i]); WARNING: line length of 82 exceeds 80 columns #178: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:138: + check_simple(skel, skel->progs.use_static_global1, in[i], out[i]); WARNING: line length of 82 exceeds 80 columns #181: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:141: + check_simple(skel, skel->progs.use_static_global2, in[i], out[i]); WARNING: line length of 85 exceeds 80 columns #184: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:144: + check_simple(skel, skel->progs.use_nonstatic_global1, in[i], out[i]); WARNING: line length of 85 exceeds 80 columns #187: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:147: + check_simple(skel, skel->progs.use_nonstatic_global2, in[i], out[i]); WARNING: line length of 92 exceeds 80 columns #191: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:151: + check_simple_fentry(skel, skel->progs.simple_test_other_sec, in[i], out[i]); WARNING: line length of 98 exceeds 80 columns #195: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:155: + check_simple_fentry(skel, skel->progs.use_static_global_other_sec, in[i], out[i]); WARNING: line length of 101 exceeds 80 columns #199: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:159: + check_simple_fentry(skel, skel->progs.use_nonstatic_global_other_sec, in[i], out[i]); ERROR: trailing statements should be on next line #201: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:161: + if (0) check_one_map_two_jumps(skel); WARNING: Consider removing the code enclosed by this #if 0 and its #endif #241: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:10: +#if 0 WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #423: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:192: +int big_jump_table(struct simple_ctx *ctx __attribute__((unused))) WARNING: Consider removing the code enclosed by this #if 0 and its #endif #425: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:194: +#if 0 WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #466: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:235: +int one_jump_two_maps(struct simple_ctx *ctx __attribute__((unused))) WARNING: Consider removing the code enclosed by this #if 0 and its #endif #468: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:237: +#if 0 WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #474: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:243: + volatile int ret = 0; WARNING: labels should not be indented #484: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:253: + l1: ret += 1; WARNING: labels should not be indented #485: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:254: + l2: ret += 3; WARNING: labels should not be indented #486: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:255: + l3: ret += 5; WARNING: labels should not be indented #487: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:256: + l4: ret += 7; WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #497: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:266: +int one_map_two_jumps(struct simple_ctx *ctx __attribute__((unused))) WARNING: Consider removing the code enclosed by this #if 0 and its #endif #499: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:268: +#if 0 WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #504: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:273: + volatile int ret = 0; WARNING: labels should not be indented #512: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:281: + l1: ret += 3; WARNING: labels should not be indented #513: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:282: + l2: ret += 5; WARNING: labels should not be indented #514: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:283: + l3: ret += 7; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #524: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:293: +static __noinline int f0(volatile struct simple_ctx *ctx __arg_ctx) total: 4 errors, 29 warnings, 1 checks, 609 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit befa6bd3095c ("selftests/bpf: add C-level selftests for indirect jumps") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.