WARNING: Argument 'SRC_REG' is not used in function-like macro #53: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:11: +#define DEFINE_SIMPLE_JUMP_TABLE_PROG(NAME, SRC_REG, OFF, IMM, OUTCOME) \ + \ + SEC("socket") \ + OUTCOME \ + __naked void jump_table_ ## NAME(void) \ + { \ + asm volatile (" \ WARNING: Argument 'OFF' is not used in function-like macro #53: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:11: +#define DEFINE_SIMPLE_JUMP_TABLE_PROG(NAME, SRC_REG, OFF, IMM, OUTCOME) \ + \ + SEC("socket") \ + OUTCOME \ + __naked void jump_table_ ## NAME(void) \ + { \ + asm volatile (" \ WARNING: Argument 'IMM' is not used in function-like macro #53: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:11: +#define DEFINE_SIMPLE_JUMP_TABLE_PROG(NAME, SRC_REG, OFF, IMM, OUTCOME) \ + \ + SEC("socket") \ + OUTCOME \ + __naked void jump_table_ ## NAME(void) \ + { \ + asm volatile (" \ WARNING: Avoid line continuations in quoted strings #59: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:17: + asm volatile (" \ WARNING: Avoid unnecessary line continuations #78: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:36: + " : \ WARNING: Avoid line continuations in quoted strings #78: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:36: + " : \ WARNING: line length of 117 exceeds 80 columns #79: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:37: + : __imm_insn(gotox_r0, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_0, (SRC_REG), (OFF) , (IMM))) \ ERROR: space prohibited before that ',' (ctx:WxW) #79: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:37: + : __imm_insn(gotox_r0, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_0, (SRC_REG), (OFF) , (IMM))) \ ^ WARNING: line length of 98 exceeds 80 columns #87: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:45: +DEFINE_SIMPLE_JUMP_TABLE_PROG(ok, BPF_REG_0, 0, 0, __success __retval(1)) WARNING: line length of 129 exceeds 80 columns #88: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:46: +DEFINE_SIMPLE_JUMP_TABLE_PROG(reserved_field_src_reg, BPF_REG_1, 0, 0, __failure __msg("BPF_JA|BPF_X uses reserved fields")) WARNING: line length of 129 exceeds 80 columns #89: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:47: +DEFINE_SIMPLE_JUMP_TABLE_PROG(reserved_field_non_zero_off, BPF_REG_0, 1, 0, __failure __msg("BPF_JA|BPF_X uses reserved fields")) WARNING: line length of 129 exceeds 80 columns #90: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:48: +DEFINE_SIMPLE_JUMP_TABLE_PROG(reserved_field_non_zero_imm, BPF_REG_0, 0, 1, __failure __msg("BPF_JA|BPF_X uses reserved fields")) WARNING: Avoid line continuations in quoted strings #100: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:58: + asm volatile (" \ WARNING: Avoid unnecessary line continuations #104: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:62: +" : \ WARNING: Avoid line continuations in quoted strings #104: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:62: +" : \ WARNING: line length of 91 exceeds 80 columns #105: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:63: + : __imm_insn(gotox_r0, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_0, 0, 0 , 0)) ERROR: space prohibited before that ',' (ctx:WxW) #105: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:63: + : __imm_insn(gotox_r0, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_0, 0, 0 , 0)) ^ WARNING: Avoid line continuations in quoted strings #116: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:74: + asm volatile (" \ WARNING: Avoid unnecessary line continuations #136: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:94: +" : \ WARNING: Avoid line continuations in quoted strings #136: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:94: +" : \ WARNING: line length of 91 exceeds 80 columns #137: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:95: + : __imm_insn(gotox_r1, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_1, 0, 0 , 0)) ERROR: space prohibited before that ',' (ctx:WxW) #137: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:95: + : __imm_insn(gotox_r1, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_1, 0, 0 , 0)) ^ WARNING: Avoid line continuations in quoted strings #147: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:105: + asm volatile (" \ WARNING: Avoid unnecessary line continuations #166: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:124: + " : \ WARNING: Avoid line continuations in quoted strings #166: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:124: + " : \ WARNING: line length of 101 exceeds 80 columns #167: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:125: + : __imm_insn(gotox_r0, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_0, 0, 0 , 0)) \ ERROR: space prohibited before that ',' (ctx:WxW) #167: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:125: + : __imm_insn(gotox_r0, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_0, 0, 0 , 0)) \ ^ WARNING: line length of 89 exceeds 80 columns #171: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:129: +DEFINE_INVALID_SIZE_PROG(u32, __failure __msg("Invalid read of 4 bytes from insn_array")) WARNING: line length of 89 exceeds 80 columns #172: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:130: +DEFINE_INVALID_SIZE_PROG(u16, __failure __msg("Invalid read of 2 bytes from insn_array")) WARNING: line length of 89 exceeds 80 columns #173: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:131: +DEFINE_INVALID_SIZE_PROG(u8, __failure __msg("Invalid read of 1 bytes from insn_array")) WARNING: Avoid line continuations in quoted strings #179: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:137: + asm volatile (" \ WARNING: Avoid unnecessary line continuations #198: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:156: +" : \ WARNING: Avoid line continuations in quoted strings #198: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:156: +" : \ WARNING: line length of 91 exceeds 80 columns #199: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:157: + : __imm_insn(gotox_r0, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_0, 0, 0 , 0)) ERROR: space prohibited before that ',' (ctx:WxW) #199: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:157: + : __imm_insn(gotox_r0, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_0, 0, 0 , 0)) ^ WARNING: Avoid line continuations in quoted strings #207: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:165: + asm volatile (" \ WARNING: Avoid unnecessary line continuations #226: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:184: +" : \ WARNING: Avoid line continuations in quoted strings #226: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:184: +" : \ WARNING: line length of 91 exceeds 80 columns #227: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:185: + : __imm_insn(gotox_r0, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_0, 0, 0 , 0)) ERROR: space prohibited before that ',' (ctx:WxW) #227: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:185: + : __imm_insn(gotox_r0, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_0, 0, 0 , 0)) ^ WARNING: Avoid line continuations in quoted strings #235: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:193: + asm volatile (" \ WARNING: Avoid unnecessary line continuations #254: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:212: +" : \ WARNING: Avoid line continuations in quoted strings #254: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:212: +" : \ WARNING: line length of 91 exceeds 80 columns #255: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:213: + : __imm_insn(gotox_r0, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_0, 0, 0 , 0)) ERROR: space prohibited before that ',' (ctx:WxW) #255: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:213: + : __imm_insn(gotox_r0, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_0, 0, 0 , 0)) ^ WARNING: Avoid line continuations in quoted strings #263: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:221: + asm volatile (" \ WARNING: Avoid unnecessary line continuations #283: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:241: +" : \ WARNING: Avoid line continuations in quoted strings #283: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:241: +" : \ WARNING: line length of 91 exceeds 80 columns #284: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:242: + : __imm_insn(gotox_r0, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_0, 0, 0 , 0)) ERROR: space prohibited before that ',' (ctx:WxW) #284: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:242: + : __imm_insn(gotox_r0, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_0, 0, 0 , 0)) ^ WARNING: Avoid line continuations in quoted strings #292: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:250: + asm volatile (" \ WARNING: Avoid unnecessary line continuations #312: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:270: +" : \ WARNING: Avoid line continuations in quoted strings #312: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:270: +" : \ WARNING: line length of 91 exceeds 80 columns #313: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:271: + : __imm_insn(gotox_r0, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_0, 0, 0 , 0)) ERROR: space prohibited before that ',' (ctx:WxW) #313: FILE: tools/testing/selftests/bpf/progs/verifier_gotox.c:271: + : __imm_insn(gotox_r0, BPF_RAW_INSN(BPF_JMP | BPF_JA | BPF_X, BPF_REG_0, 0, 0 , 0)) ^ total: 9 errors, 46 warnings, 0 checks, 291 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit ee7d9c9ee73b ("selftests/bpf: add new verifier_gotox test") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.