ShellCheck - shell script analysis tool version: 0.10.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.JMiaAZxNFV and /tmp/tmp.C7em1XU5oo Tree base: 7f864458e9a6 ("net: stmmac: dwmac-rk: Fix disabling set_clock_selection") Now at: 4867763a8c68 ("selftests: net: fix server bind failure in sctp_vrf.sh") ====== Checking before the patch ====== Checking tools/testing/selftests/net/sctp_vrf.sh - 26eb6cbdf0bcf0a9e136aca301140628a0ae8a0dd567cf7540f654bef7b73c4a In sctp_vrf.sh line 23: ip net exec $CLIENT_NS1 sysctl -w net.ipv6.conf.default.accept_dad=0 2>&1 >/dev/null ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2153 (info): Possible misspelling: CLIENT_NS1 may not be assigned. Did you mean CLIENT_NS? ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). Did you mean: ip net exec "$CLIENT_NS1" sysctl -w net.ipv6.conf.default.accept_dad=0 2>&1 >/dev/null In sctp_vrf.sh line 24: ip net exec $CLIENT_NS2 sysctl -w net.ipv6.conf.default.accept_dad=0 2>&1 >/dev/null ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2153 (info): Possible misspelling: CLIENT_NS2 may not be assigned. Did you mean CLIENT_NS? ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). Did you mean: ip net exec "$CLIENT_NS2" sysctl -w net.ipv6.conf.default.accept_dad=0 2>&1 >/dev/null In sctp_vrf.sh line 25: ip net exec $SERVER_NS sysctl -w net.ipv6.conf.default.accept_dad=0 2>&1 >/dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). Did you mean: ip net exec "$SERVER_NS" sysctl -w net.ipv6.conf.default.accept_dad=0 2>&1 >/dev/null In sctp_vrf.sh line 27: ip -n $SERVER_NS link add veth1 type veth peer name veth1 netns $CLIENT_NS1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link add veth1 type veth peer name veth1 netns "$CLIENT_NS1" In sctp_vrf.sh line 28: ip -n $SERVER_NS link add veth2 type veth peer name veth1 netns $CLIENT_NS2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link add veth2 type veth peer name veth1 netns "$CLIENT_NS2" In sctp_vrf.sh line 30: ip -n $CLIENT_NS1 link set veth1 up ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$CLIENT_NS1" link set veth1 up In sctp_vrf.sh line 31: ip -n $CLIENT_NS1 addr add $CLIENT_IP4/24 dev veth1 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$CLIENT_NS1" addr add $CLIENT_IP4/24 dev veth1 In sctp_vrf.sh line 32: ip -n $CLIENT_NS1 addr add $CLIENT_IP6/24 dev veth1 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$CLIENT_NS1" addr add $CLIENT_IP6/24 dev veth1 In sctp_vrf.sh line 34: ip -n $CLIENT_NS2 link set veth1 up ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$CLIENT_NS2" link set veth1 up In sctp_vrf.sh line 35: ip -n $CLIENT_NS2 addr add $CLIENT_IP4/24 dev veth1 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$CLIENT_NS2" addr add $CLIENT_IP4/24 dev veth1 In sctp_vrf.sh line 36: ip -n $CLIENT_NS2 addr add $CLIENT_IP6/24 dev veth1 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$CLIENT_NS2" addr add $CLIENT_IP6/24 dev veth1 In sctp_vrf.sh line 38: ip -n $SERVER_NS link add dummy1 type dummy ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link add dummy1 type dummy In sctp_vrf.sh line 39: ip -n $SERVER_NS link set dummy1 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link set dummy1 up In sctp_vrf.sh line 40: ip -n $SERVER_NS link add vrf-1 type vrf table 10 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link add vrf-1 type vrf table 10 In sctp_vrf.sh line 41: ip -n $SERVER_NS link add vrf-2 type vrf table 20 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link add vrf-2 type vrf table 20 In sctp_vrf.sh line 42: ip -n $SERVER_NS link set vrf-1 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link set vrf-1 up In sctp_vrf.sh line 43: ip -n $SERVER_NS link set vrf-2 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link set vrf-2 up In sctp_vrf.sh line 44: ip -n $SERVER_NS link set veth1 master vrf-1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link set veth1 master vrf-1 In sctp_vrf.sh line 45: ip -n $SERVER_NS link set veth2 master vrf-2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link set veth2 master vrf-2 In sctp_vrf.sh line 47: ip -n $SERVER_NS addr add $SERVER_IP4/24 dev dummy1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" addr add $SERVER_IP4/24 dev dummy1 In sctp_vrf.sh line 48: ip -n $SERVER_NS addr add $SERVER_IP4/24 dev veth1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" addr add $SERVER_IP4/24 dev veth1 In sctp_vrf.sh line 49: ip -n $SERVER_NS addr add $SERVER_IP4/24 dev veth2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" addr add $SERVER_IP4/24 dev veth2 In sctp_vrf.sh line 50: ip -n $SERVER_NS addr add $SERVER_IP6/24 dev dummy1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" addr add $SERVER_IP6/24 dev dummy1 In sctp_vrf.sh line 51: ip -n $SERVER_NS addr add $SERVER_IP6/24 dev veth1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" addr add $SERVER_IP6/24 dev veth1 In sctp_vrf.sh line 52: ip -n $SERVER_NS addr add $SERVER_IP6/24 dev veth2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" addr add $SERVER_IP6/24 dev veth2 In sctp_vrf.sh line 54: ip -n $SERVER_NS link set veth1 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link set veth1 up In sctp_vrf.sh line 55: ip -n $SERVER_NS link set veth2 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link set veth2 up In sctp_vrf.sh line 56: ip -n $SERVER_NS route add table 10 $CLIENT_IP4 dev veth1 src $SERVER_IP4 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" route add table 10 $CLIENT_IP4 dev veth1 src $SERVER_IP4 In sctp_vrf.sh line 57: ip -n $SERVER_NS route add table 20 $CLIENT_IP4 dev veth2 src $SERVER_IP4 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" route add table 20 $CLIENT_IP4 dev veth2 src $SERVER_IP4 In sctp_vrf.sh line 58: ip -n $SERVER_NS route add $CLIENT_IP4 dev veth1 src $SERVER_IP4 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" route add $CLIENT_IP4 dev veth1 src $SERVER_IP4 In sctp_vrf.sh line 59: ip -n $SERVER_NS route add table 10 $CLIENT_IP6 dev veth1 src $SERVER_IP6 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" route add table 10 $CLIENT_IP6 dev veth1 src $SERVER_IP6 In sctp_vrf.sh line 60: ip -n $SERVER_NS route add table 20 $CLIENT_IP6 dev veth2 src $SERVER_IP6 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" route add table 20 $CLIENT_IP6 dev veth2 src $SERVER_IP6 In sctp_vrf.sh line 61: ip -n $SERVER_NS route add $CLIENT_IP6 dev veth1 src $SERVER_IP6 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" route add $CLIENT_IP6 dev veth1 src $SERVER_IP6 In sctp_vrf.sh line 65: ip netns exec $SERVER_NS pkill sctp_hello 2>&1 >/dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). Did you mean: ip netns exec "$SERVER_NS" pkill sctp_hello 2>&1 >/dev/null In sctp_vrf.sh line 66: cleanup_ns $CLIENT_NS1 $CLIENT_NS2 $SERVER_NS ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cleanup_ns "$CLIENT_NS1" "$CLIENT_NS2" "$SERVER_NS" In sctp_vrf.sh line 73: until ip netns exec $SERVER_NS ss -lS src $SERVER_IP:$SERVER_PORT | \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2153 (info): Possible misspelling: SERVER_IP may not be assigned. Did you mean SERVER_IP4? Did you mean: until ip netns exec "$SERVER_NS" ss -lS src $SERVER_IP:$SERVER_PORT | \ In sctp_vrf.sh line 74: grep LISTEN | grep "$IFACE" 2>&1 >/dev/null; do ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). In sctp_vrf.sh line 84: ip netns exec $SERVER_NS pkill sctp_hello 2>&1 >/dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). Did you mean: ip netns exec "$SERVER_NS" pkill sctp_hello 2>&1 >/dev/null In sctp_vrf.sh line 85: ip netns exec $SERVER_NS ./sctp_hello server $AF $SERVER_IP \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$SERVER_NS" ./sctp_hello server $AF $SERVER_IP \ In sctp_vrf.sh line 86: $SERVER_PORT $IFACE 2>&1 >/dev/null & ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). Did you mean: $SERVER_PORT "$IFACE" 2>&1 >/dev/null & In sctp_vrf.sh line 88: wait_server $IFACE || return $RET ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: wait_server "$IFACE" || return $RET In sctp_vrf.sh line 89: timeout 3 ip netns exec $CLIENT_NS ./sctp_hello client $AF \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: timeout 3 ip netns exec "$CLIENT_NS" ./sctp_hello client $AF \ In sctp_vrf.sh line 90: $SERVER_IP $SERVER_PORT $CLIENT_IP $CLIENT_PORT 2>&1 >/dev/null ^--------^ SC2153 (info): Possible misspelling: CLIENT_IP may not be assigned. Did you mean CLIENT_IP4? ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). In sctp_vrf.sh line 99: ip netns exec $SERVER_NS pkill sctp_hello 2>&1 >/dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). Did you mean: ip netns exec "$SERVER_NS" pkill sctp_hello 2>&1 >/dev/null In sctp_vrf.sh line 100: ip netns exec $SERVER_NS ./sctp_hello server $AF $SERVER_IP \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$SERVER_NS" ./sctp_hello server $AF $SERVER_IP \ In sctp_vrf.sh line 101: $SERVER_PORT $IFACE1 2>&1 >/dev/null & ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). Did you mean: $SERVER_PORT "$IFACE1" 2>&1 >/dev/null & In sctp_vrf.sh line 103: wait_server $IFACE1 || return $RET ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: wait_server "$IFACE1" || return $RET In sctp_vrf.sh line 104: ip netns exec $SERVER_NS ./sctp_hello server $AF $SERVER_IP \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$SERVER_NS" ./sctp_hello server $AF $SERVER_IP \ In sctp_vrf.sh line 105: $SERVER_PORT $IFACE2 2>&1 >/dev/null & ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). Did you mean: $SERVER_PORT "$IFACE2" 2>&1 >/dev/null & In sctp_vrf.sh line 107: wait_server $IFACE2 || return $RET ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: wait_server "$IFACE2" || return $RET In sctp_vrf.sh line 108: timeout 3 ip netns exec $CLIENT_NS1 ./sctp_hello client $AF \ ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: timeout 3 ip netns exec "$CLIENT_NS1" ./sctp_hello client $AF \ In sctp_vrf.sh line 109: $SERVER_IP $SERVER_PORT $CLIENT_IP $CLIENT_PORT 2>&1 >/dev/null && \ ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). In sctp_vrf.sh line 110: timeout 3 ip netns exec $CLIENT_NS2 ./sctp_hello client $AF \ ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: timeout 3 ip netns exec "$CLIENT_NS2" ./sctp_hello client $AF \ In sctp_vrf.sh line 111: $SERVER_IP $SERVER_PORT $CLIENT_IP $CLIENT_PORT 2>&1 >/dev/null ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). In sctp_vrf.sh line 117: ip netns exec $SERVER_NS sysctl -w net.sctp.l3mdev_accept=1 2>&1 >/dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). Did you mean: ip netns exec "$SERVER_NS" sysctl -w net.sctp.l3mdev_accept=1 2>&1 >/dev/null In sctp_vrf.sh line 119: do_test $CLIENT_NS1 || { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS1" || { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 123: do_test $CLIENT_NS2 && { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS2" && { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 126: ip netns exec $SERVER_NS sysctl -w net.sctp.l3mdev_accept=0 2>&1 >/dev/null ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2069 (warning): To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify). Did you mean: ip netns exec "$SERVER_NS" sysctl -w net.sctp.l3mdev_accept=0 2>&1 >/dev/null In sctp_vrf.sh line 128: do_test $CLIENT_NS1 && { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS1" && { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 132: do_test $CLIENT_NS2 && { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS2" && { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 136: do_test $CLIENT_NS1 veth2 && { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS1" veth2 && { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 140: do_test $CLIENT_NS1 veth1 || { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS1" veth1 || { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 144: do_test $CLIENT_NS1 vrf-1 || { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS1" vrf-1 || { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 148: do_test $CLIENT_NS1 vrf-2 && { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS1" vrf-2 && { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 152: do_test $CLIENT_NS2 vrf-2 || { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS2" vrf-2 || { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 156: do_test $CLIENT_NS2 vrf-1 && { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS2" vrf-1 && { echo "[FAIL]"; return $RET; } For more information: https://www.shellcheck.net/wiki/SC2069 -- To redirect stdout+stderr, 2>&1 m... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... https://www.shellcheck.net/wiki/SC2153 -- Possible misspelling: CLIENT_IP m... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/sctp_vrf.sh - 26eb6cbdf0bcf0a9e136aca301140628a0ae8a0dd567cf7540f654bef7b73c4a In sctp_vrf.sh line 23: ip net exec $CLIENT_NS1 sysctl -wq net.ipv6.conf.default.accept_dad=0 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2153 (info): Possible misspelling: CLIENT_NS1 may not be assigned. Did you mean CLIENT_NS? Did you mean: ip net exec "$CLIENT_NS1" sysctl -wq net.ipv6.conf.default.accept_dad=0 In sctp_vrf.sh line 24: ip net exec $CLIENT_NS2 sysctl -wq net.ipv6.conf.default.accept_dad=0 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2153 (info): Possible misspelling: CLIENT_NS2 may not be assigned. Did you mean CLIENT_NS? Did you mean: ip net exec "$CLIENT_NS2" sysctl -wq net.ipv6.conf.default.accept_dad=0 In sctp_vrf.sh line 25: ip net exec $SERVER_NS sysctl -wq net.ipv6.conf.default.accept_dad=0 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip net exec "$SERVER_NS" sysctl -wq net.ipv6.conf.default.accept_dad=0 In sctp_vrf.sh line 27: ip -n $SERVER_NS link add veth1 type veth peer name veth1 netns $CLIENT_NS1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link add veth1 type veth peer name veth1 netns "$CLIENT_NS1" In sctp_vrf.sh line 28: ip -n $SERVER_NS link add veth2 type veth peer name veth1 netns $CLIENT_NS2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link add veth2 type veth peer name veth1 netns "$CLIENT_NS2" In sctp_vrf.sh line 30: ip -n $CLIENT_NS1 link set veth1 up ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$CLIENT_NS1" link set veth1 up In sctp_vrf.sh line 31: ip -n $CLIENT_NS1 addr add $CLIENT_IP4/24 dev veth1 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$CLIENT_NS1" addr add $CLIENT_IP4/24 dev veth1 In sctp_vrf.sh line 32: ip -n $CLIENT_NS1 addr add $CLIENT_IP6/24 dev veth1 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$CLIENT_NS1" addr add $CLIENT_IP6/24 dev veth1 In sctp_vrf.sh line 34: ip -n $CLIENT_NS2 link set veth1 up ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$CLIENT_NS2" link set veth1 up In sctp_vrf.sh line 35: ip -n $CLIENT_NS2 addr add $CLIENT_IP4/24 dev veth1 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$CLIENT_NS2" addr add $CLIENT_IP4/24 dev veth1 In sctp_vrf.sh line 36: ip -n $CLIENT_NS2 addr add $CLIENT_IP6/24 dev veth1 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$CLIENT_NS2" addr add $CLIENT_IP6/24 dev veth1 In sctp_vrf.sh line 38: ip -n $SERVER_NS link add dummy1 type dummy ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link add dummy1 type dummy In sctp_vrf.sh line 39: ip -n $SERVER_NS link set dummy1 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link set dummy1 up In sctp_vrf.sh line 40: ip -n $SERVER_NS link add vrf-1 type vrf table 10 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link add vrf-1 type vrf table 10 In sctp_vrf.sh line 41: ip -n $SERVER_NS link add vrf-2 type vrf table 20 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link add vrf-2 type vrf table 20 In sctp_vrf.sh line 42: ip -n $SERVER_NS link set vrf-1 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link set vrf-1 up In sctp_vrf.sh line 43: ip -n $SERVER_NS link set vrf-2 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link set vrf-2 up In sctp_vrf.sh line 44: ip -n $SERVER_NS link set veth1 master vrf-1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link set veth1 master vrf-1 In sctp_vrf.sh line 45: ip -n $SERVER_NS link set veth2 master vrf-2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link set veth2 master vrf-2 In sctp_vrf.sh line 47: ip -n $SERVER_NS addr add $SERVER_IP4/24 dev dummy1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" addr add $SERVER_IP4/24 dev dummy1 In sctp_vrf.sh line 48: ip -n $SERVER_NS addr add $SERVER_IP4/24 dev veth1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" addr add $SERVER_IP4/24 dev veth1 In sctp_vrf.sh line 49: ip -n $SERVER_NS addr add $SERVER_IP4/24 dev veth2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" addr add $SERVER_IP4/24 dev veth2 In sctp_vrf.sh line 50: ip -n $SERVER_NS addr add $SERVER_IP6/24 dev dummy1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" addr add $SERVER_IP6/24 dev dummy1 In sctp_vrf.sh line 51: ip -n $SERVER_NS addr add $SERVER_IP6/24 dev veth1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" addr add $SERVER_IP6/24 dev veth1 In sctp_vrf.sh line 52: ip -n $SERVER_NS addr add $SERVER_IP6/24 dev veth2 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" addr add $SERVER_IP6/24 dev veth2 In sctp_vrf.sh line 54: ip -n $SERVER_NS link set veth1 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link set veth1 up In sctp_vrf.sh line 55: ip -n $SERVER_NS link set veth2 up ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" link set veth2 up In sctp_vrf.sh line 56: ip -n $SERVER_NS route add table 10 $CLIENT_IP4 dev veth1 src $SERVER_IP4 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" route add table 10 $CLIENT_IP4 dev veth1 src $SERVER_IP4 In sctp_vrf.sh line 57: ip -n $SERVER_NS route add table 20 $CLIENT_IP4 dev veth2 src $SERVER_IP4 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" route add table 20 $CLIENT_IP4 dev veth2 src $SERVER_IP4 In sctp_vrf.sh line 58: ip -n $SERVER_NS route add $CLIENT_IP4 dev veth1 src $SERVER_IP4 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" route add $CLIENT_IP4 dev veth1 src $SERVER_IP4 In sctp_vrf.sh line 59: ip -n $SERVER_NS route add table 10 $CLIENT_IP6 dev veth1 src $SERVER_IP6 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" route add table 10 $CLIENT_IP6 dev veth1 src $SERVER_IP6 In sctp_vrf.sh line 60: ip -n $SERVER_NS route add table 20 $CLIENT_IP6 dev veth2 src $SERVER_IP6 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" route add table 20 $CLIENT_IP6 dev veth2 src $SERVER_IP6 In sctp_vrf.sh line 61: ip -n $SERVER_NS route add $CLIENT_IP6 dev veth1 src $SERVER_IP6 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -n "$SERVER_NS" route add $CLIENT_IP6 dev veth1 src $SERVER_IP6 In sctp_vrf.sh line 65: wait_client $CLIENT_NS1 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: wait_client "$CLIENT_NS1" In sctp_vrf.sh line 66: wait_client $CLIENT_NS2 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: wait_client "$CLIENT_NS2" In sctp_vrf.sh line 68: cleanup_ns $CLIENT_NS1 $CLIENT_NS2 $SERVER_NS ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cleanup_ns "$CLIENT_NS1" "$CLIENT_NS2" "$SERVER_NS" In sctp_vrf.sh line 75: ip netns exec $SERVER_NS ./sctp_hello server $AF $SERVER_IP $SERVER_PORT $IFACE & ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2153 (info): Possible misspelling: SERVER_IP may not be assigned. Did you mean SERVER_IP4? ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$SERVER_NS" ./sctp_hello server $AF $SERVER_IP $SERVER_PORT "$IFACE" & In sctp_vrf.sh line 77: until ip netns exec $SERVER_NS ss -SlH | grep -q "$IFACE"; do ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: until ip netns exec "$SERVER_NS" ss -SlH | grep -q "$IFACE"; do In sctp_vrf.sh line 86: ip netns exec $SERVER_NS pkill sctp_hello ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$SERVER_NS" pkill sctp_hello In sctp_vrf.sh line 87: while ip netns exec $SERVER_NS ss -SaH | grep -q .; do ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while ip netns exec "$SERVER_NS" ss -SaH | grep -q .; do In sctp_vrf.sh line 97: while ip netns exec $CLIENT_NS ss -SaH | grep -q .; do ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while ip netns exec "$CLIENT_NS" ss -SaH | grep -q .; do In sctp_vrf.sh line 107: start_server $IFACE || return $RET ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_server "$IFACE" || return $RET In sctp_vrf.sh line 108: timeout 3 ip netns exec $CLIENT_NS ./sctp_hello client $AF \ ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: timeout 3 ip netns exec "$CLIENT_NS" ./sctp_hello client $AF \ In sctp_vrf.sh line 109: $SERVER_IP $SERVER_PORT $CLIENT_IP $CLIENT_PORT ^--------^ SC2153 (info): Possible misspelling: CLIENT_IP may not be assigned. Did you mean CLIENT_IP4? In sctp_vrf.sh line 111: wait_client $CLIENT_NS ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: wait_client "$CLIENT_NS" In sctp_vrf.sh line 120: start_server $IFACE1 || return $RET ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_server "$IFACE1" || return $RET In sctp_vrf.sh line 121: start_server $IFACE2 || return $RET ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_server "$IFACE2" || return $RET In sctp_vrf.sh line 122: timeout 3 ip netns exec $CLIENT_NS1 ./sctp_hello client $AF \ ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: timeout 3 ip netns exec "$CLIENT_NS1" ./sctp_hello client $AF \ In sctp_vrf.sh line 124: timeout 3 ip netns exec $CLIENT_NS2 ./sctp_hello client $AF \ ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: timeout 3 ip netns exec "$CLIENT_NS2" ./sctp_hello client $AF \ In sctp_vrf.sh line 127: wait_client $CLIENT_NS1 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: wait_client "$CLIENT_NS1" In sctp_vrf.sh line 128: wait_client $CLIENT_NS2 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: wait_client "$CLIENT_NS2" In sctp_vrf.sh line 134: ip netns exec $SERVER_NS sysctl -wq net.sctp.l3mdev_accept=1 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$SERVER_NS" sysctl -wq net.sctp.l3mdev_accept=1 In sctp_vrf.sh line 136: do_test $CLIENT_NS1 || { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS1" || { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 140: do_test $CLIENT_NS2 && { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS2" && { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 143: ip netns exec $SERVER_NS sysctl -wq net.sctp.l3mdev_accept=0 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$SERVER_NS" sysctl -wq net.sctp.l3mdev_accept=0 In sctp_vrf.sh line 145: do_test $CLIENT_NS1 && { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS1" && { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 149: do_test $CLIENT_NS2 && { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS2" && { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 153: do_test $CLIENT_NS1 veth2 && { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS1" veth2 && { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 157: do_test $CLIENT_NS1 veth1 || { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS1" veth1 || { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 161: do_test $CLIENT_NS1 vrf-1 || { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS1" vrf-1 || { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 165: do_test $CLIENT_NS1 vrf-2 && { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS1" vrf-2 && { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 169: do_test $CLIENT_NS2 vrf-2 || { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS2" vrf-2 || { echo "[FAIL]"; return $RET; } In sctp_vrf.sh line 173: do_test $CLIENT_NS2 vrf-1 && { echo "[FAIL]"; return $RET; } ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: do_test "$CLIENT_NS2" vrf-1 && { echo "[FAIL]"; return $RET; } For more information: https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... https://www.shellcheck.net/wiki/SC2153 -- Possible misspelling: CLIENT_IP m...