WARNING: line length of 82 exceeds 80 columns #160: FILE: tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c:91: +static int set_subtest_progs(struct subtest_cfg *cfg, struct test_tc_tunnel *skel) CHECK: Please don't use multiple blank lines #166: FILE: tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c:97: + + WARNING: line length of 81 exceeds 80 columns #296: FILE: tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c:227: + if (!must_succeed && !ASSERT_EQ(conn, NULL, "connection that must fail")) WARNING: line length of 81 exceeds 80 columns #320: FILE: tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c:251: + if (!ASSERT_EQ(err, GSO_TEST_DATA_SIZE, "send (large) data from client")) CHECK: Please use a blank line after function/struct/union/enum declarations #330: FILE: tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c:261: +} +static void vxlan_decap_mod_args_cb(struct subtest_cfg *cfg, char *dst) CHECK: Lines should not end with a '(' #410: FILE: tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c:341: + if (cfg->configure_fou_rx_port && !ASSERT_OK( CHECK: Blank lines aren't necessary before a close brace '}' #448: FILE: tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c:379: + +} WARNING: line length of 83 exceeds 80 columns #456: FILE: tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c:387: + if (!ASSERT_OK(send_and_test_data(cfg, true), "connect without any encap")) WARNING: line length of 87 exceeds 80 columns #462: FILE: tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c:393: + if (!ASSERT_OK(send_and_test_data(cfg, false), "connect with encap prog only")) WARNING: line length of 94 exceeds 80 columns #466: FILE: tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c:397: + if (!ASSERT_OK(configure_kernel_decapsulation(cfg), "configure kernel decapsulation")) WARNING: line length of 90 exceeds 80 columns #473: FILE: tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c:404: + if (!ASSERT_OK(configure_ebpf_decapsulation(cfg), "configure ebpf decapsulation")) WARNING: line length of 87 exceeds 80 columns #475: FILE: tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c:406: + ASSERT_OK(send_and_test_data(cfg, true), "connect with encap and decap progs"); CHECK: Alignment should match open parenthesis #502: FILE: tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c:433: + SYS(fail, "ip link add %s type veth peer name %s", + "veth1 mtu 1500 netns " CLIENT_NS " address " MAC_ADDR_VETH1, CHECK: Please use a blank line after function/struct/union/enum declarations #516: FILE: tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c:447: +} +static int subtest_setup(struct test_tc_tunnel *skel, struct subtest_cfg *cfg) CHECK: Please don't use multiple blank lines #536: FILE: tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c:467: + + CHECK: spaces preferred around that '/' (ctx:VxV) #727: FILE: tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c:658: +int subtests_count = sizeof(subtests_cfg)/sizeof(struct subtest_cfg); ^ CHECK: Please don't use multiple blank lines #729: FILE: tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c:660: + + total: 0 errors, 8 warnings, 9 checks, 836 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 551274973105 ("selftests/bpf: integrate test_tc_tunnel.sh tests into test_progs") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 8 warnings, 9 checks, 836 lines checked