WARNING: line length of 93 exceeds 80 columns #42: FILE: net/smc/af_smc.c:1136: + smc_ipaddr_from(&ini->smcrv2.saddr, smc->clcsock->sk, sk_rcv_saddr, sk_v6_rcv_saddr); WARNING: line length of 88 exceeds 80 columns #64: FILE: net/smc/af_smc.c:1234: + /* v4-mapped v6 address should also be treated as v4 address. */ WARNING: line length of 82 exceeds 80 columns #65: FILE: net/smc/af_smc.c:1235: + if (smc_ib_find_route(net, smc->clcsock->sk->sk_rcv_saddr, WARNING: line length of 89 exceeds 80 columns #71: FILE: net/smc/af_smc.c:1241: + if (smc_ib_find_route_v6(net, &smc->clcsock->sk->sk_v6_rcv_saddr, WARNING: line length of 97 exceeds 80 columns #87: FILE: net/smc/af_smc.c:2320: + smc_ipaddr_from(&ini->smcrv2.saddr, new_smc->clcsock->sk, sk_rcv_saddr, sk_v6_rcv_saddr); CHECK: Macro argument '_v4_member' may be better as '(_v4_member)' to avoid precedence issues #138: FILE: net/smc/smc_core.h:630: +#define smc_ipaddr_from(_ipaddr, _sk, _v4_member, _v6_member) \ + do { \ + struct smc_ipaddr *__ipaddr = (_ipaddr); \ + struct sock *__sk = (_sk); \ + int __family = __sk->sk_family; \ + __ipaddr->family = __family; \ + if (__family == AF_INET) \ + __ipaddr->addr = __sk->_v4_member; \ + else \ + __ipaddr->addr_v6 = __sk->_v6_member; \ + } while (0) CHECK: Macro argument '_v6_member' may be better as '(_v6_member)' to avoid precedence issues #138: FILE: net/smc/smc_core.h:630: +#define smc_ipaddr_from(_ipaddr, _sk, _v4_member, _v6_member) \ + do { \ + struct smc_ipaddr *__ipaddr = (_ipaddr); \ + struct sock *__sk = (_sk); \ + int __family = __sk->sk_family; \ + __ipaddr->family = __family; \ + if (__family == AF_INET) \ + __ipaddr->addr = __sk->_v4_member; \ + else \ + __ipaddr->addr_v6 = __sk->_v6_member; \ + } while (0) WARNING: line length of 87 exceeds 80 columns #150: FILE: net/smc/smc_core.h:642: +static inline void smc_ipaddr_from_gid(struct smc_ipaddr *ipaddr, u8 gid[SMC_GID_SIZE]) WARNING: line length of 99 exceeds 80 columns #285: FILE: net/smc/smc_ib.c:313: + } else if (!(ipv6_addr_type(smc_ib_gid_to_ipv6((u8 *)&attr->gid)) & IPV6_ADDR_LINKLOCAL)) { WARNING: line length of 100 exceeds 80 columns #298: FILE: net/smc/smc_ib.c:326: + if (!ipv6_prefix_equal(&if6->addr, &smcrv2->saddr.addr_v6, if6->prefix_len)) WARNING: line length of 81 exceeds 80 columns #393: FILE: net/smc/smc_llc.c:1442: + smc_ipaddr_from_gid(&ini->smcrv2.daddr, req_add->gid[0]); total: 0 errors, 9 warnings, 2 checks, 332 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 28aeb530f30a ("net/smc: add full IPv6 support for SMC") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE FILE_PATH_CHANGES GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 9 warnings, 2 checks, 332 lines checked