ShellCheck - shell script analysis tool version: 0.10.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.uUBwv7Z63H and /tmp/tmp.vs8PIZfJiY Tree base: 0b4b77eff5f8 ("doc: fix seg6_flowlabel path") Now at: 7dd7e7928989 ("selftests: net: check jq command is supported") ====== Checking before the patch ====== Checking tools/testing/selftests/net/rtnetlink.sh - 92b39af047694c9000fd5d4b91e04b1c583b35a20f0c57eecd990e1ab7a38e29 In rtnetlink.sh line 56: if [ $1 -eq 0 ]; then ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$1" -eq 0 ]; then In rtnetlink.sh line 70: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In rtnetlink.sh line 86: check_fail $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_fail "$rc" In rtnetlink.sh line 87: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 105: check_err $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_err "$rc" In rtnetlink.sh line 106: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 113: check_fail $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_fail "$rc" In rtnetlink.sh line 114: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 124: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 129: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 152: run_cmd ip -$f netconf show dev "$dev" ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -"$f" netconf show dev "$dev" In rtnetlink.sh line 155: if [ $ret -ne 0 ] ;then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ] ;then In rtnetlink.sh line 157: test $r -eq 0 && ret=0 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: test "$r" -eq 0 && ret=0 In rtnetlink.sh line 185: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 200: run_cmd ip tunnel add $gredev mode gre remote $rem local $loc ttl 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip tunnel add "$gredev" mode gre remote "$rem" local "$loc" ttl 1 In rtnetlink.sh line 201: run_cmd ip link set $gredev up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set "$gredev" up In rtnetlink.sh line 202: run_cmd ip addr add 10.23.7.10 dev $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add 10.23.7.10 dev "$gredev" In rtnetlink.sh line 203: run_cmd ip route add 10.23.8.0/30 dev $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip route add 10.23.8.0/30 dev "$gredev" In rtnetlink.sh line 210: run_cmd ip link del $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link del "$gredev" In rtnetlink.sh line 212: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 238: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 255: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 264: local hash_policy=$(sysctl -n net.ipv4.fib_multipath_hash_policy) ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In rtnetlink.sh line 288: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 300: if ip addr show dev $dev | grep -q $addr; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if ip addr show dev "$dev" | grep -q "$addr"; then In rtnetlink.sh line 311: run_cmd ip addr add 10.23.11.$i/32 dev "$devdummy" preferred_lft $lft valid_lft $((lft+1)) ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add 10.23.11."$i"/32 dev "$devdummy" preferred_lft "$lft" valid_lft $((lft+1)) In rtnetlink.sh line 329: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 331: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 333: promote=$(sysctl -n net.ipv4.conf.$devdummy.promote_secondaries) ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: promote=$(sysctl -n net.ipv4.conf."$devdummy".promote_secondaries) In rtnetlink.sh line 335: sysctl -q net.ipv4.conf.$devdummy.promote_secondaries=1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sysctl -q net.ipv4.conf."$devdummy".promote_secondaries=1 In rtnetlink.sh line 339: ip -f inet addr add $IP/16 brd + dev "$devdummy" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -f inet addr add "$IP"/16 brd + dev "$devdummy" In rtnetlink.sh line 340: ifconfig "$devdummy" $IP netmask 255.255.0.0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ifconfig "$devdummy" "$IP" netmask 255.255.0.0 In rtnetlink.sh line 345: [ $promote -eq 0 ] && sysctl -q net.ipv4.conf.$devdummy.promote_secondaries=0 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$promote" -eq 0 ] && sysctl -q net.ipv4.conf."$devdummy".promote_secondaries=0 In rtnetlink.sh line 372: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 387: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 394: read namehave < "$syspathname" ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 419: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 432: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 434: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 437: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 442: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 451: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 464: run_cmd ip -netns "$testns" link add "$vxlan" type vxlan id 42 group 239.1.1.1 \ ^-----^ SC2154 (warning): testns is referenced but not assigned. In rtnetlink.sh line 466: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 497: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 509: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 511: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 516: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 521: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 528: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 541: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 543: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 552: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 560: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 562: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 565: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 575: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 593: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 595: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 598: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 610: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 642: spi=7 ^-^ SC2034 (warning): spi appears unused. Verify use (or export if used externally). In rtnetlink.sh line 644: ip addr add $srcip dev $devdummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "$srcip" dev "$devdummy" In rtnetlink.sh line 650: tmpfile=`mktemp /var/run/ipsectestXXX` ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: tmpfile=$(mktemp /var/run/ipsectestXXX) In rtnetlink.sh line 651: mpid=`(ip x m > $tmpfile & echo $!) 2>/dev/null` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mpid=$((ip x m > "$tmpfile" & echo $!) 2>/dev/null) In rtnetlink.sh line 655: run_cmd ip x s add $ipsecid \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add "$ipsecid" \ In rtnetlink.sh line 657: $algo sel src $srcip/24 dst $dstip/24 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$algo" sel src "$srcip"/24 dst "$dstip"/24 In rtnetlink.sh line 660: lines=`ip x s list | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x s list | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 661: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 664: lines=`ip x s get $ipsecid | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x s get "$ipsecid" | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 665: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 666: run_cmd ip x s delete $ipsecid ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s delete "$ipsecid" In rtnetlink.sh line 668: lines=`ip x s list | wc -l` ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x s list | wc -l) In rtnetlink.sh line 669: run_cmd test $lines -eq 0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 0 In rtnetlink.sh line 672: run_cmd ip x p add $ipsecsel \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add "$ipsecsel" \ In rtnetlink.sh line 673: tmpl proto esp src $srcip dst $dstip \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$srcip" dst "$dstip" \ In rtnetlink.sh line 677: lines=`ip x p list | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x p list | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 678: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 682: lines=`ip x p get $ipsecsel | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x p get "$ipsecsel" | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 683: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 685: run_cmd ip x p delete $ipsecsel ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p delete "$ipsecsel" In rtnetlink.sh line 687: lines=`ip x p list | wc -l` ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x p list | wc -l) In rtnetlink.sh line 688: run_cmd test $lines -eq 0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 0 In rtnetlink.sh line 691: kill $mpid ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill "$mpid" In rtnetlink.sh line 692: lines=`wc -l $tmpfile | cut "-d " -f1` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(wc -l "$tmpfile" | cut "-d " -f1) In rtnetlink.sh line 693: run_cmd test $lines -eq 20 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 20 In rtnetlink.sh line 694: rm -rf $tmpfile ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rm -rf "$tmpfile" In rtnetlink.sh line 699: ip addr del $srcip/32 dev $devdummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr del "$srcip"/32 dev "$devdummy" In rtnetlink.sh line 701: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 743: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 745: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 751: while [ ! -d $sysfsnet ] ; do :; done ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "$sysfsnet" ] ; do :; done In rtnetlink.sh line 753: dev=`ls $sysfsnet` ^------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev=$(ls "$sysfsnet") In rtnetlink.sh line 755: ip addr add $srcip dev $dev ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "$srcip" dev "$dev" In rtnetlink.sh line 756: ip link set $dev up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$dev" up In rtnetlink.sh line 757: if [ ! -d $sysfsd ] ; then ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ ! -d "$sysfsd" ] ; then In rtnetlink.sh line 761: if [ ! -f $sysfsf ] ; then ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ ! -f "$sysfsf" ] ; then In rtnetlink.sh line 770: run_cmd ip x p add dir out src $srcip/24 dst $dstip/24 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add dir out src "$srcip"/24 dst "$dstip"/24 \ In rtnetlink.sh line 771: tmpl proto esp src $srcip dst $dstip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$srcip" dst "$dstip" spi 9 \ In rtnetlink.sh line 774: run_cmd ip x p add dir in src $dstip/24 dst $srcip/24 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add dir in src "$dstip"/24 dst "$srcip"/24 \ In rtnetlink.sh line 775: tmpl proto esp src $dstip dst $srcip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$dstip" dst "$srcip" spi 9 \ In rtnetlink.sh line 778: run_cmd ip x s add proto esp src $srcip dst $dstip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add proto esp src "$srcip" dst "$dstip" spi 9 \ In rtnetlink.sh line 779: mode transport reqid 42 $algo sel src $srcip/24 dst $dstip/24 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mode transport reqid 42 "$algo" sel src "$srcip"/24 dst "$dstip"/24 \ In rtnetlink.sh line 780: offload dev $dev dir out ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: offload dev "$dev" dir out In rtnetlink.sh line 782: run_cmd ip x s add proto esp src $dstip dst $srcip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add proto esp src "$dstip" dst "$srcip" spi 9 \ In rtnetlink.sh line 783: mode transport reqid 42 $algo sel src $dstip/24 dst $srcip/24 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mode transport reqid 42 "$algo" sel src "$dstip"/24 dst "$srcip"/24 \ In rtnetlink.sh line 784: offload dev $dev dir in ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: offload dev "$dev" dir in In rtnetlink.sh line 786: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 792: lines=`ip x s list | grep -c "crypto offload parameters: dev $dev dir"` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x s list | grep -c "crypto offload parameters: dev $dev dir") In rtnetlink.sh line 793: if [ $lines -ne 2 ] ; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$lines" -ne 2 ] ; then In rtnetlink.sh line 799: ip neigh add $dstip dev $dev lladdr 00:11:22:33:44:55 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip neigh add "$dstip" dev "$dev" lladdr 00:11:22:33:44:55 In rtnetlink.sh line 801: ping -I $dev -c 3 -W 1 -i 0 $dstip >/dev/null ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping -I "$dev" -c 3 -W 1 -i 0 "$dstip" >/dev/null In rtnetlink.sh line 804: run_cmd diff $sysfsf - << EOF ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd diff "$sysfsf" - << EOF In rtnetlink.sh line 813: if [ $? -ne 0 ] ; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 821: lines=`grep -c "SA count=0" $sysfsf` ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(grep -c "SA count=0" "$sysfsf") In rtnetlink.sh line 822: if [ $lines -ne 1 ] ; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$lines" -ne 1 ] ; then In rtnetlink.sh line 832: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 845: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 847: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 851: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 854: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 863: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 870: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 886: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 888: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 892: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 895: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 904: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 911: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 926: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 928: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 931: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 933: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 943: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 953: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 960: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 975: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 977: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 980: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 982: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 992: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 1002: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 1011: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1031: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1033: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1037: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1039: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1043: run_cmd $IP link add "$vxlandev" type vxlan id 10 local $localip \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add "$vxlandev" type vxlan id 10 local "$localip" \ In rtnetlink.sh line 1045: run_cmd $IP link add name "$brdev" type bridge ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add name "$brdev" type bridge In rtnetlink.sh line 1046: run_cmd $IP link set dev "$vxlandev" master "$brdev" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link set dev "$vxlandev" master "$brdev" In rtnetlink.sh line 1047: run_cmd $BRIDGE fdb add $test_mac dev "$vxlandev" master ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$vxlandev" master In rtnetlink.sh line 1048: run_cmd $BRIDGE fdb add $test_mac dev "$vxlandev" dst $dstip self ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$vxlandev" dst "$dstip" self In rtnetlink.sh line 1049: run_cmd_grep "dev $vxlandev master $brdev" $BRIDGE fdb get $test_mac brport "$vxlandev" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev master $brdev" "$BRIDGE" fdb get "$test_mac" brport "$vxlandev" In rtnetlink.sh line 1050: run_cmd_grep "dev $vxlandev master $brdev" $BRIDGE fdb get $test_mac br "$brdev" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev master $brdev" "$BRIDGE" fdb get "$test_mac" br "$brdev" In rtnetlink.sh line 1051: run_cmd_grep "dev $vxlandev dst $dstip" $BRIDGE fdb get $test_mac dev "$vxlandev" self ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev dst $dstip" "$BRIDGE" fdb get "$test_mac" dev "$vxlandev" self In rtnetlink.sh line 1053: ip netns del $testns &>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" &>/dev/null In rtnetlink.sh line 1055: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1071: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1073: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1077: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1079: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1083: run_cmd $IP link add $dummydev type dummy ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add "$dummydev" type dummy In rtnetlink.sh line 1084: run_cmd $IP link add name $brdev type bridge vlan_filtering 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add name "$brdev" type bridge vlan_filtering 1 In rtnetlink.sh line 1085: run_cmd $IP link set dev $dummydev master $brdev ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link set dev "$dummydev" master "$brdev" In rtnetlink.sh line 1086: run_cmd $BRIDGE fdb add $test_mac dev $dummydev master static vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$dummydev" master static vlan 1 In rtnetlink.sh line 1087: run_cmd $BRIDGE vlan del vid 1 dev $dummydev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" vlan del vid 1 dev "$dummydev" In rtnetlink.sh line 1088: run_cmd $BRIDGE fdb get $test_mac br $brdev vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb get "$test_mac" br "$brdev" vlan 1 In rtnetlink.sh line 1089: run_cmd $BRIDGE fdb del $test_mac dev $dummydev master vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb del "$test_mac" dev "$dummydev" master vlan 1 In rtnetlink.sh line 1090: run_cmd_fail $BRIDGE fdb get $test_mac br $brdev vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_fail "$BRIDGE" fdb get "$test_mac" br "$brdev" vlan 1 In rtnetlink.sh line 1092: ip netns del $testns &>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" &>/dev/null In rtnetlink.sh line 1094: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1110: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1112: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1116: run_cmd ip neigh add $dstip lladdr $dstmac dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$dstip" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1117: run_cmd_grep "$dstmac" ip neigh get $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstmac" ip neigh get "$dstip" dev "$devdummy" In rtnetlink.sh line 1118: run_cmd ip neigh del $dstip lladdr $dstmac dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$dstip" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1121: run_cmd ip neigh add proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1122: run_cmd_grep "$dstip" ip neigh get proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip" ip neigh get proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1123: run_cmd ip neigh del proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1126: run_cmd ip neigh add $dstip6 lladdr $dstmac dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$dstip6" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1127: run_cmd_grep "$dstmac" ip neigh get $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstmac" ip neigh get "$dstip6" dev "$devdummy" In rtnetlink.sh line 1128: run_cmd ip neigh del $dstip6 lladdr $dstmac dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$dstip6" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1131: run_cmd ip neigh add proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1132: run_cmd_grep "$dstip6" ip neigh get proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip6" ip neigh get proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1133: run_cmd ip neigh del proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1135: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 1151: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1153: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1159: while [ ! -d ${sysfsnet}10 ] ; do :; done ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "${sysfsnet}"10 ] ; do :; done In rtnetlink.sh line 1161: while [ ! -d ${sysfsnet}20 ] ; do :; done ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "${sysfsnet}"20 ] ; do :; done In rtnetlink.sh line 1163: dev10=`ls ${sysfsnet}10/net/` ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev10=$(ls "${sysfsnet}"10/net/) In rtnetlink.sh line 1164: dev20=`ls ${sysfsnet}20/net/` ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev20=$(ls "${sysfsnet}"20/net/) In rtnetlink.sh line 1166: run_cmd ip link set dev $dev10 master test-bond0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set dev "$dev10" master test-bond0 In rtnetlink.sh line 1167: run_cmd ip link set dev $dev20 master test-bond0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set dev "$dev20" master test-bond0 In rtnetlink.sh line 1178: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1212: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1214: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1265: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1282: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 1291: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1293: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1296: run_cmd ip -netns $testns link add dev $bond type bond mode balance-rr ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link add dev "$bond" type bond mode balance-rr In rtnetlink.sh line 1297: run_cmd ip -netns $testns link add dev $devdummy type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link add dev "$devdummy" type dummy In rtnetlink.sh line 1298: run_cmd ip -netns $testns link set dev $devdummy up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$devdummy" up In rtnetlink.sh line 1299: run_cmd ip -netns $testns link set dev $devdummy master $bond down ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$devdummy" master "$bond" down In rtnetlink.sh line 1300: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1320: local addr_list=$(ip -j -n $testns addr show dev ${dev}) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local addr_list=$(ip -j -n "$testns" addr show dev "${dev}") In rtnetlink.sh line 1321: local temp_addrs=$(echo ${addr_list} | \ ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local temp_addrs=$(echo "${addr_list}" | \ In rtnetlink.sh line 1323: local mng_prefixes=$(echo ${addr_list} | \ ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local mng_prefixes=$(echo "${addr_list}" | \ In rtnetlink.sh line 1326: local undep_prefixes=$(echo ${addr_list} | \ ^------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local undep_prefixes=$(echo "${addr_list}" | \ In rtnetlink.sh line 1332: prefix=$(echo ${address} | cut -d: -f1-4) ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: prefix=$(echo "${address}" | cut -d: -f1-4) In rtnetlink.sh line 1333: if [[ ! " ${mng_prefixes} " =~ " $prefix " ]]; then ^---------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally. In rtnetlink.sh line 1341: if [[ ! " ${undep_prefixes} " =~ " $prefix " ]]; then ^---------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally. In rtnetlink.sh line 1355: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1357: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1361: run_cmd ip -n $testns link add ${devdummy} type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" link add "${devdummy}" type dummy In rtnetlink.sh line 1362: run_cmd ip -n $testns link set ${devdummy} up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" link set "${devdummy}" up In rtnetlink.sh line 1363: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.use_tempaddr=1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".use_tempaddr=1 In rtnetlink.sh line 1364: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.temp_prefered_lft=10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".temp_prefered_lft=10 In rtnetlink.sh line 1365: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.temp_valid_lft=25 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".temp_valid_lft=25 In rtnetlink.sh line 1366: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.max_desync_factor=1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".max_desync_factor=1 In rtnetlink.sh line 1372: run_cmd ip -n $testns addr add 2001:db8:7e57:${i}::1/64 mngtmpaddr dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr add 2001:db8:7e57:"${i}"::1/64 mngtmpaddr dev "${devdummy}" In rtnetlink.sh line 1377: slowwait 30 validate_mngtmpaddr ${devdummy} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: slowwait 30 validate_mngtmpaddr "${devdummy}" In rtnetlink.sh line 1383: (( $i % 4 == 0 )) && mng_flag="mngtmpaddr" || mng_flag="" ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables. In rtnetlink.sh line 1384: if (( $i % 2 == 0 )); then ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables. In rtnetlink.sh line 1385: run_cmd ip -n $testns addr del 2001:db8:7e57:${i}::1/64 $mng_flag dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr del 2001:db8:7e57:"${i}"::1/64 "$mng_flag" dev "${devdummy}" In rtnetlink.sh line 1387: run_cmd ip -n $testns addr change 2001:db8:7e57:${i}::1/64 dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr change 2001:db8:7e57:"${i}"::1/64 dev "${devdummy}" In rtnetlink.sh line 1390: validate_mngtmpaddr ${devdummy} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: validate_mngtmpaddr "${devdummy}" In rtnetlink.sh line 1393: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1400: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 1462: (options: $(echo $ALL_TESTS)) ^----------------^ SC2116 (style): Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: (options: $(echo "$ALL_TESTS")) In rtnetlink.sh line 1477: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. For more information: https://www.shellcheck.net/wiki/SC2034 -- spi appears unused. Verify use (o... https://www.shellcheck.net/wiki/SC2076 -- Remove quotes from right-hand sid... https://www.shellcheck.net/wiki/SC2154 -- testns is referenced but not assi... Checking tools/testing/selftests/net/vlan_bridge_binding.sh - 62b03e4b302fe2b5de91ca98e5714f032b4653afda5976a3b9816c2df41c5328 In vlan_bridge_binding.sh line 51: local operstate=$(ip -j link show $dev | jq -r .[].operstate) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local operstate=$(ip -j link show "$dev" | jq -r .[].operstate) In vlan_bridge_binding.sh line 57: echo -n $operstate ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo -n "$operstate" In vlan_bridge_binding.sh line 58: [[ $operstate == $expect ]] ^-----^ SC2053 (warning): Quote the right-hand side of == in [[ ]] to prevent glob matching. In vlan_bridge_binding.sh line 77: adf_ip_link_add $link.$id link $link type vlan id $id "$@" ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_ip_link_add "$link"."$id" link "$link" type vlan id "$id" "$@" In vlan_bridge_binding.sh line 101: adf_ip_link_set_down $dev ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_ip_link_set_down "$dev" In vlan_bridge_binding.sh line 112: check_operstate br.11 $opst_11 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_operstate br.11 "$opst_11" In vlan_bridge_binding.sh line 113: check_operstate br.12 $opst_12 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_operstate br.12 "$opst_12" In vlan_bridge_binding.sh line 114: check_operstate br.13 $opst_13 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_operstate br.13 "$opst_13" In vlan_bridge_binding.sh line 115: check_operstate br.14 $opst_14 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_operstate br.14 "$opst_14" In vlan_bridge_binding.sh line 132: check_operstates $opsts_d1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_operstates "$opsts_d1" In vlan_bridge_binding.sh line 138: check_operstates $opsts_d2 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_operstates "$opsts_d2" In vlan_bridge_binding.sh line 144: check_operstates $opsts_d12 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_operstates "$opsts_d12" In vlan_bridge_binding.sh line 150: check_operstates $opsts_d123 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_operstates "$opsts_d123" For more information: https://www.shellcheck.net/wiki/SC2053 -- Quote the right-hand side of == i... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/net/rtnetlink.sh - 92b39af047694c9000fd5d4b91e04b1c583b35a20f0c57eecd990e1ab7a38e29 In rtnetlink.sh line 56: if [ $1 -eq 0 ]; then ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$1" -eq 0 ]; then In rtnetlink.sh line 70: if [ "$VERBOSE" = "1" -a -n "$out" ]; then ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. In rtnetlink.sh line 86: check_fail $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_fail "$rc" In rtnetlink.sh line 87: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 105: check_err $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_err "$rc" In rtnetlink.sh line 106: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 113: check_fail $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_fail "$rc" In rtnetlink.sh line 114: return $rc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$rc" In rtnetlink.sh line 124: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 129: read a ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 152: run_cmd ip -$f netconf show dev "$dev" ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -"$f" netconf show dev "$dev" In rtnetlink.sh line 155: if [ $ret -ne 0 ] ;then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ] ;then In rtnetlink.sh line 157: test $r -eq 0 && ret=0 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: test "$r" -eq 0 && ret=0 In rtnetlink.sh line 185: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 200: run_cmd ip tunnel add $gredev mode gre remote $rem local $loc ttl 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip tunnel add "$gredev" mode gre remote "$rem" local "$loc" ttl 1 In rtnetlink.sh line 201: run_cmd ip link set $gredev up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set "$gredev" up In rtnetlink.sh line 202: run_cmd ip addr add 10.23.7.10 dev $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add 10.23.7.10 dev "$gredev" In rtnetlink.sh line 203: run_cmd ip route add 10.23.8.0/30 dev $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip route add 10.23.8.0/30 dev "$gredev" In rtnetlink.sh line 210: run_cmd ip link del $gredev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link del "$gredev" In rtnetlink.sh line 212: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 238: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 255: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 264: local hash_policy=$(sysctl -n net.ipv4.fib_multipath_hash_policy) ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In rtnetlink.sh line 288: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 300: if ip addr show dev $dev | grep -q $addr; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if ip addr show dev "$dev" | grep -q "$addr"; then In rtnetlink.sh line 311: run_cmd ip addr add 10.23.11.$i/32 dev "$devdummy" preferred_lft $lft valid_lft $((lft+1)) ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip addr add 10.23.11."$i"/32 dev "$devdummy" preferred_lft "$lft" valid_lft $((lft+1)) In rtnetlink.sh line 329: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 331: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 333: promote=$(sysctl -n net.ipv4.conf.$devdummy.promote_secondaries) ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: promote=$(sysctl -n net.ipv4.conf."$devdummy".promote_secondaries) In rtnetlink.sh line 335: sysctl -q net.ipv4.conf.$devdummy.promote_secondaries=1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sysctl -q net.ipv4.conf."$devdummy".promote_secondaries=1 In rtnetlink.sh line 339: ip -f inet addr add $IP/16 brd + dev "$devdummy" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -f inet addr add "$IP"/16 brd + dev "$devdummy" In rtnetlink.sh line 340: ifconfig "$devdummy" $IP netmask 255.255.0.0 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ifconfig "$devdummy" "$IP" netmask 255.255.0.0 In rtnetlink.sh line 345: [ $promote -eq 0 ] && sysctl -q net.ipv4.conf.$devdummy.promote_secondaries=0 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ "$promote" -eq 0 ] && sysctl -q net.ipv4.conf."$devdummy".promote_secondaries=0 In rtnetlink.sh line 372: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 387: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 394: read namehave < "$syspathname" ^--^ SC2162 (info): read without -r will mangle backslashes. In rtnetlink.sh line 419: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 432: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 434: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 437: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 442: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 451: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 464: run_cmd ip -netns "$testns" link add "$vxlan" type vxlan id 42 group 239.1.1.1 \ ^-----^ SC2154 (warning): testns is referenced but not assigned. In rtnetlink.sh line 466: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 497: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 509: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 511: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 516: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 521: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 528: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 541: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 543: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 552: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 560: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 562: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 565: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 575: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 593: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 595: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 598: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 610: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 642: spi=7 ^-^ SC2034 (warning): spi appears unused. Verify use (or export if used externally). In rtnetlink.sh line 644: ip addr add $srcip dev $devdummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "$srcip" dev "$devdummy" In rtnetlink.sh line 650: tmpfile=`mktemp /var/run/ipsectestXXX` ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: tmpfile=$(mktemp /var/run/ipsectestXXX) In rtnetlink.sh line 651: mpid=`(ip x m > $tmpfile & echo $!) 2>/dev/null` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mpid=$((ip x m > "$tmpfile" & echo $!) 2>/dev/null) In rtnetlink.sh line 655: run_cmd ip x s add $ipsecid \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add "$ipsecid" \ In rtnetlink.sh line 657: $algo sel src $srcip/24 dst $dstip/24 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$algo" sel src "$srcip"/24 dst "$dstip"/24 In rtnetlink.sh line 660: lines=`ip x s list | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x s list | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 661: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 664: lines=`ip x s get $ipsecid | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x s get "$ipsecid" | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 665: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 666: run_cmd ip x s delete $ipsecid ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s delete "$ipsecid" In rtnetlink.sh line 668: lines=`ip x s list | wc -l` ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x s list | wc -l) In rtnetlink.sh line 669: run_cmd test $lines -eq 0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 0 In rtnetlink.sh line 672: run_cmd ip x p add $ipsecsel \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add "$ipsecsel" \ In rtnetlink.sh line 673: tmpl proto esp src $srcip dst $dstip \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$srcip" dst "$dstip" \ In rtnetlink.sh line 677: lines=`ip x p list | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x p list | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 678: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 682: lines=`ip x p get $ipsecsel | grep $srcip | grep $dstip | wc -l` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(ip x p get "$ipsecsel" | grep "$srcip" | grep "$dstip" | wc -l) In rtnetlink.sh line 683: run_cmd test $lines -eq 2 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 2 In rtnetlink.sh line 685: run_cmd ip x p delete $ipsecsel ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p delete "$ipsecsel" In rtnetlink.sh line 687: lines=`ip x p list | wc -l` ^-------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x p list | wc -l) In rtnetlink.sh line 688: run_cmd test $lines -eq 0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 0 In rtnetlink.sh line 691: kill $mpid ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill "$mpid" In rtnetlink.sh line 692: lines=`wc -l $tmpfile | cut "-d " -f1` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(wc -l "$tmpfile" | cut "-d " -f1) In rtnetlink.sh line 693: run_cmd test $lines -eq 20 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd test "$lines" -eq 20 In rtnetlink.sh line 694: rm -rf $tmpfile ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rm -rf "$tmpfile" In rtnetlink.sh line 699: ip addr del $srcip/32 dev $devdummy ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr del "$srcip"/32 dev "$devdummy" In rtnetlink.sh line 701: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 743: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 745: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 751: while [ ! -d $sysfsnet ] ; do :; done ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "$sysfsnet" ] ; do :; done In rtnetlink.sh line 753: dev=`ls $sysfsnet` ^------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev=$(ls "$sysfsnet") In rtnetlink.sh line 755: ip addr add $srcip dev $dev ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip addr add "$srcip" dev "$dev" In rtnetlink.sh line 756: ip link set $dev up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$dev" up In rtnetlink.sh line 757: if [ ! -d $sysfsd ] ; then ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ ! -d "$sysfsd" ] ; then In rtnetlink.sh line 761: if [ ! -f $sysfsf ] ; then ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ ! -f "$sysfsf" ] ; then In rtnetlink.sh line 770: run_cmd ip x p add dir out src $srcip/24 dst $dstip/24 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add dir out src "$srcip"/24 dst "$dstip"/24 \ In rtnetlink.sh line 771: tmpl proto esp src $srcip dst $dstip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$srcip" dst "$dstip" spi 9 \ In rtnetlink.sh line 774: run_cmd ip x p add dir in src $dstip/24 dst $srcip/24 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x p add dir in src "$dstip"/24 dst "$srcip"/24 \ In rtnetlink.sh line 775: tmpl proto esp src $dstip dst $srcip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tmpl proto esp src "$dstip" dst "$srcip" spi 9 \ In rtnetlink.sh line 778: run_cmd ip x s add proto esp src $srcip dst $dstip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add proto esp src "$srcip" dst "$dstip" spi 9 \ In rtnetlink.sh line 779: mode transport reqid 42 $algo sel src $srcip/24 dst $dstip/24 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mode transport reqid 42 "$algo" sel src "$srcip"/24 dst "$dstip"/24 \ In rtnetlink.sh line 780: offload dev $dev dir out ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: offload dev "$dev" dir out In rtnetlink.sh line 782: run_cmd ip x s add proto esp src $dstip dst $srcip spi 9 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip x s add proto esp src "$dstip" dst "$srcip" spi 9 \ In rtnetlink.sh line 783: mode transport reqid 42 $algo sel src $dstip/24 dst $srcip/24 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mode transport reqid 42 "$algo" sel src "$dstip"/24 dst "$srcip"/24 \ In rtnetlink.sh line 784: offload dev $dev dir in ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: offload dev "$dev" dir in In rtnetlink.sh line 786: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 792: lines=`ip x s list | grep -c "crypto offload parameters: dev $dev dir"` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: lines=$(ip x s list | grep -c "crypto offload parameters: dev $dev dir") In rtnetlink.sh line 793: if [ $lines -ne 2 ] ; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$lines" -ne 2 ] ; then In rtnetlink.sh line 799: ip neigh add $dstip dev $dev lladdr 00:11:22:33:44:55 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip neigh add "$dstip" dev "$dev" lladdr 00:11:22:33:44:55 In rtnetlink.sh line 801: ping -I $dev -c 3 -W 1 -i 0 $dstip >/dev/null ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping -I "$dev" -c 3 -W 1 -i 0 "$dstip" >/dev/null In rtnetlink.sh line 804: run_cmd diff $sysfsf - << EOF ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd diff "$sysfsf" - << EOF In rtnetlink.sh line 813: if [ $? -ne 0 ] ; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 821: lines=`grep -c "SA count=0" $sysfsf` ^----------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lines=$(grep -c "SA count=0" "$sysfsf") In rtnetlink.sh line 822: if [ $lines -ne 1 ] ; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$lines" -ne 1 ] ; then In rtnetlink.sh line 832: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 845: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 847: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 851: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 854: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 863: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 870: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 886: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 888: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 892: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 895: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 904: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 911: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 926: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 928: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 931: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 933: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 943: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 953: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 960: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 975: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 977: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 980: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 982: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 992: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 1002: run_cmd ip -netns "$testns" link set dev $DEV_NS up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$DEV_NS" up In rtnetlink.sh line 1011: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1031: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1033: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1037: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1039: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1043: run_cmd $IP link add "$vxlandev" type vxlan id 10 local $localip \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add "$vxlandev" type vxlan id 10 local "$localip" \ In rtnetlink.sh line 1045: run_cmd $IP link add name "$brdev" type bridge ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add name "$brdev" type bridge In rtnetlink.sh line 1046: run_cmd $IP link set dev "$vxlandev" master "$brdev" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link set dev "$vxlandev" master "$brdev" In rtnetlink.sh line 1047: run_cmd $BRIDGE fdb add $test_mac dev "$vxlandev" master ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$vxlandev" master In rtnetlink.sh line 1048: run_cmd $BRIDGE fdb add $test_mac dev "$vxlandev" dst $dstip self ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$vxlandev" dst "$dstip" self In rtnetlink.sh line 1049: run_cmd_grep "dev $vxlandev master $brdev" $BRIDGE fdb get $test_mac brport "$vxlandev" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev master $brdev" "$BRIDGE" fdb get "$test_mac" brport "$vxlandev" In rtnetlink.sh line 1050: run_cmd_grep "dev $vxlandev master $brdev" $BRIDGE fdb get $test_mac br "$brdev" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev master $brdev" "$BRIDGE" fdb get "$test_mac" br "$brdev" In rtnetlink.sh line 1051: run_cmd_grep "dev $vxlandev dst $dstip" $BRIDGE fdb get $test_mac dev "$vxlandev" self ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "dev $vxlandev dst $dstip" "$BRIDGE" fdb get "$test_mac" dev "$vxlandev" self In rtnetlink.sh line 1053: ip netns del $testns &>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" &>/dev/null In rtnetlink.sh line 1055: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1071: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1073: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1077: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1079: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1083: run_cmd $IP link add $dummydev type dummy ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add "$dummydev" type dummy In rtnetlink.sh line 1084: run_cmd $IP link add name $brdev type bridge vlan_filtering 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link add name "$brdev" type bridge vlan_filtering 1 In rtnetlink.sh line 1085: run_cmd $IP link set dev $dummydev master $brdev ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$IP" link set dev "$dummydev" master "$brdev" In rtnetlink.sh line 1086: run_cmd $BRIDGE fdb add $test_mac dev $dummydev master static vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb add "$test_mac" dev "$dummydev" master static vlan 1 In rtnetlink.sh line 1087: run_cmd $BRIDGE vlan del vid 1 dev $dummydev ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" vlan del vid 1 dev "$dummydev" In rtnetlink.sh line 1088: run_cmd $BRIDGE fdb get $test_mac br $brdev vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb get "$test_mac" br "$brdev" vlan 1 In rtnetlink.sh line 1089: run_cmd $BRIDGE fdb del $test_mac dev $dummydev master vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd "$BRIDGE" fdb del "$test_mac" dev "$dummydev" master vlan 1 In rtnetlink.sh line 1090: run_cmd_fail $BRIDGE fdb get $test_mac br $brdev vlan 1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_fail "$BRIDGE" fdb get "$test_mac" br "$brdev" vlan 1 In rtnetlink.sh line 1092: ip netns del $testns &>/dev/null ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns del "$testns" &>/dev/null In rtnetlink.sh line 1094: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1110: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1112: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1116: run_cmd ip neigh add $dstip lladdr $dstmac dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$dstip" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1117: run_cmd_grep "$dstmac" ip neigh get $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstmac" ip neigh get "$dstip" dev "$devdummy" In rtnetlink.sh line 1118: run_cmd ip neigh del $dstip lladdr $dstmac dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$dstip" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1121: run_cmd ip neigh add proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1122: run_cmd_grep "$dstip" ip neigh get proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip" ip neigh get proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1123: run_cmd ip neigh del proxy $dstip dev "$devdummy" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del proxy "$dstip" dev "$devdummy" In rtnetlink.sh line 1126: run_cmd ip neigh add $dstip6 lladdr $dstmac dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add "$dstip6" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1127: run_cmd_grep "$dstmac" ip neigh get $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstmac" ip neigh get "$dstip6" dev "$devdummy" In rtnetlink.sh line 1128: run_cmd ip neigh del $dstip6 lladdr $dstmac dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del "$dstip6" lladdr "$dstmac" dev "$devdummy" In rtnetlink.sh line 1131: run_cmd ip neigh add proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh add proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1132: run_cmd_grep "$dstip6" ip neigh get proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd_grep "$dstip6" ip neigh get proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1133: run_cmd ip neigh del proxy $dstip6 dev "$devdummy" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip neigh del proxy "$dstip6" dev "$devdummy" In rtnetlink.sh line 1135: if [ $ret -ne 0 ];then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ];then In rtnetlink.sh line 1151: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1153: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1159: while [ ! -d ${sysfsnet}10 ] ; do :; done ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "${sysfsnet}"10 ] ; do :; done In rtnetlink.sh line 1161: while [ ! -d ${sysfsnet}20 ] ; do :; done ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: while [ ! -d "${sysfsnet}"20 ] ; do :; done In rtnetlink.sh line 1163: dev10=`ls ${sysfsnet}10/net/` ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev10=$(ls "${sysfsnet}"10/net/) In rtnetlink.sh line 1164: dev20=`ls ${sysfsnet}20/net/` ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dev20=$(ls "${sysfsnet}"20/net/) In rtnetlink.sh line 1166: run_cmd ip link set dev $dev10 master test-bond0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set dev "$dev10" master test-bond0 In rtnetlink.sh line 1167: run_cmd ip link set dev $dev20 master test-bond0 ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip link set dev "$dev20" master test-bond0 In rtnetlink.sh line 1178: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1212: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1214: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1265: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1282: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 1291: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1293: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1296: run_cmd ip -netns $testns link add dev $bond type bond mode balance-rr ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link add dev "$bond" type bond mode balance-rr In rtnetlink.sh line 1297: run_cmd ip -netns $testns link add dev $devdummy type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link add dev "$devdummy" type dummy In rtnetlink.sh line 1298: run_cmd ip -netns $testns link set dev $devdummy up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$devdummy" up In rtnetlink.sh line 1299: run_cmd ip -netns $testns link set dev $devdummy master $bond down ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -netns "$testns" link set dev "$devdummy" master "$bond" down In rtnetlink.sh line 1300: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1320: local addr_list=$(ip -j -n $testns addr show dev ${dev}) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local addr_list=$(ip -j -n "$testns" addr show dev "${dev}") In rtnetlink.sh line 1321: local temp_addrs=$(echo ${addr_list} | \ ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local temp_addrs=$(echo "${addr_list}" | \ In rtnetlink.sh line 1323: local mng_prefixes=$(echo ${addr_list} | \ ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local mng_prefixes=$(echo "${addr_list}" | \ In rtnetlink.sh line 1326: local undep_prefixes=$(echo ${addr_list} | \ ^------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local undep_prefixes=$(echo "${addr_list}" | \ In rtnetlink.sh line 1332: prefix=$(echo ${address} | cut -d: -f1-4) ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: prefix=$(echo "${address}" | cut -d: -f1-4) In rtnetlink.sh line 1333: if [[ ! " ${mng_prefixes} " =~ " $prefix " ]]; then ^---------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally. In rtnetlink.sh line 1341: if [[ ! " ${undep_prefixes} " =~ " $prefix " ]]; then ^---------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally. In rtnetlink.sh line 1355: if [ $? -ne 0 ]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In rtnetlink.sh line 1357: return $ksft_skip ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ksft_skip" In rtnetlink.sh line 1361: run_cmd ip -n $testns link add ${devdummy} type dummy ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" link add "${devdummy}" type dummy In rtnetlink.sh line 1362: run_cmd ip -n $testns link set ${devdummy} up ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" link set "${devdummy}" up In rtnetlink.sh line 1363: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.use_tempaddr=1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".use_tempaddr=1 In rtnetlink.sh line 1364: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.temp_prefered_lft=10 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".temp_prefered_lft=10 In rtnetlink.sh line 1365: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.temp_valid_lft=25 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".temp_valid_lft=25 In rtnetlink.sh line 1366: run_cmd ip netns exec $testns sysctl -w net.ipv6.conf.${devdummy}.max_desync_factor=1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip netns exec "$testns" sysctl -w net.ipv6.conf."${devdummy}".max_desync_factor=1 In rtnetlink.sh line 1372: run_cmd ip -n $testns addr add 2001:db8:7e57:${i}::1/64 mngtmpaddr dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr add 2001:db8:7e57:"${i}"::1/64 mngtmpaddr dev "${devdummy}" In rtnetlink.sh line 1377: slowwait 30 validate_mngtmpaddr ${devdummy} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: slowwait 30 validate_mngtmpaddr "${devdummy}" In rtnetlink.sh line 1383: (( $i % 4 == 0 )) && mng_flag="mngtmpaddr" || mng_flag="" ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables. In rtnetlink.sh line 1384: if (( $i % 2 == 0 )); then ^-- SC2004 (style): $/${} is unnecessary on arithmetic variables. In rtnetlink.sh line 1385: run_cmd ip -n $testns addr del 2001:db8:7e57:${i}::1/64 $mng_flag dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr del 2001:db8:7e57:"${i}"::1/64 "$mng_flag" dev "${devdummy}" In rtnetlink.sh line 1387: run_cmd ip -n $testns addr change 2001:db8:7e57:${i}::1/64 dev ${devdummy} ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: run_cmd ip -n "$testns" addr change 2001:db8:7e57:"${i}"::1/64 dev "${devdummy}" In rtnetlink.sh line 1390: validate_mngtmpaddr ${devdummy} ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: validate_mngtmpaddr "${devdummy}" In rtnetlink.sh line 1393: if [ $ret -ne 0 ]; then ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$ret" -ne 0 ]; then In rtnetlink.sh line 1400: return $ret ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "$ret" In rtnetlink.sh line 1462: (options: $(echo $ALL_TESTS)) ^----------------^ SC2116 (style): Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: (options: $(echo "$ALL_TESTS")) In rtnetlink.sh line 1479: if [ $? -ne 0 ];then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. For more information: https://www.shellcheck.net/wiki/SC2034 -- spi appears unused. Verify use (o... https://www.shellcheck.net/wiki/SC2076 -- Remove quotes from right-hand sid... https://www.shellcheck.net/wiki/SC2154 -- testns is referenced but not assi... Checking tools/testing/selftests/net/vlan_bridge_binding.sh - 62b03e4b302fe2b5de91ca98e5714f032b4653afda5976a3b9816c2df41c5328 In vlan_bridge_binding.sh line 51: local operstate=$(ip -j link show $dev | jq -r .[].operstate) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local operstate=$(ip -j link show "$dev" | jq -r .[].operstate) In vlan_bridge_binding.sh line 57: echo -n $operstate ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo -n "$operstate" In vlan_bridge_binding.sh line 58: [[ $operstate == $expect ]] ^-----^ SC2053 (warning): Quote the right-hand side of == in [[ ]] to prevent glob matching. In vlan_bridge_binding.sh line 77: adf_ip_link_add $link.$id link $link type vlan id $id "$@" ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_ip_link_add "$link"."$id" link "$link" type vlan id "$id" "$@" In vlan_bridge_binding.sh line 101: adf_ip_link_set_down $dev ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_ip_link_set_down "$dev" In vlan_bridge_binding.sh line 112: check_operstate br.11 $opst_11 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_operstate br.11 "$opst_11" In vlan_bridge_binding.sh line 113: check_operstate br.12 $opst_12 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_operstate br.12 "$opst_12" In vlan_bridge_binding.sh line 114: check_operstate br.13 $opst_13 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_operstate br.13 "$opst_13" In vlan_bridge_binding.sh line 115: check_operstate br.14 $opst_14 ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_operstate br.14 "$opst_14" In vlan_bridge_binding.sh line 132: check_operstates $opsts_d1 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_operstates "$opsts_d1" In vlan_bridge_binding.sh line 138: check_operstates $opsts_d2 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_operstates "$opsts_d2" In vlan_bridge_binding.sh line 144: check_operstates $opsts_d12 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_operstates "$opsts_d12" In vlan_bridge_binding.sh line 150: check_operstates $opsts_d123 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: check_operstates "$opsts_d123" In vlan_bridge_binding.sh line 258: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2053 -- Quote the right-hand side of == i... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...