ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.tA3GYxlZHj and /tmp/tmp.xjAAx5RTVJ
Tree base:
606c15c7b7a3 ("bridge: br_vlan_fill_forward_path_pvid: use br_vlan_group_rcu()")
Now at:
077063b193b7 ("selftests: netfilter: nft_fib.sh: fix spurious test failures")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/netfilter/nft_fib.sh - b90d70ed72ff4fc793dea2d892ca1b473f20fa446b4b59643853b44296949fd0


In nft_fib.sh line 23:
	[ "$log_netns" -eq 0 ] && sysctl -q net.netfilter.nf_log_all_netns=$log_netns
                                                                           ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	[ "$log_netns" -eq 0 ] && sysctl -q net.netfilter.nf_log_all_netns="$log_netns"


In nft_fib.sh line 205:
load_ruleset "$nsrouter"
              ^-------^ SC2154 (warning): nsrouter is referenced but not assigned.


In nft_fib.sh line 206:
load_ruleset "$ns1"
              ^--^ SC2154 (warning): ns1 is referenced but not assigned.


In nft_fib.sh line 207:
load_ruleset "$ns2"
              ^--^ SC2154 (warning): ns2 is referenced but not assigned.


In nft_fib.sh line 426:
if [ $? -ne 0 ] ;then
     ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In nft_fib.sh line 443:
	if ! ip netns exec "$nsrouter" nft get element inet t "$setname" { "$iifname" . "$addr" . "$type" } |grep -q "counter packets $count";then
                                                                         ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                                                                                                          ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In nft_fib.sh line 452:
	if ! ip netns exec "$nsrouter" nft delete element inet t "$setname" { "$iifname" . "$addr" . "$type" } ; then
                                                                            ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                                                                                                             ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In nft_fib.sh line 464:
	check_type $@ "local" 1
                   ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.


In nft_fib.sh line 469:
	check_type $@ "unicast" 1
                   ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.


In nft_fib.sh line 474:
	check_type $@
                   ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.


In nft_fib.sh line 670:
	local cntname=""
              ^-----^ SC2034 (warning): cntname appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ...
  https://www.shellcheck.net/wiki/SC1083 -- This { is literal. Check expressi...
  https://www.shellcheck.net/wiki/SC2034 -- cntname appears unused. Verify us...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/netfilter/nft_fib.sh - b90d70ed72ff4fc793dea2d892ca1b473f20fa446b4b59643853b44296949fd0


In nft_fib.sh line 23:
	[ "$log_netns" -eq 0 ] && sysctl -q net.netfilter.nf_log_all_netns=$log_netns
                                                                           ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	[ "$log_netns" -eq 0 ] && sysctl -q net.netfilter.nf_log_all_netns="$log_netns"


In nft_fib.sh line 205:
load_ruleset "$nsrouter"
              ^-------^ SC2154 (warning): nsrouter is referenced but not assigned.


In nft_fib.sh line 206:
load_ruleset "$ns1"
              ^--^ SC2154 (warning): ns1 is referenced but not assigned.


In nft_fib.sh line 207:
load_ruleset "$ns2"
              ^--^ SC2154 (warning): ns2 is referenced but not assigned.


In nft_fib.sh line 426:
if [ $? -ne 0 ] ;then
     ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.


In nft_fib.sh line 444:
	if ! ip netns exec "$nsrouter" nft get element inet t "$setname" { "$iifname" . "$addr" . "$type" } |grep -q "counter packets $count";then
                                                                         ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                                                                                                          ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In nft_fib.sh line 455:
	if ! ip netns exec "$nsrouter" nft delete element inet t "$setname" { "$iifname" . "$addr" . "$type" } ; then
                                                                            ^-- SC1083 (warning): This { is literal. Check expression (missing ;/\n?) or quote it.
                                                                                                             ^-- SC1083 (warning): This } is literal. Check expression (missing ;/\n?) or quote it.


In nft_fib.sh line 467:
	check_type $@ "local" 1
                   ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.


In nft_fib.sh line 472:
	check_type $@ "unicast" 1
                   ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.


In nft_fib.sh line 477:
	check_type $@
                   ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.


In nft_fib.sh line 673:
	local cntname=""
              ^-----^ SC2034 (warning): cntname appears unused. Verify use (or export if used externally).

For more information:
  https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ...
  https://www.shellcheck.net/wiki/SC1083 -- This { is literal. Check expressi...
  https://www.shellcheck.net/wiki/SC2034 -- cntname appears unused. Verify us...