pylint 3.3.7 astroid 3.3.8 Python 3.13.7 (main, Aug 14 2025, 00:00:00) [GCC 15.2.1 20250808 (Red Hat 15.2.1-1)] Redirect to /tmp/tmp.YokWZq2QYm and /tmp/tmp.oZjgFnphpU Tree base: 07fdad3a9375 ("Merge tag 'net-next-6.18' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next") Now at: beb95b4c0258 ("selftests: drv-net: make linters happy with our imports") ====== Checking before the patch ====== ************* Module hds tools/testing/selftests/drivers/net/hds.py:187:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hds.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/hds.py:10:0: E0611: No name 'random' in module 'lib.py' (no-name-in-module) tools/testing/selftests/drivers/net/hds.py:17:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:16:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:25:7: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/hds.py:27:7: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/hds.py:38:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:37:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:50:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:54:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:58:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:57:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:89:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:93:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:98:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:99:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('disabling of HDS not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:101:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:105:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:104:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:111:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:116:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:117:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('disabling of HDS not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:119:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:123:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:122:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:129:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:134:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:135:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('hds-thresh-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:137:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:141:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:140:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:147:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:152:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:158:4: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:171:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:172:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('hds-thresh-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:174:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:151:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:178:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:183:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:189:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:190:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('hds-thresh-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:192:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:182:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:196:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:201:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:200:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:238:40: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:242:0: E0102: function already defined line 212 (function-redefined) tools/testing/selftests/drivers/net/hds.py:255:0: E0102: function already defined line 226 (function-redefined) tools/testing/selftests/drivers/net/hds.py:267:40: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:271:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:305:40: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:309:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:5:0: W0611: Unused import os (unused-import) ------------------------------------------------------------------ Your code has been rated at 6.81/10 (previous run: 6.81/10, +0.00) ************* Module py tools/testing/selftests/drivers/net/lib/py/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/lib/py/__init__.py:26:4: E0601: Using variable 'ksft_pr' before assignment (used-before-assignment) tools/testing/selftests/drivers/net/lib/py/__init__.py:28:4: E0602: Undefined variable 'ktap_result' (undefined-variable) tools/testing/selftests/drivers/net/lib/py/__init__.py:31:0: C0413: Import "from .env import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:32:0: C0413: Import "from .load import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:33:0: C0413: Import "from .remote import Remote" should be placed at the top of the module (wrong-import-position) ------------------------------------------------------------------ Your code has been rated at 3.33/10 (previous run: 3.33/10, +0.00) ====== Checking the tree with the patch ====== ************* Module hds tools/testing/selftests/drivers/net/hds.py:188:0: C0301: Line too long (102/100) (line-too-long) tools/testing/selftests/drivers/net/hds.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/hds.py:18:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:17:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:26:7: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/hds.py:28:7: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/testing/selftests/drivers/net/hds.py:39:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:38:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:51:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:55:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:59:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:58:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:90:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:94:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:99:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:100:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('disabling of HDS not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:102:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:106:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:105:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:112:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:117:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:118:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('disabling of HDS not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:120:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:124:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:123:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:130:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:135:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:136:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('hds-thresh-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:138:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:142:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:141:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:148:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:153:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:159:4: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:172:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:173:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('hds-thresh-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:175:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:152:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:179:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:184:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:190:8: R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise) tools/testing/selftests/drivers/net/hds.py:191:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('hds-thresh-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:193:12: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-set not supported by the device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:183:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:197:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:202:8: W0707: Consider explicitly re-raising using 'raise KsftSkipEx('ring-get not supported by device') from e' (raise-missing-from) tools/testing/selftests/drivers/net/hds.py:201:4: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:239:40: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:243:0: E0102: function already defined line 213 (function-redefined) tools/testing/selftests/drivers/net/hds.py:256:0: E0102: function already defined line 227 (function-redefined) tools/testing/selftests/drivers/net/hds.py:268:40: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:272:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:306:40: W0612: Unused variable 'e' (unused-variable) tools/testing/selftests/drivers/net/hds.py:310:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/hds.py:5:0: W0611: Unused import os (unused-import) ------------------------------------------------------------------ Your code has been rated at 7.06/10 (previous run: 6.81/10, +0.25) ------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 3.33/10, +6.67)