WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 WARNING: line length of 82 exceeds 80 columns #58: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:18: +static void __test_run(struct bpf_program *prog, void *ctx_in, size_t ctx_size_in) CHECK: Alignment should match open parenthesis #61: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:21: + LIBBPF_OPTS(bpf_test_run_opts, topts, + .ctx_in = ctx_in, WARNING: line length of 86 exceeds 80 columns #99: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:59: +/* validate that for two loads of the same jump table libbpf generates only one map */ WARNING: line length of 86 exceeds 80 columns #136: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:96: + if (!ASSERT_EQ(seen, false, "more than one INSN_ARRAY map")) { ERROR: space prohibited before that ',' (ctx:WxW) #157: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:117: + __u64 out4[] = {12, 15, 7 , 15, 12, 15, 15}; ^ ERROR: trailing statements should be on next line #168: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:128: + if (0) for (i = 0; i < ARRAY_SIZE(in); i++) ERROR: trailing statements should be on next line #171: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:131: + if (0) for (i = 0; i < ARRAY_SIZE(in); i++) WARNING: line length of 83 exceeds 80 columns #172: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:132: + check_simple(skel, skel->progs.one_jump_two_maps, in4[i], out4[i]); WARNING: line length of 82 exceeds 80 columns #175: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:135: + check_simple(skel, skel->progs.use_static_global1, in[i], out[i]); WARNING: line length of 82 exceeds 80 columns #178: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:138: + check_simple(skel, skel->progs.use_static_global2, in[i], out[i]); WARNING: line length of 85 exceeds 80 columns #181: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:141: + check_simple(skel, skel->progs.use_nonstatic_global1, in[i], out[i]); WARNING: line length of 85 exceeds 80 columns #184: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:144: + check_simple(skel, skel->progs.use_nonstatic_global2, in[i], out[i]); WARNING: line length of 92 exceeds 80 columns #188: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:148: + check_simple_fentry(skel, skel->progs.simple_test_other_sec, in[i], out[i]); WARNING: line length of 98 exceeds 80 columns #192: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:152: + check_simple_fentry(skel, skel->progs.use_static_global_other_sec, in[i], out[i]); WARNING: line length of 101 exceeds 80 columns #196: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:156: + check_simple_fentry(skel, skel->progs.use_nonstatic_global_other_sec, in[i], out[i]); ERROR: trailing statements should be on next line #198: FILE: tools/testing/selftests/bpf/prog_tests/bpf_gotox.c:158: + if (0) check_one_map_two_jumps(skel); WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #413: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:190: +int big_jump_table(struct simple_ctx *ctx __attribute__((unused))) WARNING: Consider removing the code enclosed by this #if 0 and its #endif #415: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:192: +#if 0 WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #456: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:233: +int one_jump_two_maps(struct simple_ctx *ctx __attribute__((unused))) WARNING: Consider removing the code enclosed by this #if 0 and its #endif #458: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:235: +#if 0 WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #464: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:241: + volatile int ret = 0; WARNING: labels should not be indented #474: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:251: + l1: ret += 1; WARNING: labels should not be indented #475: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:252: + l2: ret += 3; WARNING: labels should not be indented #476: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:253: + l3: ret += 5; WARNING: labels should not be indented #477: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:254: + l4: ret += 7; WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__)) #487: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:264: +int one_map_two_jumps(struct simple_ctx *ctx __attribute__((unused))) WARNING: Consider removing the code enclosed by this #if 0 and its #endif #489: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:266: +#if 0 WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #494: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:271: + volatile int ret = 0; WARNING: labels should not be indented #502: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:279: + l1: ret += 3; WARNING: labels should not be indented #503: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:280: + l2: ret += 5; WARNING: labels should not be indented #504: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:281: + l3: ret += 7; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #514: FILE: tools/testing/selftests/bpf/progs/bpf_gotox.c:291: +static __noinline int f0(volatile struct simple_ctx *ctx __arg_ctx) total: 4 errors, 28 warnings, 1 checks, 598 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 4a633d8fb235 ("selftests/bpf: add selftests for indirect jumps") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.