WARNING: line length of 85 exceeds 80 columns #70: FILE: tools/lib/bpf/gen_loader.c:463: + libbpf_sha256(gen->data_start, gen->data_cur - gen->data_start, (__u8 *)sha); CHECK: Macro argument 'd' may be better as '(d)' to avoid precedence issues #179: FILE: tools/lib/bpf/libbpf.c:14316: +#define SHA256_ROUND(i, a, b, c, d, e, f, g, h) \ + { \ + __u32 tmp = h + Sigma_1(e) + Ch(e, f, g) + sha256_K[i] + w[i]; \ + d += tmp; \ + h = tmp + Sigma_0(a) + Maj(a, b, c); \ + } CHECK: Macro argument 'h' may be better as '(h)' to avoid precedence issues #179: FILE: tools/lib/bpf/libbpf.c:14316: +#define SHA256_ROUND(i, a, b, c, d, e, f, g, h) \ + { \ + __u32 tmp = h + Sigma_1(e) + Ch(e, f, g) + sha256_K[i] + w[i]; \ + d += tmp; \ + h = tmp + Sigma_0(a) + Maj(a, b, c); \ + } WARNING: Consider removing the code enclosed by this #if 0 and its #endif #271: FILE: tools/lib/bpf/libbpf.c:14386: +#if 0 /* To test libbpf_sha256(), uncomment this. Requires -lcrypto. */ WARNING: line length of 81 exceeds 80 columns #305: FILE: tools/lib/bpf/libbpf_internal.h:742: +void libbpf_sha256(const void *data, size_t len, __u8 out[SHA256_DIGEST_LENGTH]); total: 0 errors, 3 warnings, 2 checks, 259 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 87451cfd0465 ("libbpf: Don't use AF_ALG for SHA-256") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 3 warnings, 2 checks, 259 lines checked