pylint 3.3.7 astroid 3.3.8 Python 3.13.7 (main, Aug 14 2025, 00:00:00) [GCC 15.2.1 20250808 (Red Hat 15.2.1-1)] Redirect to /tmp/tmp.Dik6FFVvB4 and /tmp/tmp.pBIfZgkNxP Tree base: 41983a889c50 ("selftests: drv-net: psp: add test for auto-adjusting TCP MSS") Now at: 0e4d00aae054 ("selftests: drv-net: psp: add tests for destroying devices") ====== Checking before the patch ====== ************* Module py tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:30:4: E0601: Using variable 'ksft_pr' before assignment (used-before-assignment) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:32:4: E0602: Undefined variable 'ktap_result' (undefined-variable) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:15:4: C0412: Imports from package net are not grouped (ungrouped-imports) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:27:4: C0412: Imports from package drivers are not grouped (ungrouped-imports) ------------------------------------------------------------------ Your code has been rated at 4.09/10 (previous run: 3.33/10, +0.76) ************* Module py tools/testing/selftests/drivers/net/lib/py/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/lib/py/__init__.py:26:4: E0601: Using variable 'ksft_pr' before assignment (used-before-assignment) tools/testing/selftests/drivers/net/lib/py/__init__.py:28:4: E0602: Undefined variable 'ktap_result' (undefined-variable) tools/testing/selftests/drivers/net/lib/py/__init__.py:31:0: C0413: Import "from .env import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:32:0: C0413: Import "from .load import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:33:0: C0413: Import "from .remote import Remote" should be placed at the top of the module (wrong-import-position) ------------------------------------------------------------------ Your code has been rated at 3.33/10 (previous run: 4.09/10, -0.76) ************* Module py.env tools/testing/selftests/drivers/net/lib/py/env.py:164:0: C0301: Line too long (114/100) (line-too-long) tools/testing/selftests/drivers/net/lib/py/env.py:190:0: C0301: Line too long (101/100) (line-too-long) tools/testing/selftests/drivers/net/lib/py/env.py:191:0: C0301: Line too long (107/100) (line-too-long) tools/testing/selftests/drivers/net/lib/py/env.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/lib/py/env.py:6:0: E0401: Unable to import 'lib.py' (import-error) tools/testing/selftests/drivers/net/lib/py/env.py:7:0: E0401: Unable to import 'lib.py' (import-error) tools/testing/selftests/drivers/net/lib/py/env.py:8:0: E0401: Unable to import 'lib.py' (import-error) tools/testing/selftests/drivers/net/lib/py/env.py:9:0: E0401: Unable to import 'lib.py' (import-error) tools/testing/selftests/drivers/net/lib/py/env.py:38:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) tools/testing/selftests/drivers/net/lib/py/env.py:50:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/lib/py/env.py:71:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/testing/selftests/drivers/net/lib/py/env.py:100:0: R0902: Too many instance attributes (17/7) (too-many-instance-attributes) tools/testing/selftests/drivers/net/lib/py/env.py:174:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/lib/py/env.py:179:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) tools/testing/selftests/drivers/net/lib/py/env.py:180:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) tools/testing/selftests/drivers/net/lib/py/env.py:215:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/lib/py/env.py:218:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/lib/py/env.py:225:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/lib/py/env.py:227:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/lib/py/env.py:244:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/lib/py/env.py:256:4: C0116: Missing function or method docstring (missing-function-docstring) ------------------------------------------------------------------ Your code has been rated at 7.96/10 (previous run: 7.62/10, +0.33) -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) ************* Module py.ksft tools/testing/selftests/net/lib/py/ksft.py:117:0: C0301: Line too long (108/100) (line-too-long) tools/testing/selftests/net/lib/py/ksft.py:280:0: C0301: Line too long (126/100) (line-too-long) tools/testing/selftests/net/lib/py/ksft.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/net/lib/py/ksft.py:18:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:22:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:26:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:30:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:34:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:40:4: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:58:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:59:4: W0602: Using global for 'KSFT_RESULT' but no assignment is done (global-variable-not-assigned) tools/testing/selftests/net/lib/py/ksft.py:64:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:65:4: W0602: Using global for 'KSFT_RESULT' but no assignment is done (global-variable-not-assigned) tools/testing/selftests/net/lib/py/ksft.py:70:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:75:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:80:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:85:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:90:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:95:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:100:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:105:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:105:0: C0103: Class name "ksft_raises" doesn't conform to PascalCase naming style (invalid-name) tools/testing/selftests/net/lib/py/ksft.py:123:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:134:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:135:4: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:151:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:152:4: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:161:8: W0702: No exception type(s) specified (bare-except) tools/testing/selftests/net/lib/py/ksft.py:179:29: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) tools/testing/selftests/net/lib/py/ksft.py:198:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise Exception(f'failed to parse {name}') from exc' (raise-missing-from) tools/testing/selftests/net/lib/py/ksft.py:198:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/net/lib/py/ksft.py:201:8: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:210:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) tools/testing/selftests/net/lib/py/ksft.py:211:4: E0602: Undefined variable 'term_cnt' (undefined-variable) tools/testing/selftests/net/lib/py/ksft.py:212:4: R1720: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise) tools/testing/selftests/net/lib/py/ksft.py:207:15: W0613: Unused argument 'signum' (unused-argument) tools/testing/selftests/net/lib/py/ksft.py:207:23: W0613: Unused argument 'frame' (unused-argument) tools/testing/selftests/net/lib/py/ksft.py:218:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:218:0: R0914: Too many local variables (17/15) (too-many-locals) tools/testing/selftests/net/lib/py/ksft.py:230:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) tools/testing/selftests/net/lib/py/ksft.py:239:4: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:256:15: W0718: Catching too general exception BaseException (broad-exception-caught) tools/testing/selftests/net/lib/py/ksft.py:218:0: R0912: Too many branches (13/12) (too-many-branches) tools/testing/selftests/net/lib/py/ksft.py:284:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:285:4: W0602: Using global for 'KSFT_RESULT_ALL' but no assignment is done (global-variable-not-assigned) tools/testing/selftests/net/lib/py/ksft.py:3:0: W0611: Unused import builtins (unused-import) ------------------------------------------------------------------ Your code has been rated at 7.45/10 (previous run: 7.45/10, +0.00) ====== Checking the tree with the patch ====== ************* Module py tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:30:4: E0601: Using variable 'ksft_pr' before assignment (used-before-assignment) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:32:4: E0602: Undefined variable 'ktap_result' (undefined-variable) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:15:4: C0412: Imports from package net are not grouped (ungrouped-imports) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:27:4: C0412: Imports from package drivers are not grouped (ungrouped-imports) ------------------------------------------------------------------ Your code has been rated at 4.09/10 (previous run: 3.33/10, +0.76) ************* Module py tools/testing/selftests/drivers/net/lib/py/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/lib/py/__init__.py:26:4: E0601: Using variable 'ksft_pr' before assignment (used-before-assignment) tools/testing/selftests/drivers/net/lib/py/__init__.py:28:4: E0602: Undefined variable 'ktap_result' (undefined-variable) tools/testing/selftests/drivers/net/lib/py/__init__.py:31:0: C0413: Import "from .env import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:32:0: C0413: Import "from .load import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:33:0: C0413: Import "from .remote import Remote" should be placed at the top of the module (wrong-import-position) ------------------------------------------------------------------ Your code has been rated at 3.33/10 (previous run: 4.09/10, -0.76) ************* Module py.env tools/testing/selftests/drivers/net/lib/py/env.py:164:0: C0301: Line too long (114/100) (line-too-long) tools/testing/selftests/drivers/net/lib/py/env.py:190:0: C0301: Line too long (101/100) (line-too-long) tools/testing/selftests/drivers/net/lib/py/env.py:191:0: C0301: Line too long (107/100) (line-too-long) tools/testing/selftests/drivers/net/lib/py/env.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/lib/py/env.py:6:0: E0401: Unable to import 'lib.py' (import-error) tools/testing/selftests/drivers/net/lib/py/env.py:7:0: E0401: Unable to import 'lib.py' (import-error) tools/testing/selftests/drivers/net/lib/py/env.py:8:0: E0401: Unable to import 'lib.py' (import-error) tools/testing/selftests/drivers/net/lib/py/env.py:9:0: E0401: Unable to import 'lib.py' (import-error) tools/testing/selftests/drivers/net/lib/py/env.py:38:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) tools/testing/selftests/drivers/net/lib/py/env.py:50:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/lib/py/env.py:71:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/testing/selftests/drivers/net/lib/py/env.py:100:0: R0902: Too many instance attributes (17/7) (too-many-instance-attributes) tools/testing/selftests/drivers/net/lib/py/env.py:174:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/lib/py/env.py:179:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) tools/testing/selftests/drivers/net/lib/py/env.py:180:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) tools/testing/selftests/drivers/net/lib/py/env.py:215:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/lib/py/env.py:218:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/lib/py/env.py:225:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/lib/py/env.py:227:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/lib/py/env.py:244:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/lib/py/env.py:248:4: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/lib/py/env.py:260:4: C0116: Missing function or method docstring (missing-function-docstring) ------------------------------------------------------------------ Your code has been rated at 7.93/10 (previous run: 7.96/10, -0.02) ************* Module psp tools/testing/selftests/drivers/net/psp.py:506:13: R1718: Consider using a set comprehension (consider-using-set-comprehension) tools/testing/selftests/drivers/net/psp.py:508:4: W0212: Access to a protected member _ns of a client class (protected-access) tools/testing/selftests/drivers/net/psp.py:510:12: R1718: Consider using a set comprehension (consider-using-set-comprehension) ------------------------------------------------------------------- Your code has been rated at 9.91/10 (previous run: 10.00/10, -0.09) ************* Module py.ksft tools/testing/selftests/net/lib/py/ksft.py:122:0: C0301: Line too long (108/100) (line-too-long) tools/testing/selftests/net/lib/py/ksft.py:285:0: C0301: Line too long (126/100) (line-too-long) tools/testing/selftests/net/lib/py/ksft.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/net/lib/py/ksft.py:18:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:22:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:26:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:30:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:34:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:40:4: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:58:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:59:4: W0602: Using global for 'KSFT_RESULT' but no assignment is done (global-variable-not-assigned) tools/testing/selftests/net/lib/py/ksft.py:64:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:65:4: W0602: Using global for 'KSFT_RESULT' but no assignment is done (global-variable-not-assigned) tools/testing/selftests/net/lib/py/ksft.py:70:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:75:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:80:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:85:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:90:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:95:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:100:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:105:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:110:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:110:0: C0103: Class name "ksft_raises" doesn't conform to PascalCase naming style (invalid-name) tools/testing/selftests/net/lib/py/ksft.py:128:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:139:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:140:4: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:156:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:157:4: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:166:8: W0702: No exception type(s) specified (bare-except) tools/testing/selftests/net/lib/py/ksft.py:184:29: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) tools/testing/selftests/net/lib/py/ksft.py:203:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise Exception(f'failed to parse {name}') from exc' (raise-missing-from) tools/testing/selftests/net/lib/py/ksft.py:203:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/net/lib/py/ksft.py:206:8: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:215:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) tools/testing/selftests/net/lib/py/ksft.py:216:4: E0602: Undefined variable 'term_cnt' (undefined-variable) tools/testing/selftests/net/lib/py/ksft.py:217:4: R1720: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise) tools/testing/selftests/net/lib/py/ksft.py:212:15: W0613: Unused argument 'signum' (unused-argument) tools/testing/selftests/net/lib/py/ksft.py:212:23: W0613: Unused argument 'frame' (unused-argument) tools/testing/selftests/net/lib/py/ksft.py:223:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:223:0: R0914: Too many local variables (17/15) (too-many-locals) tools/testing/selftests/net/lib/py/ksft.py:235:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) tools/testing/selftests/net/lib/py/ksft.py:244:4: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:261:15: W0718: Catching too general exception BaseException (broad-exception-caught) tools/testing/selftests/net/lib/py/ksft.py:223:0: R0912: Too many branches (13/12) (too-many-branches) tools/testing/selftests/net/lib/py/ksft.py:289:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:290:4: W0602: Using global for 'KSFT_RESULT_ALL' but no assignment is done (global-variable-not-assigned) tools/testing/selftests/net/lib/py/ksft.py:3:0: W0611: Unused import builtins (unused-import) ------------------------------------------------------------------ Your code has been rated at 7.44/10 (previous run: 7.45/10, -0.01)