====== Checking before the patch ====== ====== Checking the tree with the patch ====== New warnings added --- /tmp/tmp.Dik6FFVvB4 2025-09-27 17:05:49.739992237 -0700 +++ /tmp/tmp.pBIfZgkNxP 2025-09-27 17:05:54.782477229 -0700 @@ -43 +43,2 @@ -tools/testing/selftests/drivers/net/lib/py/env.py:256:4: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/drivers/net/lib/py/env.py:248:4: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/drivers/net/lib/py/env.py:260:4: C0116: Missing function or method docstring (missing-function-docstring) @@ -46 +47 @@ -Your code has been rated at 7.96/10 (previous run: 7.62/10, +0.33) +Your code has been rated at 7.93/10 (previous run: 7.96/10, -0.02) @@ -47,0 +49,4 @@ +************* Module psp +tools/testing/selftests/drivers/net/psp.py:506:13: R1718: Consider using a set comprehension (consider-using-set-comprehension) +tools/testing/selftests/drivers/net/psp.py:508:4: W0212: Access to a protected member _ns of a client class (protected-access) +tools/testing/selftests/drivers/net/psp.py:510:12: R1718: Consider using a set comprehension (consider-using-set-comprehension) @@ -49,2 +54,2 @@ --------------------------------------------------------------------- -Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) +------------------------------------------------------------------- +Your code has been rated at 9.91/10 (previous run: 10.00/10, -0.09) @@ -53,2 +58,2 @@ -tools/testing/selftests/net/lib/py/ksft.py:117:0: C0301: Line too long (108/100) (line-too-long) -tools/testing/selftests/net/lib/py/ksft.py:280:0: C0301: Line too long (126/100) (line-too-long) +tools/testing/selftests/net/lib/py/ksft.py:122:0: C0301: Line too long (108/100) (line-too-long) +tools/testing/selftests/net/lib/py/ksft.py:285:0: C0301: Line too long (126/100) (line-too-long) @@ -73,25 +78,26 @@ -tools/testing/selftests/net/lib/py/ksft.py:105:0: C0115: Missing class docstring (missing-class-docstring) -tools/testing/selftests/net/lib/py/ksft.py:105:0: C0103: Class name "ksft_raises" doesn't conform to PascalCase naming style (invalid-name) -tools/testing/selftests/net/lib/py/ksft.py:123:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/ksft.py:134:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/ksft.py:135:4: W0603: Using the global statement (global-statement) -tools/testing/selftests/net/lib/py/ksft.py:151:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/ksft.py:152:4: W0603: Using the global statement (global-statement) -tools/testing/selftests/net/lib/py/ksft.py:161:8: W0702: No exception type(s) specified (bare-except) -tools/testing/selftests/net/lib/py/ksft.py:179:29: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) -tools/testing/selftests/net/lib/py/ksft.py:198:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise Exception(f'failed to parse {name}') from exc' (raise-missing-from) -tools/testing/selftests/net/lib/py/ksft.py:198:12: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/testing/selftests/net/lib/py/ksft.py:201:8: W0603: Using the global statement (global-statement) -tools/testing/selftests/net/lib/py/ksft.py:210:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) -tools/testing/selftests/net/lib/py/ksft.py:211:4: E0602: Undefined variable 'term_cnt' (undefined-variable) -tools/testing/selftests/net/lib/py/ksft.py:212:4: R1720: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise) -tools/testing/selftests/net/lib/py/ksft.py:207:15: W0613: Unused argument 'signum' (unused-argument) -tools/testing/selftests/net/lib/py/ksft.py:207:23: W0613: Unused argument 'frame' (unused-argument) -tools/testing/selftests/net/lib/py/ksft.py:218:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/ksft.py:218:0: R0914: Too many local variables (17/15) (too-many-locals) -tools/testing/selftests/net/lib/py/ksft.py:230:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) -tools/testing/selftests/net/lib/py/ksft.py:239:4: W0603: Using the global statement (global-statement) -tools/testing/selftests/net/lib/py/ksft.py:256:15: W0718: Catching too general exception BaseException (broad-exception-caught) -tools/testing/selftests/net/lib/py/ksft.py:218:0: R0912: Too many branches (13/12) (too-many-branches) -tools/testing/selftests/net/lib/py/ksft.py:284:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/ksft.py:285:4: W0602: Using global for 'KSFT_RESULT_ALL' but no assignment is done (global-variable-not-assigned) +tools/testing/selftests/net/lib/py/ksft.py:105:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/ksft.py:110:0: C0115: Missing class docstring (missing-class-docstring) +tools/testing/selftests/net/lib/py/ksft.py:110:0: C0103: Class name "ksft_raises" doesn't conform to PascalCase naming style (invalid-name) +tools/testing/selftests/net/lib/py/ksft.py:128:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/ksft.py:139:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/ksft.py:140:4: W0603: Using the global statement (global-statement) +tools/testing/selftests/net/lib/py/ksft.py:156:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/ksft.py:157:4: W0603: Using the global statement (global-statement) +tools/testing/selftests/net/lib/py/ksft.py:166:8: W0702: No exception type(s) specified (bare-except) +tools/testing/selftests/net/lib/py/ksft.py:184:29: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) +tools/testing/selftests/net/lib/py/ksft.py:203:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise Exception(f'failed to parse {name}') from exc' (raise-missing-from) +tools/testing/selftests/net/lib/py/ksft.py:203:12: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/testing/selftests/net/lib/py/ksft.py:206:8: W0603: Using the global statement (global-statement) +tools/testing/selftests/net/lib/py/ksft.py:215:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) +tools/testing/selftests/net/lib/py/ksft.py:216:4: E0602: Undefined variable 'term_cnt' (undefined-variable) +tools/testing/selftests/net/lib/py/ksft.py:217:4: R1720: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise) +tools/testing/selftests/net/lib/py/ksft.py:212:15: W0613: Unused argument 'signum' (unused-argument) +tools/testing/selftests/net/lib/py/ksft.py:212:23: W0613: Unused argument 'frame' (unused-argument) +tools/testing/selftests/net/lib/py/ksft.py:223:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/ksft.py:223:0: R0914: Too many local variables (17/15) (too-many-locals) +tools/testing/selftests/net/lib/py/ksft.py:235:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) +tools/testing/selftests/net/lib/py/ksft.py:244:4: W0603: Using the global statement (global-statement) +tools/testing/selftests/net/lib/py/ksft.py:261:15: W0718: Catching too general exception BaseException (broad-exception-caught) +tools/testing/selftests/net/lib/py/ksft.py:223:0: R0912: Too many branches (13/12) (too-many-branches) +tools/testing/selftests/net/lib/py/ksft.py:289:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/ksft.py:290:4: W0602: Using global for 'KSFT_RESULT_ALL' but no assignment is done (global-variable-not-assigned) @@ -101 +107 @@ -Your code has been rated at 7.45/10 (previous run: 7.45/10, +0.00) +Your code has been rated at 7.44/10 (previous run: 7.45/10, -0.01)