WARNING: line length of 82 exceeds 80 columns #72: FILE: tools/testing/selftests/bpf/prog_tests/res_spin_lock.c:110: + ASSERT_OK(load_module("bpf_test_rqspinlock.ko", false), "load module AA"); WARNING: line length of 104 exceeds 80 columns #76: FILE: tools/testing/selftests/bpf/prog_tests/res_spin_lock.c:114: + ASSERT_OK(load_module_params("bpf_test_rqspinlock.ko", "test_ab=1", false), "load module ABBA"); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #94: new file mode 100644 ERROR: do not initialise statics to false #127: FILE: tools/testing/selftests/bpf/test_kmods/bpf_test_rqspinlock.c:29: +static bool test_ab = false; ERROR: do not initialise statics to 0 #135: FILE: tools/testing/selftests/bpf/test_kmods/bpf_test_rqspinlock.c:37: +static int pause = 0; WARNING: line length of 84 exceeds 80 columns #202: FILE: tools/testing/selftests/bpf/test_kmods/bpf_test_rqspinlock.c:104: + ret = raw_res_spin_lock_irqsave(test_ab ? &lock_b : &lock_a, flags); WARNING: line length of 83 exceeds 80 columns #209: FILE: tools/testing/selftests/bpf/test_kmods/bpf_test_rqspinlock.c:111: + raw_res_spin_unlock_irqrestore(test_ab ? &lock_b : &lock_a, flags); WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP #246: FILE: tools/testing/selftests/bpf/test_kmods/bpf_test_rqspinlock.c:148: + return -ENOTSUPP; WARNING: line length of 86 exceeds 80 columns #259: FILE: tools/testing/selftests/bpf/test_kmods/bpf_test_rqspinlock.c:161: + e = perf_event_create_kernel_counter(&hw_attr, i, NULL, nmi_cb, NULL); WARNING: line length of 82 exceeds 80 columns #317: FILE: tools/testing/selftests/bpf/testing_helpers.c:402: +static int __load_module(const char *path, const char *param_values, bool verbose) WARNING: line length of 81 exceeds 80 columns #355: FILE: tools/testing/selftests/bpf/testing_helpers.h:42: +int load_module_params(const char *path, const char *param_values, bool verbose); total: 2 errors, 9 warnings, 0 checks, 283 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit b78b29e65ada ("selftests/bpf: Add stress test for rqspinlock in NMI") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.