WARNING: line length of 81 exceeds 80 columns #95: FILE: kernel/bpf/syscall.c:2855: + err = bpf_verify_pkcs7_signature((struct bpf_dynptr *)&insns_ptr, WARNING: line length of 85 exceeds 80 columns #96: FILE: kernel/bpf/syscall.c:2856: + (struct bpf_dynptr *)&sig_ptr, key); WARNING: line length of 89 exceeds 80 columns #101: FILE: kernel/bpf/syscall.c:2861: + maps = kvmemdup_bpfptr(umaps, attr->signature_maps_size * sizeof(*maps)); WARNING: line length of 82 exceeds 80 columns #106: FILE: kernel/bpf/syscall.c:2866: + /* Process the map array in reverse order to generate a hash chain WARNING: line length of 93 exceeds 80 columns #112: FILE: kernel/bpf/syscall.c:2872: + make_bpfptr(attr->fd_array, is_kernel), CHECK: braces {} should be used on all arms of this statement #118: FILE: kernel/bpf/syscall.c:2878: + if (n == attr->signature_maps_size - 1) [...] + else { [...] CHECK: Unbalanced braces around else statement #120: FILE: kernel/bpf/syscall.c:2880: + else { WARNING: line length of 90 exceeds 80 columns #122: FILE: kernel/bpf/syscall.c:2882: + err = bpf_map_get_hash(map_fd, buffer + ARRAY_SIZE(hash)); WARNING: line length of 82 exceeds 80 columns #123: FILE: kernel/bpf/syscall.c:2883: + sha256((u8 *)buffer, sizeof(buffer), (u8 *)&hash); WARNING: line length of 95 exceeds 80 columns #131: FILE: kernel/bpf/syscall.c:2891: + sha256((u8 *)prog->insnsi, prog->len * sizeof(struct bpf_insn), (u8 *)&buffer); WARNING: line length of 85 exceeds 80 columns #135: FILE: kernel/bpf/syscall.c:2895: + (struct bpf_dynptr *)&sig_ptr, key); WARNING: Avoid line continuations in quoted strings #205: FILE: tools/bpf/bpftool/gen.c:831: + codegen("\ WARNING: line length of 114 exceeds 80 columns #207: FILE: tools/bpf/bpftool/gen.c:833: + static const int opts_signature_maps[1] __attribute__((__aligned__(8))) = {0}; \n\ WARNING: Prefer __aligned(8) over __attribute__((__aligned__(8))) #207: FILE: tools/bpf/bpftool/gen.c:833: + static const int opts_signature_maps[1] __attribute__((__aligned__(8))) = {0}; \n\ WARNING: Avoid unnecessary line continuations #219: FILE: tools/bpf/bpftool/gen.c:846: + codegen("\ WARNING: Avoid line continuations in quoted strings #219: FILE: tools/bpf/bpftool/gen.c:846: + codegen("\ WARNING: line length of 91 exceeds 80 columns #221: FILE: tools/bpf/bpftool/gen.c:848: + opts.signature_maps = (void *)opts_signature_maps; \n\ WARNING: line length of 91 exceeds 80 columns #222: FILE: tools/bpf/bpftool/gen.c:849: + opts.signature_maps_sz = 1; \n\ WARNING: please, no space before tabs #222: FILE: tools/bpf/bpftool/gen.c:849: +^I^I^I^Iopts.signature_maps_sz = 1; ^I^I^I^I\n\$ WARNING: Avoid unnecessary line continuations #225: FILE: tools/bpf/bpftool/gen.c:852: + codegen("\ WARNING: Avoid line continuations in quoted strings #225: FILE: tools/bpf/bpftool/gen.c:852: + codegen("\ WARNING: line length of 83 exceeds 80 columns #227: FILE: tools/bpf/bpftool/gen.c:854: + opts.signature_maps = (void *)NULL; \n\ WARNING: line length of 83 exceeds 80 columns #228: FILE: tools/bpf/bpftool/gen.c:855: + opts.signature_maps_sz = 0; \n\ WARNING: line length of 87 exceeds 80 columns #318: FILE: tools/bpf/bpftool/sign.c:139: + libbpf_sha256(opts->insns, opts->insns_sz, hash, SHA256_DIGEST_LENGTH); WARNING: line length of 85 exceeds 80 columns #319: FILE: tools/bpf/bpftool/sign.c:140: + libbpf_sha256(opts->data, opts->data_sz, hash + SHA256_DIGEST_LENGTH, WARNING: line length of 90 exceeds 80 columns #389: FILE: tools/lib/bpf/skel_internal.h:357: + const size_t prog_load_attr_sz = offsetofend(union bpf_attr, signature_maps_size); CHECK: No space is necessary after a cast #397: FILE: tools/lib/bpf/skel_internal.h:400: + attr.signature_maps = (long) opts->signature_maps; total: 0 errors, 24 warnings, 3 checks, 309 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 0804895f92be ("bpf: Add hash chain signature support for arbitrary maps") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 24 warnings, 3 checks, 309 lines checked