ShellCheck - shell script analysis tool version: 0.10.0 license: GNU General Public License, version 3 website: https://www.shellcheck.net Redirect to /tmp/tmp.lJlJRTiAJm and /tmp/tmp.jtpW3PhI44 Tree base: d588b3989d6b ("selftests: net: vlan_bridge_binding: Rename dfr_set_binding_*() to adf_*") Now at: 49796ea07382 ("selftests: forwarding: lib: Add an autodefer variant of vrf_prepare()") ====== Checking before the patch ====== Checking tools/testing/selftests/drivers/net/mlxsw/devlink_trap_policer.sh - 65535651f418e37b316cad52376e7013340517991fea6bd42c8581edc5fcdc4a In devlink_trap_policer.sh line 32: lib_dir=$(dirname $0)/../../../net/forwarding ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lib_dir=$(dirname "$0")/../../../net/forwarding In devlink_trap_policer.sh line 34: ALL_TESTS=" ^-------^ SC2034 (warning): ALL_TESTS appears unused. Verify use (or export if used externally). In devlink_trap_policer.sh line 40: NUM_NETIFS=4 ^--------^ SC2034 (warning): NUM_NETIFS appears unused. Verify use (or export if used externally). In devlink_trap_policer.sh line 41: source $lib_dir/tc_common.sh ^-------------------^ SC1091 (info): Not following: ./tc_common.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/tc_common.sh In devlink_trap_policer.sh line 42: source $lib_dir/lib.sh ^-------------^ SC1091 (info): Not following: ./lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In devlink_trap_policer.sh line 43: source $lib_dir/devlink_lib.sh ^---------------------^ SC1091 (info): Not following: ./devlink_lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/devlink_lib.sh In devlink_trap_policer.sh line 47: simple_if_init $h1 192.0.2.1/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" 192.0.2.1/24 In devlink_trap_policer.sh line 48: defer simple_if_fini $h1 192.0.2.1/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h1" 192.0.2.1/24 In devlink_trap_policer.sh line 50: mtu_set $h1 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h1" 10000 In devlink_trap_policer.sh line 51: defer mtu_restore $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h1" In devlink_trap_policer.sh line 53: ip -4 route add default vrf v$h1 nexthop via 192.0.2.2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -4 route add default vrf v"$h1" nexthop via 192.0.2.2 In devlink_trap_policer.sh line 54: defer ip -4 route del default vrf v$h1 nexthop via 192.0.2.2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip -4 route del default vrf v"$h1" nexthop via 192.0.2.2 In devlink_trap_policer.sh line 59: simple_if_init $h2 198.51.100.1/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" 198.51.100.1/24 In devlink_trap_policer.sh line 60: defer simple_if_fini $h2 198.51.100.1/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h2" 198.51.100.1/24 In devlink_trap_policer.sh line 62: mtu_set $h2 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h2" 10000 In devlink_trap_policer.sh line 63: defer mtu_restore $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h2" In devlink_trap_policer.sh line 65: ip -4 route add default vrf v$h2 nexthop via 198.51.100.2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -4 route add default vrf v"$h2" nexthop via 198.51.100.2 In devlink_trap_policer.sh line 66: defer ip -4 route del default vrf v$h2 nexthop via 198.51.100.2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip -4 route del default vrf v"$h2" nexthop via 198.51.100.2 In devlink_trap_policer.sh line 71: ip link set dev $rp1 up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rp1" up In devlink_trap_policer.sh line 72: defer ip link set dev $rp1 down ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$rp1" down In devlink_trap_policer.sh line 74: ip link set dev $rp2 up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rp2" up In devlink_trap_policer.sh line 75: defer ip link set dev $rp2 down ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$rp2" down In devlink_trap_policer.sh line 77: __addr_add_del $rp1 add 192.0.2.2/24 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __addr_add_del "$rp1" add 192.0.2.2/24 In devlink_trap_policer.sh line 78: defer __addr_add_del $rp1 del 192.0.2.2/24 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer __addr_add_del "$rp1" del 192.0.2.2/24 In devlink_trap_policer.sh line 80: __addr_add_del $rp2 add 198.51.100.2/24 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __addr_add_del "$rp2" add 198.51.100.2/24 In devlink_trap_policer.sh line 81: defer __addr_add_del $rp2 del 198.51.100.2/24 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer __addr_add_del "$rp2" del 198.51.100.2/24 In devlink_trap_policer.sh line 83: mtu_set $rp1 10000 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$rp1" 10000 In devlink_trap_policer.sh line 84: defer mtu_restore $rp1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$rp1" In devlink_trap_policer.sh line 86: mtu_set $rp2 10000 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$rp2" 10000 In devlink_trap_policer.sh line 87: defer mtu_restore $rp2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$rp2" In devlink_trap_policer.sh line 92: devlink trap set $DEVLINK_DEV trap blackhole_route action trap ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap set "$DEVLINK_DEV" trap blackhole_route action trap In devlink_trap_policer.sh line 93: defer devlink trap set $DEVLINK_DEV trap blackhole_route action drop ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink trap set "$DEVLINK_DEV" trap blackhole_route action drop In devlink_trap_policer.sh line 104: rp1_mac=$(mac_get $rp1) ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rp1_mac=$(mac_get "$rp1") In devlink_trap_policer.sh line 122: devlink trap policer set $DEVLINK_DEV policer 1 rate 0 &> /dev/null ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 rate 0 &> /dev/null In devlink_trap_policer.sh line 124: devlink trap policer set $DEVLINK_DEV policer 1 \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 \ In devlink_trap_policer.sh line 128: devlink trap policer set $DEVLINK_DEV policer 1 rate 1 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 rate 1 In devlink_trap_policer.sh line 130: devlink trap policer set $DEVLINK_DEV policer 1 rate 2000000000 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 rate 2000000000 In devlink_trap_policer.sh line 140: devlink trap policer set $DEVLINK_DEV policer 1 burst 0 &> /dev/null ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 burst 0 &> /dev/null In devlink_trap_policer.sh line 142: devlink trap policer set $DEVLINK_DEV policer 1 burst 17 &> /dev/null ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 burst 17 &> /dev/null In devlink_trap_policer.sh line 144: devlink trap policer set $DEVLINK_DEV policer 1 burst 8 &> /dev/null ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 burst 8 &> /dev/null In devlink_trap_policer.sh line 146: devlink trap policer set $DEVLINK_DEV policer 1 \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 \ In devlink_trap_policer.sh line 150: devlink trap policer set $DEVLINK_DEV policer 1 burst 16 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 burst 16 In devlink_trap_policer.sh line 152: devlink trap policer set $DEVLINK_DEV policer 1 burst $((2**24)) ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 burst $((2**24)) In devlink_trap_policer.sh line 174: t0=$(devlink_trap_policer_rx_dropped_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: t0=$(devlink_trap_policer_rx_dropped_get "$id") In devlink_trap_policer.sh line 176: t1=$(devlink_trap_policer_rx_dropped_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: t1=$(devlink_trap_policer_rx_dropped_get "$id") In devlink_trap_policer.sh line 188: devlink trap policer set $DEVLINK_DEV policer $id rate 1000 burst 512 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer "$id" rate 1000 burst 512 In devlink_trap_policer.sh line 189: devlink trap group set $DEVLINK_DEV group l3_drops policer $id ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap group set "$DEVLINK_DEV" group l3_drops policer "$id" In devlink_trap_policer.sh line 197: start_traffic $h1 192.0.2.1 198.51.100.100 $rp1_mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1" 192.0.2.1 198.51.100.100 "$rp1_mac" In devlink_trap_policer.sh line 208: drop_rate=$(policer_drop_rate_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: drop_rate=$(policer_drop_rate_get "$id") In devlink_trap_policer.sh line 221: start_traffic $h1 192.0.2.1 198.51.100.100 $rp1_mac -d 1msec ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1" 192.0.2.1 198.51.100.100 "$rp1_mac" -d 1msec In devlink_trap_policer.sh line 226: drop_rate=$(policer_drop_rate_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: drop_rate=$(policer_drop_rate_get "$id") In devlink_trap_policer.sh line 238: devlink trap group set $DEVLINK_DEV group l3_drops nopolicer ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap group set "$DEVLINK_DEV" group l3_drops nopolicer In devlink_trap_policer.sh line 242: start_traffic $h1 192.0.2.1 198.51.100.100 $rp1_mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1" 192.0.2.1 198.51.100.100 "$rp1_mac" In devlink_trap_policer.sh line 250: drop_rate=$(policer_drop_rate_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: drop_rate=$(policer_drop_rate_get "$id") In devlink_trap_policer.sh line 262: local last_policer=$(devlink -j -p trap policer show | ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In devlink_trap_policer.sh line 263: jq '[.[]["'$DEVLINK_DEV'"][].policer] | max') ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: jq '[.[]["'"$DEVLINK_DEV"'"][].policer] | max') In devlink_trap_policer.sh line 272: __rate_test $last_policer ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __rate_test "$last_policer" In devlink_trap_policer.sh line 280: RET=0 ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally). In devlink_trap_policer.sh line 282: devlink trap policer set $DEVLINK_DEV policer $id rate 1000 burst 512 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer "$id" rate 1000 burst 512 In devlink_trap_policer.sh line 283: devlink trap group set $DEVLINK_DEV group l3_drops policer $id ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap group set "$DEVLINK_DEV" group l3_drops policer "$id" In devlink_trap_policer.sh line 290: t0_drop=$(devlink_trap_policer_rx_dropped_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: t0_drop=$(devlink_trap_policer_rx_dropped_get "$id") In devlink_trap_policer.sh line 292: start_traffic $h1 192.0.2.1 198.51.100.100 $rp1_mac -c 16 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1" 192.0.2.1 198.51.100.100 "$rp1_mac" -c 16 In devlink_trap_policer.sh line 295: t1_drop=$(devlink_trap_policer_rx_dropped_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: t1_drop=$(devlink_trap_policer_rx_dropped_get "$id") In devlink_trap_policer.sh line 311: devlink trap group set $DEVLINK_DEV group l3_drops nopolicer ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap group set "$DEVLINK_DEV" group l3_drops nopolicer In devlink_trap_policer.sh line 314: t0_drop=$(devlink_trap_policer_rx_dropped_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: t0_drop=$(devlink_trap_policer_rx_dropped_get "$id") In devlink_trap_policer.sh line 316: start_traffic $h1 192.0.2.1 198.51.100.100 $rp1_mac -c 64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1" 192.0.2.1 198.51.100.100 "$rp1_mac" -c 64 In devlink_trap_policer.sh line 319: t1_drop=$(devlink_trap_policer_rx_dropped_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: t1_drop=$(devlink_trap_policer_rx_dropped_get "$id") In devlink_trap_policer.sh line 336: local last_policer=$(devlink -j -p trap policer show | ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In devlink_trap_policer.sh line 337: jq '[.[]["'$DEVLINK_DEV'"][].policer] | max') ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: jq '[.[]["'"$DEVLINK_DEV"'"][].policer] | max') In devlink_trap_policer.sh line 346: __burst_test $last_policer ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __burst_test "$last_policer" In devlink_trap_policer.sh line 356: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2034 -- ALL_TESTS appears unused. Verify ... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... https://www.shellcheck.net/wiki/SC1091 -- Not following: ./devlink_lib.sh: ... Checking tools/testing/selftests/drivers/net/mlxsw/qos_ets_strict.sh - cd5fda03da1fc3ff4428c6739dddf9aced769f63169957c0589e5d411b07a143 In qos_ets_strict.sh line 46: ALL_TESTS=" ^-------^ SC2034 (warning): ALL_TESTS appears unused. Verify use (or export if used externally). In qos_ets_strict.sh line 51: lib_dir=$(dirname $0)/../../../net/forwarding ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lib_dir=$(dirname "$0")/../../../net/forwarding In qos_ets_strict.sh line 53: NUM_NETIFS=6 ^--------^ SC2034 (warning): NUM_NETIFS appears unused. Verify use (or export if used externally). In qos_ets_strict.sh line 54: source $lib_dir/lib.sh ^-------------^ SC1091 (info): Not following: ./lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In qos_ets_strict.sh line 55: source $lib_dir/devlink_lib.sh ^---------------------^ SC1091 (info): Not following: ./devlink_lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/devlink_lib.sh In qos_ets_strict.sh line 60: simple_if_init $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" In qos_ets_strict.sh line 61: defer simple_if_fini $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h1" In qos_ets_strict.sh line 63: mtu_set $h1 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h1" 10000 In qos_ets_strict.sh line 64: defer mtu_restore $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h1" In qos_ets_strict.sh line 66: vlan_create $h1 111 v$h1 192.0.2.33/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h1" 111 v"$h1" 192.0.2.33/28 In qos_ets_strict.sh line 67: defer vlan_destroy $h1 111 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h1" 111 In qos_ets_strict.sh line 68: ip link set dev $h1.111 type vlan egress-qos-map 0:1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$h1".111 type vlan egress-qos-map 0:1 In qos_ets_strict.sh line 73: simple_if_init $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" In qos_ets_strict.sh line 74: defer simple_if_fini $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h2" In qos_ets_strict.sh line 76: mtu_set $h2 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h2" 10000 In qos_ets_strict.sh line 77: defer mtu_restore $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h2" In qos_ets_strict.sh line 79: vlan_create $h2 222 v$h2 192.0.2.65/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h2" 222 v"$h2" 192.0.2.65/28 In qos_ets_strict.sh line 80: defer vlan_destroy $h2 222 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h2" 222 In qos_ets_strict.sh line 81: ip link set dev $h2.222 type vlan egress-qos-map 0:2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$h2".222 type vlan egress-qos-map 0:2 In qos_ets_strict.sh line 86: simple_if_init $h3 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h3" In qos_ets_strict.sh line 87: defer simple_if_fini $h3 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h3" In qos_ets_strict.sh line 89: mtu_set $h3 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h3" 10000 In qos_ets_strict.sh line 90: defer mtu_restore $h3 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h3" In qos_ets_strict.sh line 92: vlan_create $h3 111 v$h3 192.0.2.34/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h3" 111 v"$h3" 192.0.2.34/28 In qos_ets_strict.sh line 93: defer vlan_destroy $h3 111 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h3" 111 In qos_ets_strict.sh line 95: vlan_create $h3 222 v$h3 192.0.2.66/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h3" 222 v"$h3" 192.0.2.66/28 In qos_ets_strict.sh line 96: defer vlan_destroy $h3 222 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h3" 222 In qos_ets_strict.sh line 101: ip link set dev $swp1 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up In qos_ets_strict.sh line 102: defer ip link set dev $swp1 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1" down In qos_ets_strict.sh line 104: mtu_set $swp1 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp1" 10000 In qos_ets_strict.sh line 105: defer mtu_restore $swp1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp1" In qos_ets_strict.sh line 107: ip link set dev $swp2 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up In qos_ets_strict.sh line 108: defer ip link set dev $swp2 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2" down In qos_ets_strict.sh line 110: mtu_set $swp2 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp2" 10000 In qos_ets_strict.sh line 111: defer mtu_restore $swp2 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp2" In qos_ets_strict.sh line 114: lldptool -T -i $swp3 -V ETS-CFG up2tc=0:0,1:1,2:2,3:3,4:4,5:5,6:6,7:7 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lldptool -T -i "$swp3" -V ETS-CFG up2tc=0:0,1:1,2:2,3:3,4:4,5:5,6:6,7:7 In qos_ets_strict.sh line 115: defer lldptool -T -i $swp3 -V ETS-CFG up2tc=0:0,1:0,2:0,3:0,4:0,5:0,6:0,7:0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer lldptool -T -i "$swp3" -V ETS-CFG up2tc=0:0,1:0,2:0,3:0,4:0,5:0,6:0,7:0 In qos_ets_strict.sh line 117: lldptool -T -i $swp3 -V ETS-CFG tsa=$( ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lldptool -T -i "$swp3" -V ETS-CFG tsa=$( In qos_ets_strict.sh line 118: )"0:strict,"$( ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In qos_ets_strict.sh line 119: )"1:strict,"$( ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In qos_ets_strict.sh line 120: )"2:strict,"$( ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In qos_ets_strict.sh line 121: )"3:strict,"$( ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In qos_ets_strict.sh line 122: )"4:strict,"$( ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In qos_ets_strict.sh line 123: )"5:strict,"$( ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In qos_ets_strict.sh line 124: )"6:strict,"$( ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In qos_ets_strict.sh line 128: ip link set dev $swp3 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp3" up In qos_ets_strict.sh line 129: defer ip link set dev $swp3 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp3" down In qos_ets_strict.sh line 131: mtu_set $swp3 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp3" 10000 In qos_ets_strict.sh line 132: defer mtu_restore $swp3 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp3" In qos_ets_strict.sh line 134: tc qdisc replace dev $swp3 root handle 101: tbf rate 1gbit \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$swp3" root handle 101: tbf rate 1gbit \ In qos_ets_strict.sh line 136: defer tc qdisc del dev $swp3 root handle 101: ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$swp3" root handle 101: In qos_ets_strict.sh line 138: vlan_create $swp1 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp1" 111 In qos_ets_strict.sh line 139: defer vlan_destroy $swp1 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp1" 111 In qos_ets_strict.sh line 141: vlan_create $swp2 222 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp2" 222 In qos_ets_strict.sh line 142: defer vlan_destroy $swp2 222 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp2" 222 In qos_ets_strict.sh line 144: vlan_create $swp3 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp3" 111 In qos_ets_strict.sh line 145: defer vlan_destroy $swp3 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp3" 111 In qos_ets_strict.sh line 147: vlan_create $swp3 222 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp3" 222 In qos_ets_strict.sh line 148: defer vlan_destroy $swp3 222 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp3" 222 In qos_ets_strict.sh line 157: ip link set dev $swp1.111 master br111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".111 master br111 In qos_ets_strict.sh line 158: defer ip link set dev $swp1.111 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1".111 nomaster In qos_ets_strict.sh line 160: ip link set dev $swp3.111 master br111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp3".111 master br111 In qos_ets_strict.sh line 161: defer ip link set dev $swp3.111 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp3".111 nomaster In qos_ets_strict.sh line 170: ip link set dev $swp2.222 master br222 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2".222 master br222 In qos_ets_strict.sh line 171: defer ip link set dev $swp2.222 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2".222 nomaster In qos_ets_strict.sh line 173: ip link set dev $swp3.222 master br222 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp3".222 master br222 In qos_ets_strict.sh line 174: defer ip link set dev $swp3.222 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp3".222 nomaster In qos_ets_strict.sh line 186: devlink_port_pool_th_save $swp1 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp1" 0 In qos_ets_strict.sh line 187: devlink_port_pool_th_set $swp1 0 6 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp1" 0 6 In qos_ets_strict.sh line 188: defer devlink_port_pool_th_restore $swp1 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp1" 0 In qos_ets_strict.sh line 190: devlink_tc_bind_pool_th_save $swp1 1 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_save "$swp1" 1 ingress In qos_ets_strict.sh line 191: devlink_tc_bind_pool_th_set $swp1 1 ingress 0 6 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_set "$swp1" 1 ingress 0 6 In qos_ets_strict.sh line 192: defer devlink_tc_bind_pool_th_restore $swp1 1 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_tc_bind_pool_th_restore "$swp1" 1 ingress In qos_ets_strict.sh line 194: devlink_port_pool_th_save $swp2 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp2" 0 In qos_ets_strict.sh line 195: devlink_port_pool_th_set $swp2 0 6 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp2" 0 6 In qos_ets_strict.sh line 196: defer devlink_port_pool_th_restore $swp2 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp2" 0 In qos_ets_strict.sh line 198: devlink_tc_bind_pool_th_save $swp2 2 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_save "$swp2" 2 ingress In qos_ets_strict.sh line 199: devlink_tc_bind_pool_th_set $swp2 2 ingress 0 6 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_set "$swp2" 2 ingress 0 6 In qos_ets_strict.sh line 200: defer devlink_tc_bind_pool_th_restore $swp2 2 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_tc_bind_pool_th_restore "$swp2" 2 ingress In qos_ets_strict.sh line 202: devlink_tc_bind_pool_th_save $swp3 1 egress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_save "$swp3" 1 egress In qos_ets_strict.sh line 203: devlink_tc_bind_pool_th_set $swp3 1 egress 4 7 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_set "$swp3" 1 egress 4 7 In qos_ets_strict.sh line 204: defer devlink_tc_bind_pool_th_restore $swp3 1 egress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_tc_bind_pool_th_restore "$swp3" 1 egress In qos_ets_strict.sh line 206: devlink_tc_bind_pool_th_save $swp3 2 egress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_save "$swp3" 2 egress In qos_ets_strict.sh line 207: devlink_tc_bind_pool_th_set $swp3 2 egress 4 7 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_set "$swp3" 2 egress 4 7 In qos_ets_strict.sh line 208: defer devlink_tc_bind_pool_th_restore $swp3 2 egress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_tc_bind_pool_th_restore "$swp3" 2 egress In qos_ets_strict.sh line 210: devlink_port_pool_th_save $swp3 4 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp3" 4 In qos_ets_strict.sh line 211: devlink_port_pool_th_set $swp3 4 7 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp3" 4 7 In qos_ets_strict.sh line 212: defer devlink_port_pool_th_restore $swp3 4 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp3" 4 In qos_ets_strict.sh line 226: h3mac=$(mac_get $h3) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h3mac=$(mac_get "$h3") In qos_ets_strict.sh line 239: ping_test $h1 192.0.2.34 " from H1" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h1" 192.0.2.34 " from H1" In qos_ets_strict.sh line 240: ping_test $h2 192.0.2.66 " from H2" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h2" 192.0.2.66 " from H2" In qos_ets_strict.sh line 260: start_traffic $h2.222 192.0.2.65 192.0.2.66 $h3mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h2".222 192.0.2.65 192.0.2.66 "$h3mac" In qos_ets_strict.sh line 263: uc_rate=($(measure_rate $swp2 $h3 rx_octets_prio_2 "$what")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: uc_rate=($(measure_rate "$swp2" "$h3" rx_octets_prio_2 "$what")) In qos_ets_strict.sh line 266: echo ${uc_rate[@]} ^-----------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In qos_ets_strict.sh line 276: RET=0 ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally). In qos_ets_strict.sh line 280: rate_2=($(run_hi_measure_rate "prio 2")) ^-----------------------------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). In qos_ets_strict.sh line 285: start_traffic $h1.111 192.0.2.33 192.0.2.34 $h3mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1".111 192.0.2.33 192.0.2.34 "$h3mac" In qos_ets_strict.sh line 289: rate_1=($(measure_rate $swp1 $h3 rx_octets_prio_1 "prio 1")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_1=($(measure_rate "$swp1" "$h3" rx_octets_prio_1 "prio 1")) In qos_ets_strict.sh line 296: local rel21=$(rel $rate_1_eg $rate_2_eg) ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local rel21=$(rel "$rate_1_eg" "$rate_2_eg") In qos_ets_strict.sh line 297: check_err $(bc <<< "$rel21 < 95") ^---------------------^ SC2046 (warning): Quote this to prevent word splitting. In qos_ets_strict.sh line 298: check_err $(bc <<< "$rel21 > 105") ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. In qos_ets_strict.sh line 301: rate_3=($(run_hi_measure_rate "prio 2+1")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). In qos_ets_strict.sh line 307: local rel32=$(rel $rate_2_eg $rate_3_eg) ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local rel32=$(rel "$rate_2_eg" "$rate_3_eg") In qos_ets_strict.sh line 308: check_err $(bc <<< "$rel32 < 95") ^---------------------^ SC2046 (warning): Quote this to prevent word splitting. In qos_ets_strict.sh line 312: echo " p1 in rate $(humanize $rate_1_in)" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " p1 in rate $(humanize "$rate_1_in")" In qos_ets_strict.sh line 313: echo " p2 in rate $(humanize $rate_2_in)" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " p2 in rate $(humanize "$rate_2_in")" In qos_ets_strict.sh line 314: echo " p2 in rate w/ p1 $(humanize $rate_3_in)" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " p2 in rate w/ p1 $(humanize "$rate_3_in")" In qos_ets_strict.sh line 316: echo " p1 eg rate $(humanize $rate_1_eg)" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " p1 eg rate $(humanize "$rate_1_eg")" In qos_ets_strict.sh line 317: echo " p2 eg rate $(humanize $rate_2_eg) ($rel21% of p1)" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " p2 eg rate $(humanize "$rate_2_eg") ($rel21% of p1)" In qos_ets_strict.sh line 318: echo " p2 eg rate w/ p1 $(humanize $rate_3_eg) ($rel32% of p2)" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " p2 eg rate w/ p1 $(humanize "$rate_3_eg") ($rel32% of p2)" In qos_ets_strict.sh line 328: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u... https://www.shellcheck.net/wiki/SC2034 -- ALL_TESTS appears unused. Verify ... Checking tools/testing/selftests/drivers/net/mlxsw/qos_max_descriptors.sh - 043dafd07ecd59d7b96f10e3191cc872c3ac6314c145bce82b9fb319d48d1b6a In qos_max_descriptors.sh line 47: ALL_TESTS=" ^-------^ SC2034 (warning): ALL_TESTS appears unused. Verify use (or export if used externally). In qos_max_descriptors.sh line 52: lib_dir=$(dirname $0)/../../../net/forwarding ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lib_dir=$(dirname "$0")/../../../net/forwarding In qos_max_descriptors.sh line 54: NUM_NETIFS=4 ^--------^ SC2034 (warning): NUM_NETIFS appears unused. Verify use (or export if used externally). In qos_max_descriptors.sh line 55: source $lib_dir/lib.sh ^-------------^ SC1091 (info): Not following: ./lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In qos_max_descriptors.sh line 56: source $lib_dir/devlink_lib.sh ^---------------------^ SC1091 (info): Not following: ./devlink_lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/devlink_lib.sh In qos_max_descriptors.sh line 71: simple_if_init $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" In qos_max_descriptors.sh line 72: defer simple_if_fini $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h1" In qos_max_descriptors.sh line 74: vlan_create $h1 111 v$h1 192.0.2.33/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h1" 111 v"$h1" 192.0.2.33/28 In qos_max_descriptors.sh line 75: defer vlan_destroy $h1 111 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h1" 111 In qos_max_descriptors.sh line 76: ip link set dev $h1.111 type vlan egress-qos-map 0:1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$h1".111 type vlan egress-qos-map 0:1 In qos_max_descriptors.sh line 81: simple_if_init $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" In qos_max_descriptors.sh line 82: defer simple_if_fini $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h2" In qos_max_descriptors.sh line 84: vlan_create $h2 111 v$h2 192.0.2.34/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h2" 111 v"$h2" 192.0.2.34/28 In qos_max_descriptors.sh line 85: defer vlan_destroy $h2 111 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h2" 111 In qos_max_descriptors.sh line 97: devlink_pool_size_thtype_set 1 dynamic $MAX_POOL_SIZE ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_pool_size_thtype_set 1 dynamic "$MAX_POOL_SIZE" In qos_max_descriptors.sh line 101: devlink_pool_size_thtype_set 6 static $MAX_POOL_SIZE ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_pool_size_thtype_set 6 static "$MAX_POOL_SIZE" In qos_max_descriptors.sh line 107: ip link set dev $swp1 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up In qos_max_descriptors.sh line 108: defer ip link set dev $swp1 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1" down In qos_max_descriptors.sh line 110: vlan_create $swp1 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp1" 111 In qos_max_descriptors.sh line 111: defer vlan_destroy $swp1 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp1" 111 In qos_max_descriptors.sh line 112: ip link set dev $swp1.111 type vlan ingress-qos-map 0:0 1:1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".111 type vlan ingress-qos-map 0:0 1:1 In qos_max_descriptors.sh line 114: devlink_port_pool_th_save $swp1 1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp1" 1 In qos_max_descriptors.sh line 115: devlink_port_pool_th_set $swp1 1 16 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp1" 1 16 In qos_max_descriptors.sh line 116: defer devlink_tc_bind_pool_th_restore $swp1 1 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_tc_bind_pool_th_restore "$swp1" 1 ingress In qos_max_descriptors.sh line 118: devlink_tc_bind_pool_th_save $swp1 1 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_save "$swp1" 1 ingress In qos_max_descriptors.sh line 119: devlink_tc_bind_pool_th_set $swp1 1 ingress 1 16 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_set "$swp1" 1 ingress 1 16 In qos_max_descriptors.sh line 120: defer devlink_port_pool_th_restore $swp1 1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp1" 1 In qos_max_descriptors.sh line 122: tc qdisc replace dev $swp1 root handle 1: \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$swp1" root handle 1: \ In qos_max_descriptors.sh line 124: defer tc qdisc del dev $swp1 root ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$swp1" root In qos_max_descriptors.sh line 126: dcb buffer set dev $swp1 prio-buffer all:0 1:1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dcb buffer set dev "$swp1" prio-buffer all:0 1:1 In qos_max_descriptors.sh line 127: defer dcb buffer set dev $swp1 prio-buffer all:0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer dcb buffer set dev "$swp1" prio-buffer all:0 In qos_max_descriptors.sh line 132: ip link set dev $swp2 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up In qos_max_descriptors.sh line 133: defer ip link set dev $swp2 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2" down In qos_max_descriptors.sh line 135: vlan_create $swp2 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp2" 111 In qos_max_descriptors.sh line 136: defer vlan_destroy $swp2 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp2" 111 In qos_max_descriptors.sh line 137: ip link set dev $swp2.111 type vlan egress-qos-map 0:0 1:1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2".111 type vlan egress-qos-map 0:0 1:1 In qos_max_descriptors.sh line 139: devlink_port_pool_th_save $swp2 6 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp2" 6 In qos_max_descriptors.sh line 140: devlink_port_pool_th_set $swp2 6 $MAX_POOL_SIZE ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp2" 6 "$MAX_POOL_SIZE" In qos_max_descriptors.sh line 141: defer devlink_tc_bind_pool_th_restore $swp2 1 egress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_tc_bind_pool_th_restore "$swp2" 1 egress In qos_max_descriptors.sh line 143: devlink_tc_bind_pool_th_save $swp2 1 egress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_save "$swp2" 1 egress In qos_max_descriptors.sh line 144: devlink_tc_bind_pool_th_set $swp2 1 egress 6 $MAX_POOL_SIZE ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_set "$swp2" 1 egress 6 "$MAX_POOL_SIZE" In qos_max_descriptors.sh line 145: defer devlink_port_pool_th_restore $swp2 6 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp2" 6 In qos_max_descriptors.sh line 147: tc qdisc replace dev $swp2 root handle 1: tbf rate $SHAPER_RATE \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$swp2" root handle 1: tbf rate $SHAPER_RATE \ In qos_max_descriptors.sh line 149: defer tc qdisc del dev $swp2 root ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$swp2" root In qos_max_descriptors.sh line 151: tc qdisc replace dev $swp2 parent 1:1 handle 11: \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$swp2" parent 1:1 handle 11: \ In qos_max_descriptors.sh line 153: defer tc qdisc del dev $swp2 parent 1:1 handle 11: ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$swp2" parent 1:1 handle 11: In qos_max_descriptors.sh line 161: ip link set dev $swp1.111 master br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".111 master br1 In qos_max_descriptors.sh line 162: defer ip link set dev $swp1.111 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1".111 nomaster In qos_max_descriptors.sh line 167: ip link set dev $swp2.111 master br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2".111 master br1 In qos_max_descriptors.sh line 168: defer ip link set dev $swp2.111 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2".111 nomaster In qos_max_descriptors.sh line 179: h2mac=$(mac_get $h2) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2mac=$(mac_get "$h2") In qos_max_descriptors.sh line 191: ping_test $h1 192.0.2.34 " h1->h2" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h1" 192.0.2.34 " h1->h2" In qos_max_descriptors.sh line 207: local cell_size=$(devlink_cell_size_get) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In qos_max_descriptors.sh line 212: RET=0 ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally). In qos_max_descriptors.sh line 216: local d0=$(ethtool_stats_get $swp2 tc_no_buffer_discard_uc_tc_1) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local d0=$(ethtool_stats_get "$swp2" tc_no_buffer_discard_uc_tc_1) In qos_max_descriptors.sh line 219: start_traffic_pktsize $pktsize $h1.111 192.0.2.33 192.0.2.34 $h2mac ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic_pktsize "$pktsize" "$h1".111 192.0.2.33 192.0.2.34 "$h2mac" In qos_max_descriptors.sh line 225: local d1=$(ethtool_stats_get $swp2 tc_no_buffer_discard_uc_tc_1) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local d1=$(ethtool_stats_get "$swp2" tc_no_buffer_discard_uc_tc_1) In qos_max_descriptors.sh line 231: local pkts_bytes=$(ethtool_stats_get $swp2 tc_transmit_queue_tc_1) ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local pkts_bytes=$(ethtool_stats_get "$swp2" tc_transmit_queue_tc_1) In qos_max_descriptors.sh line 233: local perc_used=$(percentage_used $pkts_num $max_descriptors) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local perc_used=$(percentage_used "$pkts_num" "$max_descriptors") In qos_max_descriptors.sh line 235: check_err $(bc <<< "$perc_used < $exp_perc_used") \ ^-- SC2046 (warning): Quote this to prevent word splitting. In qos_max_descriptors.sh line 246: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2034 -- ALL_TESTS appears unused. Verify ... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... Checking tools/testing/selftests/drivers/net/mlxsw/qos_mc_aware.sh - 933f8438a48a2efb8659a329984860377c91c863f6a30214c47f2a0fb2ba8929 In qos_mc_aware.sh line 60: ALL_TESTS=" ^-------^ SC2034 (warning): ALL_TESTS appears unused. Verify use (or export if used externally). In qos_mc_aware.sh line 66: lib_dir=$(dirname $0)/../../../net/forwarding ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lib_dir=$(dirname "$0")/../../../net/forwarding In qos_mc_aware.sh line 68: NUM_NETIFS=6 ^--------^ SC2034 (warning): NUM_NETIFS appears unused. Verify use (or export if used externally). In qos_mc_aware.sh line 69: source $lib_dir/lib.sh ^-------------^ SC1091 (info): Not following: ./lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In qos_mc_aware.sh line 70: source $lib_dir/devlink_lib.sh ^---------------------^ SC1091 (info): Not following: ./devlink_lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/devlink_lib.sh In qos_mc_aware.sh line 75: simple_if_init $h1 192.0.2.65/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" 192.0.2.65/28 In qos_mc_aware.sh line 76: defer simple_if_fini $h1 192.0.2.65/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h1" 192.0.2.65/28 In qos_mc_aware.sh line 78: mtu_set $h1 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h1" 10000 In qos_mc_aware.sh line 79: defer mtu_restore $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h1" In qos_mc_aware.sh line 84: simple_if_init $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" In qos_mc_aware.sh line 85: defer simple_if_fini $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h2" In qos_mc_aware.sh line 87: mtu_set $h2 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h2" 10000 In qos_mc_aware.sh line 88: defer mtu_restore $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h2" In qos_mc_aware.sh line 90: vlan_create $h2 111 v$h2 192.0.2.129/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h2" 111 v"$h2" 192.0.2.129/28 In qos_mc_aware.sh line 91: defer vlan_destroy $h2 111 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h2" 111 In qos_mc_aware.sh line 92: ip link set dev $h2.111 type vlan egress-qos-map 0:1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$h2".111 type vlan egress-qos-map 0:1 In qos_mc_aware.sh line 97: simple_if_init $h3 192.0.2.66/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h3" 192.0.2.66/28 In qos_mc_aware.sh line 98: defer simple_if_fini $h3 192.0.2.66/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h3" 192.0.2.66/28 In qos_mc_aware.sh line 100: mtu_set $h3 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h3" 10000 In qos_mc_aware.sh line 101: defer mtu_restore $h3 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h3" In qos_mc_aware.sh line 103: vlan_create $h3 111 v$h3 192.0.2.130/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h3" 111 v"$h3" 192.0.2.130/28 In qos_mc_aware.sh line 104: defer vlan_destroy $h3 111 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h3" 111 In qos_mc_aware.sh line 109: ip link set dev $swp1 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up In qos_mc_aware.sh line 110: defer ip link set dev $swp1 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1" down In qos_mc_aware.sh line 112: mtu_set $swp1 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp1" 10000 In qos_mc_aware.sh line 113: defer mtu_restore $swp1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp1" In qos_mc_aware.sh line 115: ip link set dev $swp2 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up In qos_mc_aware.sh line 116: defer ip link set dev $swp2 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2" down In qos_mc_aware.sh line 118: mtu_set $swp2 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp2" 10000 In qos_mc_aware.sh line 119: defer mtu_restore $swp2 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp2" In qos_mc_aware.sh line 121: ip link set dev $swp3 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp3" up In qos_mc_aware.sh line 122: defer ip link set dev $swp3 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp3" down In qos_mc_aware.sh line 124: mtu_set $swp3 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp3" 10000 In qos_mc_aware.sh line 125: defer mtu_restore $swp3 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp3" In qos_mc_aware.sh line 127: vlan_create $swp2 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp2" 111 In qos_mc_aware.sh line 128: defer vlan_destroy $swp2 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp2" 111 In qos_mc_aware.sh line 130: vlan_create $swp3 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp3" 111 In qos_mc_aware.sh line 131: defer vlan_destroy $swp3 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp3" 111 In qos_mc_aware.sh line 133: tc qdisc replace dev $swp3 root handle 3: tbf rate 1gbit \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$swp3" root handle 3: tbf rate 1gbit \ In qos_mc_aware.sh line 135: defer tc qdisc del dev $swp3 root handle 3: ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$swp3" root handle 3: In qos_mc_aware.sh line 137: tc qdisc replace dev $swp3 parent 3:3 handle 33: \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$swp3" parent 3:3 handle 33: \ In qos_mc_aware.sh line 139: defer tc qdisc del dev $swp3 parent 3:3 handle 33: ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$swp3" parent 3:3 handle 33: In qos_mc_aware.sh line 146: ip link set dev $swp1 master br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" master br1 In qos_mc_aware.sh line 147: defer ip link set dev $swp1 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1" nomaster In qos_mc_aware.sh line 149: ip link set dev $swp3 master br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp3" master br1 In qos_mc_aware.sh line 150: defer ip link set dev $swp3 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp3" nomaster In qos_mc_aware.sh line 157: ip link set dev $swp2.111 master br111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2".111 master br111 In qos_mc_aware.sh line 158: defer ip link set dev $swp2.111 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2".111 nomaster In qos_mc_aware.sh line 160: ip link set dev $swp3.111 master br111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp3".111 master br111 In qos_mc_aware.sh line 161: defer ip link set dev $swp3.111 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp3".111 nomaster In qos_mc_aware.sh line 165: devlink_port_pool_th_save $swp1 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp1" 0 In qos_mc_aware.sh line 166: devlink_port_pool_th_set $swp1 0 5 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp1" 0 5 In qos_mc_aware.sh line 167: defer devlink_port_pool_th_restore $swp1 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp1" 0 In qos_mc_aware.sh line 169: devlink_tc_bind_pool_th_save $swp1 0 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_save "$swp1" 0 ingress In qos_mc_aware.sh line 170: devlink_tc_bind_pool_th_set $swp1 0 ingress 0 5 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_set "$swp1" 0 ingress 0 5 In qos_mc_aware.sh line 171: defer devlink_tc_bind_pool_th_restore $swp1 0 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_tc_bind_pool_th_restore "$swp1" 0 ingress In qos_mc_aware.sh line 173: devlink_port_pool_th_save $swp2 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp2" 0 In qos_mc_aware.sh line 174: devlink_port_pool_th_set $swp2 0 5 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp2" 0 5 In qos_mc_aware.sh line 175: defer devlink_port_pool_th_restore $swp2 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp2" 0 In qos_mc_aware.sh line 177: devlink_tc_bind_pool_th_save $swp2 1 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_save "$swp2" 1 ingress In qos_mc_aware.sh line 178: devlink_tc_bind_pool_th_set $swp2 1 ingress 0 5 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_set "$swp2" 1 ingress 0 5 In qos_mc_aware.sh line 179: defer devlink_tc_bind_pool_th_restore $swp2 1 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_tc_bind_pool_th_restore "$swp2" 1 ingress In qos_mc_aware.sh line 181: devlink_port_pool_th_save $swp3 4 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp3" 4 In qos_mc_aware.sh line 182: devlink_port_pool_th_set $swp3 4 12 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp3" 4 12 In qos_mc_aware.sh line 183: defer devlink_port_pool_th_restore $swp3 4 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp3" 4 In qos_mc_aware.sh line 197: h3mac=$(mac_get $h3) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h3mac=$(mac_get "$h3") In qos_mc_aware.sh line 210: ping_test $h2 192.0.2.130 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h2" 192.0.2.130 In qos_mc_aware.sh line 218: start_traffic $h2.111 192.0.2.129 192.0.2.130 $h3mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h2".111 192.0.2.129 192.0.2.130 "$h3mac" In qos_mc_aware.sh line 221: uc_rate=($(measure_rate $swp2 $h3 rx_octets_prio_1 "$what")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: uc_rate=($(measure_rate "$swp2" "$h3" rx_octets_prio_1 "$what")) In qos_mc_aware.sh line 224: echo ${uc_rate[@]} ^-----------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In qos_mc_aware.sh line 236: local -a uc_rate=($(run_uc_measure_rate "UC-only")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). In qos_mc_aware.sh line 239: start_traffic $h1 192.0.2.65 bc bc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1" 192.0.2.65 bc bc In qos_mc_aware.sh line 242: local d0=$(date +%s) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In qos_mc_aware.sh line 243: local t0=$(ethtool_stats_get $h3 rx_octets_prio_0) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t0=$(ethtool_stats_get "$h3" rx_octets_prio_0) In qos_mc_aware.sh line 244: local u0=$(ethtool_stats_get $swp1 rx_octets_prio_0) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local u0=$(ethtool_stats_get "$swp1" rx_octets_prio_0) In qos_mc_aware.sh line 246: local -a uc_rate_2=($(run_uc_measure_rate "UC+MC")) ^----------------------------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). In qos_mc_aware.sh line 249: local d1=$(date +%s) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In qos_mc_aware.sh line 250: local t1=$(ethtool_stats_get $h3 rx_octets_prio_0) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t1=$(ethtool_stats_get "$h3" rx_octets_prio_0) In qos_mc_aware.sh line 251: local u1=$(ethtool_stats_get $swp1 rx_octets_prio_0) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local u1=$(ethtool_stats_get "$swp1" rx_octets_prio_0) In qos_mc_aware.sh line 253: local deg=$(bc <<< " ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values. In qos_mc_aware.sh line 261: check_err $(bc <<< "$deg < 15") "Minimum shaper not in effect" ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. In qos_mc_aware.sh line 262: check_err $(bc <<< "$deg > 25") "MC traffic degrades UC performance too much" ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. In qos_mc_aware.sh line 265: local mc_ir=$(rate $u0 $u1 $interval) ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local mc_ir=$(rate "$u0" "$u1" "$interval") In qos_mc_aware.sh line 266: local mc_er=$(rate $t0 $t1 $interval) ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local mc_er=$(rate "$t0" "$t1" "$interval") In qos_mc_aware.sh line 270: echo "UC-only throughput $(humanize $ucth1)" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "UC-only throughput $(humanize "$ucth1")" In qos_mc_aware.sh line 271: echo "UC+MC throughput $(humanize $ucth2)" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "UC+MC throughput $(humanize "$ucth2")" In qos_mc_aware.sh line 276: echo " ingress UC throughput $(humanize ${uc_rate[0]})" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " ingress UC throughput $(humanize "${uc_rate[0]}")" In qos_mc_aware.sh line 277: echo " egress UC throughput $(humanize ${uc_rate[1]})" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " egress UC throughput $(humanize "${uc_rate[1]}")" In qos_mc_aware.sh line 279: echo " ingress UC throughput $(humanize ${uc_rate_2[0]})" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " ingress UC throughput $(humanize "${uc_rate_2[0]}")" In qos_mc_aware.sh line 280: echo " egress UC throughput $(humanize ${uc_rate_2[1]})" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " egress UC throughput $(humanize "${uc_rate_2[1]}")" In qos_mc_aware.sh line 281: echo " ingress MC throughput $(humanize $mc_ir)" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " ingress MC throughput $(humanize "$mc_ir")" In qos_mc_aware.sh line 282: echo " egress MC throughput $(humanize $mc_er)" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " egress MC throughput $(humanize "$mc_er")" In qos_mc_aware.sh line 288: RET=0 ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally). In qos_mc_aware.sh line 290: start_traffic $h2.111 192.0.2.129 192.0.2.130 $h3mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h2".111 192.0.2.129 192.0.2.130 "$h3mac" In qos_mc_aware.sh line 293: local d0=$(date +%s) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In qos_mc_aware.sh line 294: local t0=$(ethtool_stats_get $h3 rx_octets_prio_1) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t0=$(ethtool_stats_get "$h3" rx_octets_prio_1) In qos_mc_aware.sh line 295: local u0=$(ethtool_stats_get $swp2 rx_octets_prio_1) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local u0=$(ethtool_stats_get "$swp2" rx_octets_prio_1) In qos_mc_aware.sh line 303: if $ARPING -c 1 -I $h1 -b 192.0.2.66 -q -w 1; then ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if $ARPING -c 1 -I "$h1" -b 192.0.2.66 -q -w 1; then In qos_mc_aware.sh line 310: local d1=$(date +%s) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In qos_mc_aware.sh line 311: local t1=$(ethtool_stats_get $h3 rx_octets_prio_1) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t1=$(ethtool_stats_get "$h3" rx_octets_prio_1) In qos_mc_aware.sh line 312: local u1=$(ethtool_stats_get $swp2 rx_octets_prio_1) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local u1=$(ethtool_stats_get "$swp2" rx_octets_prio_1) In qos_mc_aware.sh line 315: local uc_ir=$(rate $u0 $u1 $interval) ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local uc_ir=$(rate "$u0" "$u1" "$interval") In qos_mc_aware.sh line 316: local uc_er=$(rate $t0 $t1 $interval) ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local uc_er=$(rate "$t0" "$t1" "$interval") In qos_mc_aware.sh line 322: echo " ingress UC throughput $(humanize ${uc_ir})" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " ingress UC throughput $(humanize "${uc_ir}")" In qos_mc_aware.sh line 323: echo " egress UC throughput $(humanize ${uc_er})" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " egress UC throughput $(humanize "${uc_er}")" In qos_mc_aware.sh line 334: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2034 -- ALL_TESTS appears unused. Verify ... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... Checking tools/testing/selftests/drivers/net/mlxsw/sch_red_core.sh - 08d2ef05e2210a31654fc90db58d1f462ce46e6f86fec6fc6b2b52cc8fbdda3e In sch_red_core.sh line 1: # SPDX-License-Identifier: GPL-2.0 ^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. In sch_red_core.sh line 71: NUM_NETIFS=8 ^--------^ SC2034 (warning): NUM_NETIFS appears unused. Verify use (or export if used externally). In sch_red_core.sh line 72: CHECK_TC="yes" ^------^ SC2034 (warning): CHECK_TC appears unused. Verify use (or export if used externally). In sch_red_core.sh line 73: lib_dir=$(dirname $0)/../../../net/forwarding ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lib_dir=$(dirname "$0")/../../../net/forwarding In sch_red_core.sh line 74: source $lib_dir/lib.sh ^-------------^ SC1091 (info): Not following: ./lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In sch_red_core.sh line 75: source $lib_dir/devlink_lib.sh ^---------------------^ SC1091 (info): Not following: ./devlink_lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/devlink_lib.sh In sch_red_core.sh line 103: simple_if_init $dev ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$dev" In sch_red_core.sh line 104: defer simple_if_fini $dev ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$dev" In sch_red_core.sh line 106: mtu_set $dev 10000 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$dev" 10000 In sch_red_core.sh line 107: defer mtu_restore $dev ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$dev" In sch_red_core.sh line 109: vlan_create $dev 10 v$dev $(ipaddr $host 10)/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$dev" 10 v"$dev" $(ipaddr "$host" 10)/28 In sch_red_core.sh line 110: defer vlan_destroy $dev 10 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$dev" 10 In sch_red_core.sh line 111: ip link set dev $dev.10 type vlan egress 0:0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev".10 type vlan egress 0:0 In sch_red_core.sh line 113: vlan_create $dev 11 v$dev $(ipaddr $host 11)/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$dev" 11 v"$dev" $(ipaddr "$host" 11)/28 In sch_red_core.sh line 114: defer vlan_destroy $dev 11 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$dev" 11 In sch_red_core.sh line 115: ip link set dev $dev.11 type vlan egress 0:1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev".11 type vlan egress 0:1 In sch_red_core.sh line 120: host_create $h1 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: host_create "$h1" 1 In sch_red_core.sh line 125: host_create $h2 2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: host_create "$h2" 2 In sch_red_core.sh line 127: tc qdisc add dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$h2" clsact In sch_red_core.sh line 128: defer tc qdisc del dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$h2" clsact In sch_red_core.sh line 144: tc qdisc replace dev $h2 root handle 10: tbf rate 200mbit \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$h2" root handle 10: tbf rate 200mbit \ In sch_red_core.sh line 146: defer tc qdisc del dev $h2 root handle 10: ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$h2" root handle 10: In sch_red_core.sh line 151: host_create $h3 3 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: host_create "$h3" 3 In sch_red_core.sh line 172: ip link set dev $intf up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf" up In sch_red_core.sh line 173: defer ip link set dev $intf down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$intf" down In sch_red_core.sh line 175: mtu_set $intf 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$intf" 10000 In sch_red_core.sh line 176: defer mtu_restore $intf ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$intf" In sch_red_core.sh line 181: vlan_create $intf $vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$intf" $vlan In sch_red_core.sh line 182: defer vlan_destroy $intf $vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$intf" $vlan In sch_red_core.sh line 184: ip link set dev $intf.$vlan master br1_$vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf".$vlan master br1_$vlan In sch_red_core.sh line 185: defer ip link set dev $intf.$vlan nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$intf".$vlan nomaster In sch_red_core.sh line 187: ip link set dev $intf.$vlan up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf".$vlan up In sch_red_core.sh line 188: defer ip link set dev $intf.$vlan up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$intf".$vlan up In sch_red_core.sh line 194: vlan_create $intf $vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$intf" $vlan In sch_red_core.sh line 195: defer vlan_destroy $intf $vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$intf" $vlan In sch_red_core.sh line 197: ip link set dev $intf.$vlan master br2_$vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf".$vlan master br2_$vlan In sch_red_core.sh line 198: defer ip link set dev $intf.$vlan nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$intf".$vlan nomaster In sch_red_core.sh line 200: ip link set dev $intf.$vlan up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf".$vlan up In sch_red_core.sh line 201: defer ip link set dev $intf.$vlan up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$intf".$vlan up In sch_red_core.sh line 205: ip link set dev $swp4.10 type vlan egress 0:0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp4".10 type vlan egress 0:0 In sch_red_core.sh line 206: ip link set dev $swp4.11 type vlan egress 0:1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp4".11 type vlan egress 0:1 In sch_red_core.sh line 209: ip link set dev $intf.$vlan type vlan ingress 0:0 1:1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf".$vlan type vlan ingress 0:0 1:1 In sch_red_core.sh line 214: tc qdisc replace dev $intf root handle 1: tbf rate 200mbit \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$intf" root handle 1: tbf rate 200mbit \ In sch_red_core.sh line 216: defer tc qdisc del dev $intf root handle 1: ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$intf" root handle 1: In sch_red_core.sh line 231: local size=$(devlink_pool_size_thtype 0 | cut -d' ' -f 1) ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red_core.sh line 232: devlink_port_pool_th_save $swp3 8 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp3" 8 In sch_red_core.sh line 233: devlink_port_pool_th_set $swp3 8 $size ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp3" 8 "$size" In sch_red_core.sh line 234: defer devlink_port_pool_th_restore $swp3 8 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp3" 8 In sch_red_core.sh line 251: h3_mac=$(mac_get $h3) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h3_mac=$(mac_get "$h3") In sch_red_core.sh line 264: ping_test $h1.10 $(ipaddr 3 10) " from host 1, vlan 10" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".10 $(ipaddr 3 10) " from host 1, vlan 10" In sch_red_core.sh line 265: ping_test $h1.11 $(ipaddr 3 11) " from host 1, vlan 11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".11 $(ipaddr 3 11) " from host 1, vlan 11" In sch_red_core.sh line 266: ping_test $h2.10 $(ipaddr 3 10) " from host 2, vlan 10" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h2".10 $(ipaddr 3 10) " from host 2, vlan 10" In sch_red_core.sh line 267: ping_test $h2.11 $(ipaddr 3 11) " from host 2, vlan 11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h2".11 $(ipaddr 3 11) " from host 2, vlan 11" In sch_red_core.sh line 281: local tc=$(get_tc $vlan) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local tc=$(get_tc "$vlan") In sch_red_core.sh line 292: qdisc_stats_get $swp3 $(get_qdisc_handle $vlan) .backlog ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qdisc_stats_get "$swp3" $(get_qdisc_handle "$vlan") .backlog In sch_red_core.sh line 299: local tc=$(($(get_tc $vlan) + 8)) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local tc=$(($(get_tc "$vlan") + 8)) In sch_red_core.sh line 300: ethtool_stats_get $swp3 tc_transmit_queue_tc_$tc ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool_stats_get "$swp3" tc_transmit_queue_tc_$tc In sch_red_core.sh line 307: ethtool_stats_get $swp3 ecn_marked ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool_stats_get "$swp3" ecn_marked In sch_red_core.sh line 315: qdisc_stats_get $swp3 $(get_qdisc_handle $vlan) .marked ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qdisc_stats_get "$swp3" $(get_qdisc_handle "$vlan") .marked In sch_red_core.sh line 323: qdisc_stats_get $swp3 $(get_qdisc_handle $vlan) .packets ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qdisc_stats_get "$swp3" $(get_qdisc_handle "$vlan") .packets In sch_red_core.sh line 332: $MZ $h2.$vlan -p 8000 -a own -b $h3_mac \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h2"."$vlan" -p 8000 -a own -b "$h3_mac" \ In sch_red_core.sh line 333: -A $(ipaddr 2 $vlan) -B $(ipaddr 3 $vlan) \ ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -A $(ipaddr 2 "$vlan") -B $(ipaddr 3 "$vlan") \ In sch_red_core.sh line 334: -t $proto -q -c $pkts "$@" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -t "$proto" -q -c "$pkts" "$@" In sch_red_core.sh line 353: local cur=$(busywait 1100 until_counter_is "> $cur" \ ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red_core.sh line 354: get_qdisc_backlog $vlan) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: get_qdisc_backlog "$vlan") In sch_red_core.sh line 359: echo $cur ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$cur" In sch_red_core.sh line 362: echo $cur ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$cur" In sch_red_core.sh line 366: send_packets $vlan $proto $pkts "$@" ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_packets "$vlan" "$proto" $pkts "$@" In sch_red_core.sh line 376: local npackets_0=$(get_qdisc_npackets $vlan) ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local npackets_0=$(get_qdisc_npackets "$vlan") In sch_red_core.sh line 377: local nmarked_0=$($get_nmarked $vlan) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local nmarked_0=$($get_nmarked "$vlan") In sch_red_core.sh line 379: local npackets_1=$(get_qdisc_npackets $vlan) ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local npackets_1=$(get_qdisc_npackets "$vlan") In sch_red_core.sh line 380: local nmarked_1=$($get_nmarked $vlan) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local nmarked_1=$($get_nmarked "$vlan") In sch_red_core.sh line 387: ((pct $cond)) ^-- SC1105 (error): Shells disambiguate (( differently or not at all. For subshell, add spaces around ( . For ((, fix parsing errors. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ((pct "$cond")) In sch_red_core.sh line 404: backlog=$(build_backlog $vlan $((2 * limit / 3)) udp) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: backlog=$(build_backlog "$vlan" $((2 * limit / 3)) udp) In sch_red_core.sh line 406: pct=$(check_marking "$get_nmarked" $vlan "== 0") ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pct=$(check_marking "$get_nmarked" "$vlan" "== 0") In sch_red_core.sh line 414: backlog=$(build_backlog $vlan $((3 * limit / 2)) tcp tos=0x01) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: backlog=$(build_backlog "$vlan" $((3 * limit / 2)) tcp tos=0x01) In sch_red_core.sh line 416: pct=$(check_marking "$get_nmarked" $vlan ">= 95") ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pct=$(check_marking "$get_nmarked" "$vlan" ">= 95") In sch_red_core.sh line 428: start_tcp_traffic $h1.$vlan $(ipaddr 1 $vlan) $(ipaddr 3 $vlan) \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_tcp_traffic "$h1"."$vlan" $(ipaddr 1 "$vlan") $(ipaddr 3 "$vlan") \ In sch_red_core.sh line 429: $h3_mac tos=0x01 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$h3_mac" tos=0x01 In sch_red_core.sh line 433: ecn_test_common "$name" "$get_nmarked" $vlan $limit ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ecn_test_common "$name" "$get_nmarked" "$vlan" "$limit" In sch_red_core.sh line 439: build_backlog $vlan $((2 * limit)) udp >/dev/null ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: build_backlog "$vlan" $((2 * limit)) udp >/dev/null In sch_red_core.sh line 469: start_tcp_traffic $h1.$vlan $(ipaddr 1 $vlan) $(ipaddr 3 $vlan) \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_tcp_traffic "$h1"."$vlan" $(ipaddr 1 "$vlan") $(ipaddr 3 "$vlan") \ In sch_red_core.sh line 470: $h3_mac tos=0x01 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$h3_mac" tos=0x01 In sch_red_core.sh line 474: ecn_test_common "$name" get_nmarked $vlan $limit ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ecn_test_common "$name" get_nmarked "$vlan" "$limit" In sch_red_core.sh line 480: build_backlog $vlan $((2 * limit)) udp >/dev/null ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: build_backlog "$vlan" $((2 * limit)) udp >/dev/null In sch_red_core.sh line 500: start_tcp_traffic $h1.$vlan $(ipaddr 1 $vlan) $(ipaddr 3 $vlan) \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_tcp_traffic "$h1"."$vlan" $(ipaddr 1 "$vlan") $(ipaddr 3 "$vlan") \ In sch_red_core.sh line 501: $h3_mac tos=0x01 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$h3_mac" tos=0x01 In sch_red_core.sh line 506: backlog=$(build_backlog $vlan $((2 * limit / 3)) tcp tos=0x01) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: backlog=$(build_backlog "$vlan" $((2 * limit / 3)) tcp tos=0x01) In sch_red_core.sh line 508: pct=$(check_marking get_nmarked $vlan "== 0") ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pct=$(check_marking get_nmarked "$vlan" "== 0") In sch_red_core.sh line 514: backlog=$(build_backlog $vlan $((3 * limit / 2)) tcp tos=0x01) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: backlog=$(build_backlog "$vlan" $((3 * limit / 2)) tcp tos=0x01) In sch_red_core.sh line 516: pct=$(check_marking get_nmarked $vlan "== 0") ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pct=$(check_marking get_nmarked "$vlan" "== 0") In sch_red_core.sh line 518: backlog=$(get_qdisc_backlog $vlan) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: backlog=$(get_qdisc_backlog "$vlan") In sch_red_core.sh line 541: start_tcp_traffic $h1.$vlan $(ipaddr 1 $vlan) $(ipaddr 3 $vlan) bc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_tcp_traffic "$h1"."$vlan" $(ipaddr 1 "$vlan") $(ipaddr 3 "$vlan") bc In sch_red_core.sh line 544: start_tcp_traffic $h2.$vlan $(ipaddr 2 $vlan) $(ipaddr 3 $vlan) bc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_tcp_traffic "$h2"."$vlan" $(ipaddr 2 "$vlan") $(ipaddr 3 "$vlan") bc In sch_red_core.sh line 547: qbl=$(busywait 5000 until_counter_is ">= 500000" \ ^-^ SC2034 (warning): qbl appears unused. Verify use (or export if used externally). In sch_red_core.sh line 548: get_qdisc_backlog $vlan) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: get_qdisc_backlog "$vlan") In sch_red_core.sh line 554: ebl=$(busywait 5000 until_counter_is ">= 500000" \ ^-^ SC2034 (warning): ebl appears unused. Verify use (or export if used externally). In sch_red_core.sh line 555: get_mc_transmit_queue $vlan) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: get_mc_transmit_queue "$vlan") In sch_red_core.sh line 580: start_tcp_traffic $h1.$vlan $(ipaddr 1 $vlan) $(ipaddr 3 $vlan) \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_tcp_traffic "$h1"."$vlan" $(ipaddr 1 "$vlan") $(ipaddr 3 "$vlan") \ In sch_red_core.sh line 581: $h3_mac tos=0x01 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$h3_mac" tos=0x01 In sch_red_core.sh line 585: qevent_rule_install_$subtest ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qevent_rule_install_"$subtest" In sch_red_core.sh line 587: build_backlog $vlan $((2 * limit / 3)) tcp tos=0x01 >/dev/null ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: build_backlog "$vlan" $((2 * limit / 3)) tcp tos=0x01 >/dev/null In sch_red_core.sh line 591: $fetch_counter) ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$fetch_counter") In sch_red_core.sh line 596: build_backlog $vlan $((3 * limit / 2)) tcp tos=0x01 >/dev/null ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: build_backlog "$vlan" $((3 * limit / 2)) tcp tos=0x01 >/dev/null In sch_red_core.sh line 598: $fetch_counter > /dev/null ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$fetch_counter" > /dev/null In sch_red_core.sh line 602: qevent_rule_uninstall_$subtest ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qevent_rule_uninstall_"$subtest" In sch_red_core.sh line 604: $fetch_counter > /dev/null ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$fetch_counter" > /dev/null In sch_red_core.sh line 632: RET=0 ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally). In sch_red_core.sh line 634: start_traffic $h1.$vlan $(ipaddr 1 $vlan) $(ipaddr 3 $vlan) $h3_mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1"."$vlan" $(ipaddr 1 "$vlan") $(ipaddr 3 "$vlan") "$h3_mac" In sch_red_core.sh line 638: qevent_rule_install_$subtest ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qevent_rule_install_"$subtest" In sch_red_core.sh line 641: build_backlog $vlan $((2 * limit / 3)) udp >/dev/null ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: build_backlog "$vlan" $((2 * limit / 3)) udp >/dev/null In sch_red_core.sh line 643: busywait 1100 until_counter_is ">= $((base + 1))" $fetch_counter >/dev/null ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait 1100 until_counter_is ">= $((base + 1))" "$fetch_counter" >/dev/null In sch_red_core.sh line 649: build_backlog $vlan $((3 * limit / 2)) udp >/dev/null ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: build_backlog "$vlan" $((3 * limit / 2)) udp >/dev/null In sch_red_core.sh line 652: send_packets $vlan udp 100 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_packets "$vlan" udp 100 In sch_red_core.sh line 654: now=$(busywait 1100 until_counter_is ">= $((base + 95))" $fetch_counter) ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: now=$(busywait 1100 until_counter_is ">= $((base + 95))" "$fetch_counter") In sch_red_core.sh line 659: $fetch_counter >/dev/null ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$fetch_counter" >/dev/null In sch_red_core.sh line 663: qevent_rule_uninstall_$subtest ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qevent_rule_uninstall_"$subtest" In sch_red_core.sh line 664: send_packets $vlan udp 100 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_packets "$vlan" udp 100 In sch_red_core.sh line 666: $fetch_counter) ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$fetch_counter") In sch_red_core.sh line 681: action mirred egress mirror dev $swp2 hw_stats disabled ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: action mirred egress mirror dev "$swp2" hw_stats disabled In sch_red_core.sh line 700: tc filter add dev $h2 ingress pref 1 handle 101 prot ip \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress pref 1 handle 101 prot ip \ In sch_red_core.sh line 707: tc filter del dev $h2 ingress pref 1 handle 101 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress pref 1 handle 101 flower In sch_red_core.sh line 715: tc filter add dev $h2 ingress pref 1 handle 101 prot ip \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress pref 1 handle 101 prot ip \ In sch_red_core.sh line 721: $(: should_fail=)0 ^---------------^ SC2046 (warning): Quote this to prevent word splitting. In sch_red_core.sh line 723: tc filter del dev $h2 ingress pref 1 handle 101 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress pref 1 handle 101 flower For more information: https://www.shellcheck.net/wiki/SC1105 -- Shells disambiguate (( differentl... https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y... https://www.shellcheck.net/wiki/SC2034 -- CHECK_TC appears unused. Verify u... Checking tools/testing/selftests/net/forwarding/bridge_activity_notify.sh - 4b25b7f31c0402b456b678840d313b3e1670b579a4a63da34db9448f6b1ecadd Checking tools/testing/selftests/net/forwarding/bridge_fdb_local_vlan_0.sh - eb4b9d40065ea6bedb08db2f927c7c68c9e183e694b90fda2fd0107282573fb6 Checking tools/testing/selftests/net/forwarding/lib.sh - e1a847ed4d4592e29820ec7d4d0de16c1b815b225d7508d588b8b4f99ffa9610 In lib.sh line 97: basename `realpath $driver_path` ^---------------------^ SC2046 (warning): Quote this to prevent word splitting. ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: basename $(realpath "$driver_path") In lib.sh line 103: local ifnames=`ip -j link show | jq -r ".[].ifname"` ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: local ifnames=$(ip -j link show | jq -r ".[].ifname") In lib.sh line 108: local driver_name=`driver_name_get $ifname` ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-----------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local driver_name=$(driver_name_get "$ifname") In lib.sh line 109: if [[ ! -z $driver_name && $driver_name == $NETIF_FIND_DRIVER ]]; then ^-- SC2236 (style): Use -n instead of ! -z. ^----------------^ SC2053 (warning): Quote the right-hand side of == in [[ ]] to prevent glob matching. In lib.sh line 128: source "$net_forwarding_dir/forwarding.config" ^-- SC1091 (info): Not following: ./forwarding.config: openBinaryFile: does not exist (No such file or directory) In lib.sh line 139: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 149: tc filter add dev $dev ingress pref 1 handle 1 flower \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$dev" ingress pref 1 handle 1 flower \ In lib.sh line 151: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 155: tc filter del dev $dev ingress pref 1 handle 1 flower \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$dev" ingress pref 1 handle 1 flower \ In lib.sh line 164: tc filter add dev $dev ingress protocol mpls_uc pref 1 handle 1 \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$dev" ingress protocol mpls_uc pref 1 handle 1 \ In lib.sh line 166: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 170: tc filter del dev $dev ingress protocol mpls_uc pref 1 handle 1 \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$dev" ingress protocol mpls_uc pref 1 handle 1 \ In lib.sh line 180: tc filter add dev $dev ingress protocol mpls_uc pref 1 handle 1 \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$dev" ingress protocol mpls_uc pref 1 handle 1 \ In lib.sh line 184: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 189: tc -j filter show dev $dev ingress protocol mpls_uc | jq . &> /dev/null ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc -j filter show dev "$dev" ingress protocol mpls_uc | jq . &> /dev/null In lib.sh line 191: tc filter del dev $dev ingress protocol mpls_uc pref 1 handle 1 \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$dev" ingress protocol mpls_uc pref 1 handle 1 \ In lib.sh line 203: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 212: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 221: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 230: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 239: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 248: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 257: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 268: [ 0 -ne $(ethtool --json -S $dev --all-groups --src pmac 2>/dev/null \ ^-- SC2046 (warning): Quote this to prevent word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ 0 -ne $(ethtool --json -S "$dev" --all-groups --src pmac 2>/dev/null \ In lib.sh line 297: local driver_name=`driver_name_get $dev` ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local driver_name=$(driver_name_get "$dev") In lib.sh line 299: if [[ $driver_name != $expected ]]; then ^-------^ SC2053 (warning): Quote the right-hand side of != in [[ ]] to prevent glob matching. In lib.sh line 312: local version="$(msend -v)" ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 316: major=$(echo $version | cut -d. -f1) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: major=$(echo "$version" | cut -d. -f1) In lib.sh line 318: if [ $major -lt 3 ]; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$major" -lt 3 ]; then In lib.sh line 328: require_command $MZ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: require_command "$MZ" In lib.sh line 331: require_command $TEAMD ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: require_command "$TEAMD" In lib.sh line 364: echo "SKIP: Importer requires $NUM_NETIFS NETIFS, but only ${#NETIFS[@]} are defined (${NETIFS[@]})" ^----------^ SC2145 (error): Argument mixes string and array. Use * or separate argument. In lib.sh line 382: if [ -z ${NETIFS[p$i]} ]; then ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ -z "${NETIFS[p$i]}" ]; then In lib.sh line 387: ip link show dev ${NETIFS[p$i]} &> /dev/null ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link show dev "${NETIFS[p$i]}" &> /dev/null In lib.sh line 388: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 389: ip link add ${NETIFS[p$i]} type veth \ ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add "${NETIFS[p$i]}" type veth \ In lib.sh line 390: peer name ${NETIFS[p$j]} ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: peer name "${NETIFS[p$j]}" In lib.sh line 391: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 405: *) echo "Can not create interfaces of type \'$NETIF_TYPE\'" ^-- SC2028 (info): echo may not expand escape sequences. Use printf. In lib.sh line 421: MAC_ADDR_ORIG["$dev"]=$(ip -j link show dev $dev | jq -e '.[].address') ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: MAC_ADDR_ORIG["$dev"]=$(ip -j link show dev "$dev" | jq -e '.[].address') In lib.sh line 424: ip link set dev $dev address $new_addr ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev" address "$new_addr" In lib.sh line 434: ip link set dev $dev address ${MAC_ADDR_ORIG["$dev"]} ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev" address "${MAC_ADDR_ORIG["$dev"]}" In lib.sh line 447: ip link show dev ${NETIFS[p$i]} &> /dev/null ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link show dev "${NETIFS[p$i]}" &> /dev/null In lib.sh line 448: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 460: [[ $? != 0 ]] ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 468: for cur in ${arr[@]}; do ^-------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In lib.sh line 474: echo $max ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$max" In lib.sh line 490: $@ | grep $addr | grep $flag "$word" ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $@ | grep "$addr" | grep "$flag" "$word" In lib.sh line 513: setup_wait_dev_with_timeout "$dev" $INTERFACE_TIMEOUT $wait_time ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_wait_dev_with_timeout "$dev" "$INTERFACE_TIMEOUT" "$wait_time" In lib.sh line 515: if (($?)); then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 529: for ((i = 1; i <= $max_iterations; ++i)); do ^-------------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In lib.sh line 530: ip link show dev $dev up \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link show dev "$dev" up \ In lib.sh line 532: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 535: sleep $wait_time ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sleep "$wait_time" In lib.sh line 549: setup_wait_dev ${NETIFS[p$i]} 0 ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_wait_dev "${NETIFS[p$i]}" 0 In lib.sh line 553: sleep $WAIT_TIME ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sleep "$WAIT_TIME" In lib.sh line 566: slowwait $timeout ip link show dev $dev &> /dev/null ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: slowwait "$timeout" ip link show dev "$dev" &> /dev/null In lib.sh line 567: if (( $? )); then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 570: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" In lib.sh line 578: read ^--^ SC2162 (info): read without -r will mangle backslashes. In lib.sh line 618: return ${__TB_IDS[$vrf_name]} ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "${__TB_IDS[$vrf_name]}" In lib.sh line 626: __vrf_td_id_assign $vrf_name ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __vrf_td_id_assign "$vrf_name" In lib.sh line 629: ip link add dev $vrf_name type vrf table $tb_id ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add dev "$vrf_name" type vrf table $tb_id In lib.sh line 639: __vrf_td_id_lookup $vrf_name ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __vrf_td_id_lookup "$vrf_name" In lib.sh line 644: ip link del dev $vrf_name ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link del dev "$vrf_name" In lib.sh line 658: ip address $add_del $addrstr dev $if_name ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address "$add_del" "$addrstr" dev "$if_name" In lib.sh line 668: ip link set dev $if_name master $vrf_name ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$if_name" master "$vrf_name" In lib.sh line 669: ip link set dev $if_name up ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$if_name" up In lib.sh line 671: __addr_add_del $if_name add "${addrs[@]}" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __addr_add_del "$if_name" add "${addrs[@]}" In lib.sh line 679: __addr_add_del $if_name del "${addrs[@]}" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __addr_add_del "$if_name" del "${addrs[@]}" In lib.sh line 681: ip link set dev $if_name down ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$if_name" down In lib.sh line 682: ip link set dev $if_name nomaster ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$if_name" nomaster In lib.sh line 695: vrf_create $vrf_name ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vrf_create "$vrf_name" In lib.sh line 696: ip link set dev $vrf_name up ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$vrf_name" up In lib.sh line 697: __simple_if_init $if_name $vrf_name "${array[@]}" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __simple_if_init "$if_name" "$vrf_name" "${array[@]}" In lib.sh line 710: __simple_if_fini $if_name "${array[@]}" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __simple_if_fini "$if_name" "${array[@]}" In lib.sh line 711: vrf_destroy $vrf_name ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vrf_destroy "$vrf_name" In lib.sh line 721: ip link add name $name type $type \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add name "$name" type "$type" \ In lib.sh line 722: local $local remote $remote "$@" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local "$local" remote "$remote" "$@" In lib.sh line 723: ip link set dev $name up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$name" up In lib.sh line 730: ip link del dev $name ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link del dev "$name" In lib.sh line 741: ip link add name $name link $if_name type vlan id $vid ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add name "$name" link "$if_name" type vlan id "$vid" In lib.sh line 743: ip link set dev $name master $vrf ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$name" master "$vrf" In lib.sh line 745: ip link set dev $name up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$name" up In lib.sh line 746: __addr_add_del $name add "${ips[@]}" ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __addr_add_del "$name" add "${ips[@]}" In lib.sh line 755: ip link del dev $name ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link del dev "$name" In lib.sh line 763: require_command $TEAMD ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: require_command "$TEAMD" In lib.sh line 764: $TEAMD -t $if_name -d -c '{"runner": {"name": "'$mode'"}}' ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $TEAMD -t "$if_name" -d -c '{"runner": {"name": "'"$mode"'"}}' In lib.sh line 766: ip link set dev $slave down ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$slave" down In lib.sh line 767: ip link set dev $slave master $if_name ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$slave" master "$if_name" In lib.sh line 768: ip link set dev $slave up ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$slave" up In lib.sh line 770: ip link set dev $if_name up ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$if_name" up In lib.sh line 777: $TEAMD -t $if_name -k ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $TEAMD -t "$if_name" -k In lib.sh line 784: ip -j link show dev $if_name | jq -r '.[]["master"]' ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -j link show dev "$if_name" | jq -r '.[]["master"]' In lib.sh line 793: ip -j -s link show dev $if_name \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -j -s link show dev "$if_name" \ In lib.sh line 794: | jq '.[]["stats64"]["'$dir'"]["'$stat'"]' ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: | jq '.[]["stats64"]["'"$dir"'"]["'"$stat"'"]' In lib.sh line 799: link_stats_get $1 tx packets ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: link_stats_get "$1" tx packets In lib.sh line 804: link_stats_get $1 rx errors ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: link_stats_get "$1" rx errors In lib.sh line 812: ethtool -S $dev | grep "^ *$stat:" | head -n 1 | cut -d: -f2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool -S "$dev" | grep "^ *$stat:" | head -n 1 | cut -d: -f2 In lib.sh line 822: ethtool --json -S $dev --groups $grp -- --src $src | \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool --json -S "$dev" --groups "$grp" -- --src "$src" | \ In lib.sh line 823: jq '.[]."'"$grp"'"."'$name'"' ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: jq '.[]."'"$grp"'"."'"$name"'"' In lib.sh line 851: cat /proc/net/dev_snmp6/$dev | grep "^$stat" | cut -f2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cat /proc/net/dev_snmp6/"$dev" | grep "^$stat" | cut -f2 In lib.sh line 861: ip -j stats show dev $if_name group offload subgroup $suite | ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -j stats show dev "$if_name" group offload subgroup "$suite" | In lib.sh line 871: ip -j -s -s nexthop show id $group_id | ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -j -s -s nexthop show id "$group_id" | In lib.sh line 962: ip -j addr show dev $if_name | \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -j addr show dev "$if_name" | \ In lib.sh line 973: ageing_time=$(ip -j -d link show dev $bridge \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ageing_time=$(ip -j -d link show dev "$bridge" \ In lib.sh line 983: SYSCTL_ORIG[$key]=$(sysctl -n $key) ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: SYSCTL_ORIG[$key]=$(sysctl -n "$key") In lib.sh line 992: sysctl -qw $key="$value" ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sysctl -qw "$key"="$value" In lib.sh line 999: sysctl -qw $key="${SYSCTL_ORIG[$key]}" ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sysctl -qw "$key"="${SYSCTL_ORIG[$key]}" In lib.sh line 1020: MTU_ORIG["$dev"]=$(ip -j link show dev $dev | jq -e '.[].mtu') ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: MTU_ORIG["$dev"]=$(ip -j link show dev "$dev" | jq -e '.[].mtu') In lib.sh line 1021: ip link set dev $dev mtu $mtu ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev" mtu "$mtu" In lib.sh line 1028: ip link set dev $dev mtu ${MTU_ORIG["$dev"]} ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev" mtu "${MTU_ORIG["$dev"]}" In lib.sh line 1036: ethtool -k ${NETIFS[p$i]} \ ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool -k "${NETIFS[p$i]}" \ In lib.sh line 1038: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 1056: tc filter add dev $dev $direction pref 1 \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$dev" "$direction" pref 1 \ In lib.sh line 1058: || tc filter add dev $dev $direction pref 1 \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: || tc filter add dev "$dev" "$direction" pref 1 \ In lib.sh line 1067: tc filter del dev $dev $direction pref 1 flower ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$dev" "$direction" pref 1 flower In lib.sh line 1078: tc filter $add_del dev "$tundev" ingress \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter "$add_del" dev "$tundev" ingress \ In lib.sh line 1079: proto ip$vsuf pref $pref \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: proto ip"$vsuf" pref "$pref" \ In lib.sh line 1080: flower ip_proto icmp$vsuf $filter \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower ip_proto icmp"$vsuf" "$filter" \ In lib.sh line 1123: tc filter $add_del dev "$dev" ingress \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter "$add_del" dev "$dev" ingress \ In lib.sh line 1124: proto 802.1q pref $pref \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: proto 802.1q pref "$pref" \ In lib.sh line 1125: flower $filter \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower "$filter" \ In lib.sh line 1154: __icmp_capture_add_del $add_del $((dscp + 100)) "" $dev \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __icmp_capture_add_del "$add_del" $((dscp + 100)) "" "$dev" \ In lib.sh line 1164: __dscp_capture_add_del add $dev $base ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __dscp_capture_add_del add "$dev" "$base" In lib.sh line 1172: __dscp_capture_add_del del $dev $base ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __dscp_capture_add_del del "$dev" "$base" In lib.sh line 1182: local t=$(tc_rule_stats_get $dev $((dscp + 100))) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t=$(tc_rule_stats_get "$dev" $((dscp + 100))) In lib.sh line 1191: tc qdisc add dev $dev clsact ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$dev" clsact In lib.sh line 1192: tc filter add dev $dev ingress \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$dev" ingress \ In lib.sh line 1238: diff=$(echo $weights_ratio - $packets_ratio | bc -l) ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: diff=$(echo "$weights_ratio" - "$packets_ratio" | bc -l) In lib.sh line 1251: ip netns exec $name bash <<-EOF ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$name" bash <<-EOF In lib.sh line 1268: vrf_name=$(master_name_get $if_name) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vrf_name=$(master_name_get "$if_name") In lib.sh line 1269: ip vrf exec $vrf_name \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip vrf exec "$vrf_name" \ In lib.sh line 1270: $PING $args -c $PING_COUNT -i 0.1 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$PING" "$args" -c "$PING_COUNT" -i 0.1 \ In lib.sh line 1271: -w $PING_TIMEOUT $dip &> /dev/null ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -w "$PING_TIMEOUT" "$dip" &> /dev/null In lib.sh line 1278: ping_do $1 $2 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_do "$1" "$2" In lib.sh line 1287: ping_do $1 $2 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_do "$1" "$2" In lib.sh line 1299: vrf_name=$(master_name_get $if_name) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vrf_name=$(master_name_get "$if_name") In lib.sh line 1300: ip vrf exec $vrf_name \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip vrf exec "$vrf_name" \ In lib.sh line 1301: $PING6 $args -c $PING_COUNT -i 0.1 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$PING6" "$args" -c "$PING_COUNT" -i 0.1 \ In lib.sh line 1302: -w $PING_TIMEOUT $dip &> /dev/null ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -w "$PING_TIMEOUT" "$dip" &> /dev/null In lib.sh line 1309: ping6_do $1 $2 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping6_do "$1" "$2" In lib.sh line 1318: ping6_do $1 $2 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping6_do "$1" "$2" In lib.sh line 1334: bridge -j fdb show br $bridge brport $br_port1 \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -j fdb show br "$bridge" brport "$br_port1" \ In lib.sh line 1341: bridge link set dev $br_port1 flood off ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge link set dev "$br_port1" flood off In lib.sh line 1343: ip link set $host1_if promisc on ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$host1_if" promisc on In lib.sh line 1344: tc qdisc add dev $host1_if ingress ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$host1_if" ingress In lib.sh line 1345: tc filter add dev $host1_if ingress protocol ip pref 1 handle 101 \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$host1_if" ingress protocol ip pref 1 handle 101 \ In lib.sh line 1348: $MZ $host2_if -c 1 -p 64 -b $mac -t ip -q ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$host2_if" -c 1 -p 64 -b $mac -t ip -q In lib.sh line 1351: tc -j -s filter show dev $host1_if ingress \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc -j -s filter show dev "$host1_if" ingress \ In lib.sh line 1356: $MZ $host1_if -c 1 -p 64 -a $mac -t ip -q ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$host1_if" -c 1 -p 64 -a $mac -t ip -q In lib.sh line 1359: bridge -j fdb show br $bridge brport $br_port1 \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -j fdb show br "$bridge" brport "$br_port1" \ In lib.sh line 1363: $MZ $host2_if -c 1 -p 64 -b $mac -t ip -q ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$host2_if" -c 1 -p 64 -b $mac -t ip -q In lib.sh line 1366: tc -j -s filter show dev $host1_if ingress \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc -j -s filter show dev "$host1_if" ingress \ In lib.sh line 1373: ageing_time=$(bridge_ageing_time_get $bridge) ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ageing_time=$(bridge_ageing_time_get "$bridge") In lib.sh line 1376: bridge -j fdb show br $bridge brport $br_port1 \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -j fdb show br "$bridge" brport "$br_port1" \ In lib.sh line 1380: bridge link set dev $br_port1 learning off ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge link set dev "$br_port1" learning off In lib.sh line 1382: $MZ $host1_if -c 1 -p 64 -a $mac -t ip -q ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$host1_if" -c 1 -p 64 -a $mac -t ip -q In lib.sh line 1385: bridge -j fdb show br $bridge brport $br_port1 \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -j fdb show br "$bridge" brport "$br_port1" \ In lib.sh line 1389: bridge link set dev $br_port1 learning on ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge link set dev "$br_port1" learning on In lib.sh line 1391: tc filter del dev $host1_if ingress protocol ip pref 1 handle 101 flower ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$host1_if" ingress protocol ip pref 1 handle 101 flower In lib.sh line 1392: tc qdisc del dev $host1_if ingress ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$host1_if" ingress In lib.sh line 1393: ip link set $host1_if promisc off ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$host1_if" promisc off In lib.sh line 1395: bridge link set dev $br_port1 flood on ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge link set dev "$br_port1" flood on In lib.sh line 1411: ip link set $host2_if promisc on ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$host2_if" promisc on In lib.sh line 1412: tc qdisc add dev $host2_if ingress ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$host2_if" ingress In lib.sh line 1413: tc filter add dev $host2_if ingress protocol ip pref 1 handle 101 \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$host2_if" ingress protocol ip pref 1 handle 101 \ In lib.sh line 1414: flower dst_mac $mac action drop ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower dst_mac "$mac" action drop In lib.sh line 1416: $MZ $host1_if -c 1 -p 64 -b $mac -B $ip -t ip -q ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$host1_if" -c 1 -p 64 -b "$mac" -B "$ip" -t ip -q In lib.sh line 1419: tc -j -s filter show dev $host2_if ingress \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc -j -s filter show dev "$host2_if" ingress \ In lib.sh line 1427: tc filter del dev $host2_if ingress protocol ip pref 1 handle 101 flower ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$host2_if" ingress protocol ip pref 1 handle 101 flower In lib.sh line 1428: tc qdisc del dev $host2_if ingress ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$host2_if" ingress In lib.sh line 1429: ip link set $host2_if promisc off ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$host2_if" promisc off In lib.sh line 1444: bridge link set dev $br_port flood off ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge link set dev "$br_port" flood off In lib.sh line 1446: flood_test_do false $mac $ip $host1_if $host2_if ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_test_do false $mac $ip "$host1_if" "$host2_if" In lib.sh line 1449: bridge link set dev $br_port flood on ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge link set dev "$br_port" flood on In lib.sh line 1451: flood_test_do true $mac $ip $host1_if $host2_if ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_test_do true $mac $ip "$host1_if" "$host2_if" In lib.sh line 1467: bridge link set dev $br_port mcast_flood off ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge link set dev "$br_port" mcast_flood off In lib.sh line 1469: flood_test_do false $mac $ip $host1_if $host2_if ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_test_do false $mac $ip "$host1_if" "$host2_if" In lib.sh line 1472: bridge link set dev $br_port mcast_flood on ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge link set dev "$br_port" mcast_flood on In lib.sh line 1474: flood_test_do true $mac $ip $host1_if $host2_if ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_test_do true $mac $ip "$host1_if" "$host2_if" In lib.sh line 1487: flood_unicast_test $br_port $host1_if $host2_if ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_unicast_test "$br_port" "$host1_if" "$host2_if" In lib.sh line 1488: flood_multicast_test $br_port $host1_if $host2_if ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_multicast_test "$br_port" "$host1_if" "$host2_if" In lib.sh line 1501: $MZ $h_in -p $pktsize -A $sip -B $dip -c 0 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h_in" -p "$pktsize" -A "$sip" -B "$dip" -c 0 \ In lib.sh line 1502: -a own -b $dmac -t "$proto" -q "${mz_args[@]}" & ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -a own -b "$dmac" -t "$proto" -q "${mz_args[@]}" & In lib.sh line 1515: __start_traffic $pktsize udp "$h_in" "$sip" "$dip" "$dmac" \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __start_traffic "$pktsize" udp "$h_in" "$sip" "$dip" "$dmac" \ In lib.sh line 1528: __start_traffic $pktsize tcp "$h_in" "$sip" "$dip" "$dmac" \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __start_traffic "$pktsize" tcp "$h_in" "$sip" "$dip" "$dmac" \ In lib.sh line 1575: if [ -z $ns ]; then ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ -z "$ns" ]; then In lib.sh line 1581: if [ -z $SUDO_USER ] ; then ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ -z "$SUDO_USER" ] ; then In lib.sh line 1587: $ns_cmd tcpdump $TCPDUMP_EXTRA_FLAGS -e -n -Q in -i $if_name \ ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $ns_cmd tcpdump "$TCPDUMP_EXTRA_FLAGS" -e -n -Q in -i "$if_name" \ In lib.sh line 1588: -s 65535 -B 32768 $capuser -w ${capfile[$if_name]} \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -s 65535 -B 32768 "$capuser" -w "${capfile[$if_name]}" \ In lib.sh line 1608: rm ${capfile[$if_name]} ${capout[$if_name]} ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rm "${capfile[$if_name]}" "${capout[$if_name]}" In lib.sh line 1615: tcpdump -e -n -r ${capfile[$if_name]} 2>&1 ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump -e -n -r "${capfile[$if_name]}" 2>&1 In lib.sh line 1638: tc qdisc add dev $host2_if ingress ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$host2_if" ingress In lib.sh line 1639: tc filter add dev $host2_if ingress protocol $tc_proto pref 1 handle 101 \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$host2_if" ingress protocol $tc_proto pref 1 handle 101 \ In lib.sh line 1640: flower ip_proto udp dst_mac $mac action drop ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower ip_proto udp dst_mac "$mac" action drop In lib.sh line 1642: $MZ $host1_if $mz_v6arg -c 1 -p 64 -b $mac -A $src_ip -B $ip -t udp "dp=4096,sp=2048" -q ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$host1_if" $mz_v6arg -c 1 -p 64 -b "$mac" -A "$src_ip" -B "$ip" -t udp "dp=4096,sp=2048" -q In lib.sh line 1645: tc -j -s filter show dev $host2_if ingress \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc -j -s filter show dev "$host2_if" ingress \ In lib.sh line 1648: if [[ $? -eq 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. In lib.sh line 1652: tc filter del dev $host2_if ingress protocol $tc_proto pref 1 handle 101 flower ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$host2_if" ingress protocol $tc_proto pref 1 handle 101 flower In lib.sh line 1653: tc qdisc del dev $host2_if ingress ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$host2_if" ingress In lib.sh line 1688: mcast_packet_test $TEST_GROUP_MAC $src $TEST_GROUP $h2 $h1 ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2154 (warning): h2 is referenced but not assigned. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2154 (warning): h1 is referenced but not assigned. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mcast_packet_test "$TEST_GROUP_MAC" "$src" "$TEST_GROUP" "$h2" "$h1" In lib.sh line 1690: if [ $should_fwd -eq 1 ]; then ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$should_fwd" -eq 1 ]; then In lib.sh line 1704: if [ $is_blocked -eq 1 ]; then ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$is_blocked" -eq 1 ]; then In lib.sh line 1729: local vrf_name=$(master_name_get $if_name) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local vrf_name=$(master_name_get "$if_name") In lib.sh line 1734: ip vrf exec $vrf_name \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip vrf exec "$vrf_name" \ In lib.sh line 1735: mreceive -g $group -I $if_name > /dev/null 2>&1 & ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mreceive -g "$group" -I "$if_name" > /dev/null 2>&1 & In lib.sh line 1750: local vrf_name=$(master_name_get $if_name) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local vrf_name=$(master_name_get "$if_name") In lib.sh line 1752: ip vrf exec $vrf_name \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip vrf exec "$vrf_name" \ In lib.sh line 1753: msend -g $groups -I $if_name -c 1 > /dev/null 2>&1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: msend -g "$groups" -I "$if_name" -c 1 > /dev/null 2>&1 In lib.sh line 1807: tmpfile=`mktemp /var/run/nexthoptestXXX` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: tmpfile=$(mktemp /var/run/nexthoptestXXX) In lib.sh line 1808: mpid=`($ip monitor $mtype > $tmpfile & echo $!) 2>/dev/null` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mpid=$(($ip monitor "$mtype" > "$tmpfile" & echo $!) 2>/dev/null) In lib.sh line 1821: kill $mpid ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill "$mpid" In lib.sh line 1822: local lines=`grep '^\w' $tmpfile | wc -l` ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local lines=$(grep '^\w' "$tmpfile" | wc -l) In lib.sh line 1823: test $lines -eq $el ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: test "$lines" -eq "$el" In lib.sh line 1825: rm -rf $tmpfile ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rm -rf "$tmpfile" In lib.sh line 1839: local ipmout=$(start_ip_monitor stats "$ip") ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 1840: $ip stats set dev $dev ${type}_stats on ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $ip stats set dev "$dev" "${type}"_stats on In lib.sh line 1841: stop_ip_monitor $ipmout 1 "${type}_stats enablement" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: stop_ip_monitor "$ipmout" 1 "${type}_stats enablement" In lib.sh line 1844: local ipmout=$(start_ip_monitor stats "$ip") ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 1846: stop_ip_monitor $ipmout 1 "${type}_stats installation" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: stop_ip_monitor "$ipmout" 1 "${type}_stats installation" In lib.sh line 1849: local ipmout=$(start_ip_monitor stats "$ip") ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 1851: stop_ip_monitor $ipmout 1 "${type}_stats deinstallation" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: stop_ip_monitor "$ipmout" 1 "${type}_stats deinstallation" In lib.sh line 1854: local ipmout=$(start_ip_monitor stats "$ip") ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 1855: $ip stats set dev $dev ${type}_stats off ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $ip stats set dev "$dev" "${type}"_stats off In lib.sh line 1856: stop_ip_monitor $ipmout 1 "${type}_stats disablement" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: stop_ip_monitor "$ipmout" 1 "${type}_stats disablement" In lib.sh line 1865: printf '%02x:' ${IP//./ } | ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf '%02x:' "${IP//./ }" | In lib.sh line 1884: echo $allcol_ip | tr : '\n' | ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$allcol_ip" | tr : '\n' | In lib.sh line 1902: printf "%04x" $u16 | sed 's/^/000/;s/^.*\(..\)\(..\)$/\1:\2/' ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf "%04x" "$u16" | sed 's/^/000/;s/^.*\(..\)\(..\)$/\1:\2/' In lib.sh line 1941: local ckbytes=$(u16_to_bytes $checksum) ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local ckbytes=$(u16_to_bytes "$checksum") In lib.sh line 1943: echo "$payload" | sed "s/CHECKSUM/$ckbytes/g" ^-- SC2001 (style): See if you can use ${variable//search/replace} instead. In lib.sh line 1960: local nsources=$(u16_to_bytes ${#sources[@]}) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 1964: )"22:"$( : Type - Membership Report ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1965: )"00:"$( : Reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1966: )"CHECKSUM:"$( : Checksum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1967: )"00:00:"$( : Reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1968: )"00:01:"$( : Number of Group Records ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1969: )"01:"$( : Record Type - IS_IN ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1970: )"00:"$( : Aux Data Len ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1971: )"${nsources}:"$( : Number of Sources ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1972: )"$(ipv4_to_bytes $GRP):"$( : Multicast Address ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. Did you mean: )"$(ipv4_to_bytes "$GRP"):"$( : Multicast Address In lib.sh line 1974: ipv4_to_bytes $src ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ipv4_to_bytes "$src" In lib.sh line 1978: local checksum=$(payload_template_calc_checksum "$igmpv3") ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 1980: payload_template_expand_checksum "$igmpv3" $checksum ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: payload_template_expand_checksum "$igmpv3" "$checksum" In lib.sh line 1987: local payload=$(: ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 1988: )"17:"$( : Type - Leave Group ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1989: )"00:"$( : Max Resp Time - not meaningful ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1990: )"CHECKSUM:"$( : Checksum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1991: )"$(ipv4_to_bytes $GRP)"$( : Group Address ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: )"$(ipv4_to_bytes "$GRP")"$( : Group Address In lib.sh line 1993: local checksum=$(payload_template_calc_checksum "$payload") ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 1995: payload_template_expand_checksum "$payload" $checksum ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: payload_template_expand_checksum "$payload" "$checksum" In lib.sh line 2006: local nsources=$(u16_to_bytes ${#sources[@]}) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 2009: )"3a:"$( : Next Header - ICMPv6 ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2010: )"00:"$( : Hdr Ext Len ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2015: )"8f:"$( : Type - MLDv2 Report ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2016: )"00:"$( : Code ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2017: )"CHECKSUM:"$( : Checksum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2018: )"00:00:"$( : Reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2019: )"00:01:"$( : Number of Group Records ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2020: )"01:"$( : Record Type - IS_IN ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2021: )"00:"$( : Aux Data Len ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2022: )"${nsources}:"$( : Number of Sources ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2023: )"$(ipv6_to_bytes $GRP):"$( : Multicast address ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. Did you mean: )"$(ipv6_to_bytes "$GRP"):"$( : Multicast address In lib.sh line 2025: ipv6_to_bytes $src ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ipv6_to_bytes "$src" In lib.sh line 2030: local len=$(u16_to_bytes $(payload_template_nbytes $icmpv6)) ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-- SC2046 (warning): Quote this to prevent word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local len=$(u16_to_bytes $(payload_template_nbytes "$icmpv6")) In lib.sh line 2031: local sudohdr=$(: ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 2032: )"$(ipv6_to_bytes $SIP):"$( : SIP ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. Did you mean: )"$(ipv6_to_bytes "$SIP"):"$( : SIP In lib.sh line 2033: )"$(ipv6_to_bytes $GRP):"$( : DIP is multicast address ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. Did you mean: )"$(ipv6_to_bytes "$GRP"):"$( : DIP is multicast address In lib.sh line 2034: )"${len}:"$( : Upper-layer length ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2037: local checksum=$(payload_template_calc_checksum ${sudohdr}${icmpv6}) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local checksum=$(payload_template_calc_checksum "${sudohdr}""${icmpv6}") In lib.sh line 2039: payload_template_expand_checksum "$hbh$icmpv6" $checksum ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: payload_template_expand_checksum "$hbh$icmpv6" "$checksum" In lib.sh line 2051: )"3a:"$( : Next Header - ICMPv6 ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2052: )"00:"$( : Hdr Ext Len ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2057: )"84:"$( : Type - MLDv1 Done ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2058: )"00:"$( : Code ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2059: )"CHECKSUM:"$( : Checksum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2060: )"00:00:"$( : Max Resp Delay - not meaningful ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2061: )"00:00:"$( : Reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2062: )"$(ipv6_to_bytes $GRP):"$( : Multicast address ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: )"$(ipv6_to_bytes "$GRP"):"$( : Multicast address In lib.sh line 2065: local len=$(u16_to_bytes $(payload_template_nbytes $icmpv6)) ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-- SC2046 (warning): Quote this to prevent word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local len=$(u16_to_bytes $(payload_template_nbytes "$icmpv6")) In lib.sh line 2066: local sudohdr=$(: ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 2067: )"$(ipv6_to_bytes $SIP):"$( : SIP ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. Did you mean: )"$(ipv6_to_bytes "$SIP"):"$( : SIP In lib.sh line 2068: )"$(ipv6_to_bytes $GRP):"$( : DIP is multicast address ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. Did you mean: )"$(ipv6_to_bytes "$GRP"):"$( : DIP is multicast address In lib.sh line 2069: )"${len}:"$( : Upper-layer length ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2072: local checksum=$(payload_template_calc_checksum ${sudohdr}${icmpv6}) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local checksum=$(payload_template_calc_checksum "${sudohdr}""${icmpv6}") In lib.sh line 2074: payload_template_expand_checksum "$hbh$icmpv6" $checksum ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: payload_template_expand_checksum "$hbh$icmpv6" "$checksum" In lib.sh line 2103: log_test_skip $src:$caller ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: log_test_skip "$src":"$caller" In lib.sh line 2104: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" In lib.sh line 2121: local mac_addr=$(mac_get $dev) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local mac_addr=$(mac_get "$dev") In lib.sh line 2122: local tmp=$(ether_addr_to_u64 $mac_addr) ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local tmp=$(ether_addr_to_u64 "$mac_addr") In lib.sh line 2125: ip link set $dev up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$dev" up In lib.sh line 2126: ip link add link $dev name macvlan-tmp type macvlan mode private ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add link "$dev" name macvlan-tmp type macvlan mode private In lib.sh line 2127: ip link set macvlan-tmp address $(u64_to_ether_addr $((tmp + 1))) ^-- SC2046 (warning): Quote this to prevent word splitting. In lib.sh line 2130: promisc=$(ip -j -d link show dev $dev | jq -r '.[].promiscuity') ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: promisc=$(ip -j -d link show dev "$dev" | jq -r '.[].promiscuity') For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2145 -- Argument mixes string and array. ... https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u... Checking tools/testing/selftests/net/forwarding/sch_ets_core.sh - 91c0ef3e5c7c9ac93ca1d489ed11736ec497e2186b369d2b2b4c16148a492d69 In sch_ets_core.sh line 1: # SPDX-License-Identifier: GPL-2.0 ^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. In sch_ets_core.sh line 63: source $lib_dir/lib.sh ^------^ SC2154 (warning): lib_dir is referenced but not assigned. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In sch_ets_core.sh line 64: source $lib_dir/sch_ets_tests.sh ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/sch_ets_tests.sh In sch_ets_core.sh line 82: local dst_mac=$(mac_get $h2) ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local dst_mac=$(mac_get "$h2") In sch_ets_core.sh line 85: start_traffic $h1.1$i $(sip $i) $(dip $i) $dst_mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1".1"$i" $(sip "$i") $(dip "$i") "$dst_mac" In sch_ets_core.sh line 111: local op=$(if [[ -n $QDISC_DEV ]]; then echo change; else echo add; fi) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_ets_core.sh line 113: tc qdisc $op dev $dev $PARENT handle 10: ets \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc "$op" dev "$dev" $PARENT handle 10: ets \ In sch_ets_core.sh line 114: $(if ((nstrict)); then echo strict $nstrict; fi) \ ^-- SC2046 (warning): Quote this to prevent word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(if ((nstrict)); then echo strict "$nstrict"; fi) \ In sch_ets_core.sh line 115: $(if ((${#quanta[@]})); then echo quanta ${quanta[@]}; fi) \ ^-- SC2046 (warning): Quote this to prevent word splitting. ^----------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In sch_ets_core.sh line 116: priomap $priomap ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: priomap "$priomap" In sch_ets_core.sh line 127: local op=$(if [[ -n $QDISC_DEV ]]; then echo change; else echo add; fi) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_ets_core.sh line 129: tc qdisc $op dev $dev $PARENT handle 10: ets \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc "$op" dev "$dev" $PARENT handle 10: ets \ In sch_ets_core.sh line 130: $(if ((nstrict)); then echo strict $nstrict; fi) \ ^-- SC2046 (warning): Quote this to prevent word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(if ((nstrict)); then echo strict "$nstrict"; fi) \ In sch_ets_core.sh line 131: $(if ((${#quanta[@]})); then echo quanta ${quanta[@]}; fi) ^-- SC2046 (warning): Quote this to prevent word splitting. ^----------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In sch_ets_core.sh line 138: tc filter add dev $dev parent 10: basic \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$dev" parent 10: basic \ In sch_ets_core.sh line 159: tc qdisc del dev $QDISC_DEV $PARENT ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$QDISC_DEV" $PARENT In sch_ets_core.sh line 168: simple_if_init $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" In sch_ets_core.sh line 169: defer simple_if_fini $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h1" In sch_ets_core.sh line 171: mtu_set $h1 9900 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h1" 9900 In sch_ets_core.sh line 172: defer mtu_restore $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h1" In sch_ets_core.sh line 175: vlan_create $h1 1$i v$h1 $(sip $i)/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h1" 1"$i" v"$h1" $(sip "$i")/28 In sch_ets_core.sh line 176: defer vlan_destroy $h1 1$i ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h1" 1"$i" In sch_ets_core.sh line 177: ip link set dev $h1.1$i type vlan egress 0:$i ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$h1".1"$i" type vlan egress 0:"$i" In sch_ets_core.sh line 185: simple_if_init $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" In sch_ets_core.sh line 186: defer simple_if_fini $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h2" In sch_ets_core.sh line 188: mtu_set $h2 9900 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h2" 9900 In sch_ets_core.sh line 189: defer mtu_restore $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h2" In sch_ets_core.sh line 192: vlan_create $h2 1$i v$h2 $(dip $i)/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h2" 1"$i" v"$h2" $(dip "$i")/28 In sch_ets_core.sh line 193: defer vlan_destroy $h2 1$i ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h2" 1"$i" In sch_ets_core.sh line 201: ip link set dev $swp1 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up In sch_ets_core.sh line 202: defer ip link set dev $swp1 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1" down In sch_ets_core.sh line 204: mtu_set $swp1 9900 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp1" 9900 In sch_ets_core.sh line 205: defer mtu_restore $swp1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp1" In sch_ets_core.sh line 207: ip link set dev $swp2 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up In sch_ets_core.sh line 208: defer ip link set dev $swp2 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2" down In sch_ets_core.sh line 210: mtu_set $swp2 9900 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp2" 9900 In sch_ets_core.sh line 211: defer mtu_restore $swp2 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp2" In sch_ets_core.sh line 214: vlan_create $swp1 1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp1" 1"$i" In sch_ets_core.sh line 215: defer vlan_destroy $swp1 1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp1" 1"$i" In sch_ets_core.sh line 216: ip link set dev $swp1.1$i type vlan ingress 0:0 1:1 2:2 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".1"$i" type vlan ingress 0:0 1:1 2:2 In sch_ets_core.sh line 218: vlan_create $swp2 1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp2" 1"$i" In sch_ets_core.sh line 219: defer vlan_destroy $swp2 1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp2" 1"$i" In sch_ets_core.sh line 221: ip link add dev br1$i type bridge ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add dev br1"$i" type bridge In sch_ets_core.sh line 222: defer ip link del dev br1$i ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link del dev br1"$i" In sch_ets_core.sh line 224: ip link set dev $swp1.1$i master br1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".1"$i" master br1"$i" In sch_ets_core.sh line 225: defer ip link set dev $swp1.1$i nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1".1"$i" nomaster In sch_ets_core.sh line 227: ip link set dev $swp2.1$i master br1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2".1"$i" master br1"$i" In sch_ets_core.sh line 228: defer ip link set dev $swp2.1$i nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2".1"$i" nomaster In sch_ets_core.sh line 230: ip link set dev br1$i up ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev br1"$i" up In sch_ets_core.sh line 231: defer ip link set dev br1$i down ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev br1"$i" down In sch_ets_core.sh line 233: ip link set dev $swp1.1$i up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".1"$i" up In sch_ets_core.sh line 234: defer ip link set dev $swp1.1$i down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1".1"$i" down In sch_ets_core.sh line 236: ip link set dev $swp2.1$i up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2".1"$i" up In sch_ets_core.sh line 237: defer ip link set dev $swp2.1$i down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2".1"$i" down In sch_ets_core.sh line 252: hut=$h2 ^-^ SC2034 (warning): hut appears unused. Verify use (or export if used externally). In sch_ets_core.sh line 264: ping_test $h1.10 $(dip 0) " vlan 10" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".10 $(dip 0) " vlan 10" In sch_ets_core.sh line 265: ping_test $h1.11 $(dip 1) " vlan 11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".11 $(dip 1) " vlan 11" In sch_ets_core.sh line 266: ping_test $h1.12 $(dip 2) " vlan 12" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".12 $(dip 2) " vlan 12" In sch_ets_core.sh line 278: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y... https://www.shellcheck.net/wiki/SC2034 -- hut appears unused. Verify use (o... Checking tools/testing/selftests/net/forwarding/sch_red.sh - b974d6ed50fb0f56318fae59a2628612b268dbe080393d0ce1a7bcacbbcc561b In sch_red.sh line 55: simple_if_init $h1 192.0.2.1/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" 192.0.2.1/28 In sch_red.sh line 56: defer simple_if_fini $h1 192.0.2.1/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h1" 192.0.2.1/28 In sch_red.sh line 58: mtu_set $h1 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h1" 10000 In sch_red.sh line 59: defer mtu_restore $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h1" In sch_red.sh line 61: tc qdisc replace dev $h1 root handle 1: tbf \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$h1" root handle 1: tbf \ In sch_red.sh line 63: defer tc qdisc del dev $h1 root ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$h1" root In sch_red.sh line 68: simple_if_init $h2 192.0.2.2/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" 192.0.2.2/28 In sch_red.sh line 69: defer simple_if_fini $h2 192.0.2.2/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h2" 192.0.2.2/28 In sch_red.sh line 71: mtu_set $h2 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h2" 10000 In sch_red.sh line 72: defer mtu_restore $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h2" In sch_red.sh line 77: simple_if_init $h3 192.0.2.3/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h3" 192.0.2.3/28 In sch_red.sh line 78: defer simple_if_fini $h3 192.0.2.3/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h3" 192.0.2.3/28 In sch_red.sh line 80: mtu_set $h3 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h3" 10000 In sch_red.sh line 81: defer mtu_restore $h3 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h3" In sch_red.sh line 89: ip link set dev $swp1 up master br ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up master br In sch_red.sh line 90: defer ip link set dev $swp1 down nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1" down nomaster In sch_red.sh line 92: ip link set dev $swp2 up master br ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up master br In sch_red.sh line 93: defer ip link set dev $swp2 down nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2" down nomaster In sch_red.sh line 95: ip link set dev $swp3 up master br ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp3" up master br In sch_red.sh line 96: defer ip link set dev $swp3 down nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp3" down nomaster In sch_red.sh line 98: mtu_set $swp1 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp1" 10000 In sch_red.sh line 99: defer mtu_restore $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h1" In sch_red.sh line 101: mtu_set $swp2 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp2" 10000 In sch_red.sh line 102: defer mtu_restore $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h2" In sch_red.sh line 104: mtu_set $swp3 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp3" 10000 In sch_red.sh line 105: defer mtu_restore $h3 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h3" In sch_red.sh line 107: tc qdisc replace dev $swp3 root handle 1: tbf \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$swp3" root handle 1: tbf \ In sch_red.sh line 109: defer tc qdisc del dev $swp3 root ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$swp3" root In sch_red.sh line 126: h3_mac=$(mac_get $h3) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h3_mac=$(mac_get "$h3") In sch_red.sh line 139: ping_test $h1 192.0.2.3 " from host 1" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h1" 192.0.2.3 " from host 1" In sch_red.sh line 140: ping_test $h2 192.0.2.3 " from host 2" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h2" 192.0.2.3 " from host 2" In sch_red.sh line 145: qdisc_stats_get $swp3 11: .backlog ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qdisc_stats_get "$swp3" 11: .backlog In sch_red.sh line 150: qdisc_stats_get $swp3 11: .marked ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qdisc_stats_get "$swp3" 11: .marked In sch_red.sh line 155: qdisc_stats_get $swp3 11: .packets ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qdisc_stats_get "$swp3" 11: .packets In sch_red.sh line 168: $MZ $h2 -p $PKTSZ -a own -b $h3_mac -A 192.0.2.2 -B 192.0.2.3 -t $proto -q -c $pkts "$@" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h2" -p "$PKTSZ" -a own -b "$h3_mac" -A 192.0.2.2 -B 192.0.2.3 -t "$proto" -q -c "$pkts" "$@" In sch_red.sh line 182: local cur=$(get_qdisc_backlog) ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 187: echo $cur ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$cur" In sch_red.sh line 190: echo $cur ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$cur" In sch_red.sh line 194: send_packets $proto $pkts "$@" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_packets "$proto" "$pkts" "$@" In sch_red.sh line 203: local npackets_0=$(get_qdisc_npackets) ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 204: local nmarked_0=$(get_nmarked) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 206: local npackets_1=$(get_qdisc_npackets) ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 207: local nmarked_1=$(get_nmarked) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 213: echo $pct ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$pct" In sch_red.sh line 214: ((pct $cond)) ^-- SC1105 (error): Shells disambiguate (( differently or not at all. For subshell, add spaces around ( . For ((, fix parsing errors. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ((pct "$cond")) In sch_red.sh line 221: local npackets_0=$(get_qdisc_npackets) ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 222: local nmirrored_0=$(get_nmirrored) ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 224: local npackets_1=$(get_qdisc_npackets) ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 225: local nmirrored_1=$(get_nmirrored) ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 231: echo $pct ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$pct" In sch_red.sh line 232: ((pct $cond)) ^-- SC1105 (error): Shells disambiguate (( differently or not at all. For subshell, add spaces around ( . For ((, fix parsing errors. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ((pct "$cond")) In sch_red.sh line 269: $MZ $h1 -p $PKTSZ -A 192.0.2.1 -B 192.0.2.3 -c 0 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -p "$PKTSZ" -A 192.0.2.1 -B 192.0.2.3 -c 0 \ In sch_red.sh line 270: -a own -b $h3_mac -t tcp -q tos=0x01 & ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -a own -b "$h3_mac" -t tcp -q tos=0x01 & In sch_red.sh line 274: ecn_test_common "$name" $limit ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ecn_test_common "$name" "$limit" In sch_red.sh line 290: $MZ $h1 -p $PKTSZ -A 192.0.2.1 -B 192.0.2.3 -c 0 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -p "$PKTSZ" -A 192.0.2.1 -B 192.0.2.3 -c 0 \ In sch_red.sh line 291: -a own -b $h3_mac -t tcp -q tos=0x01 & ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -a own -b "$h3_mac" -t tcp -q tos=0x01 & In sch_red.sh line 295: ecn_test_common "$name" $limit ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ecn_test_common "$name" "$limit" In sch_red.sh line 314: $MZ $h1 -p $PKTSZ -A 192.0.2.1 -B 192.0.2.3 -c 0 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -p "$PKTSZ" -A 192.0.2.1 -B 192.0.2.3 -c 0 \ In sch_red.sh line 315: -a own -b $h3_mac -t tcp -q tos=0x01 & ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -a own -b "$h3_mac" -t tcp -q tos=0x01 & In sch_red.sh line 345: $MZ $h1 -p $PKTSZ -A 192.0.2.1 -B 192.0.2.3 -c 0 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -p "$PKTSZ" -A 192.0.2.1 -B 192.0.2.3 -c 0 \ In sch_red.sh line 346: -a own -b $h3_mac -t udp -q & ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -a own -b "$h3_mac" -t udp -q & In sch_red.sh line 384: $MZ $h1 -p $PKTSZ -A 192.0.2.1 -B 192.0.2.3 -c 0 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -p "$PKTSZ" -A 192.0.2.1 -B 192.0.2.3 -c 0 \ In sch_red.sh line 385: -a own -b $h3_mac -t tcp -q tos=0x01 & ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -a own -b "$h3_mac" -t tcp -q tos=0x01 & In sch_red.sh line 411: tc qdisc replace dev $swp3 parent 1:1 handle 11: red \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$swp3" parent 1:1 handle 11: red \ In sch_red.sh line 412: limit 1M avpkt $PKTSZ probability 1 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: limit 1M avpkt "$PKTSZ" probability 1 \ In sch_red.sh line 413: min $BACKLOG max $((BACKLOG + 1)) burst 38 "${args[@]}" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: min "$BACKLOG" max $((BACKLOG + 1)) burst 38 "${args[@]}" In sch_red.sh line 419: tc qdisc del dev $swp3 parent 1:1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$swp3" parent 1:1 In sch_red.sh line 426: xfail_on_slow do_ecn_test $BACKLOG ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: xfail_on_slow do_ecn_test "$BACKLOG" In sch_red.sh line 433: xfail_on_slow do_ecn_nodrop_test $BACKLOG ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: xfail_on_slow do_ecn_nodrop_test "$BACKLOG" In sch_red.sh line 440: xfail_on_slow do_red_test $BACKLOG ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: xfail_on_slow do_red_test "$BACKLOG" In sch_red.sh line 447: xfail_on_slow do_red_qevent_test $BACKLOG ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: xfail_on_slow do_red_qevent_test "$BACKLOG" In sch_red.sh line 454: xfail_on_slow do_ecn_qevent_test $BACKLOG ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: xfail_on_slow do_ecn_qevent_test "$BACKLOG" In sch_red.sh line 464: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC1105 -- Shells disambiguate (( differentl... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... Checking tools/testing/selftests/net/forwarding/sch_tbf_core.sh - dd0d397c1f13f03da505068dcd421716336e436161dc1694426fe293151f415e In sch_tbf_core.sh line 1: # SPDX-License-Identifier: GPL-2.0 ^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. In sch_tbf_core.sh line 47: source $lib_dir/lib.sh ^------^ SC2154 (warning): lib_dir is referenced but not assigned. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In sch_tbf_core.sh line 62: simple_if_init $dev ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$dev" In sch_tbf_core.sh line 63: defer simple_if_fini $dev ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$dev" In sch_tbf_core.sh line 65: mtu_set $dev 10000 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$dev" 10000 In sch_tbf_core.sh line 66: defer mtu_restore $dev ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$dev" In sch_tbf_core.sh line 68: vlan_create $dev 10 v$dev $(ipaddr $host 10)/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$dev" 10 v"$dev" $(ipaddr "$host" 10)/28 In sch_tbf_core.sh line 69: defer vlan_destroy $dev 10 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$dev" 10 In sch_tbf_core.sh line 70: ip link set dev $dev.10 type vlan egress 0:0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev".10 type vlan egress 0:0 In sch_tbf_core.sh line 72: vlan_create $dev 11 v$dev $(ipaddr $host 11)/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$dev" 11 v"$dev" $(ipaddr "$host" 11)/28 In sch_tbf_core.sh line 73: defer vlan_destroy $dev 11 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$dev" 11 In sch_tbf_core.sh line 74: ip link set dev $dev.11 type vlan egress 0:1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev".11 type vlan egress 0:1 In sch_tbf_core.sh line 79: host_create $h1 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: host_create "$h1" 1 In sch_tbf_core.sh line 84: host_create $h2 2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: host_create "$h2" 2 In sch_tbf_core.sh line 86: tc qdisc add dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$h2" clsact In sch_tbf_core.sh line 87: defer tc qdisc del dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$h2" clsact In sch_tbf_core.sh line 89: tc filter add dev $h2 ingress pref 1010 prot 802.1q \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress pref 1010 prot 802.1q \ In sch_tbf_core.sh line 90: flower $TCFLAGS vlan_id 10 action pass ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower "$TCFLAGS" vlan_id 10 action pass In sch_tbf_core.sh line 91: tc filter add dev $h2 ingress pref 1011 prot 802.1q \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress pref 1011 prot 802.1q \ In sch_tbf_core.sh line 92: flower $TCFLAGS vlan_id 11 action pass ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower "$TCFLAGS" vlan_id 11 action pass In sch_tbf_core.sh line 107: ip link set dev $intf up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf" up In sch_tbf_core.sh line 108: defer ip link set dev $intf down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$intf" down In sch_tbf_core.sh line 110: mtu_set $intf 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$intf" 10000 In sch_tbf_core.sh line 111: defer mtu_restore $intf ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$intf" In sch_tbf_core.sh line 114: vlan_create $intf $vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$intf" $vlan In sch_tbf_core.sh line 115: defer vlan_destroy $intf $vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$intf" $vlan In sch_tbf_core.sh line 117: ip link set dev $intf.$vlan master br$vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf".$vlan master br$vlan In sch_tbf_core.sh line 118: defer ip link set dev $intf.$vlan nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$intf".$vlan nomaster In sch_tbf_core.sh line 120: ip link set dev $intf.$vlan up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf".$vlan up In sch_tbf_core.sh line 121: defer ip link set dev $intf.$vlan down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$intf".$vlan down In sch_tbf_core.sh line 126: ip link set dev $swp1.$vlan type vlan ingress 0:0 1:1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".$vlan type vlan ingress 0:0 1:1 In sch_tbf_core.sh line 144: swp3=${NETIFS[p5]} ^--^ SC2034 (warning): swp3 appears unused. Verify use (or export if used externally). In sch_tbf_core.sh line 145: h3=${NETIFS[p6]} ^-- SC2034 (warning): h3 appears unused. Verify use (or export if used externally). In sch_tbf_core.sh line 147: swp4=${NETIFS[p7]} ^--^ SC2034 (warning): swp4 appears unused. Verify use (or export if used externally). In sch_tbf_core.sh line 148: swp5=${NETIFS[p8]} ^--^ SC2034 (warning): swp5 appears unused. Verify use (or export if used externally). In sch_tbf_core.sh line 150: h2_mac=$(mac_get $h2) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac=$(mac_get "$h2") In sch_tbf_core.sh line 162: ping_test $h1.10 $(ipaddr 2 10) " vlan 10" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".10 $(ipaddr 2 10) " vlan 10" In sch_tbf_core.sh line 163: ping_test $h1.11 $(ipaddr 2 11) " vlan 11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".11 $(ipaddr 2 11) " vlan 11" In sch_tbf_core.sh line 170: tc_rule_stats_get $h2 10$vlan ingress .bytes ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_rule_stats_get "$h2" 10"$vlan" ingress .bytes In sch_tbf_core.sh line 178: start_traffic $h1.$vlan $(ipaddr 1 $vlan) $(ipaddr 2 $vlan) $h2_mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1"."$vlan" $(ipaddr 1 "$vlan") $(ipaddr 2 "$vlan") "$h2_mac" In sch_tbf_core.sh line 182: local t2=$(busywait_for_counter 1000 +1 tbf_get_counter $vlan) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t2=$(busywait_for_counter 1000 +1 tbf_get_counter "$vlan") In sch_tbf_core.sh line 184: local t3=$(tbf_get_counter $vlan) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t3=$(tbf_get_counter "$vlan") In sch_tbf_core.sh line 190: local nr=$(rate $t2 $t3 10) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local nr=$(rate "$t2" "$t3" 10) In sch_tbf_core.sh line 193: xfail_on_slow check_err $? "Expected rate $(humanize $er), got $(humanize $nr), which is $nr_pct% off. Required accuracy is +-5%." ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: xfail_on_slow check_err $? "Expected rate $(humanize $er), got $(humanize "$nr"), which is $nr_pct% off. Required accuracy is +-5%." For more information: https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y... https://www.shellcheck.net/wiki/SC2034 -- h3 appears unused. Verify use (or... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... Checking tools/testing/selftests/net/forwarding/vxlan_bridge_1q_mc_ul.sh - 55b8974b9512d983f0a799e4fd3181679e3083095be6248a3e44aae8bf92da20 Checking tools/testing/selftests/net/forwarding/vxlan_reserved.sh - e33a9ba82143df5f32f8b769667f1e5fcc5da104dc3f8741ba0113d3d0fc98f4 In vxlan_reserved.sh line 34: : ${VXPORT:=4789} ^-------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it. In vxlan_reserved.sh line 35: : ${ALL_TESTS:=" ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it. In vxlan_reserved.sh line 50: simple_if_init $h1 192.0.2.1/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" 192.0.2.1/28 In vxlan_reserved.sh line 51: defer simple_if_fini $h1 192.0.2.1/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h1" 192.0.2.1/28 In vxlan_reserved.sh line 53: tc qdisc add dev $h1 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$h1" clsact In vxlan_reserved.sh line 54: defer tc qdisc del dev $h1 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$h1" clsact In vxlan_reserved.sh line 56: tc filter add dev $h1 ingress pref 77 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h1" ingress pref 77 \ In vxlan_reserved.sh line 58: defer tc filter del dev $h1 ingress pref 77 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc filter del dev "$h1" ingress pref 77 In vxlan_reserved.sh line 66: adf_ip_link_set_addr br1 $(mac_get $swp1) ^--------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_ip_link_set_addr br1 $(mac_get "$swp1") In vxlan_reserved.sh line 69: adf_ip_link_set_up $rp1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_ip_link_set_up "$rp1" In vxlan_reserved.sh line 70: adf_ip_addr_add $rp1 192.0.2.17/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_ip_addr_add "$rp1" 192.0.2.17/28 In vxlan_reserved.sh line 73: adf_ip_link_set_master $swp1 br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_ip_link_set_master "$swp1" br1 In vxlan_reserved.sh line 74: adf_ip_link_set_up $swp1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_ip_link_set_up "$swp1" In vxlan_reserved.sh line 79: simple_if_init $rp2 192.0.2.18/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$rp2" 192.0.2.18/28 In vxlan_reserved.sh line 80: defer simple_if_fini $rp2 192.0.2.18/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$rp2" 192.0.2.18/28 In vxlan_reserved.sh line 117: for i in ${extra_bits[@]}; do ^--------------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In vxlan_reserved.sh line 124: bits[$((i + 32))]=$(((vni & mask) != 0)) ^---------^ SC2321 (style): Array indices are already arithmetic contexts. Prefer removing the $(( and )). Did you mean: bits[i + 32]=$(((vni & mask) != 0)) In vxlan_reserved.sh line 136: bytes+=$(printf %02x $byte): ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bytes+=$(printf %02x "$byte"): In vxlan_reserved.sh line 139: echo ${bytes%:} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "${bytes%:}" In vxlan_reserved.sh line 155: echo $out ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$out" In vxlan_reserved.sh line 168: local vxlan_header=$(vxlan_header_bytes $vni $reserved_bits) ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local vxlan_header=$(vxlan_header_bytes "$vni" "$reserved_bits") In vxlan_reserved.sh line 170: $MZ $dev -c $count -d 100msec -q \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$dev" -c "$count" -d 100msec -q \ In vxlan_reserved.sh line 171: -b $next_hop_mac -B $dest_ip \ ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -b "$next_hop_mac" -B "$dest_ip" \ In vxlan_reserved.sh line 172: -t udp sp=23456,dp=$VXPORT,p=$(: ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2046 (warning): Quote this to prevent word splitting. Did you mean: -t udp sp=23456,dp="$VXPORT",p=$(: In vxlan_reserved.sh line 173: )"$vxlan_header:"$( : VXLAN ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 174: )"$dest_mac:"$( : ETH daddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 175: )"00:11:22:33:44:55:"$( : ETH saddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 176: )"08:00:"$( : ETH type ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 177: )"45:"$( : IP version + IHL ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 178: )"00:"$( : IP TOS ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 179: )"00:54:"$( : IP total length ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 180: )"99:83:"$( : IP identification ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 181: )"40:00:"$( : IP flags + frag off ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 182: )"40:"$( : IP TTL ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 183: )"01:"$( : IP proto ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 184: )"00:00:"$( : IP header csum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 185: )"$(ipv4_to_bytes 192.0.2.3):"$( : IP saddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 186: )"$(ipv4_to_bytes 192.0.2.1):"$( : IP daddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 187: )"08:"$( : ICMP type ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 188: )"00:"$( : ICMP code ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 189: )"8b:f2:"$( : ICMP csum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 190: )"1f:6a:"$( : ICMP request identifier ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 191: )"00:01:"$( : ICMP request seq. number ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 192: )"4f:ff:c5:5b:00:00:00:00:"$( : ICMP payload ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 193: )"6d:74:0b:00:00:00:00:00:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 194: )"10:11:12:13:14:15:16:17:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 195: )"18:19:1a:1b:1c:1d:1e:1f:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 196: )"20:21:22:23:24:25:26:27:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 197: )"28:29:2a:2b:2c:2d:2e:2f:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 217: echo $i ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$i" In vxlan_reserved.sh line 223: vxlan_ping_do 10 $rp2 $(mac_get $rp1) 192.0.2.17 $(mac_get $h1) 1000 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2046 (warning): Quote this to prevent word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_do 10 "$rp2" $(mac_get "$rp1") 192.0.2.17 $(mac_get "$h1") 1000 In vxlan_reserved.sh line 229: vxlan_ping_do 1 $rp2 $(mac_get $rp1) \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2046 (warning): Quote this to prevent word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_do 1 "$rp2" $(mac_get "$rp1") \ In vxlan_reserved.sh line 230: 192.0.2.17 $(mac_get $h1) 1000 "$bit" ^------------^ SC2046 (warning): Quote this to prevent word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: 192.0.2.17 $(mac_get "$h1") 1000 "$bit" In vxlan_reserved.sh line 243: local t0=$($get_stat) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_reserved.sh line 246: check_err $? "Failure when running $@" ^-- SC2145 (error): Argument mixes string and array. Use * or separate argument. In vxlan_reserved.sh line 248: local t1=$($get_stat) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_reserved.sh line 266: local t0=$(link_stats_get vx1 rx errors) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_reserved.sh line 269: $n_allowed_bits vxlan_ping_reserved ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$n_allowed_bits" vxlan_ping_reserved In vxlan_reserved.sh line 270: local t1=$(link_stats_get vx1 rx errors) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_reserved.sh line 308: local allowed_bytes=$(vxlan_header_bytes 0xffffff $bit) ^-----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local allowed_bytes=$(vxlan_header_bytes 0xffffff "$bit") In vxlan_reserved.sh line 309: local reserved_bytes=$(neg_bytes $allowed_bytes) ^------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local reserved_bytes=$(neg_bytes "$allowed_bytes") In vxlan_reserved.sh line 312: vxlan_device_add reserved_bits 0x$reserved_bits ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_device_add reserved_bits 0x"$reserved_bits" In vxlan_reserved.sh line 352: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2145 -- Argument mixes string and array. ... https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u... ====== Checking the tree with the patch ====== Checking tools/testing/selftests/drivers/net/mlxsw/devlink_trap_policer.sh - 65535651f418e37b316cad52376e7013340517991fea6bd42c8581edc5fcdc4a In devlink_trap_policer.sh line 32: lib_dir=$(dirname $0)/../../../net/forwarding ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lib_dir=$(dirname "$0")/../../../net/forwarding In devlink_trap_policer.sh line 34: ALL_TESTS=" ^-------^ SC2034 (warning): ALL_TESTS appears unused. Verify use (or export if used externally). In devlink_trap_policer.sh line 40: NUM_NETIFS=4 ^--------^ SC2034 (warning): NUM_NETIFS appears unused. Verify use (or export if used externally). In devlink_trap_policer.sh line 41: source $lib_dir/tc_common.sh ^-------------------^ SC1091 (info): Not following: ./tc_common.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/tc_common.sh In devlink_trap_policer.sh line 42: source $lib_dir/lib.sh ^-------------^ SC1091 (info): Not following: ./lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In devlink_trap_policer.sh line 43: source $lib_dir/devlink_lib.sh ^---------------------^ SC1091 (info): Not following: ./devlink_lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/devlink_lib.sh In devlink_trap_policer.sh line 47: simple_if_init $h1 192.0.2.1/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" 192.0.2.1/24 In devlink_trap_policer.sh line 48: defer simple_if_fini $h1 192.0.2.1/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h1" 192.0.2.1/24 In devlink_trap_policer.sh line 50: mtu_set $h1 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h1" 10000 In devlink_trap_policer.sh line 51: defer mtu_restore $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h1" In devlink_trap_policer.sh line 53: ip -4 route add default vrf v$h1 nexthop via 192.0.2.2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -4 route add default vrf v"$h1" nexthop via 192.0.2.2 In devlink_trap_policer.sh line 54: defer ip -4 route del default vrf v$h1 nexthop via 192.0.2.2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip -4 route del default vrf v"$h1" nexthop via 192.0.2.2 In devlink_trap_policer.sh line 59: simple_if_init $h2 198.51.100.1/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" 198.51.100.1/24 In devlink_trap_policer.sh line 60: defer simple_if_fini $h2 198.51.100.1/24 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h2" 198.51.100.1/24 In devlink_trap_policer.sh line 62: mtu_set $h2 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h2" 10000 In devlink_trap_policer.sh line 63: defer mtu_restore $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h2" In devlink_trap_policer.sh line 65: ip -4 route add default vrf v$h2 nexthop via 198.51.100.2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -4 route add default vrf v"$h2" nexthop via 198.51.100.2 In devlink_trap_policer.sh line 66: defer ip -4 route del default vrf v$h2 nexthop via 198.51.100.2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip -4 route del default vrf v"$h2" nexthop via 198.51.100.2 In devlink_trap_policer.sh line 71: ip link set dev $rp1 up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rp1" up In devlink_trap_policer.sh line 72: defer ip link set dev $rp1 down ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$rp1" down In devlink_trap_policer.sh line 74: ip link set dev $rp2 up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$rp2" up In devlink_trap_policer.sh line 75: defer ip link set dev $rp2 down ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$rp2" down In devlink_trap_policer.sh line 77: __addr_add_del $rp1 add 192.0.2.2/24 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __addr_add_del "$rp1" add 192.0.2.2/24 In devlink_trap_policer.sh line 78: defer __addr_add_del $rp1 del 192.0.2.2/24 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer __addr_add_del "$rp1" del 192.0.2.2/24 In devlink_trap_policer.sh line 80: __addr_add_del $rp2 add 198.51.100.2/24 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __addr_add_del "$rp2" add 198.51.100.2/24 In devlink_trap_policer.sh line 81: defer __addr_add_del $rp2 del 198.51.100.2/24 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer __addr_add_del "$rp2" del 198.51.100.2/24 In devlink_trap_policer.sh line 83: mtu_set $rp1 10000 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$rp1" 10000 In devlink_trap_policer.sh line 84: defer mtu_restore $rp1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$rp1" In devlink_trap_policer.sh line 86: mtu_set $rp2 10000 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$rp2" 10000 In devlink_trap_policer.sh line 87: defer mtu_restore $rp2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$rp2" In devlink_trap_policer.sh line 92: devlink trap set $DEVLINK_DEV trap blackhole_route action trap ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap set "$DEVLINK_DEV" trap blackhole_route action trap In devlink_trap_policer.sh line 93: defer devlink trap set $DEVLINK_DEV trap blackhole_route action drop ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink trap set "$DEVLINK_DEV" trap blackhole_route action drop In devlink_trap_policer.sh line 104: rp1_mac=$(mac_get $rp1) ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rp1_mac=$(mac_get "$rp1") In devlink_trap_policer.sh line 121: devlink trap policer set $DEVLINK_DEV policer 1 rate 0 &> /dev/null ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 rate 0 &> /dev/null In devlink_trap_policer.sh line 123: devlink trap policer set $DEVLINK_DEV policer 1 \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 \ In devlink_trap_policer.sh line 127: devlink trap policer set $DEVLINK_DEV policer 1 rate 1 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 rate 1 In devlink_trap_policer.sh line 129: devlink trap policer set $DEVLINK_DEV policer 1 rate 2000000000 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 rate 2000000000 In devlink_trap_policer.sh line 139: devlink trap policer set $DEVLINK_DEV policer 1 burst 0 &> /dev/null ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 burst 0 &> /dev/null In devlink_trap_policer.sh line 141: devlink trap policer set $DEVLINK_DEV policer 1 burst 17 &> /dev/null ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 burst 17 &> /dev/null In devlink_trap_policer.sh line 143: devlink trap policer set $DEVLINK_DEV policer 1 burst 8 &> /dev/null ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 burst 8 &> /dev/null In devlink_trap_policer.sh line 145: devlink trap policer set $DEVLINK_DEV policer 1 \ ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 \ In devlink_trap_policer.sh line 149: devlink trap policer set $DEVLINK_DEV policer 1 burst 16 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 burst 16 In devlink_trap_policer.sh line 151: devlink trap policer set $DEVLINK_DEV policer 1 burst $((2**24)) ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer 1 burst $((2**24)) In devlink_trap_policer.sh line 173: t0=$(devlink_trap_policer_rx_dropped_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: t0=$(devlink_trap_policer_rx_dropped_get "$id") In devlink_trap_policer.sh line 175: t1=$(devlink_trap_policer_rx_dropped_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: t1=$(devlink_trap_policer_rx_dropped_get "$id") In devlink_trap_policer.sh line 187: devlink trap policer set $DEVLINK_DEV policer $id rate 1000 burst 512 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer "$id" rate 1000 burst 512 In devlink_trap_policer.sh line 188: devlink trap group set $DEVLINK_DEV group l3_drops policer $id ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap group set "$DEVLINK_DEV" group l3_drops policer "$id" In devlink_trap_policer.sh line 196: start_traffic $h1 192.0.2.1 198.51.100.100 $rp1_mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1" 192.0.2.1 198.51.100.100 "$rp1_mac" In devlink_trap_policer.sh line 207: drop_rate=$(policer_drop_rate_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: drop_rate=$(policer_drop_rate_get "$id") In devlink_trap_policer.sh line 220: start_traffic $h1 192.0.2.1 198.51.100.100 $rp1_mac -d 1msec ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1" 192.0.2.1 198.51.100.100 "$rp1_mac" -d 1msec In devlink_trap_policer.sh line 225: drop_rate=$(policer_drop_rate_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: drop_rate=$(policer_drop_rate_get "$id") In devlink_trap_policer.sh line 237: devlink trap group set $DEVLINK_DEV group l3_drops nopolicer ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap group set "$DEVLINK_DEV" group l3_drops nopolicer In devlink_trap_policer.sh line 241: start_traffic $h1 192.0.2.1 198.51.100.100 $rp1_mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1" 192.0.2.1 198.51.100.100 "$rp1_mac" In devlink_trap_policer.sh line 249: drop_rate=$(policer_drop_rate_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: drop_rate=$(policer_drop_rate_get "$id") In devlink_trap_policer.sh line 261: local last_policer=$(devlink -j -p trap policer show | ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In devlink_trap_policer.sh line 262: jq '[.[]["'$DEVLINK_DEV'"][].policer] | max') ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: jq '[.[]["'"$DEVLINK_DEV"'"][].policer] | max') In devlink_trap_policer.sh line 271: __rate_test $last_policer ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __rate_test "$last_policer" In devlink_trap_policer.sh line 279: RET=0 ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally). In devlink_trap_policer.sh line 281: devlink trap policer set $DEVLINK_DEV policer $id rate 1000 burst 512 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap policer set "$DEVLINK_DEV" policer "$id" rate 1000 burst 512 In devlink_trap_policer.sh line 282: devlink trap group set $DEVLINK_DEV group l3_drops policer $id ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap group set "$DEVLINK_DEV" group l3_drops policer "$id" In devlink_trap_policer.sh line 289: t0_drop=$(devlink_trap_policer_rx_dropped_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: t0_drop=$(devlink_trap_policer_rx_dropped_get "$id") In devlink_trap_policer.sh line 291: start_traffic $h1 192.0.2.1 198.51.100.100 $rp1_mac -c 16 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1" 192.0.2.1 198.51.100.100 "$rp1_mac" -c 16 In devlink_trap_policer.sh line 294: t1_drop=$(devlink_trap_policer_rx_dropped_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: t1_drop=$(devlink_trap_policer_rx_dropped_get "$id") In devlink_trap_policer.sh line 310: devlink trap group set $DEVLINK_DEV group l3_drops nopolicer ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink trap group set "$DEVLINK_DEV" group l3_drops nopolicer In devlink_trap_policer.sh line 313: t0_drop=$(devlink_trap_policer_rx_dropped_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: t0_drop=$(devlink_trap_policer_rx_dropped_get "$id") In devlink_trap_policer.sh line 315: start_traffic $h1 192.0.2.1 198.51.100.100 $rp1_mac -c 64 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1" 192.0.2.1 198.51.100.100 "$rp1_mac" -c 64 In devlink_trap_policer.sh line 318: t1_drop=$(devlink_trap_policer_rx_dropped_get $id) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: t1_drop=$(devlink_trap_policer_rx_dropped_get "$id") In devlink_trap_policer.sh line 335: local last_policer=$(devlink -j -p trap policer show | ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In devlink_trap_policer.sh line 336: jq '[.[]["'$DEVLINK_DEV'"][].policer] | max') ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: jq '[.[]["'"$DEVLINK_DEV"'"][].policer] | max') In devlink_trap_policer.sh line 345: __burst_test $last_policer ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __burst_test "$last_policer" In devlink_trap_policer.sh line 355: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2034 -- ALL_TESTS appears unused. Verify ... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... https://www.shellcheck.net/wiki/SC1091 -- Not following: ./devlink_lib.sh: ... Checking tools/testing/selftests/drivers/net/mlxsw/qos_ets_strict.sh - cd5fda03da1fc3ff4428c6739dddf9aced769f63169957c0589e5d411b07a143 In qos_ets_strict.sh line 46: ALL_TESTS=" ^-------^ SC2034 (warning): ALL_TESTS appears unused. Verify use (or export if used externally). In qos_ets_strict.sh line 51: lib_dir=$(dirname $0)/../../../net/forwarding ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lib_dir=$(dirname "$0")/../../../net/forwarding In qos_ets_strict.sh line 53: NUM_NETIFS=6 ^--------^ SC2034 (warning): NUM_NETIFS appears unused. Verify use (or export if used externally). In qos_ets_strict.sh line 54: source $lib_dir/lib.sh ^-------------^ SC1091 (info): Not following: ./lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In qos_ets_strict.sh line 55: source $lib_dir/devlink_lib.sh ^---------------------^ SC1091 (info): Not following: ./devlink_lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/devlink_lib.sh In qos_ets_strict.sh line 60: simple_if_init $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" In qos_ets_strict.sh line 61: defer simple_if_fini $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h1" In qos_ets_strict.sh line 63: mtu_set $h1 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h1" 10000 In qos_ets_strict.sh line 64: defer mtu_restore $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h1" In qos_ets_strict.sh line 66: vlan_create $h1 111 v$h1 192.0.2.33/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h1" 111 v"$h1" 192.0.2.33/28 In qos_ets_strict.sh line 67: defer vlan_destroy $h1 111 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h1" 111 In qos_ets_strict.sh line 68: ip link set dev $h1.111 type vlan egress-qos-map 0:1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$h1".111 type vlan egress-qos-map 0:1 In qos_ets_strict.sh line 73: simple_if_init $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" In qos_ets_strict.sh line 74: defer simple_if_fini $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h2" In qos_ets_strict.sh line 76: mtu_set $h2 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h2" 10000 In qos_ets_strict.sh line 77: defer mtu_restore $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h2" In qos_ets_strict.sh line 79: vlan_create $h2 222 v$h2 192.0.2.65/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h2" 222 v"$h2" 192.0.2.65/28 In qos_ets_strict.sh line 80: defer vlan_destroy $h2 222 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h2" 222 In qos_ets_strict.sh line 81: ip link set dev $h2.222 type vlan egress-qos-map 0:2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$h2".222 type vlan egress-qos-map 0:2 In qos_ets_strict.sh line 86: simple_if_init $h3 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h3" In qos_ets_strict.sh line 87: defer simple_if_fini $h3 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h3" In qos_ets_strict.sh line 89: mtu_set $h3 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h3" 10000 In qos_ets_strict.sh line 90: defer mtu_restore $h3 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h3" In qos_ets_strict.sh line 92: vlan_create $h3 111 v$h3 192.0.2.34/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h3" 111 v"$h3" 192.0.2.34/28 In qos_ets_strict.sh line 93: defer vlan_destroy $h3 111 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h3" 111 In qos_ets_strict.sh line 95: vlan_create $h3 222 v$h3 192.0.2.66/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h3" 222 v"$h3" 192.0.2.66/28 In qos_ets_strict.sh line 96: defer vlan_destroy $h3 222 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h3" 222 In qos_ets_strict.sh line 101: ip link set dev $swp1 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up In qos_ets_strict.sh line 102: defer ip link set dev $swp1 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1" down In qos_ets_strict.sh line 104: mtu_set $swp1 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp1" 10000 In qos_ets_strict.sh line 105: defer mtu_restore $swp1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp1" In qos_ets_strict.sh line 107: ip link set dev $swp2 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up In qos_ets_strict.sh line 108: defer ip link set dev $swp2 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2" down In qos_ets_strict.sh line 110: mtu_set $swp2 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp2" 10000 In qos_ets_strict.sh line 111: defer mtu_restore $swp2 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp2" In qos_ets_strict.sh line 114: lldptool -T -i $swp3 -V ETS-CFG up2tc=0:0,1:1,2:2,3:3,4:4,5:5,6:6,7:7 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lldptool -T -i "$swp3" -V ETS-CFG up2tc=0:0,1:1,2:2,3:3,4:4,5:5,6:6,7:7 In qos_ets_strict.sh line 115: defer lldptool -T -i $swp3 -V ETS-CFG up2tc=0:0,1:0,2:0,3:0,4:0,5:0,6:0,7:0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer lldptool -T -i "$swp3" -V ETS-CFG up2tc=0:0,1:0,2:0,3:0,4:0,5:0,6:0,7:0 In qos_ets_strict.sh line 117: lldptool -T -i $swp3 -V ETS-CFG tsa=$( ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lldptool -T -i "$swp3" -V ETS-CFG tsa=$( In qos_ets_strict.sh line 118: )"0:strict,"$( ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In qos_ets_strict.sh line 119: )"1:strict,"$( ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In qos_ets_strict.sh line 120: )"2:strict,"$( ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In qos_ets_strict.sh line 121: )"3:strict,"$( ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In qos_ets_strict.sh line 122: )"4:strict,"$( ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In qos_ets_strict.sh line 123: )"5:strict,"$( ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In qos_ets_strict.sh line 124: )"6:strict,"$( ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In qos_ets_strict.sh line 128: ip link set dev $swp3 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp3" up In qos_ets_strict.sh line 129: defer ip link set dev $swp3 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp3" down In qos_ets_strict.sh line 131: mtu_set $swp3 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp3" 10000 In qos_ets_strict.sh line 132: defer mtu_restore $swp3 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp3" In qos_ets_strict.sh line 134: tc qdisc replace dev $swp3 root handle 101: tbf rate 1gbit \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$swp3" root handle 101: tbf rate 1gbit \ In qos_ets_strict.sh line 136: defer tc qdisc del dev $swp3 root handle 101: ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$swp3" root handle 101: In qos_ets_strict.sh line 138: vlan_create $swp1 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp1" 111 In qos_ets_strict.sh line 139: defer vlan_destroy $swp1 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp1" 111 In qos_ets_strict.sh line 141: vlan_create $swp2 222 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp2" 222 In qos_ets_strict.sh line 142: defer vlan_destroy $swp2 222 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp2" 222 In qos_ets_strict.sh line 144: vlan_create $swp3 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp3" 111 In qos_ets_strict.sh line 145: defer vlan_destroy $swp3 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp3" 111 In qos_ets_strict.sh line 147: vlan_create $swp3 222 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp3" 222 In qos_ets_strict.sh line 148: defer vlan_destroy $swp3 222 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp3" 222 In qos_ets_strict.sh line 157: ip link set dev $swp1.111 master br111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".111 master br111 In qos_ets_strict.sh line 158: defer ip link set dev $swp1.111 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1".111 nomaster In qos_ets_strict.sh line 160: ip link set dev $swp3.111 master br111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp3".111 master br111 In qos_ets_strict.sh line 161: defer ip link set dev $swp3.111 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp3".111 nomaster In qos_ets_strict.sh line 170: ip link set dev $swp2.222 master br222 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2".222 master br222 In qos_ets_strict.sh line 171: defer ip link set dev $swp2.222 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2".222 nomaster In qos_ets_strict.sh line 173: ip link set dev $swp3.222 master br222 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp3".222 master br222 In qos_ets_strict.sh line 174: defer ip link set dev $swp3.222 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp3".222 nomaster In qos_ets_strict.sh line 186: devlink_port_pool_th_save $swp1 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp1" 0 In qos_ets_strict.sh line 187: devlink_port_pool_th_set $swp1 0 6 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp1" 0 6 In qos_ets_strict.sh line 188: defer devlink_port_pool_th_restore $swp1 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp1" 0 In qos_ets_strict.sh line 190: devlink_tc_bind_pool_th_save $swp1 1 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_save "$swp1" 1 ingress In qos_ets_strict.sh line 191: devlink_tc_bind_pool_th_set $swp1 1 ingress 0 6 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_set "$swp1" 1 ingress 0 6 In qos_ets_strict.sh line 192: defer devlink_tc_bind_pool_th_restore $swp1 1 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_tc_bind_pool_th_restore "$swp1" 1 ingress In qos_ets_strict.sh line 194: devlink_port_pool_th_save $swp2 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp2" 0 In qos_ets_strict.sh line 195: devlink_port_pool_th_set $swp2 0 6 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp2" 0 6 In qos_ets_strict.sh line 196: defer devlink_port_pool_th_restore $swp2 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp2" 0 In qos_ets_strict.sh line 198: devlink_tc_bind_pool_th_save $swp2 2 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_save "$swp2" 2 ingress In qos_ets_strict.sh line 199: devlink_tc_bind_pool_th_set $swp2 2 ingress 0 6 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_set "$swp2" 2 ingress 0 6 In qos_ets_strict.sh line 200: defer devlink_tc_bind_pool_th_restore $swp2 2 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_tc_bind_pool_th_restore "$swp2" 2 ingress In qos_ets_strict.sh line 202: devlink_tc_bind_pool_th_save $swp3 1 egress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_save "$swp3" 1 egress In qos_ets_strict.sh line 203: devlink_tc_bind_pool_th_set $swp3 1 egress 4 7 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_set "$swp3" 1 egress 4 7 In qos_ets_strict.sh line 204: defer devlink_tc_bind_pool_th_restore $swp3 1 egress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_tc_bind_pool_th_restore "$swp3" 1 egress In qos_ets_strict.sh line 206: devlink_tc_bind_pool_th_save $swp3 2 egress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_save "$swp3" 2 egress In qos_ets_strict.sh line 207: devlink_tc_bind_pool_th_set $swp3 2 egress 4 7 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_set "$swp3" 2 egress 4 7 In qos_ets_strict.sh line 208: defer devlink_tc_bind_pool_th_restore $swp3 2 egress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_tc_bind_pool_th_restore "$swp3" 2 egress In qos_ets_strict.sh line 210: devlink_port_pool_th_save $swp3 4 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp3" 4 In qos_ets_strict.sh line 211: devlink_port_pool_th_set $swp3 4 7 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp3" 4 7 In qos_ets_strict.sh line 212: defer devlink_port_pool_th_restore $swp3 4 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp3" 4 In qos_ets_strict.sh line 226: h3mac=$(mac_get $h3) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h3mac=$(mac_get "$h3") In qos_ets_strict.sh line 238: ping_test $h1 192.0.2.34 " from H1" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h1" 192.0.2.34 " from H1" In qos_ets_strict.sh line 239: ping_test $h2 192.0.2.66 " from H2" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h2" 192.0.2.66 " from H2" In qos_ets_strict.sh line 259: start_traffic $h2.222 192.0.2.65 192.0.2.66 $h3mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h2".222 192.0.2.65 192.0.2.66 "$h3mac" In qos_ets_strict.sh line 262: uc_rate=($(measure_rate $swp2 $h3 rx_octets_prio_2 "$what")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: uc_rate=($(measure_rate "$swp2" "$h3" rx_octets_prio_2 "$what")) In qos_ets_strict.sh line 265: echo ${uc_rate[@]} ^-----------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In qos_ets_strict.sh line 275: RET=0 ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally). In qos_ets_strict.sh line 279: rate_2=($(run_hi_measure_rate "prio 2")) ^-----------------------------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). In qos_ets_strict.sh line 284: start_traffic $h1.111 192.0.2.33 192.0.2.34 $h3mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1".111 192.0.2.33 192.0.2.34 "$h3mac" In qos_ets_strict.sh line 288: rate_1=($(measure_rate $swp1 $h3 rx_octets_prio_1 "prio 1")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rate_1=($(measure_rate "$swp1" "$h3" rx_octets_prio_1 "prio 1")) In qos_ets_strict.sh line 295: local rel21=$(rel $rate_1_eg $rate_2_eg) ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local rel21=$(rel "$rate_1_eg" "$rate_2_eg") In qos_ets_strict.sh line 296: check_err $(bc <<< "$rel21 < 95") ^---------------------^ SC2046 (warning): Quote this to prevent word splitting. In qos_ets_strict.sh line 297: check_err $(bc <<< "$rel21 > 105") ^----------------------^ SC2046 (warning): Quote this to prevent word splitting. In qos_ets_strict.sh line 300: rate_3=($(run_hi_measure_rate "prio 2+1")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). In qos_ets_strict.sh line 306: local rel32=$(rel $rate_2_eg $rate_3_eg) ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local rel32=$(rel "$rate_2_eg" "$rate_3_eg") In qos_ets_strict.sh line 307: check_err $(bc <<< "$rel32 < 95") ^---------------------^ SC2046 (warning): Quote this to prevent word splitting. In qos_ets_strict.sh line 311: echo " p1 in rate $(humanize $rate_1_in)" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " p1 in rate $(humanize "$rate_1_in")" In qos_ets_strict.sh line 312: echo " p2 in rate $(humanize $rate_2_in)" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " p2 in rate $(humanize "$rate_2_in")" In qos_ets_strict.sh line 313: echo " p2 in rate w/ p1 $(humanize $rate_3_in)" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " p2 in rate w/ p1 $(humanize "$rate_3_in")" In qos_ets_strict.sh line 315: echo " p1 eg rate $(humanize $rate_1_eg)" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " p1 eg rate $(humanize "$rate_1_eg")" In qos_ets_strict.sh line 316: echo " p2 eg rate $(humanize $rate_2_eg) ($rel21% of p1)" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " p2 eg rate $(humanize "$rate_2_eg") ($rel21% of p1)" In qos_ets_strict.sh line 317: echo " p2 eg rate w/ p1 $(humanize $rate_3_eg) ($rel32% of p2)" ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " p2 eg rate w/ p1 $(humanize "$rate_3_eg") ($rel32% of p2)" In qos_ets_strict.sh line 327: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u... https://www.shellcheck.net/wiki/SC2034 -- ALL_TESTS appears unused. Verify ... Checking tools/testing/selftests/drivers/net/mlxsw/qos_max_descriptors.sh - 043dafd07ecd59d7b96f10e3191cc872c3ac6314c145bce82b9fb319d48d1b6a In qos_max_descriptors.sh line 47: ALL_TESTS=" ^-------^ SC2034 (warning): ALL_TESTS appears unused. Verify use (or export if used externally). In qos_max_descriptors.sh line 52: lib_dir=$(dirname $0)/../../../net/forwarding ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lib_dir=$(dirname "$0")/../../../net/forwarding In qos_max_descriptors.sh line 54: NUM_NETIFS=4 ^--------^ SC2034 (warning): NUM_NETIFS appears unused. Verify use (or export if used externally). In qos_max_descriptors.sh line 55: source $lib_dir/lib.sh ^-------------^ SC1091 (info): Not following: ./lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In qos_max_descriptors.sh line 56: source $lib_dir/devlink_lib.sh ^---------------------^ SC1091 (info): Not following: ./devlink_lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/devlink_lib.sh In qos_max_descriptors.sh line 71: simple_if_init $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" In qos_max_descriptors.sh line 72: defer simple_if_fini $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h1" In qos_max_descriptors.sh line 74: vlan_create $h1 111 v$h1 192.0.2.33/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h1" 111 v"$h1" 192.0.2.33/28 In qos_max_descriptors.sh line 75: defer vlan_destroy $h1 111 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h1" 111 In qos_max_descriptors.sh line 76: ip link set dev $h1.111 type vlan egress-qos-map 0:1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$h1".111 type vlan egress-qos-map 0:1 In qos_max_descriptors.sh line 81: simple_if_init $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" In qos_max_descriptors.sh line 82: defer simple_if_fini $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h2" In qos_max_descriptors.sh line 84: vlan_create $h2 111 v$h2 192.0.2.34/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h2" 111 v"$h2" 192.0.2.34/28 In qos_max_descriptors.sh line 85: defer vlan_destroy $h2 111 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h2" 111 In qos_max_descriptors.sh line 97: devlink_pool_size_thtype_set 1 dynamic $MAX_POOL_SIZE ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_pool_size_thtype_set 1 dynamic "$MAX_POOL_SIZE" In qos_max_descriptors.sh line 101: devlink_pool_size_thtype_set 6 static $MAX_POOL_SIZE ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_pool_size_thtype_set 6 static "$MAX_POOL_SIZE" In qos_max_descriptors.sh line 107: ip link set dev $swp1 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up In qos_max_descriptors.sh line 108: defer ip link set dev $swp1 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1" down In qos_max_descriptors.sh line 110: vlan_create $swp1 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp1" 111 In qos_max_descriptors.sh line 111: defer vlan_destroy $swp1 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp1" 111 In qos_max_descriptors.sh line 112: ip link set dev $swp1.111 type vlan ingress-qos-map 0:0 1:1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".111 type vlan ingress-qos-map 0:0 1:1 In qos_max_descriptors.sh line 114: devlink_port_pool_th_save $swp1 1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp1" 1 In qos_max_descriptors.sh line 115: devlink_port_pool_th_set $swp1 1 16 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp1" 1 16 In qos_max_descriptors.sh line 116: defer devlink_tc_bind_pool_th_restore $swp1 1 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_tc_bind_pool_th_restore "$swp1" 1 ingress In qos_max_descriptors.sh line 118: devlink_tc_bind_pool_th_save $swp1 1 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_save "$swp1" 1 ingress In qos_max_descriptors.sh line 119: devlink_tc_bind_pool_th_set $swp1 1 ingress 1 16 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_set "$swp1" 1 ingress 1 16 In qos_max_descriptors.sh line 120: defer devlink_port_pool_th_restore $swp1 1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp1" 1 In qos_max_descriptors.sh line 122: tc qdisc replace dev $swp1 root handle 1: \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$swp1" root handle 1: \ In qos_max_descriptors.sh line 124: defer tc qdisc del dev $swp1 root ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$swp1" root In qos_max_descriptors.sh line 126: dcb buffer set dev $swp1 prio-buffer all:0 1:1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: dcb buffer set dev "$swp1" prio-buffer all:0 1:1 In qos_max_descriptors.sh line 127: defer dcb buffer set dev $swp1 prio-buffer all:0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer dcb buffer set dev "$swp1" prio-buffer all:0 In qos_max_descriptors.sh line 132: ip link set dev $swp2 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up In qos_max_descriptors.sh line 133: defer ip link set dev $swp2 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2" down In qos_max_descriptors.sh line 135: vlan_create $swp2 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp2" 111 In qos_max_descriptors.sh line 136: defer vlan_destroy $swp2 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp2" 111 In qos_max_descriptors.sh line 137: ip link set dev $swp2.111 type vlan egress-qos-map 0:0 1:1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2".111 type vlan egress-qos-map 0:0 1:1 In qos_max_descriptors.sh line 139: devlink_port_pool_th_save $swp2 6 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp2" 6 In qos_max_descriptors.sh line 140: devlink_port_pool_th_set $swp2 6 $MAX_POOL_SIZE ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp2" 6 "$MAX_POOL_SIZE" In qos_max_descriptors.sh line 141: defer devlink_tc_bind_pool_th_restore $swp2 1 egress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_tc_bind_pool_th_restore "$swp2" 1 egress In qos_max_descriptors.sh line 143: devlink_tc_bind_pool_th_save $swp2 1 egress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_save "$swp2" 1 egress In qos_max_descriptors.sh line 144: devlink_tc_bind_pool_th_set $swp2 1 egress 6 $MAX_POOL_SIZE ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_set "$swp2" 1 egress 6 "$MAX_POOL_SIZE" In qos_max_descriptors.sh line 145: defer devlink_port_pool_th_restore $swp2 6 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp2" 6 In qos_max_descriptors.sh line 147: tc qdisc replace dev $swp2 root handle 1: tbf rate $SHAPER_RATE \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$swp2" root handle 1: tbf rate $SHAPER_RATE \ In qos_max_descriptors.sh line 149: defer tc qdisc del dev $swp2 root ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$swp2" root In qos_max_descriptors.sh line 151: tc qdisc replace dev $swp2 parent 1:1 handle 11: \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$swp2" parent 1:1 handle 11: \ In qos_max_descriptors.sh line 153: defer tc qdisc del dev $swp2 parent 1:1 handle 11: ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$swp2" parent 1:1 handle 11: In qos_max_descriptors.sh line 161: ip link set dev $swp1.111 master br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".111 master br1 In qos_max_descriptors.sh line 162: defer ip link set dev $swp1.111 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1".111 nomaster In qos_max_descriptors.sh line 167: ip link set dev $swp2.111 master br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2".111 master br1 In qos_max_descriptors.sh line 168: defer ip link set dev $swp2.111 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2".111 nomaster In qos_max_descriptors.sh line 179: h2mac=$(mac_get $h2) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2mac=$(mac_get "$h2") In qos_max_descriptors.sh line 190: ping_test $h1 192.0.2.34 " h1->h2" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h1" 192.0.2.34 " h1->h2" In qos_max_descriptors.sh line 206: local cell_size=$(devlink_cell_size_get) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In qos_max_descriptors.sh line 211: RET=0 ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally). In qos_max_descriptors.sh line 215: local d0=$(ethtool_stats_get $swp2 tc_no_buffer_discard_uc_tc_1) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local d0=$(ethtool_stats_get "$swp2" tc_no_buffer_discard_uc_tc_1) In qos_max_descriptors.sh line 218: start_traffic_pktsize $pktsize $h1.111 192.0.2.33 192.0.2.34 $h2mac ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic_pktsize "$pktsize" "$h1".111 192.0.2.33 192.0.2.34 "$h2mac" In qos_max_descriptors.sh line 224: local d1=$(ethtool_stats_get $swp2 tc_no_buffer_discard_uc_tc_1) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local d1=$(ethtool_stats_get "$swp2" tc_no_buffer_discard_uc_tc_1) In qos_max_descriptors.sh line 230: local pkts_bytes=$(ethtool_stats_get $swp2 tc_transmit_queue_tc_1) ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local pkts_bytes=$(ethtool_stats_get "$swp2" tc_transmit_queue_tc_1) In qos_max_descriptors.sh line 232: local perc_used=$(percentage_used $pkts_num $max_descriptors) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local perc_used=$(percentage_used "$pkts_num" "$max_descriptors") In qos_max_descriptors.sh line 234: check_err $(bc <<< "$perc_used < $exp_perc_used") \ ^-- SC2046 (warning): Quote this to prevent word splitting. In qos_max_descriptors.sh line 245: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2034 -- ALL_TESTS appears unused. Verify ... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... Checking tools/testing/selftests/drivers/net/mlxsw/qos_mc_aware.sh - 933f8438a48a2efb8659a329984860377c91c863f6a30214c47f2a0fb2ba8929 In qos_mc_aware.sh line 60: ALL_TESTS=" ^-------^ SC2034 (warning): ALL_TESTS appears unused. Verify use (or export if used externally). In qos_mc_aware.sh line 66: lib_dir=$(dirname $0)/../../../net/forwarding ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lib_dir=$(dirname "$0")/../../../net/forwarding In qos_mc_aware.sh line 68: NUM_NETIFS=6 ^--------^ SC2034 (warning): NUM_NETIFS appears unused. Verify use (or export if used externally). In qos_mc_aware.sh line 69: source $lib_dir/lib.sh ^-------------^ SC1091 (info): Not following: ./lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In qos_mc_aware.sh line 70: source $lib_dir/devlink_lib.sh ^---------------------^ SC1091 (info): Not following: ./devlink_lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/devlink_lib.sh In qos_mc_aware.sh line 75: simple_if_init $h1 192.0.2.65/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" 192.0.2.65/28 In qos_mc_aware.sh line 76: defer simple_if_fini $h1 192.0.2.65/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h1" 192.0.2.65/28 In qos_mc_aware.sh line 78: mtu_set $h1 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h1" 10000 In qos_mc_aware.sh line 79: defer mtu_restore $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h1" In qos_mc_aware.sh line 84: simple_if_init $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" In qos_mc_aware.sh line 85: defer simple_if_fini $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h2" In qos_mc_aware.sh line 87: mtu_set $h2 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h2" 10000 In qos_mc_aware.sh line 88: defer mtu_restore $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h2" In qos_mc_aware.sh line 90: vlan_create $h2 111 v$h2 192.0.2.129/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h2" 111 v"$h2" 192.0.2.129/28 In qos_mc_aware.sh line 91: defer vlan_destroy $h2 111 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h2" 111 In qos_mc_aware.sh line 92: ip link set dev $h2.111 type vlan egress-qos-map 0:1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$h2".111 type vlan egress-qos-map 0:1 In qos_mc_aware.sh line 97: simple_if_init $h3 192.0.2.66/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h3" 192.0.2.66/28 In qos_mc_aware.sh line 98: defer simple_if_fini $h3 192.0.2.66/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h3" 192.0.2.66/28 In qos_mc_aware.sh line 100: mtu_set $h3 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h3" 10000 In qos_mc_aware.sh line 101: defer mtu_restore $h3 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h3" In qos_mc_aware.sh line 103: vlan_create $h3 111 v$h3 192.0.2.130/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h3" 111 v"$h3" 192.0.2.130/28 In qos_mc_aware.sh line 104: defer vlan_destroy $h3 111 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h3" 111 In qos_mc_aware.sh line 109: ip link set dev $swp1 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up In qos_mc_aware.sh line 110: defer ip link set dev $swp1 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1" down In qos_mc_aware.sh line 112: mtu_set $swp1 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp1" 10000 In qos_mc_aware.sh line 113: defer mtu_restore $swp1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp1" In qos_mc_aware.sh line 115: ip link set dev $swp2 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up In qos_mc_aware.sh line 116: defer ip link set dev $swp2 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2" down In qos_mc_aware.sh line 118: mtu_set $swp2 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp2" 10000 In qos_mc_aware.sh line 119: defer mtu_restore $swp2 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp2" In qos_mc_aware.sh line 121: ip link set dev $swp3 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp3" up In qos_mc_aware.sh line 122: defer ip link set dev $swp3 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp3" down In qos_mc_aware.sh line 124: mtu_set $swp3 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp3" 10000 In qos_mc_aware.sh line 125: defer mtu_restore $swp3 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp3" In qos_mc_aware.sh line 127: vlan_create $swp2 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp2" 111 In qos_mc_aware.sh line 128: defer vlan_destroy $swp2 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp2" 111 In qos_mc_aware.sh line 130: vlan_create $swp3 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp3" 111 In qos_mc_aware.sh line 131: defer vlan_destroy $swp3 111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp3" 111 In qos_mc_aware.sh line 133: tc qdisc replace dev $swp3 root handle 3: tbf rate 1gbit \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$swp3" root handle 3: tbf rate 1gbit \ In qos_mc_aware.sh line 135: defer tc qdisc del dev $swp3 root handle 3: ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$swp3" root handle 3: In qos_mc_aware.sh line 137: tc qdisc replace dev $swp3 parent 3:3 handle 33: \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$swp3" parent 3:3 handle 33: \ In qos_mc_aware.sh line 139: defer tc qdisc del dev $swp3 parent 3:3 handle 33: ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$swp3" parent 3:3 handle 33: In qos_mc_aware.sh line 146: ip link set dev $swp1 master br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" master br1 In qos_mc_aware.sh line 147: defer ip link set dev $swp1 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1" nomaster In qos_mc_aware.sh line 149: ip link set dev $swp3 master br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp3" master br1 In qos_mc_aware.sh line 150: defer ip link set dev $swp3 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp3" nomaster In qos_mc_aware.sh line 157: ip link set dev $swp2.111 master br111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2".111 master br111 In qos_mc_aware.sh line 158: defer ip link set dev $swp2.111 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2".111 nomaster In qos_mc_aware.sh line 160: ip link set dev $swp3.111 master br111 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp3".111 master br111 In qos_mc_aware.sh line 161: defer ip link set dev $swp3.111 nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp3".111 nomaster In qos_mc_aware.sh line 165: devlink_port_pool_th_save $swp1 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp1" 0 In qos_mc_aware.sh line 166: devlink_port_pool_th_set $swp1 0 5 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp1" 0 5 In qos_mc_aware.sh line 167: defer devlink_port_pool_th_restore $swp1 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp1" 0 In qos_mc_aware.sh line 169: devlink_tc_bind_pool_th_save $swp1 0 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_save "$swp1" 0 ingress In qos_mc_aware.sh line 170: devlink_tc_bind_pool_th_set $swp1 0 ingress 0 5 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_set "$swp1" 0 ingress 0 5 In qos_mc_aware.sh line 171: defer devlink_tc_bind_pool_th_restore $swp1 0 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_tc_bind_pool_th_restore "$swp1" 0 ingress In qos_mc_aware.sh line 173: devlink_port_pool_th_save $swp2 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp2" 0 In qos_mc_aware.sh line 174: devlink_port_pool_th_set $swp2 0 5 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp2" 0 5 In qos_mc_aware.sh line 175: defer devlink_port_pool_th_restore $swp2 0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp2" 0 In qos_mc_aware.sh line 177: devlink_tc_bind_pool_th_save $swp2 1 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_save "$swp2" 1 ingress In qos_mc_aware.sh line 178: devlink_tc_bind_pool_th_set $swp2 1 ingress 0 5 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_tc_bind_pool_th_set "$swp2" 1 ingress 0 5 In qos_mc_aware.sh line 179: defer devlink_tc_bind_pool_th_restore $swp2 1 ingress ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_tc_bind_pool_th_restore "$swp2" 1 ingress In qos_mc_aware.sh line 181: devlink_port_pool_th_save $swp3 4 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp3" 4 In qos_mc_aware.sh line 182: devlink_port_pool_th_set $swp3 4 12 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp3" 4 12 In qos_mc_aware.sh line 183: defer devlink_port_pool_th_restore $swp3 4 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp3" 4 In qos_mc_aware.sh line 197: h3mac=$(mac_get $h3) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h3mac=$(mac_get "$h3") In qos_mc_aware.sh line 209: ping_test $h2 192.0.2.130 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h2" 192.0.2.130 In qos_mc_aware.sh line 217: start_traffic $h2.111 192.0.2.129 192.0.2.130 $h3mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h2".111 192.0.2.129 192.0.2.130 "$h3mac" In qos_mc_aware.sh line 220: uc_rate=($(measure_rate $swp2 $h3 rx_octets_prio_1 "$what")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: uc_rate=($(measure_rate "$swp2" "$h3" rx_octets_prio_1 "$what")) In qos_mc_aware.sh line 223: echo ${uc_rate[@]} ^-----------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In qos_mc_aware.sh line 235: local -a uc_rate=($(run_uc_measure_rate "UC-only")) ^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). In qos_mc_aware.sh line 238: start_traffic $h1 192.0.2.65 bc bc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1" 192.0.2.65 bc bc In qos_mc_aware.sh line 241: local d0=$(date +%s) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In qos_mc_aware.sh line 242: local t0=$(ethtool_stats_get $h3 rx_octets_prio_0) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t0=$(ethtool_stats_get "$h3" rx_octets_prio_0) In qos_mc_aware.sh line 243: local u0=$(ethtool_stats_get $swp1 rx_octets_prio_0) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local u0=$(ethtool_stats_get "$swp1" rx_octets_prio_0) In qos_mc_aware.sh line 245: local -a uc_rate_2=($(run_uc_measure_rate "UC+MC")) ^----------------------------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting). In qos_mc_aware.sh line 248: local d1=$(date +%s) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In qos_mc_aware.sh line 249: local t1=$(ethtool_stats_get $h3 rx_octets_prio_0) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t1=$(ethtool_stats_get "$h3" rx_octets_prio_0) In qos_mc_aware.sh line 250: local u1=$(ethtool_stats_get $swp1 rx_octets_prio_0) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local u1=$(ethtool_stats_get "$swp1" rx_octets_prio_0) In qos_mc_aware.sh line 252: local deg=$(bc <<< " ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values. In qos_mc_aware.sh line 260: check_err $(bc <<< "$deg < 15") "Minimum shaper not in effect" ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. In qos_mc_aware.sh line 261: check_err $(bc <<< "$deg > 25") "MC traffic degrades UC performance too much" ^-------------------^ SC2046 (warning): Quote this to prevent word splitting. In qos_mc_aware.sh line 264: local mc_ir=$(rate $u0 $u1 $interval) ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local mc_ir=$(rate "$u0" "$u1" "$interval") In qos_mc_aware.sh line 265: local mc_er=$(rate $t0 $t1 $interval) ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local mc_er=$(rate "$t0" "$t1" "$interval") In qos_mc_aware.sh line 269: echo "UC-only throughput $(humanize $ucth1)" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "UC-only throughput $(humanize "$ucth1")" In qos_mc_aware.sh line 270: echo "UC+MC throughput $(humanize $ucth2)" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "UC+MC throughput $(humanize "$ucth2")" In qos_mc_aware.sh line 275: echo " ingress UC throughput $(humanize ${uc_rate[0]})" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " ingress UC throughput $(humanize "${uc_rate[0]}")" In qos_mc_aware.sh line 276: echo " egress UC throughput $(humanize ${uc_rate[1]})" ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " egress UC throughput $(humanize "${uc_rate[1]}")" In qos_mc_aware.sh line 278: echo " ingress UC throughput $(humanize ${uc_rate_2[0]})" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " ingress UC throughput $(humanize "${uc_rate_2[0]}")" In qos_mc_aware.sh line 279: echo " egress UC throughput $(humanize ${uc_rate_2[1]})" ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " egress UC throughput $(humanize "${uc_rate_2[1]}")" In qos_mc_aware.sh line 280: echo " ingress MC throughput $(humanize $mc_ir)" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " ingress MC throughput $(humanize "$mc_ir")" In qos_mc_aware.sh line 281: echo " egress MC throughput $(humanize $mc_er)" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " egress MC throughput $(humanize "$mc_er")" In qos_mc_aware.sh line 287: RET=0 ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally). In qos_mc_aware.sh line 289: start_traffic $h2.111 192.0.2.129 192.0.2.130 $h3mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h2".111 192.0.2.129 192.0.2.130 "$h3mac" In qos_mc_aware.sh line 292: local d0=$(date +%s) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In qos_mc_aware.sh line 293: local t0=$(ethtool_stats_get $h3 rx_octets_prio_1) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t0=$(ethtool_stats_get "$h3" rx_octets_prio_1) In qos_mc_aware.sh line 294: local u0=$(ethtool_stats_get $swp2 rx_octets_prio_1) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local u0=$(ethtool_stats_get "$swp2" rx_octets_prio_1) In qos_mc_aware.sh line 302: if $ARPING -c 1 -I $h1 -b 192.0.2.66 -q -w 1; then ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if $ARPING -c 1 -I "$h1" -b 192.0.2.66 -q -w 1; then In qos_mc_aware.sh line 309: local d1=$(date +%s) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In qos_mc_aware.sh line 310: local t1=$(ethtool_stats_get $h3 rx_octets_prio_1) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t1=$(ethtool_stats_get "$h3" rx_octets_prio_1) In qos_mc_aware.sh line 311: local u1=$(ethtool_stats_get $swp2 rx_octets_prio_1) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local u1=$(ethtool_stats_get "$swp2" rx_octets_prio_1) In qos_mc_aware.sh line 314: local uc_ir=$(rate $u0 $u1 $interval) ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local uc_ir=$(rate "$u0" "$u1" "$interval") In qos_mc_aware.sh line 315: local uc_er=$(rate $t0 $t1 $interval) ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local uc_er=$(rate "$t0" "$t1" "$interval") In qos_mc_aware.sh line 321: echo " ingress UC throughput $(humanize ${uc_ir})" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " ingress UC throughput $(humanize "${uc_ir}")" In qos_mc_aware.sh line 322: echo " egress UC throughput $(humanize ${uc_er})" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " egress UC throughput $(humanize "${uc_er}")" In qos_mc_aware.sh line 333: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2034 -- ALL_TESTS appears unused. Verify ... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... Checking tools/testing/selftests/drivers/net/mlxsw/sch_red_core.sh - 08d2ef05e2210a31654fc90db58d1f462ce46e6f86fec6fc6b2b52cc8fbdda3e In sch_red_core.sh line 1: # SPDX-License-Identifier: GPL-2.0 ^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. In sch_red_core.sh line 71: NUM_NETIFS=8 ^--------^ SC2034 (warning): NUM_NETIFS appears unused. Verify use (or export if used externally). In sch_red_core.sh line 72: CHECK_TC="yes" ^------^ SC2034 (warning): CHECK_TC appears unused. Verify use (or export if used externally). In sch_red_core.sh line 73: lib_dir=$(dirname $0)/../../../net/forwarding ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: lib_dir=$(dirname "$0")/../../../net/forwarding In sch_red_core.sh line 74: source $lib_dir/lib.sh ^-------------^ SC1091 (info): Not following: ./lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In sch_red_core.sh line 75: source $lib_dir/devlink_lib.sh ^---------------------^ SC1091 (info): Not following: ./devlink_lib.sh: openBinaryFile: does not exist (No such file or directory) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/devlink_lib.sh In sch_red_core.sh line 103: simple_if_init $dev ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$dev" In sch_red_core.sh line 104: defer simple_if_fini $dev ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$dev" In sch_red_core.sh line 106: mtu_set $dev 10000 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$dev" 10000 In sch_red_core.sh line 107: defer mtu_restore $dev ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$dev" In sch_red_core.sh line 109: vlan_create $dev 10 v$dev $(ipaddr $host 10)/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$dev" 10 v"$dev" $(ipaddr "$host" 10)/28 In sch_red_core.sh line 110: defer vlan_destroy $dev 10 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$dev" 10 In sch_red_core.sh line 111: ip link set dev $dev.10 type vlan egress 0:0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev".10 type vlan egress 0:0 In sch_red_core.sh line 113: vlan_create $dev 11 v$dev $(ipaddr $host 11)/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$dev" 11 v"$dev" $(ipaddr "$host" 11)/28 In sch_red_core.sh line 114: defer vlan_destroy $dev 11 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$dev" 11 In sch_red_core.sh line 115: ip link set dev $dev.11 type vlan egress 0:1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev".11 type vlan egress 0:1 In sch_red_core.sh line 120: host_create $h1 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: host_create "$h1" 1 In sch_red_core.sh line 125: host_create $h2 2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: host_create "$h2" 2 In sch_red_core.sh line 127: tc qdisc add dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$h2" clsact In sch_red_core.sh line 128: defer tc qdisc del dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$h2" clsact In sch_red_core.sh line 144: tc qdisc replace dev $h2 root handle 10: tbf rate 200mbit \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$h2" root handle 10: tbf rate 200mbit \ In sch_red_core.sh line 146: defer tc qdisc del dev $h2 root handle 10: ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$h2" root handle 10: In sch_red_core.sh line 151: host_create $h3 3 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: host_create "$h3" 3 In sch_red_core.sh line 172: ip link set dev $intf up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf" up In sch_red_core.sh line 173: defer ip link set dev $intf down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$intf" down In sch_red_core.sh line 175: mtu_set $intf 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$intf" 10000 In sch_red_core.sh line 176: defer mtu_restore $intf ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$intf" In sch_red_core.sh line 181: vlan_create $intf $vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$intf" $vlan In sch_red_core.sh line 182: defer vlan_destroy $intf $vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$intf" $vlan In sch_red_core.sh line 184: ip link set dev $intf.$vlan master br1_$vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf".$vlan master br1_$vlan In sch_red_core.sh line 185: defer ip link set dev $intf.$vlan nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$intf".$vlan nomaster In sch_red_core.sh line 187: ip link set dev $intf.$vlan up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf".$vlan up In sch_red_core.sh line 188: defer ip link set dev $intf.$vlan up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$intf".$vlan up In sch_red_core.sh line 194: vlan_create $intf $vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$intf" $vlan In sch_red_core.sh line 195: defer vlan_destroy $intf $vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$intf" $vlan In sch_red_core.sh line 197: ip link set dev $intf.$vlan master br2_$vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf".$vlan master br2_$vlan In sch_red_core.sh line 198: defer ip link set dev $intf.$vlan nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$intf".$vlan nomaster In sch_red_core.sh line 200: ip link set dev $intf.$vlan up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf".$vlan up In sch_red_core.sh line 201: defer ip link set dev $intf.$vlan up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$intf".$vlan up In sch_red_core.sh line 205: ip link set dev $swp4.10 type vlan egress 0:0 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp4".10 type vlan egress 0:0 In sch_red_core.sh line 206: ip link set dev $swp4.11 type vlan egress 0:1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp4".11 type vlan egress 0:1 In sch_red_core.sh line 209: ip link set dev $intf.$vlan type vlan ingress 0:0 1:1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf".$vlan type vlan ingress 0:0 1:1 In sch_red_core.sh line 214: tc qdisc replace dev $intf root handle 1: tbf rate 200mbit \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$intf" root handle 1: tbf rate 200mbit \ In sch_red_core.sh line 216: defer tc qdisc del dev $intf root handle 1: ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$intf" root handle 1: In sch_red_core.sh line 231: local size=$(devlink_pool_size_thtype 0 | cut -d' ' -f 1) ^--^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red_core.sh line 232: devlink_port_pool_th_save $swp3 8 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_save "$swp3" 8 In sch_red_core.sh line 233: devlink_port_pool_th_set $swp3 8 $size ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: devlink_port_pool_th_set "$swp3" 8 "$size" In sch_red_core.sh line 234: defer devlink_port_pool_th_restore $swp3 8 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer devlink_port_pool_th_restore "$swp3" 8 In sch_red_core.sh line 251: h3_mac=$(mac_get $h3) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h3_mac=$(mac_get "$h3") In sch_red_core.sh line 263: ping_test $h1.10 $(ipaddr 3 10) " from host 1, vlan 10" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".10 $(ipaddr 3 10) " from host 1, vlan 10" In sch_red_core.sh line 264: ping_test $h1.11 $(ipaddr 3 11) " from host 1, vlan 11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".11 $(ipaddr 3 11) " from host 1, vlan 11" In sch_red_core.sh line 265: ping_test $h2.10 $(ipaddr 3 10) " from host 2, vlan 10" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h2".10 $(ipaddr 3 10) " from host 2, vlan 10" In sch_red_core.sh line 266: ping_test $h2.11 $(ipaddr 3 11) " from host 2, vlan 11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h2".11 $(ipaddr 3 11) " from host 2, vlan 11" In sch_red_core.sh line 280: local tc=$(get_tc $vlan) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local tc=$(get_tc "$vlan") In sch_red_core.sh line 291: qdisc_stats_get $swp3 $(get_qdisc_handle $vlan) .backlog ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qdisc_stats_get "$swp3" $(get_qdisc_handle "$vlan") .backlog In sch_red_core.sh line 298: local tc=$(($(get_tc $vlan) + 8)) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local tc=$(($(get_tc "$vlan") + 8)) In sch_red_core.sh line 299: ethtool_stats_get $swp3 tc_transmit_queue_tc_$tc ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool_stats_get "$swp3" tc_transmit_queue_tc_$tc In sch_red_core.sh line 306: ethtool_stats_get $swp3 ecn_marked ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool_stats_get "$swp3" ecn_marked In sch_red_core.sh line 314: qdisc_stats_get $swp3 $(get_qdisc_handle $vlan) .marked ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qdisc_stats_get "$swp3" $(get_qdisc_handle "$vlan") .marked In sch_red_core.sh line 322: qdisc_stats_get $swp3 $(get_qdisc_handle $vlan) .packets ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qdisc_stats_get "$swp3" $(get_qdisc_handle "$vlan") .packets In sch_red_core.sh line 331: $MZ $h2.$vlan -p 8000 -a own -b $h3_mac \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h2"."$vlan" -p 8000 -a own -b "$h3_mac" \ In sch_red_core.sh line 332: -A $(ipaddr 2 $vlan) -B $(ipaddr 3 $vlan) \ ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -A $(ipaddr 2 "$vlan") -B $(ipaddr 3 "$vlan") \ In sch_red_core.sh line 333: -t $proto -q -c $pkts "$@" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -t "$proto" -q -c "$pkts" "$@" In sch_red_core.sh line 352: local cur=$(busywait 1100 until_counter_is "> $cur" \ ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red_core.sh line 353: get_qdisc_backlog $vlan) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: get_qdisc_backlog "$vlan") In sch_red_core.sh line 358: echo $cur ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$cur" In sch_red_core.sh line 361: echo $cur ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$cur" In sch_red_core.sh line 365: send_packets $vlan $proto $pkts "$@" ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_packets "$vlan" "$proto" $pkts "$@" In sch_red_core.sh line 375: local npackets_0=$(get_qdisc_npackets $vlan) ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local npackets_0=$(get_qdisc_npackets "$vlan") In sch_red_core.sh line 376: local nmarked_0=$($get_nmarked $vlan) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local nmarked_0=$($get_nmarked "$vlan") In sch_red_core.sh line 378: local npackets_1=$(get_qdisc_npackets $vlan) ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local npackets_1=$(get_qdisc_npackets "$vlan") In sch_red_core.sh line 379: local nmarked_1=$($get_nmarked $vlan) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local nmarked_1=$($get_nmarked "$vlan") In sch_red_core.sh line 386: ((pct $cond)) ^-- SC1105 (error): Shells disambiguate (( differently or not at all. For subshell, add spaces around ( . For ((, fix parsing errors. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ((pct "$cond")) In sch_red_core.sh line 403: backlog=$(build_backlog $vlan $((2 * limit / 3)) udp) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: backlog=$(build_backlog "$vlan" $((2 * limit / 3)) udp) In sch_red_core.sh line 405: pct=$(check_marking "$get_nmarked" $vlan "== 0") ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pct=$(check_marking "$get_nmarked" "$vlan" "== 0") In sch_red_core.sh line 413: backlog=$(build_backlog $vlan $((3 * limit / 2)) tcp tos=0x01) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: backlog=$(build_backlog "$vlan" $((3 * limit / 2)) tcp tos=0x01) In sch_red_core.sh line 415: pct=$(check_marking "$get_nmarked" $vlan ">= 95") ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pct=$(check_marking "$get_nmarked" "$vlan" ">= 95") In sch_red_core.sh line 427: start_tcp_traffic $h1.$vlan $(ipaddr 1 $vlan) $(ipaddr 3 $vlan) \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_tcp_traffic "$h1"."$vlan" $(ipaddr 1 "$vlan") $(ipaddr 3 "$vlan") \ In sch_red_core.sh line 428: $h3_mac tos=0x01 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$h3_mac" tos=0x01 In sch_red_core.sh line 432: ecn_test_common "$name" "$get_nmarked" $vlan $limit ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ecn_test_common "$name" "$get_nmarked" "$vlan" "$limit" In sch_red_core.sh line 438: build_backlog $vlan $((2 * limit)) udp >/dev/null ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: build_backlog "$vlan" $((2 * limit)) udp >/dev/null In sch_red_core.sh line 468: start_tcp_traffic $h1.$vlan $(ipaddr 1 $vlan) $(ipaddr 3 $vlan) \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_tcp_traffic "$h1"."$vlan" $(ipaddr 1 "$vlan") $(ipaddr 3 "$vlan") \ In sch_red_core.sh line 469: $h3_mac tos=0x01 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$h3_mac" tos=0x01 In sch_red_core.sh line 473: ecn_test_common "$name" get_nmarked $vlan $limit ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ecn_test_common "$name" get_nmarked "$vlan" "$limit" In sch_red_core.sh line 479: build_backlog $vlan $((2 * limit)) udp >/dev/null ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: build_backlog "$vlan" $((2 * limit)) udp >/dev/null In sch_red_core.sh line 499: start_tcp_traffic $h1.$vlan $(ipaddr 1 $vlan) $(ipaddr 3 $vlan) \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_tcp_traffic "$h1"."$vlan" $(ipaddr 1 "$vlan") $(ipaddr 3 "$vlan") \ In sch_red_core.sh line 500: $h3_mac tos=0x01 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$h3_mac" tos=0x01 In sch_red_core.sh line 505: backlog=$(build_backlog $vlan $((2 * limit / 3)) tcp tos=0x01) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: backlog=$(build_backlog "$vlan" $((2 * limit / 3)) tcp tos=0x01) In sch_red_core.sh line 507: pct=$(check_marking get_nmarked $vlan "== 0") ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pct=$(check_marking get_nmarked "$vlan" "== 0") In sch_red_core.sh line 513: backlog=$(build_backlog $vlan $((3 * limit / 2)) tcp tos=0x01) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: backlog=$(build_backlog "$vlan" $((3 * limit / 2)) tcp tos=0x01) In sch_red_core.sh line 515: pct=$(check_marking get_nmarked $vlan "== 0") ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pct=$(check_marking get_nmarked "$vlan" "== 0") In sch_red_core.sh line 517: backlog=$(get_qdisc_backlog $vlan) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: backlog=$(get_qdisc_backlog "$vlan") In sch_red_core.sh line 540: start_tcp_traffic $h1.$vlan $(ipaddr 1 $vlan) $(ipaddr 3 $vlan) bc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_tcp_traffic "$h1"."$vlan" $(ipaddr 1 "$vlan") $(ipaddr 3 "$vlan") bc In sch_red_core.sh line 543: start_tcp_traffic $h2.$vlan $(ipaddr 2 $vlan) $(ipaddr 3 $vlan) bc ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_tcp_traffic "$h2"."$vlan" $(ipaddr 2 "$vlan") $(ipaddr 3 "$vlan") bc In sch_red_core.sh line 546: qbl=$(busywait 5000 until_counter_is ">= 500000" \ ^-^ SC2034 (warning): qbl appears unused. Verify use (or export if used externally). In sch_red_core.sh line 547: get_qdisc_backlog $vlan) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: get_qdisc_backlog "$vlan") In sch_red_core.sh line 553: ebl=$(busywait 5000 until_counter_is ">= 500000" \ ^-^ SC2034 (warning): ebl appears unused. Verify use (or export if used externally). In sch_red_core.sh line 554: get_mc_transmit_queue $vlan) ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: get_mc_transmit_queue "$vlan") In sch_red_core.sh line 579: start_tcp_traffic $h1.$vlan $(ipaddr 1 $vlan) $(ipaddr 3 $vlan) \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_tcp_traffic "$h1"."$vlan" $(ipaddr 1 "$vlan") $(ipaddr 3 "$vlan") \ In sch_red_core.sh line 580: $h3_mac tos=0x01 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$h3_mac" tos=0x01 In sch_red_core.sh line 584: qevent_rule_install_$subtest ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qevent_rule_install_"$subtest" In sch_red_core.sh line 586: build_backlog $vlan $((2 * limit / 3)) tcp tos=0x01 >/dev/null ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: build_backlog "$vlan" $((2 * limit / 3)) tcp tos=0x01 >/dev/null In sch_red_core.sh line 590: $fetch_counter) ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$fetch_counter") In sch_red_core.sh line 595: build_backlog $vlan $((3 * limit / 2)) tcp tos=0x01 >/dev/null ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: build_backlog "$vlan" $((3 * limit / 2)) tcp tos=0x01 >/dev/null In sch_red_core.sh line 597: $fetch_counter > /dev/null ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$fetch_counter" > /dev/null In sch_red_core.sh line 601: qevent_rule_uninstall_$subtest ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qevent_rule_uninstall_"$subtest" In sch_red_core.sh line 603: $fetch_counter > /dev/null ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$fetch_counter" > /dev/null In sch_red_core.sh line 631: RET=0 ^-^ SC2034 (warning): RET appears unused. Verify use (or export if used externally). In sch_red_core.sh line 633: start_traffic $h1.$vlan $(ipaddr 1 $vlan) $(ipaddr 3 $vlan) $h3_mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1"."$vlan" $(ipaddr 1 "$vlan") $(ipaddr 3 "$vlan") "$h3_mac" In sch_red_core.sh line 637: qevent_rule_install_$subtest ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qevent_rule_install_"$subtest" In sch_red_core.sh line 640: build_backlog $vlan $((2 * limit / 3)) udp >/dev/null ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: build_backlog "$vlan" $((2 * limit / 3)) udp >/dev/null In sch_red_core.sh line 642: busywait 1100 until_counter_is ">= $((base + 1))" $fetch_counter >/dev/null ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: busywait 1100 until_counter_is ">= $((base + 1))" "$fetch_counter" >/dev/null In sch_red_core.sh line 648: build_backlog $vlan $((3 * limit / 2)) udp >/dev/null ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: build_backlog "$vlan" $((3 * limit / 2)) udp >/dev/null In sch_red_core.sh line 651: send_packets $vlan udp 100 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_packets "$vlan" udp 100 In sch_red_core.sh line 653: now=$(busywait 1100 until_counter_is ">= $((base + 95))" $fetch_counter) ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: now=$(busywait 1100 until_counter_is ">= $((base + 95))" "$fetch_counter") In sch_red_core.sh line 658: $fetch_counter >/dev/null ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$fetch_counter" >/dev/null In sch_red_core.sh line 662: qevent_rule_uninstall_$subtest ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qevent_rule_uninstall_"$subtest" In sch_red_core.sh line 663: send_packets $vlan udp 100 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_packets "$vlan" udp 100 In sch_red_core.sh line 665: $fetch_counter) ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$fetch_counter") In sch_red_core.sh line 680: action mirred egress mirror dev $swp2 hw_stats disabled ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: action mirred egress mirror dev "$swp2" hw_stats disabled In sch_red_core.sh line 699: tc filter add dev $h2 ingress pref 1 handle 101 prot ip \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress pref 1 handle 101 prot ip \ In sch_red_core.sh line 706: tc filter del dev $h2 ingress pref 1 handle 101 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress pref 1 handle 101 flower In sch_red_core.sh line 714: tc filter add dev $h2 ingress pref 1 handle 101 prot ip \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress pref 1 handle 101 prot ip \ In sch_red_core.sh line 720: $(: should_fail=)0 ^---------------^ SC2046 (warning): Quote this to prevent word splitting. In sch_red_core.sh line 722: tc filter del dev $h2 ingress pref 1 handle 101 flower ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$h2" ingress pref 1 handle 101 flower For more information: https://www.shellcheck.net/wiki/SC1105 -- Shells disambiguate (( differentl... https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y... https://www.shellcheck.net/wiki/SC2034 -- CHECK_TC appears unused. Verify u... Checking tools/testing/selftests/net/forwarding/bridge_activity_notify.sh - 4b25b7f31c0402b456b678840d313b3e1670b579a4a63da34db9448f6b1ecadd Checking tools/testing/selftests/net/forwarding/bridge_fdb_local_vlan_0.sh - eb4b9d40065ea6bedb08db2f927c7c68c9e183e694b90fda2fd0107282573fb6 Checking tools/testing/selftests/net/forwarding/lib.sh - e1a847ed4d4592e29820ec7d4d0de16c1b815b225d7508d588b8b4f99ffa9610 In lib.sh line 97: basename `realpath $driver_path` ^---------------------^ SC2046 (warning): Quote this to prevent word splitting. ^---------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: basename $(realpath "$driver_path") In lib.sh line 103: local ifnames=`ip -j link show | jq -r ".[].ifname"` ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: local ifnames=$(ip -j link show | jq -r ".[].ifname") In lib.sh line 108: local driver_name=`driver_name_get $ifname` ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-----------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local driver_name=$(driver_name_get "$ifname") In lib.sh line 109: if [[ ! -z $driver_name && $driver_name == $NETIF_FIND_DRIVER ]]; then ^-- SC2236 (style): Use -n instead of ! -z. ^----------------^ SC2053 (warning): Quote the right-hand side of == in [[ ]] to prevent glob matching. In lib.sh line 128: source "$net_forwarding_dir/forwarding.config" ^-- SC1091 (info): Not following: ./forwarding.config: openBinaryFile: does not exist (No such file or directory) In lib.sh line 139: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 149: tc filter add dev $dev ingress pref 1 handle 1 flower \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$dev" ingress pref 1 handle 1 flower \ In lib.sh line 151: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 155: tc filter del dev $dev ingress pref 1 handle 1 flower \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$dev" ingress pref 1 handle 1 flower \ In lib.sh line 164: tc filter add dev $dev ingress protocol mpls_uc pref 1 handle 1 \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$dev" ingress protocol mpls_uc pref 1 handle 1 \ In lib.sh line 166: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 170: tc filter del dev $dev ingress protocol mpls_uc pref 1 handle 1 \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$dev" ingress protocol mpls_uc pref 1 handle 1 \ In lib.sh line 180: tc filter add dev $dev ingress protocol mpls_uc pref 1 handle 1 \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$dev" ingress protocol mpls_uc pref 1 handle 1 \ In lib.sh line 184: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 189: tc -j filter show dev $dev ingress protocol mpls_uc | jq . &> /dev/null ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc -j filter show dev "$dev" ingress protocol mpls_uc | jq . &> /dev/null In lib.sh line 191: tc filter del dev $dev ingress protocol mpls_uc pref 1 handle 1 \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$dev" ingress protocol mpls_uc pref 1 handle 1 \ In lib.sh line 203: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 212: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 221: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 230: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 239: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 248: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 257: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 268: [ 0 -ne $(ethtool --json -S $dev --all-groups --src pmac 2>/dev/null \ ^-- SC2046 (warning): Quote this to prevent word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: [ 0 -ne $(ethtool --json -S "$dev" --all-groups --src pmac 2>/dev/null \ In lib.sh line 297: local driver_name=`driver_name_get $dev` ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local driver_name=$(driver_name_get "$dev") In lib.sh line 299: if [[ $driver_name != $expected ]]; then ^-------^ SC2053 (warning): Quote the right-hand side of != in [[ ]] to prevent glob matching. In lib.sh line 312: local version="$(msend -v)" ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 316: major=$(echo $version | cut -d. -f1) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: major=$(echo "$version" | cut -d. -f1) In lib.sh line 318: if [ $major -lt 3 ]; then ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$major" -lt 3 ]; then In lib.sh line 328: require_command $MZ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: require_command "$MZ" In lib.sh line 331: require_command $TEAMD ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: require_command "$TEAMD" In lib.sh line 364: echo "SKIP: Importer requires $NUM_NETIFS NETIFS, but only ${#NETIFS[@]} are defined (${NETIFS[@]})" ^----------^ SC2145 (error): Argument mixes string and array. Use * or separate argument. In lib.sh line 382: if [ -z ${NETIFS[p$i]} ]; then ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ -z "${NETIFS[p$i]}" ]; then In lib.sh line 387: ip link show dev ${NETIFS[p$i]} &> /dev/null ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link show dev "${NETIFS[p$i]}" &> /dev/null In lib.sh line 388: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 389: ip link add ${NETIFS[p$i]} type veth \ ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add "${NETIFS[p$i]}" type veth \ In lib.sh line 390: peer name ${NETIFS[p$j]} ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: peer name "${NETIFS[p$j]}" In lib.sh line 391: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 405: *) echo "Can not create interfaces of type \'$NETIF_TYPE\'" ^-- SC2028 (info): echo may not expand escape sequences. Use printf. In lib.sh line 421: MAC_ADDR_ORIG["$dev"]=$(ip -j link show dev $dev | jq -e '.[].address') ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: MAC_ADDR_ORIG["$dev"]=$(ip -j link show dev "$dev" | jq -e '.[].address') In lib.sh line 424: ip link set dev $dev address $new_addr ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev" address "$new_addr" In lib.sh line 434: ip link set dev $dev address ${MAC_ADDR_ORIG["$dev"]} ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev" address "${MAC_ADDR_ORIG["$dev"]}" In lib.sh line 447: ip link show dev ${NETIFS[p$i]} &> /dev/null ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link show dev "${NETIFS[p$i]}" &> /dev/null In lib.sh line 448: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 460: [[ $? != 0 ]] ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 468: for cur in ${arr[@]}; do ^-------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In lib.sh line 474: echo $max ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$max" In lib.sh line 490: $@ | grep $addr | grep $flag "$word" ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $@ | grep "$addr" | grep "$flag" "$word" In lib.sh line 513: setup_wait_dev_with_timeout "$dev" $INTERFACE_TIMEOUT $wait_time ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_wait_dev_with_timeout "$dev" "$INTERFACE_TIMEOUT" "$wait_time" In lib.sh line 515: if (($?)); then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 529: for ((i = 1; i <= $max_iterations; ++i)); do ^-------------^ SC2004 (style): $/${} is unnecessary on arithmetic variables. In lib.sh line 530: ip link show dev $dev up \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link show dev "$dev" up \ In lib.sh line 532: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 535: sleep $wait_time ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sleep "$wait_time" In lib.sh line 549: setup_wait_dev ${NETIFS[p$i]} 0 ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: setup_wait_dev "${NETIFS[p$i]}" 0 In lib.sh line 553: sleep $WAIT_TIME ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sleep "$WAIT_TIME" In lib.sh line 566: slowwait $timeout ip link show dev $dev &> /dev/null ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: slowwait "$timeout" ip link show dev "$dev" &> /dev/null In lib.sh line 567: if (( $? )); then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 570: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" In lib.sh line 578: read ^--^ SC2162 (info): read without -r will mangle backslashes. In lib.sh line 624: return ${__TB_IDS[$vrf_name]} ^--------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: return "${__TB_IDS[$vrf_name]}" In lib.sh line 632: __vrf_td_id_assign $vrf_name ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __vrf_td_id_assign "$vrf_name" In lib.sh line 635: ip link add dev $vrf_name type vrf table $tb_id ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add dev "$vrf_name" type vrf table $tb_id In lib.sh line 645: __vrf_td_id_lookup $vrf_name ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __vrf_td_id_lookup "$vrf_name" In lib.sh line 650: ip link del dev $vrf_name ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link del dev "$vrf_name" In lib.sh line 664: ip address $add_del $addrstr dev $if_name ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip address "$add_del" "$addrstr" dev "$if_name" In lib.sh line 674: ip link set dev $if_name master $vrf_name ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$if_name" master "$vrf_name" In lib.sh line 675: ip link set dev $if_name up ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$if_name" up In lib.sh line 677: __addr_add_del $if_name add "${addrs[@]}" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __addr_add_del "$if_name" add "${addrs[@]}" In lib.sh line 685: __addr_add_del $if_name del "${addrs[@]}" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __addr_add_del "$if_name" del "${addrs[@]}" In lib.sh line 687: ip link set dev $if_name down ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$if_name" down In lib.sh line 688: ip link set dev $if_name nomaster ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$if_name" nomaster In lib.sh line 701: vrf_create $vrf_name ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vrf_create "$vrf_name" In lib.sh line 702: ip link set dev $vrf_name up ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$vrf_name" up In lib.sh line 703: __simple_if_init $if_name $vrf_name "${array[@]}" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __simple_if_init "$if_name" "$vrf_name" "${array[@]}" In lib.sh line 716: __simple_if_fini $if_name "${array[@]}" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __simple_if_fini "$if_name" "${array[@]}" In lib.sh line 717: vrf_destroy $vrf_name ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vrf_destroy "$vrf_name" In lib.sh line 727: ip link add name $name type $type \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add name "$name" type "$type" \ In lib.sh line 728: local $local remote $remote "$@" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local "$local" remote "$remote" "$@" In lib.sh line 729: ip link set dev $name up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$name" up In lib.sh line 736: ip link del dev $name ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link del dev "$name" In lib.sh line 747: ip link add name $name link $if_name type vlan id $vid ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add name "$name" link "$if_name" type vlan id "$vid" In lib.sh line 749: ip link set dev $name master $vrf ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$name" master "$vrf" In lib.sh line 751: ip link set dev $name up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$name" up In lib.sh line 752: __addr_add_del $name add "${ips[@]}" ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __addr_add_del "$name" add "${ips[@]}" In lib.sh line 761: ip link del dev $name ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link del dev "$name" In lib.sh line 769: require_command $TEAMD ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: require_command "$TEAMD" In lib.sh line 770: $TEAMD -t $if_name -d -c '{"runner": {"name": "'$mode'"}}' ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $TEAMD -t "$if_name" -d -c '{"runner": {"name": "'"$mode"'"}}' In lib.sh line 772: ip link set dev $slave down ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$slave" down In lib.sh line 773: ip link set dev $slave master $if_name ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$slave" master "$if_name" In lib.sh line 774: ip link set dev $slave up ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$slave" up In lib.sh line 776: ip link set dev $if_name up ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$if_name" up In lib.sh line 783: $TEAMD -t $if_name -k ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $TEAMD -t "$if_name" -k In lib.sh line 790: ip -j link show dev $if_name | jq -r '.[]["master"]' ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -j link show dev "$if_name" | jq -r '.[]["master"]' In lib.sh line 799: ip -j -s link show dev $if_name \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -j -s link show dev "$if_name" \ In lib.sh line 800: | jq '.[]["stats64"]["'$dir'"]["'$stat'"]' ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: | jq '.[]["stats64"]["'"$dir"'"]["'"$stat"'"]' In lib.sh line 805: link_stats_get $1 tx packets ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: link_stats_get "$1" tx packets In lib.sh line 810: link_stats_get $1 rx errors ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: link_stats_get "$1" rx errors In lib.sh line 818: ethtool -S $dev | grep "^ *$stat:" | head -n 1 | cut -d: -f2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool -S "$dev" | grep "^ *$stat:" | head -n 1 | cut -d: -f2 In lib.sh line 828: ethtool --json -S $dev --groups $grp -- --src $src | \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool --json -S "$dev" --groups "$grp" -- --src "$src" | \ In lib.sh line 829: jq '.[]."'"$grp"'"."'$name'"' ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: jq '.[]."'"$grp"'"."'"$name"'"' In lib.sh line 857: cat /proc/net/dev_snmp6/$dev | grep "^$stat" | cut -f2 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cat /proc/net/dev_snmp6/"$dev" | grep "^$stat" | cut -f2 In lib.sh line 867: ip -j stats show dev $if_name group offload subgroup $suite | ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -j stats show dev "$if_name" group offload subgroup "$suite" | In lib.sh line 877: ip -j -s -s nexthop show id $group_id | ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -j -s -s nexthop show id "$group_id" | In lib.sh line 968: ip -j addr show dev $if_name | \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip -j addr show dev "$if_name" | \ In lib.sh line 979: ageing_time=$(ip -j -d link show dev $bridge \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ageing_time=$(ip -j -d link show dev "$bridge" \ In lib.sh line 989: SYSCTL_ORIG[$key]=$(sysctl -n $key) ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: SYSCTL_ORIG[$key]=$(sysctl -n "$key") In lib.sh line 998: sysctl -qw $key="$value" ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sysctl -qw "$key"="$value" In lib.sh line 1005: sysctl -qw $key="${SYSCTL_ORIG[$key]}" ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sysctl -qw "$key"="${SYSCTL_ORIG[$key]}" In lib.sh line 1026: MTU_ORIG["$dev"]=$(ip -j link show dev $dev | jq -e '.[].mtu') ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: MTU_ORIG["$dev"]=$(ip -j link show dev "$dev" | jq -e '.[].mtu') In lib.sh line 1027: ip link set dev $dev mtu $mtu ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev" mtu "$mtu" In lib.sh line 1034: ip link set dev $dev mtu ${MTU_ORIG["$dev"]} ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev" mtu "${MTU_ORIG["$dev"]}" In lib.sh line 1042: ethtool -k ${NETIFS[p$i]} \ ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ethtool -k "${NETIFS[p$i]}" \ In lib.sh line 1044: if [[ $? -ne 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. In lib.sh line 1062: tc filter add dev $dev $direction pref 1 \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$dev" "$direction" pref 1 \ In lib.sh line 1064: || tc filter add dev $dev $direction pref 1 \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: || tc filter add dev "$dev" "$direction" pref 1 \ In lib.sh line 1073: tc filter del dev $dev $direction pref 1 flower ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$dev" "$direction" pref 1 flower In lib.sh line 1084: tc filter $add_del dev "$tundev" ingress \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter "$add_del" dev "$tundev" ingress \ In lib.sh line 1085: proto ip$vsuf pref $pref \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: proto ip"$vsuf" pref "$pref" \ In lib.sh line 1086: flower ip_proto icmp$vsuf $filter \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower ip_proto icmp"$vsuf" "$filter" \ In lib.sh line 1129: tc filter $add_del dev "$dev" ingress \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter "$add_del" dev "$dev" ingress \ In lib.sh line 1130: proto 802.1q pref $pref \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: proto 802.1q pref "$pref" \ In lib.sh line 1131: flower $filter \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower "$filter" \ In lib.sh line 1160: __icmp_capture_add_del $add_del $((dscp + 100)) "" $dev \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __icmp_capture_add_del "$add_del" $((dscp + 100)) "" "$dev" \ In lib.sh line 1170: __dscp_capture_add_del add $dev $base ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __dscp_capture_add_del add "$dev" "$base" In lib.sh line 1178: __dscp_capture_add_del del $dev $base ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __dscp_capture_add_del del "$dev" "$base" In lib.sh line 1188: local t=$(tc_rule_stats_get $dev $((dscp + 100))) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t=$(tc_rule_stats_get "$dev" $((dscp + 100))) In lib.sh line 1197: tc qdisc add dev $dev clsact ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$dev" clsact In lib.sh line 1198: tc filter add dev $dev ingress \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$dev" ingress \ In lib.sh line 1244: diff=$(echo $weights_ratio - $packets_ratio | bc -l) ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: diff=$(echo "$weights_ratio" - "$packets_ratio" | bc -l) In lib.sh line 1257: ip netns exec $name bash <<-EOF ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip netns exec "$name" bash <<-EOF In lib.sh line 1274: vrf_name=$(master_name_get $if_name) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vrf_name=$(master_name_get "$if_name") In lib.sh line 1275: ip vrf exec $vrf_name \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip vrf exec "$vrf_name" \ In lib.sh line 1276: $PING $args -c $PING_COUNT -i 0.1 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$PING" "$args" -c "$PING_COUNT" -i 0.1 \ In lib.sh line 1277: -w $PING_TIMEOUT $dip &> /dev/null ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -w "$PING_TIMEOUT" "$dip" &> /dev/null In lib.sh line 1284: ping_do $1 $2 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_do "$1" "$2" In lib.sh line 1293: ping_do $1 $2 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_do "$1" "$2" In lib.sh line 1305: vrf_name=$(master_name_get $if_name) ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vrf_name=$(master_name_get "$if_name") In lib.sh line 1306: ip vrf exec $vrf_name \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip vrf exec "$vrf_name" \ In lib.sh line 1307: $PING6 $args -c $PING_COUNT -i 0.1 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$PING6" "$args" -c "$PING_COUNT" -i 0.1 \ In lib.sh line 1308: -w $PING_TIMEOUT $dip &> /dev/null ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -w "$PING_TIMEOUT" "$dip" &> /dev/null In lib.sh line 1315: ping6_do $1 $2 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping6_do "$1" "$2" In lib.sh line 1324: ping6_do $1 $2 ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping6_do "$1" "$2" In lib.sh line 1340: bridge -j fdb show br $bridge brport $br_port1 \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -j fdb show br "$bridge" brport "$br_port1" \ In lib.sh line 1347: bridge link set dev $br_port1 flood off ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge link set dev "$br_port1" flood off In lib.sh line 1349: ip link set $host1_if promisc on ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$host1_if" promisc on In lib.sh line 1350: tc qdisc add dev $host1_if ingress ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$host1_if" ingress In lib.sh line 1351: tc filter add dev $host1_if ingress protocol ip pref 1 handle 101 \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$host1_if" ingress protocol ip pref 1 handle 101 \ In lib.sh line 1354: $MZ $host2_if -c 1 -p 64 -b $mac -t ip -q ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$host2_if" -c 1 -p 64 -b $mac -t ip -q In lib.sh line 1357: tc -j -s filter show dev $host1_if ingress \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc -j -s filter show dev "$host1_if" ingress \ In lib.sh line 1362: $MZ $host1_if -c 1 -p 64 -a $mac -t ip -q ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$host1_if" -c 1 -p 64 -a $mac -t ip -q In lib.sh line 1365: bridge -j fdb show br $bridge brport $br_port1 \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -j fdb show br "$bridge" brport "$br_port1" \ In lib.sh line 1369: $MZ $host2_if -c 1 -p 64 -b $mac -t ip -q ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$host2_if" -c 1 -p 64 -b $mac -t ip -q In lib.sh line 1372: tc -j -s filter show dev $host1_if ingress \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc -j -s filter show dev "$host1_if" ingress \ In lib.sh line 1379: ageing_time=$(bridge_ageing_time_get $bridge) ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ageing_time=$(bridge_ageing_time_get "$bridge") In lib.sh line 1382: bridge -j fdb show br $bridge brport $br_port1 \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -j fdb show br "$bridge" brport "$br_port1" \ In lib.sh line 1386: bridge link set dev $br_port1 learning off ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge link set dev "$br_port1" learning off In lib.sh line 1388: $MZ $host1_if -c 1 -p 64 -a $mac -t ip -q ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$host1_if" -c 1 -p 64 -a $mac -t ip -q In lib.sh line 1391: bridge -j fdb show br $bridge brport $br_port1 \ ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge -j fdb show br "$bridge" brport "$br_port1" \ In lib.sh line 1395: bridge link set dev $br_port1 learning on ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge link set dev "$br_port1" learning on In lib.sh line 1397: tc filter del dev $host1_if ingress protocol ip pref 1 handle 101 flower ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$host1_if" ingress protocol ip pref 1 handle 101 flower In lib.sh line 1398: tc qdisc del dev $host1_if ingress ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$host1_if" ingress In lib.sh line 1399: ip link set $host1_if promisc off ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$host1_if" promisc off In lib.sh line 1401: bridge link set dev $br_port1 flood on ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge link set dev "$br_port1" flood on In lib.sh line 1417: ip link set $host2_if promisc on ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$host2_if" promisc on In lib.sh line 1418: tc qdisc add dev $host2_if ingress ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$host2_if" ingress In lib.sh line 1419: tc filter add dev $host2_if ingress protocol ip pref 1 handle 101 \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$host2_if" ingress protocol ip pref 1 handle 101 \ In lib.sh line 1420: flower dst_mac $mac action drop ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower dst_mac "$mac" action drop In lib.sh line 1422: $MZ $host1_if -c 1 -p 64 -b $mac -B $ip -t ip -q ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$host1_if" -c 1 -p 64 -b "$mac" -B "$ip" -t ip -q In lib.sh line 1425: tc -j -s filter show dev $host2_if ingress \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc -j -s filter show dev "$host2_if" ingress \ In lib.sh line 1433: tc filter del dev $host2_if ingress protocol ip pref 1 handle 101 flower ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$host2_if" ingress protocol ip pref 1 handle 101 flower In lib.sh line 1434: tc qdisc del dev $host2_if ingress ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$host2_if" ingress In lib.sh line 1435: ip link set $host2_if promisc off ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$host2_if" promisc off In lib.sh line 1450: bridge link set dev $br_port flood off ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge link set dev "$br_port" flood off In lib.sh line 1452: flood_test_do false $mac $ip $host1_if $host2_if ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_test_do false $mac $ip "$host1_if" "$host2_if" In lib.sh line 1455: bridge link set dev $br_port flood on ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge link set dev "$br_port" flood on In lib.sh line 1457: flood_test_do true $mac $ip $host1_if $host2_if ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_test_do true $mac $ip "$host1_if" "$host2_if" In lib.sh line 1473: bridge link set dev $br_port mcast_flood off ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge link set dev "$br_port" mcast_flood off In lib.sh line 1475: flood_test_do false $mac $ip $host1_if $host2_if ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_test_do false $mac $ip "$host1_if" "$host2_if" In lib.sh line 1478: bridge link set dev $br_port mcast_flood on ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bridge link set dev "$br_port" mcast_flood on In lib.sh line 1480: flood_test_do true $mac $ip $host1_if $host2_if ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_test_do true $mac $ip "$host1_if" "$host2_if" In lib.sh line 1493: flood_unicast_test $br_port $host1_if $host2_if ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_unicast_test "$br_port" "$host1_if" "$host2_if" In lib.sh line 1494: flood_multicast_test $br_port $host1_if $host2_if ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flood_multicast_test "$br_port" "$host1_if" "$host2_if" In lib.sh line 1507: $MZ $h_in -p $pktsize -A $sip -B $dip -c 0 \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h_in" -p "$pktsize" -A "$sip" -B "$dip" -c 0 \ In lib.sh line 1508: -a own -b $dmac -t "$proto" -q "${mz_args[@]}" & ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -a own -b "$dmac" -t "$proto" -q "${mz_args[@]}" & In lib.sh line 1521: __start_traffic $pktsize udp "$h_in" "$sip" "$dip" "$dmac" \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __start_traffic "$pktsize" udp "$h_in" "$sip" "$dip" "$dmac" \ In lib.sh line 1534: __start_traffic $pktsize tcp "$h_in" "$sip" "$dip" "$dmac" \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: __start_traffic "$pktsize" tcp "$h_in" "$sip" "$dip" "$dmac" \ In lib.sh line 1581: if [ -z $ns ]; then ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ -z "$ns" ]; then In lib.sh line 1587: if [ -z $SUDO_USER ] ; then ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ -z "$SUDO_USER" ] ; then In lib.sh line 1593: $ns_cmd tcpdump $TCPDUMP_EXTRA_FLAGS -e -n -Q in -i $if_name \ ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $ns_cmd tcpdump "$TCPDUMP_EXTRA_FLAGS" -e -n -Q in -i "$if_name" \ In lib.sh line 1594: -s 65535 -B 32768 $capuser -w ${capfile[$if_name]} \ ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -s 65535 -B 32768 "$capuser" -w "${capfile[$if_name]}" \ In lib.sh line 1614: rm ${capfile[$if_name]} ${capout[$if_name]} ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rm "${capfile[$if_name]}" "${capout[$if_name]}" In lib.sh line 1621: tcpdump -e -n -r ${capfile[$if_name]} 2>&1 ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tcpdump -e -n -r "${capfile[$if_name]}" 2>&1 In lib.sh line 1644: tc qdisc add dev $host2_if ingress ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$host2_if" ingress In lib.sh line 1645: tc filter add dev $host2_if ingress protocol $tc_proto pref 1 handle 101 \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$host2_if" ingress protocol $tc_proto pref 1 handle 101 \ In lib.sh line 1646: flower ip_proto udp dst_mac $mac action drop ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower ip_proto udp dst_mac "$mac" action drop In lib.sh line 1648: $MZ $host1_if $mz_v6arg -c 1 -p 64 -b $mac -A $src_ip -B $ip -t udp "dp=4096,sp=2048" -q ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$host1_if" $mz_v6arg -c 1 -p 64 -b "$mac" -A "$src_ip" -B "$ip" -t udp "dp=4096,sp=2048" -q In lib.sh line 1651: tc -j -s filter show dev $host2_if ingress \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc -j -s filter show dev "$host2_if" ingress \ In lib.sh line 1654: if [[ $? -eq 0 ]]; then ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. In lib.sh line 1658: tc filter del dev $host2_if ingress protocol $tc_proto pref 1 handle 101 flower ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter del dev "$host2_if" ingress protocol $tc_proto pref 1 handle 101 flower In lib.sh line 1659: tc qdisc del dev $host2_if ingress ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$host2_if" ingress In lib.sh line 1694: mcast_packet_test $TEST_GROUP_MAC $src $TEST_GROUP $h2 $h1 ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2154 (warning): h2 is referenced but not assigned. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2154 (warning): h1 is referenced but not assigned. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mcast_packet_test "$TEST_GROUP_MAC" "$src" "$TEST_GROUP" "$h2" "$h1" In lib.sh line 1696: if [ $should_fwd -eq 1 ]; then ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$should_fwd" -eq 1 ]; then In lib.sh line 1710: if [ $is_blocked -eq 1 ]; then ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ "$is_blocked" -eq 1 ]; then In lib.sh line 1735: local vrf_name=$(master_name_get $if_name) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local vrf_name=$(master_name_get "$if_name") In lib.sh line 1740: ip vrf exec $vrf_name \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip vrf exec "$vrf_name" \ In lib.sh line 1741: mreceive -g $group -I $if_name > /dev/null 2>&1 & ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mreceive -g "$group" -I "$if_name" > /dev/null 2>&1 & In lib.sh line 1756: local vrf_name=$(master_name_get $if_name) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local vrf_name=$(master_name_get "$if_name") In lib.sh line 1758: ip vrf exec $vrf_name \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip vrf exec "$vrf_name" \ In lib.sh line 1759: msend -g $groups -I $if_name -c 1 > /dev/null 2>&1 ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: msend -g "$groups" -I "$if_name" -c 1 > /dev/null 2>&1 In lib.sh line 1813: tmpfile=`mktemp /var/run/nexthoptestXXX` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. Did you mean: tmpfile=$(mktemp /var/run/nexthoptestXXX) In lib.sh line 1814: mpid=`($ip monitor $mtype > $tmpfile & echo $!) 2>/dev/null` ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mpid=$(($ip monitor "$mtype" > "$tmpfile" & echo $!) 2>/dev/null) In lib.sh line 1827: kill $mpid ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: kill "$mpid" In lib.sh line 1828: local lines=`grep '^\w' $tmpfile | wc -l` ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^---------------------------^ SC2006 (style): Use $(...) notation instead of legacy backticks `...`. ^-----------------^ SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local lines=$(grep '^\w' "$tmpfile" | wc -l) In lib.sh line 1829: test $lines -eq $el ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: test "$lines" -eq "$el" In lib.sh line 1831: rm -rf $tmpfile ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rm -rf "$tmpfile" In lib.sh line 1845: local ipmout=$(start_ip_monitor stats "$ip") ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 1846: $ip stats set dev $dev ${type}_stats on ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $ip stats set dev "$dev" "${type}"_stats on In lib.sh line 1847: stop_ip_monitor $ipmout 1 "${type}_stats enablement" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: stop_ip_monitor "$ipmout" 1 "${type}_stats enablement" In lib.sh line 1850: local ipmout=$(start_ip_monitor stats "$ip") ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 1852: stop_ip_monitor $ipmout 1 "${type}_stats installation" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: stop_ip_monitor "$ipmout" 1 "${type}_stats installation" In lib.sh line 1855: local ipmout=$(start_ip_monitor stats "$ip") ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 1857: stop_ip_monitor $ipmout 1 "${type}_stats deinstallation" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: stop_ip_monitor "$ipmout" 1 "${type}_stats deinstallation" In lib.sh line 1860: local ipmout=$(start_ip_monitor stats "$ip") ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 1861: $ip stats set dev $dev ${type}_stats off ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $ip stats set dev "$dev" "${type}"_stats off In lib.sh line 1862: stop_ip_monitor $ipmout 1 "${type}_stats disablement" ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: stop_ip_monitor "$ipmout" 1 "${type}_stats disablement" In lib.sh line 1871: printf '%02x:' ${IP//./ } | ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf '%02x:' "${IP//./ }" | In lib.sh line 1890: echo $allcol_ip | tr : '\n' | ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$allcol_ip" | tr : '\n' | In lib.sh line 1908: printf "%04x" $u16 | sed 's/^/000/;s/^.*\(..\)\(..\)$/\1:\2/' ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: printf "%04x" "$u16" | sed 's/^/000/;s/^.*\(..\)\(..\)$/\1:\2/' In lib.sh line 1947: local ckbytes=$(u16_to_bytes $checksum) ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local ckbytes=$(u16_to_bytes "$checksum") In lib.sh line 1949: echo "$payload" | sed "s/CHECKSUM/$ckbytes/g" ^-- SC2001 (style): See if you can use ${variable//search/replace} instead. In lib.sh line 1966: local nsources=$(u16_to_bytes ${#sources[@]}) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 1970: )"22:"$( : Type - Membership Report ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1971: )"00:"$( : Reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1972: )"CHECKSUM:"$( : Checksum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1973: )"00:00:"$( : Reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1974: )"00:01:"$( : Number of Group Records ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1975: )"01:"$( : Record Type - IS_IN ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1976: )"00:"$( : Aux Data Len ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1977: )"${nsources}:"$( : Number of Sources ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1978: )"$(ipv4_to_bytes $GRP):"$( : Multicast Address ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. Did you mean: )"$(ipv4_to_bytes "$GRP"):"$( : Multicast Address In lib.sh line 1980: ipv4_to_bytes $src ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ipv4_to_bytes "$src" In lib.sh line 1984: local checksum=$(payload_template_calc_checksum "$igmpv3") ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 1986: payload_template_expand_checksum "$igmpv3" $checksum ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: payload_template_expand_checksum "$igmpv3" "$checksum" In lib.sh line 1993: local payload=$(: ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 1994: )"17:"$( : Type - Leave Group ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1995: )"00:"$( : Max Resp Time - not meaningful ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1996: )"CHECKSUM:"$( : Checksum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 1997: )"$(ipv4_to_bytes $GRP)"$( : Group Address ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: )"$(ipv4_to_bytes "$GRP")"$( : Group Address In lib.sh line 1999: local checksum=$(payload_template_calc_checksum "$payload") ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 2001: payload_template_expand_checksum "$payload" $checksum ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: payload_template_expand_checksum "$payload" "$checksum" In lib.sh line 2012: local nsources=$(u16_to_bytes ${#sources[@]}) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 2015: )"3a:"$( : Next Header - ICMPv6 ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2016: )"00:"$( : Hdr Ext Len ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2021: )"8f:"$( : Type - MLDv2 Report ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2022: )"00:"$( : Code ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2023: )"CHECKSUM:"$( : Checksum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2024: )"00:00:"$( : Reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2025: )"00:01:"$( : Number of Group Records ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2026: )"01:"$( : Record Type - IS_IN ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2027: )"00:"$( : Aux Data Len ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2028: )"${nsources}:"$( : Number of Sources ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2029: )"$(ipv6_to_bytes $GRP):"$( : Multicast address ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. Did you mean: )"$(ipv6_to_bytes "$GRP"):"$( : Multicast address In lib.sh line 2031: ipv6_to_bytes $src ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ipv6_to_bytes "$src" In lib.sh line 2036: local len=$(u16_to_bytes $(payload_template_nbytes $icmpv6)) ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-- SC2046 (warning): Quote this to prevent word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local len=$(u16_to_bytes $(payload_template_nbytes "$icmpv6")) In lib.sh line 2037: local sudohdr=$(: ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 2038: )"$(ipv6_to_bytes $SIP):"$( : SIP ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. Did you mean: )"$(ipv6_to_bytes "$SIP"):"$( : SIP In lib.sh line 2039: )"$(ipv6_to_bytes $GRP):"$( : DIP is multicast address ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. Did you mean: )"$(ipv6_to_bytes "$GRP"):"$( : DIP is multicast address In lib.sh line 2040: )"${len}:"$( : Upper-layer length ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2043: local checksum=$(payload_template_calc_checksum ${sudohdr}${icmpv6}) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local checksum=$(payload_template_calc_checksum "${sudohdr}""${icmpv6}") In lib.sh line 2045: payload_template_expand_checksum "$hbh$icmpv6" $checksum ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: payload_template_expand_checksum "$hbh$icmpv6" "$checksum" In lib.sh line 2057: )"3a:"$( : Next Header - ICMPv6 ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2058: )"00:"$( : Hdr Ext Len ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2063: )"84:"$( : Type - MLDv1 Done ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2064: )"00:"$( : Code ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2065: )"CHECKSUM:"$( : Checksum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2066: )"00:00:"$( : Max Resp Delay - not meaningful ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2067: )"00:00:"$( : Reserved ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2068: )"$(ipv6_to_bytes $GRP):"$( : Multicast address ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: )"$(ipv6_to_bytes "$GRP"):"$( : Multicast address In lib.sh line 2071: local len=$(u16_to_bytes $(payload_template_nbytes $icmpv6)) ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-- SC2046 (warning): Quote this to prevent word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local len=$(u16_to_bytes $(payload_template_nbytes "$icmpv6")) In lib.sh line 2072: local sudohdr=$(: ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. In lib.sh line 2073: )"$(ipv6_to_bytes $SIP):"$( : SIP ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. Did you mean: )"$(ipv6_to_bytes "$SIP"):"$( : SIP In lib.sh line 2074: )"$(ipv6_to_bytes $GRP):"$( : DIP is multicast address ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. Did you mean: )"$(ipv6_to_bytes "$GRP"):"$( : DIP is multicast address In lib.sh line 2075: )"${len}:"$( : Upper-layer length ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. In lib.sh line 2078: local checksum=$(payload_template_calc_checksum ${sudohdr}${icmpv6}) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local checksum=$(payload_template_calc_checksum "${sudohdr}""${icmpv6}") In lib.sh line 2080: payload_template_expand_checksum "$hbh$icmpv6" $checksum ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: payload_template_expand_checksum "$hbh$icmpv6" "$checksum" In lib.sh line 2109: log_test_skip $src:$caller ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: log_test_skip "$src":"$caller" In lib.sh line 2110: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" In lib.sh line 2127: local mac_addr=$(mac_get $dev) ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local mac_addr=$(mac_get "$dev") In lib.sh line 2128: local tmp=$(ether_addr_to_u64 $mac_addr) ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local tmp=$(ether_addr_to_u64 "$mac_addr") In lib.sh line 2131: ip link set $dev up ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set "$dev" up In lib.sh line 2132: ip link add link $dev name macvlan-tmp type macvlan mode private ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add link "$dev" name macvlan-tmp type macvlan mode private In lib.sh line 2133: ip link set macvlan-tmp address $(u64_to_ether_addr $((tmp + 1))) ^-- SC2046 (warning): Quote this to prevent word splitting. In lib.sh line 2136: promisc=$(ip -j -d link show dev $dev | jq -r '.[].promiscuity') ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: promisc=$(ip -j -d link show dev "$dev" | jq -r '.[].promiscuity') For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2145 -- Argument mixes string and array. ... https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u... Checking tools/testing/selftests/net/forwarding/sch_ets_core.sh - 91c0ef3e5c7c9ac93ca1d489ed11736ec497e2186b369d2b2b4c16148a492d69 In sch_ets_core.sh line 1: # SPDX-License-Identifier: GPL-2.0 ^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. In sch_ets_core.sh line 63: source $lib_dir/lib.sh ^------^ SC2154 (warning): lib_dir is referenced but not assigned. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In sch_ets_core.sh line 64: source $lib_dir/sch_ets_tests.sh ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/sch_ets_tests.sh In sch_ets_core.sh line 82: local dst_mac=$(mac_get $h2) ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local dst_mac=$(mac_get "$h2") In sch_ets_core.sh line 85: start_traffic $h1.1$i $(sip $i) $(dip $i) $dst_mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1".1"$i" $(sip "$i") $(dip "$i") "$dst_mac" In sch_ets_core.sh line 111: local op=$(if [[ -n $QDISC_DEV ]]; then echo change; else echo add; fi) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_ets_core.sh line 113: tc qdisc $op dev $dev $PARENT handle 10: ets \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc "$op" dev "$dev" $PARENT handle 10: ets \ In sch_ets_core.sh line 114: $(if ((nstrict)); then echo strict $nstrict; fi) \ ^-- SC2046 (warning): Quote this to prevent word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(if ((nstrict)); then echo strict "$nstrict"; fi) \ In sch_ets_core.sh line 115: $(if ((${#quanta[@]})); then echo quanta ${quanta[@]}; fi) \ ^-- SC2046 (warning): Quote this to prevent word splitting. ^----------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In sch_ets_core.sh line 116: priomap $priomap ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: priomap "$priomap" In sch_ets_core.sh line 127: local op=$(if [[ -n $QDISC_DEV ]]; then echo change; else echo add; fi) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_ets_core.sh line 129: tc qdisc $op dev $dev $PARENT handle 10: ets \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc "$op" dev "$dev" $PARENT handle 10: ets \ In sch_ets_core.sh line 130: $(if ((nstrict)); then echo strict $nstrict; fi) \ ^-- SC2046 (warning): Quote this to prevent word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $(if ((nstrict)); then echo strict "$nstrict"; fi) \ In sch_ets_core.sh line 131: $(if ((${#quanta[@]})); then echo quanta ${quanta[@]}; fi) ^-- SC2046 (warning): Quote this to prevent word splitting. ^----------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In sch_ets_core.sh line 138: tc filter add dev $dev parent 10: basic \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$dev" parent 10: basic \ In sch_ets_core.sh line 159: tc qdisc del dev $QDISC_DEV $PARENT ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$QDISC_DEV" $PARENT In sch_ets_core.sh line 168: simple_if_init $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" In sch_ets_core.sh line 169: defer simple_if_fini $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h1" In sch_ets_core.sh line 171: mtu_set $h1 9900 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h1" 9900 In sch_ets_core.sh line 172: defer mtu_restore $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h1" In sch_ets_core.sh line 175: vlan_create $h1 1$i v$h1 $(sip $i)/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h1" 1"$i" v"$h1" $(sip "$i")/28 In sch_ets_core.sh line 176: defer vlan_destroy $h1 1$i ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h1" 1"$i" In sch_ets_core.sh line 177: ip link set dev $h1.1$i type vlan egress 0:$i ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$h1".1"$i" type vlan egress 0:"$i" In sch_ets_core.sh line 185: simple_if_init $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" In sch_ets_core.sh line 186: defer simple_if_fini $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h2" In sch_ets_core.sh line 188: mtu_set $h2 9900 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h2" 9900 In sch_ets_core.sh line 189: defer mtu_restore $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h2" In sch_ets_core.sh line 192: vlan_create $h2 1$i v$h2 $(dip $i)/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------^ SC2046 (warning): Quote this to prevent word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$h2" 1"$i" v"$h2" $(dip "$i")/28 In sch_ets_core.sh line 193: defer vlan_destroy $h2 1$i ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$h2" 1"$i" In sch_ets_core.sh line 201: ip link set dev $swp1 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up In sch_ets_core.sh line 202: defer ip link set dev $swp1 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1" down In sch_ets_core.sh line 204: mtu_set $swp1 9900 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp1" 9900 In sch_ets_core.sh line 205: defer mtu_restore $swp1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp1" In sch_ets_core.sh line 207: ip link set dev $swp2 up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up In sch_ets_core.sh line 208: defer ip link set dev $swp2 down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2" down In sch_ets_core.sh line 210: mtu_set $swp2 9900 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp2" 9900 In sch_ets_core.sh line 211: defer mtu_restore $swp2 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$swp2" In sch_ets_core.sh line 214: vlan_create $swp1 1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp1" 1"$i" In sch_ets_core.sh line 215: defer vlan_destroy $swp1 1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp1" 1"$i" In sch_ets_core.sh line 216: ip link set dev $swp1.1$i type vlan ingress 0:0 1:1 2:2 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".1"$i" type vlan ingress 0:0 1:1 2:2 In sch_ets_core.sh line 218: vlan_create $swp2 1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$swp2" 1"$i" In sch_ets_core.sh line 219: defer vlan_destroy $swp2 1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$swp2" 1"$i" In sch_ets_core.sh line 221: ip link add dev br1$i type bridge ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link add dev br1"$i" type bridge In sch_ets_core.sh line 222: defer ip link del dev br1$i ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link del dev br1"$i" In sch_ets_core.sh line 224: ip link set dev $swp1.1$i master br1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".1"$i" master br1"$i" In sch_ets_core.sh line 225: defer ip link set dev $swp1.1$i nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1".1"$i" nomaster In sch_ets_core.sh line 227: ip link set dev $swp2.1$i master br1$i ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2".1"$i" master br1"$i" In sch_ets_core.sh line 228: defer ip link set dev $swp2.1$i nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2".1"$i" nomaster In sch_ets_core.sh line 230: ip link set dev br1$i up ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev br1"$i" up In sch_ets_core.sh line 231: defer ip link set dev br1$i down ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev br1"$i" down In sch_ets_core.sh line 233: ip link set dev $swp1.1$i up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".1"$i" up In sch_ets_core.sh line 234: defer ip link set dev $swp1.1$i down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1".1"$i" down In sch_ets_core.sh line 236: ip link set dev $swp2.1$i up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2".1"$i" up In sch_ets_core.sh line 237: defer ip link set dev $swp2.1$i down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2".1"$i" down In sch_ets_core.sh line 252: hut=$h2 ^-^ SC2034 (warning): hut appears unused. Verify use (or export if used externally). In sch_ets_core.sh line 263: ping_test $h1.10 $(dip 0) " vlan 10" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".10 $(dip 0) " vlan 10" In sch_ets_core.sh line 264: ping_test $h1.11 $(dip 1) " vlan 11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".11 $(dip 1) " vlan 11" In sch_ets_core.sh line 265: ping_test $h1.12 $(dip 2) " vlan 12" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".12 $(dip 2) " vlan 12" In sch_ets_core.sh line 277: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y... https://www.shellcheck.net/wiki/SC2034 -- hut appears unused. Verify use (o... Checking tools/testing/selftests/net/forwarding/sch_red.sh - b974d6ed50fb0f56318fae59a2628612b268dbe080393d0ce1a7bcacbbcc561b In sch_red.sh line 55: simple_if_init $h1 192.0.2.1/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" 192.0.2.1/28 In sch_red.sh line 56: defer simple_if_fini $h1 192.0.2.1/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h1" 192.0.2.1/28 In sch_red.sh line 58: mtu_set $h1 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h1" 10000 In sch_red.sh line 59: defer mtu_restore $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h1" In sch_red.sh line 61: tc qdisc replace dev $h1 root handle 1: tbf \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$h1" root handle 1: tbf \ In sch_red.sh line 63: defer tc qdisc del dev $h1 root ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$h1" root In sch_red.sh line 68: simple_if_init $h2 192.0.2.2/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h2" 192.0.2.2/28 In sch_red.sh line 69: defer simple_if_fini $h2 192.0.2.2/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h2" 192.0.2.2/28 In sch_red.sh line 71: mtu_set $h2 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h2" 10000 In sch_red.sh line 72: defer mtu_restore $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h2" In sch_red.sh line 77: simple_if_init $h3 192.0.2.3/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h3" 192.0.2.3/28 In sch_red.sh line 78: defer simple_if_fini $h3 192.0.2.3/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h3" 192.0.2.3/28 In sch_red.sh line 80: mtu_set $h3 10000 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$h3" 10000 In sch_red.sh line 81: defer mtu_restore $h3 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h3" In sch_red.sh line 89: ip link set dev $swp1 up master br ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1" up master br In sch_red.sh line 90: defer ip link set dev $swp1 down nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp1" down nomaster In sch_red.sh line 92: ip link set dev $swp2 up master br ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp2" up master br In sch_red.sh line 93: defer ip link set dev $swp2 down nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp2" down nomaster In sch_red.sh line 95: ip link set dev $swp3 up master br ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp3" up master br In sch_red.sh line 96: defer ip link set dev $swp3 down nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$swp3" down nomaster In sch_red.sh line 98: mtu_set $swp1 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp1" 10000 In sch_red.sh line 99: defer mtu_restore $h1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h1" In sch_red.sh line 101: mtu_set $swp2 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp2" 10000 In sch_red.sh line 102: defer mtu_restore $h2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h2" In sch_red.sh line 104: mtu_set $swp3 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$swp3" 10000 In sch_red.sh line 105: defer mtu_restore $h3 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$h3" In sch_red.sh line 107: tc qdisc replace dev $swp3 root handle 1: tbf \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$swp3" root handle 1: tbf \ In sch_red.sh line 109: defer tc qdisc del dev $swp3 root ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$swp3" root In sch_red.sh line 126: h3_mac=$(mac_get $h3) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h3_mac=$(mac_get "$h3") In sch_red.sh line 138: ping_test $h1 192.0.2.3 " from host 1" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h1" 192.0.2.3 " from host 1" In sch_red.sh line 139: ping_test $h2 192.0.2.3 " from host 2" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ping_test "$h2" 192.0.2.3 " from host 2" In sch_red.sh line 144: qdisc_stats_get $swp3 11: .backlog ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qdisc_stats_get "$swp3" 11: .backlog In sch_red.sh line 149: qdisc_stats_get $swp3 11: .marked ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qdisc_stats_get "$swp3" 11: .marked In sch_red.sh line 154: qdisc_stats_get $swp3 11: .packets ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: qdisc_stats_get "$swp3" 11: .packets In sch_red.sh line 167: $MZ $h2 -p $PKTSZ -a own -b $h3_mac -A 192.0.2.2 -B 192.0.2.3 -t $proto -q -c $pkts "$@" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h2" -p "$PKTSZ" -a own -b "$h3_mac" -A 192.0.2.2 -B 192.0.2.3 -t "$proto" -q -c "$pkts" "$@" In sch_red.sh line 181: local cur=$(get_qdisc_backlog) ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 186: echo $cur ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$cur" In sch_red.sh line 189: echo $cur ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$cur" In sch_red.sh line 193: send_packets $proto $pkts "$@" ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: send_packets "$proto" "$pkts" "$@" In sch_red.sh line 202: local npackets_0=$(get_qdisc_npackets) ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 203: local nmarked_0=$(get_nmarked) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 205: local npackets_1=$(get_qdisc_npackets) ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 206: local nmarked_1=$(get_nmarked) ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 212: echo $pct ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$pct" In sch_red.sh line 213: ((pct $cond)) ^-- SC1105 (error): Shells disambiguate (( differently or not at all. For subshell, add spaces around ( . For ((, fix parsing errors. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ((pct "$cond")) In sch_red.sh line 220: local npackets_0=$(get_qdisc_npackets) ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 221: local nmirrored_0=$(get_nmirrored) ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 223: local npackets_1=$(get_qdisc_npackets) ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 224: local nmirrored_1=$(get_nmirrored) ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. In sch_red.sh line 230: echo $pct ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$pct" In sch_red.sh line 231: ((pct $cond)) ^-- SC1105 (error): Shells disambiguate (( differently or not at all. For subshell, add spaces around ( . For ((, fix parsing errors. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ((pct "$cond")) In sch_red.sh line 268: $MZ $h1 -p $PKTSZ -A 192.0.2.1 -B 192.0.2.3 -c 0 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -p "$PKTSZ" -A 192.0.2.1 -B 192.0.2.3 -c 0 \ In sch_red.sh line 269: -a own -b $h3_mac -t tcp -q tos=0x01 & ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -a own -b "$h3_mac" -t tcp -q tos=0x01 & In sch_red.sh line 273: ecn_test_common "$name" $limit ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ecn_test_common "$name" "$limit" In sch_red.sh line 289: $MZ $h1 -p $PKTSZ -A 192.0.2.1 -B 192.0.2.3 -c 0 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -p "$PKTSZ" -A 192.0.2.1 -B 192.0.2.3 -c 0 \ In sch_red.sh line 290: -a own -b $h3_mac -t tcp -q tos=0x01 & ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -a own -b "$h3_mac" -t tcp -q tos=0x01 & In sch_red.sh line 294: ecn_test_common "$name" $limit ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ecn_test_common "$name" "$limit" In sch_red.sh line 313: $MZ $h1 -p $PKTSZ -A 192.0.2.1 -B 192.0.2.3 -c 0 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -p "$PKTSZ" -A 192.0.2.1 -B 192.0.2.3 -c 0 \ In sch_red.sh line 314: -a own -b $h3_mac -t tcp -q tos=0x01 & ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -a own -b "$h3_mac" -t tcp -q tos=0x01 & In sch_red.sh line 344: $MZ $h1 -p $PKTSZ -A 192.0.2.1 -B 192.0.2.3 -c 0 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -p "$PKTSZ" -A 192.0.2.1 -B 192.0.2.3 -c 0 \ In sch_red.sh line 345: -a own -b $h3_mac -t udp -q & ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -a own -b "$h3_mac" -t udp -q & In sch_red.sh line 383: $MZ $h1 -p $PKTSZ -A 192.0.2.1 -B 192.0.2.3 -c 0 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$h1" -p "$PKTSZ" -A 192.0.2.1 -B 192.0.2.3 -c 0 \ In sch_red.sh line 384: -a own -b $h3_mac -t tcp -q tos=0x01 & ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -a own -b "$h3_mac" -t tcp -q tos=0x01 & In sch_red.sh line 410: tc qdisc replace dev $swp3 parent 1:1 handle 11: red \ ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc replace dev "$swp3" parent 1:1 handle 11: red \ In sch_red.sh line 411: limit 1M avpkt $PKTSZ probability 1 \ ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: limit 1M avpkt "$PKTSZ" probability 1 \ In sch_red.sh line 412: min $BACKLOG max $((BACKLOG + 1)) burst 38 "${args[@]}" ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: min "$BACKLOG" max $((BACKLOG + 1)) burst 38 "${args[@]}" In sch_red.sh line 418: tc qdisc del dev $swp3 parent 1:1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc del dev "$swp3" parent 1:1 In sch_red.sh line 425: xfail_on_slow do_ecn_test $BACKLOG ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: xfail_on_slow do_ecn_test "$BACKLOG" In sch_red.sh line 432: xfail_on_slow do_ecn_nodrop_test $BACKLOG ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: xfail_on_slow do_ecn_nodrop_test "$BACKLOG" In sch_red.sh line 439: xfail_on_slow do_red_test $BACKLOG ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: xfail_on_slow do_red_test "$BACKLOG" In sch_red.sh line 446: xfail_on_slow do_red_qevent_test $BACKLOG ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: xfail_on_slow do_red_qevent_test "$BACKLOG" In sch_red.sh line 453: xfail_on_slow do_ecn_qevent_test $BACKLOG ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: xfail_on_slow do_ecn_qevent_test "$BACKLOG" In sch_red.sh line 463: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC1105 -- Shells disambiguate (( differentl... https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... Checking tools/testing/selftests/net/forwarding/sch_tbf_core.sh - dd0d397c1f13f03da505068dcd421716336e436161dc1694426fe293151f415e In sch_tbf_core.sh line 1: # SPDX-License-Identifier: GPL-2.0 ^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive. In sch_tbf_core.sh line 47: source $lib_dir/lib.sh ^------^ SC2154 (warning): lib_dir is referenced but not assigned. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: source "$lib_dir"/lib.sh In sch_tbf_core.sh line 62: simple_if_init $dev ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$dev" In sch_tbf_core.sh line 63: defer simple_if_fini $dev ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$dev" In sch_tbf_core.sh line 65: mtu_set $dev 10000 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$dev" 10000 In sch_tbf_core.sh line 66: defer mtu_restore $dev ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$dev" In sch_tbf_core.sh line 68: vlan_create $dev 10 v$dev $(ipaddr $host 10)/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$dev" 10 v"$dev" $(ipaddr "$host" 10)/28 In sch_tbf_core.sh line 69: defer vlan_destroy $dev 10 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$dev" 10 In sch_tbf_core.sh line 70: ip link set dev $dev.10 type vlan egress 0:0 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev".10 type vlan egress 0:0 In sch_tbf_core.sh line 72: vlan_create $dev 11 v$dev $(ipaddr $host 11)/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$dev" 11 v"$dev" $(ipaddr "$host" 11)/28 In sch_tbf_core.sh line 73: defer vlan_destroy $dev 11 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$dev" 11 In sch_tbf_core.sh line 74: ip link set dev $dev.11 type vlan egress 0:1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$dev".11 type vlan egress 0:1 In sch_tbf_core.sh line 79: host_create $h1 1 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: host_create "$h1" 1 In sch_tbf_core.sh line 84: host_create $h2 2 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: host_create "$h2" 2 In sch_tbf_core.sh line 86: tc qdisc add dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$h2" clsact In sch_tbf_core.sh line 87: defer tc qdisc del dev $h2 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$h2" clsact In sch_tbf_core.sh line 89: tc filter add dev $h2 ingress pref 1010 prot 802.1q \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress pref 1010 prot 802.1q \ In sch_tbf_core.sh line 90: flower $TCFLAGS vlan_id 10 action pass ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower "$TCFLAGS" vlan_id 10 action pass In sch_tbf_core.sh line 91: tc filter add dev $h2 ingress pref 1011 prot 802.1q \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h2" ingress pref 1011 prot 802.1q \ In sch_tbf_core.sh line 92: flower $TCFLAGS vlan_id 11 action pass ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: flower "$TCFLAGS" vlan_id 11 action pass In sch_tbf_core.sh line 107: ip link set dev $intf up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf" up In sch_tbf_core.sh line 108: defer ip link set dev $intf down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$intf" down In sch_tbf_core.sh line 110: mtu_set $intf 10000 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mtu_set "$intf" 10000 In sch_tbf_core.sh line 111: defer mtu_restore $intf ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer mtu_restore "$intf" In sch_tbf_core.sh line 114: vlan_create $intf $vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vlan_create "$intf" $vlan In sch_tbf_core.sh line 115: defer vlan_destroy $intf $vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer vlan_destroy "$intf" $vlan In sch_tbf_core.sh line 117: ip link set dev $intf.$vlan master br$vlan ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf".$vlan master br$vlan In sch_tbf_core.sh line 118: defer ip link set dev $intf.$vlan nomaster ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$intf".$vlan nomaster In sch_tbf_core.sh line 120: ip link set dev $intf.$vlan up ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$intf".$vlan up In sch_tbf_core.sh line 121: defer ip link set dev $intf.$vlan down ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer ip link set dev "$intf".$vlan down In sch_tbf_core.sh line 126: ip link set dev $swp1.$vlan type vlan ingress 0:0 1:1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: ip link set dev "$swp1".$vlan type vlan ingress 0:0 1:1 In sch_tbf_core.sh line 144: swp3=${NETIFS[p5]} ^--^ SC2034 (warning): swp3 appears unused. Verify use (or export if used externally). In sch_tbf_core.sh line 145: h3=${NETIFS[p6]} ^-- SC2034 (warning): h3 appears unused. Verify use (or export if used externally). In sch_tbf_core.sh line 147: swp4=${NETIFS[p7]} ^--^ SC2034 (warning): swp4 appears unused. Verify use (or export if used externally). In sch_tbf_core.sh line 148: swp5=${NETIFS[p8]} ^--^ SC2034 (warning): swp5 appears unused. Verify use (or export if used externally). In sch_tbf_core.sh line 150: h2_mac=$(mac_get $h2) ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: h2_mac=$(mac_get "$h2") In sch_tbf_core.sh line 161: ping_test $h1.10 $(ipaddr 2 10) " vlan 10" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".10 $(ipaddr 2 10) " vlan 10" In sch_tbf_core.sh line 162: ping_test $h1.11 $(ipaddr 2 11) " vlan 11" ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. Did you mean: ping_test "$h1".11 $(ipaddr 2 11) " vlan 11" In sch_tbf_core.sh line 169: tc_rule_stats_get $h2 10$vlan ingress .bytes ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc_rule_stats_get "$h2" 10"$vlan" ingress .bytes In sch_tbf_core.sh line 177: start_traffic $h1.$vlan $(ipaddr 1 $vlan) $(ipaddr 2 $vlan) $h2_mac ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^---------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: start_traffic "$h1"."$vlan" $(ipaddr 1 "$vlan") $(ipaddr 2 "$vlan") "$h2_mac" In sch_tbf_core.sh line 181: local t2=$(busywait_for_counter 1000 +1 tbf_get_counter $vlan) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t2=$(busywait_for_counter 1000 +1 tbf_get_counter "$vlan") In sch_tbf_core.sh line 183: local t3=$(tbf_get_counter $vlan) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local t3=$(tbf_get_counter "$vlan") In sch_tbf_core.sh line 189: local nr=$(rate $t2 $t3 10) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local nr=$(rate "$t2" "$t3" 10) In sch_tbf_core.sh line 192: xfail_on_slow check_err $? "Expected rate $(humanize $er), got $(humanize $nr), which is $nr_pct% off. Required accuracy is +-5%." ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: xfail_on_slow check_err $? "Expected rate $(humanize $er), got $(humanize "$nr"), which is $nr_pct% off. Required accuracy is +-5%." For more information: https://www.shellcheck.net/wiki/SC2148 -- Tips depend on target shell and y... https://www.shellcheck.net/wiki/SC2034 -- h3 appears unused. Verify use (or... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... Checking tools/testing/selftests/net/forwarding/vxlan_bridge_1q_mc_ul.sh - 55b8974b9512d983f0a799e4fd3181679e3083095be6248a3e44aae8bf92da20 Checking tools/testing/selftests/net/forwarding/vxlan_reserved.sh - e33a9ba82143df5f32f8b769667f1e5fcc5da104dc3f8741ba0113d3d0fc98f4 In vxlan_reserved.sh line 34: : ${VXPORT:=4789} ^-------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it. In vxlan_reserved.sh line 35: : ${ALL_TESTS:=" ^-- SC2223 (info): This default assignment may cause DoS due to globbing. Quote it. In vxlan_reserved.sh line 50: simple_if_init $h1 192.0.2.1/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$h1" 192.0.2.1/28 In vxlan_reserved.sh line 51: defer simple_if_fini $h1 192.0.2.1/28 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$h1" 192.0.2.1/28 In vxlan_reserved.sh line 53: tc qdisc add dev $h1 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc qdisc add dev "$h1" clsact In vxlan_reserved.sh line 54: defer tc qdisc del dev $h1 clsact ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc qdisc del dev "$h1" clsact In vxlan_reserved.sh line 56: tc filter add dev $h1 ingress pref 77 \ ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: tc filter add dev "$h1" ingress pref 77 \ In vxlan_reserved.sh line 58: defer tc filter del dev $h1 ingress pref 77 ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer tc filter del dev "$h1" ingress pref 77 In vxlan_reserved.sh line 66: adf_ip_link_set_addr br1 $(mac_get $swp1) ^--------------^ SC2046 (warning): Quote this to prevent word splitting. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_ip_link_set_addr br1 $(mac_get "$swp1") In vxlan_reserved.sh line 69: adf_ip_link_set_up $rp1 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_ip_link_set_up "$rp1" In vxlan_reserved.sh line 70: adf_ip_addr_add $rp1 192.0.2.17/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_ip_addr_add "$rp1" 192.0.2.17/28 In vxlan_reserved.sh line 73: adf_ip_link_set_master $swp1 br1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_ip_link_set_master "$swp1" br1 In vxlan_reserved.sh line 74: adf_ip_link_set_up $swp1 ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: adf_ip_link_set_up "$swp1" In vxlan_reserved.sh line 79: simple_if_init $rp2 192.0.2.18/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: simple_if_init "$rp2" 192.0.2.18/28 In vxlan_reserved.sh line 80: defer simple_if_fini $rp2 192.0.2.18/28 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: defer simple_if_fini "$rp2" 192.0.2.18/28 In vxlan_reserved.sh line 116: for i in ${extra_bits[@]}; do ^--------------^ SC2068 (error): Double quote array expansions to avoid re-splitting elements. In vxlan_reserved.sh line 123: bits[$((i + 32))]=$(((vni & mask) != 0)) ^---------^ SC2321 (style): Array indices are already arithmetic contexts. Prefer removing the $(( and )). Did you mean: bits[i + 32]=$(((vni & mask) != 0)) In vxlan_reserved.sh line 135: bytes+=$(printf %02x $byte): ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: bytes+=$(printf %02x "$byte"): In vxlan_reserved.sh line 138: echo ${bytes%:} ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "${bytes%:}" In vxlan_reserved.sh line 154: echo $out ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$out" In vxlan_reserved.sh line 167: local vxlan_header=$(vxlan_header_bytes $vni $reserved_bits) ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local vxlan_header=$(vxlan_header_bytes "$vni" "$reserved_bits") In vxlan_reserved.sh line 169: $MZ $dev -c $count -d 100msec -q \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: $MZ "$dev" -c "$count" -d 100msec -q \ In vxlan_reserved.sh line 170: -b $next_hop_mac -B $dest_ip \ ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: -b "$next_hop_mac" -B "$dest_ip" \ In vxlan_reserved.sh line 171: -t udp sp=23456,dp=$VXPORT,p=$(: ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-- SC2046 (warning): Quote this to prevent word splitting. Did you mean: -t udp sp=23456,dp="$VXPORT",p=$(: In vxlan_reserved.sh line 172: )"$vxlan_header:"$( : VXLAN ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 173: )"$dest_mac:"$( : ETH daddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 174: )"00:11:22:33:44:55:"$( : ETH saddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 175: )"08:00:"$( : ETH type ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 176: )"45:"$( : IP version + IHL ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 177: )"00:"$( : IP TOS ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 178: )"00:54:"$( : IP total length ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 179: )"99:83:"$( : IP identification ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 180: )"40:00:"$( : IP flags + frag off ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 181: )"40:"$( : IP TTL ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 182: )"01:"$( : IP proto ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 183: )"00:00:"$( : IP header csum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 184: )"$(ipv4_to_bytes 192.0.2.3):"$( : IP saddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 185: )"$(ipv4_to_bytes 192.0.2.1):"$( : IP daddr ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 186: )"08:"$( : ICMP type ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 187: )"00:"$( : ICMP code ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 188: )"8b:f2:"$( : ICMP csum ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 189: )"1f:6a:"$( : ICMP request identifier ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 190: )"00:01:"$( : ICMP request seq. number ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 191: )"4f:ff:c5:5b:00:00:00:00:"$( : ICMP payload ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 192: )"6d:74:0b:00:00:00:00:00:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 193: )"10:11:12:13:14:15:16:17:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 194: )"18:19:1a:1b:1c:1d:1e:1f:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 195: )"20:21:22:23:24:25:26:27:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 196: )"28:29:2a:2b:2c:2d:2e:2f:"$( : ^-- SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them. ^-- SC2046 (warning): Quote this to prevent word splitting. In vxlan_reserved.sh line 216: echo $i ^-- SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "$i" In vxlan_reserved.sh line 222: vxlan_ping_do 10 $rp2 $(mac_get $rp1) 192.0.2.17 $(mac_get $h1) 1000 ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2046 (warning): Quote this to prevent word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^------------^ SC2046 (warning): Quote this to prevent word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_do 10 "$rp2" $(mac_get "$rp1") 192.0.2.17 $(mac_get "$h1") 1000 In vxlan_reserved.sh line 228: vxlan_ping_do 1 $rp2 $(mac_get $rp1) \ ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-------------^ SC2046 (warning): Quote this to prevent word splitting. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_ping_do 1 "$rp2" $(mac_get "$rp1") \ In vxlan_reserved.sh line 229: 192.0.2.17 $(mac_get $h1) 1000 "$bit" ^------------^ SC2046 (warning): Quote this to prevent word splitting. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: 192.0.2.17 $(mac_get "$h1") 1000 "$bit" In vxlan_reserved.sh line 242: local t0=$($get_stat) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_reserved.sh line 245: check_err $? "Failure when running $@" ^-- SC2145 (error): Argument mixes string and array. Use * or separate argument. In vxlan_reserved.sh line 247: local t1=$($get_stat) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_reserved.sh line 265: local t0=$(link_stats_get vx1 rx errors) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_reserved.sh line 268: $n_allowed_bits vxlan_ping_reserved ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "$n_allowed_bits" vxlan_ping_reserved In vxlan_reserved.sh line 269: local t1=$(link_stats_get vx1 rx errors) ^-- SC2155 (warning): Declare and assign separately to avoid masking return values. In vxlan_reserved.sh line 307: local allowed_bytes=$(vxlan_header_bytes 0xffffff $bit) ^-----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local allowed_bytes=$(vxlan_header_bytes 0xffffff "$bit") In vxlan_reserved.sh line 308: local reserved_bytes=$(neg_bytes $allowed_bytes) ^------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: local reserved_bytes=$(neg_bytes "$allowed_bytes") In vxlan_reserved.sh line 311: vxlan_device_add reserved_bits 0x$reserved_bits ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: vxlan_device_add reserved_bits 0x"$reserved_bits" In vxlan_reserved.sh line 351: exit $EXIT_STATUS ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: exit "$EXIT_STATUS" For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2145 -- Argument mixes string and array. ... https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u... tools/testing/selftests/net/forwarding/bridge_activity_notify.sh is shellcheck compliant tools/testing/selftests/net/forwarding/vxlan_bridge_1q_mc_ul.sh is shellcheck compliant tools/testing/selftests/net/forwarding/bridge_fdb_local_vlan_0.sh is shellcheck compliant