ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.vS9bcdQ4iu and /tmp/tmp.bNyGvQSA7U
Tree base:
d2cb14cda6d2 ("selftests: net: lib: Rename bridge_vlan_add() to adf_*")
Now at:
d588b3989d6b ("selftests: net: vlan_bridge_binding: Rename dfr_set_binding_*() to adf_*")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/vlan_bridge_binding.sh - 62b03e4b302fe2b5de91ca98e5714f032b4653afda5976a3b9816c2df41c5328


In vlan_bridge_binding.sh line 51:
	local operstate=$(ip -j link show $dev | jq -r .[].operstate)
              ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local operstate=$(ip -j link show "$dev" | jq -r .[].operstate)


In vlan_bridge_binding.sh line 57:
	echo -n $operstate
                ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	echo -n "$operstate"


In vlan_bridge_binding.sh line 58:
	[[ $operstate == $expect ]]
                         ^-----^ SC2053 (warning): Quote the right-hand side of == in [[ ]] to prevent glob matching.


In vlan_bridge_binding.sh line 77:
	adf_ip_link_add $link.$id link $link type vlan id $id "$@"
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                       ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	adf_ip_link_add "$link"."$id" link "$link" type vlan id "$id" "$@"


In vlan_bridge_binding.sh line 101:
		adf_ip_link_set_down $dev
                                     ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		adf_ip_link_set_down "$dev"


In vlan_bridge_binding.sh line 112:
	check_operstate br.11 $opst_11
                              ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	check_operstate br.11 "$opst_11"


In vlan_bridge_binding.sh line 113:
	check_operstate br.12 $opst_12
                              ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	check_operstate br.12 "$opst_12"


In vlan_bridge_binding.sh line 114:
	check_operstate br.13 $opst_13
                              ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	check_operstate br.13 "$opst_13"


In vlan_bridge_binding.sh line 115:
	check_operstate br.14 $opst_14
                              ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	check_operstate br.14 "$opst_14"


In vlan_bridge_binding.sh line 132:
		check_operstates $opsts_d1
                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		check_operstates "$opsts_d1"


In vlan_bridge_binding.sh line 138:
		check_operstates $opsts_d2
                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		check_operstates "$opsts_d2"


In vlan_bridge_binding.sh line 144:
		check_operstates $opsts_d12
                                 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		check_operstates "$opsts_d12"


In vlan_bridge_binding.sh line 150:
		check_operstates $opsts_d123
                                 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		check_operstates "$opsts_d123"

For more information:
  https://www.shellcheck.net/wiki/SC2053 -- Quote the right-hand side of == i...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/vlan_bridge_binding.sh - 62b03e4b302fe2b5de91ca98e5714f032b4653afda5976a3b9816c2df41c5328


In vlan_bridge_binding.sh line 51:
	local operstate=$(ip -j link show $dev | jq -r .[].operstate)
              ^-------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
                                          ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	local operstate=$(ip -j link show "$dev" | jq -r .[].operstate)


In vlan_bridge_binding.sh line 57:
	echo -n $operstate
                ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	echo -n "$operstate"


In vlan_bridge_binding.sh line 58:
	[[ $operstate == $expect ]]
                         ^-----^ SC2053 (warning): Quote the right-hand side of == in [[ ]] to prevent glob matching.


In vlan_bridge_binding.sh line 77:
	adf_ip_link_add $link.$id link $link type vlan id $id "$@"
                        ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                              ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                       ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                          ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	adf_ip_link_add "$link"."$id" link "$link" type vlan id "$id" "$@"


In vlan_bridge_binding.sh line 101:
		adf_ip_link_set_down $dev
                                     ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		adf_ip_link_set_down "$dev"


In vlan_bridge_binding.sh line 112:
	check_operstate br.11 $opst_11
                              ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	check_operstate br.11 "$opst_11"


In vlan_bridge_binding.sh line 113:
	check_operstate br.12 $opst_12
                              ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	check_operstate br.12 "$opst_12"


In vlan_bridge_binding.sh line 114:
	check_operstate br.13 $opst_13
                              ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	check_operstate br.13 "$opst_13"


In vlan_bridge_binding.sh line 115:
	check_operstate br.14 $opst_14
                              ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
	check_operstate br.14 "$opst_14"


In vlan_bridge_binding.sh line 132:
		check_operstates $opsts_d1
                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		check_operstates "$opsts_d1"


In vlan_bridge_binding.sh line 138:
		check_operstates $opsts_d2
                                 ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		check_operstates "$opsts_d2"


In vlan_bridge_binding.sh line 144:
		check_operstates $opsts_d12
                                 ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		check_operstates "$opsts_d12"


In vlan_bridge_binding.sh line 150:
		check_operstates $opsts_d123
                                 ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
		check_operstates "$opsts_d123"

For more information:
  https://www.shellcheck.net/wiki/SC2053 -- Quote the right-hand side of == i...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...