pylint 3.3.7 astroid 3.3.8 Python 3.13.7 (main, Aug 14 2025, 00:00:00) [GCC 15.2.1 20250808 (Red Hat 15.2.1-1)] Redirect to /tmp/tmp.rwvNxdBp8A and /tmp/tmp.BM5WcoTE6I Tree base: 199b83a24f9e ("selftests: drv-net: psp: add basic data transfer and key rotation tests") Now at: 36e9ca6ff4cf ("selftests: drv-net: psp: add association tests") ====== Checking before the patch ====== ************* Module py tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:30:4: E0601: Using variable 'ksft_pr' before assignment (used-before-assignment) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:32:4: E0602: Undefined variable 'ktap_result' (undefined-variable) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:15:4: C0412: Imports from package net are not grouped (ungrouped-imports) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:27:4: C0412: Imports from package drivers are not grouped (ungrouped-imports) ------------------------------------------------------------------ Your code has been rated at 4.09/10 (previous run: 8.57/10, -4.48) ************* Module py tools/testing/selftests/drivers/net/lib/py/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/lib/py/__init__.py:26:4: E0601: Using variable 'ksft_pr' before assignment (used-before-assignment) tools/testing/selftests/drivers/net/lib/py/__init__.py:28:4: E0602: Undefined variable 'ktap_result' (undefined-variable) tools/testing/selftests/drivers/net/lib/py/__init__.py:31:0: C0413: Import "from .env import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:32:0: C0413: Import "from .load import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:33:0: C0413: Import "from .remote import Remote" should be placed at the top of the module (wrong-import-position) ------------------------------------------------------------------ Your code has been rated at 3.33/10 (previous run: 4.09/10, -0.76) ************* Module psp tools/testing/selftests/drivers/net/psp.py:233:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) tools/testing/selftests/drivers/net/psp.py:28:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/psp.py:80:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/psp.py:161:21: E0602: Undefined variable 'ksft_raises' (undefined-variable) tools/testing/selftests/drivers/net/psp.py:195:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/psp.py:241:15: E0601: Using variable 'srv' before assignment (used-before-assignment) ------------------------------------------------------------------ Your code has been rated at 9.11/10 (previous run: 9.11/10, +0.00) ************* Module py.ksft tools/testing/selftests/net/lib/py/ksft.py:112:0: C0301: Line too long (108/100) (line-too-long) tools/testing/selftests/net/lib/py/ksft.py:277:0: C0301: Line too long (126/100) (line-too-long) tools/testing/selftests/net/lib/py/ksft.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/net/lib/py/ksft.py:18:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:22:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:26:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:30:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:34:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:40:4: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:58:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:59:4: W0602: Using global for 'KSFT_RESULT' but no assignment is done (global-variable-not-assigned) tools/testing/selftests/net/lib/py/ksft.py:64:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:65:4: W0602: Using global for 'KSFT_RESULT' but no assignment is done (global-variable-not-assigned) tools/testing/selftests/net/lib/py/ksft.py:70:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:75:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:80:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:85:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:90:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:95:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:100:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:100:0: C0103: Class name "ksft_raises" doesn't conform to PascalCase naming style (invalid-name) tools/testing/selftests/net/lib/py/ksft.py:118:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:129:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:130:4: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:146:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:147:4: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:156:8: W0702: No exception type(s) specified (bare-except) tools/testing/selftests/net/lib/py/ksft.py:174:29: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) tools/testing/selftests/net/lib/py/ksft.py:193:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise Exception(f'failed to parse {name}') from exc' (raise-missing-from) tools/testing/selftests/net/lib/py/ksft.py:193:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/net/lib/py/ksft.py:196:8: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:205:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) tools/testing/selftests/net/lib/py/ksft.py:206:4: E0602: Undefined variable 'term_cnt' (undefined-variable) tools/testing/selftests/net/lib/py/ksft.py:207:4: R1720: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise) tools/testing/selftests/net/lib/py/ksft.py:202:15: W0613: Unused argument 'signum' (unused-argument) tools/testing/selftests/net/lib/py/ksft.py:202:23: W0613: Unused argument 'frame' (unused-argument) tools/testing/selftests/net/lib/py/ksft.py:213:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:213:0: R0914: Too many local variables (18/15) (too-many-locals) tools/testing/selftests/net/lib/py/ksft.py:225:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) tools/testing/selftests/net/lib/py/ksft.py:234:4: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:253:15: W0718: Catching too general exception BaseException (broad-exception-caught) tools/testing/selftests/net/lib/py/ksft.py:213:0: R0912: Too many branches (14/12) (too-many-branches) tools/testing/selftests/net/lib/py/ksft.py:281:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:282:4: W0602: Using global for 'KSFT_RESULT_ALL' but no assignment is done (global-variable-not-assigned) tools/testing/selftests/net/lib/py/ksft.py:3:0: W0611: Unused import builtins (unused-import) ------------------------------------------------------------------ Your code has been rated at 7.49/10 (previous run: 7.49/10, +0.00) ====== Checking the tree with the patch ====== ************* Module py tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:30:4: E0601: Using variable 'ksft_pr' before assignment (used-before-assignment) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:32:4: E0602: Undefined variable 'ktap_result' (undefined-variable) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:15:4: C0412: Imports from package net are not grouped (ungrouped-imports) tools/testing/selftests/drivers/net/hw/lib/py/__init__.py:27:4: C0412: Imports from package drivers are not grouped (ungrouped-imports) ------------------------------------------------------------------ Your code has been rated at 4.09/10 (previous run: 3.33/10, +0.76) ************* Module py tools/testing/selftests/drivers/net/lib/py/__init__.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/drivers/net/lib/py/__init__.py:26:4: E0601: Using variable 'ksft_pr' before assignment (used-before-assignment) tools/testing/selftests/drivers/net/lib/py/__init__.py:28:4: E0602: Undefined variable 'ktap_result' (undefined-variable) tools/testing/selftests/drivers/net/lib/py/__init__.py:31:0: C0413: Import "from .env import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:32:0: C0413: Import "from .load import *" should be placed at the top of the module (wrong-import-position) tools/testing/selftests/drivers/net/lib/py/__init__.py:33:0: C0413: Import "from .remote import Remote" should be placed at the top of the module (wrong-import-position) ------------------------------------------------------------------ Your code has been rated at 3.33/10 (previous run: 4.09/10, -0.76) ************* Module psp tools/testing/selftests/drivers/net/psp.py:374:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) tools/testing/selftests/drivers/net/psp.py:28:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/psp.py:87:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/drivers/net/psp.py:336:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/drivers/net/psp.py:382:15: E0601: Using variable 'srv' before assignment (used-before-assignment) ------------------------------------------------------------------ Your code has been rated at 9.61/10 (previous run: 9.11/10, +0.50) ************* Module py.ksft tools/testing/selftests/net/lib/py/ksft.py:117:0: C0301: Line too long (108/100) (line-too-long) tools/testing/selftests/net/lib/py/ksft.py:282:0: C0301: Line too long (126/100) (line-too-long) tools/testing/selftests/net/lib/py/ksft.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/testing/selftests/net/lib/py/ksft.py:18:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:22:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:26:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:30:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:34:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:40:4: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:58:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:59:4: W0602: Using global for 'KSFT_RESULT' but no assignment is done (global-variable-not-assigned) tools/testing/selftests/net/lib/py/ksft.py:64:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:65:4: W0602: Using global for 'KSFT_RESULT' but no assignment is done (global-variable-not-assigned) tools/testing/selftests/net/lib/py/ksft.py:70:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:75:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:80:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:85:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:90:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:95:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:100:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:105:0: C0115: Missing class docstring (missing-class-docstring) tools/testing/selftests/net/lib/py/ksft.py:105:0: C0103: Class name "ksft_raises" doesn't conform to PascalCase naming style (invalid-name) tools/testing/selftests/net/lib/py/ksft.py:123:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:134:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:135:4: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:151:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:152:4: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:161:8: W0702: No exception type(s) specified (bare-except) tools/testing/selftests/net/lib/py/ksft.py:179:29: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) tools/testing/selftests/net/lib/py/ksft.py:198:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise Exception(f'failed to parse {name}') from exc' (raise-missing-from) tools/testing/selftests/net/lib/py/ksft.py:198:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/testing/selftests/net/lib/py/ksft.py:201:8: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:210:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) tools/testing/selftests/net/lib/py/ksft.py:211:4: E0602: Undefined variable 'term_cnt' (undefined-variable) tools/testing/selftests/net/lib/py/ksft.py:212:4: R1720: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise) tools/testing/selftests/net/lib/py/ksft.py:207:15: W0613: Unused argument 'signum' (unused-argument) tools/testing/selftests/net/lib/py/ksft.py:207:23: W0613: Unused argument 'frame' (unused-argument) tools/testing/selftests/net/lib/py/ksft.py:218:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:218:0: R0914: Too many local variables (18/15) (too-many-locals) tools/testing/selftests/net/lib/py/ksft.py:230:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) tools/testing/selftests/net/lib/py/ksft.py:239:4: W0603: Using the global statement (global-statement) tools/testing/selftests/net/lib/py/ksft.py:258:15: W0718: Catching too general exception BaseException (broad-exception-caught) tools/testing/selftests/net/lib/py/ksft.py:218:0: R0912: Too many branches (14/12) (too-many-branches) tools/testing/selftests/net/lib/py/ksft.py:286:0: C0116: Missing function or method docstring (missing-function-docstring) tools/testing/selftests/net/lib/py/ksft.py:287:4: W0602: Using global for 'KSFT_RESULT_ALL' but no assignment is done (global-variable-not-assigned) tools/testing/selftests/net/lib/py/ksft.py:3:0: W0611: Unused import builtins (unused-import) ------------------------------------------------------------------ Your code has been rated at 7.47/10 (previous run: 7.49/10, -0.01)