====== Checking before the patch ====== ====== Checking the tree with the patch ====== New warnings added --- /tmp/tmp.rwvNxdBp8A 2025-09-24 13:57:11.065408221 -0700 +++ /tmp/tmp.BM5WcoTE6I 2025-09-24 13:57:14.966382842 -0700 @@ -9 +9 @@ -Your code has been rated at 4.09/10 (previous run: 8.57/10, -4.48) +Your code has been rated at 4.09/10 (previous run: 3.33/10, +0.76) @@ -23 +23 @@ -tools/testing/selftests/drivers/net/psp.py:233:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) +tools/testing/selftests/drivers/net/psp.py:374:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) @@ -25,4 +25,3 @@ -tools/testing/selftests/drivers/net/psp.py:80:20: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/testing/selftests/drivers/net/psp.py:161:21: E0602: Undefined variable 'ksft_raises' (undefined-variable) -tools/testing/selftests/drivers/net/psp.py:195:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/drivers/net/psp.py:241:15: E0601: Using variable 'srv' before assignment (used-before-assignment) +tools/testing/selftests/drivers/net/psp.py:87:20: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/testing/selftests/drivers/net/psp.py:336:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/drivers/net/psp.py:382:15: E0601: Using variable 'srv' before assignment (used-before-assignment) @@ -31 +30 @@ -Your code has been rated at 9.11/10 (previous run: 9.11/10, +0.00) +Your code has been rated at 9.61/10 (previous run: 9.11/10, +0.50) @@ -34,2 +33,2 @@ -tools/testing/selftests/net/lib/py/ksft.py:112:0: C0301: Line too long (108/100) (line-too-long) -tools/testing/selftests/net/lib/py/ksft.py:277:0: C0301: Line too long (126/100) (line-too-long) +tools/testing/selftests/net/lib/py/ksft.py:117:0: C0301: Line too long (108/100) (line-too-long) +tools/testing/selftests/net/lib/py/ksft.py:282:0: C0301: Line too long (126/100) (line-too-long) @@ -53,25 +52,26 @@ -tools/testing/selftests/net/lib/py/ksft.py:100:0: C0115: Missing class docstring (missing-class-docstring) -tools/testing/selftests/net/lib/py/ksft.py:100:0: C0103: Class name "ksft_raises" doesn't conform to PascalCase naming style (invalid-name) -tools/testing/selftests/net/lib/py/ksft.py:118:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/ksft.py:129:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/ksft.py:130:4: W0603: Using the global statement (global-statement) -tools/testing/selftests/net/lib/py/ksft.py:146:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/ksft.py:147:4: W0603: Using the global statement (global-statement) -tools/testing/selftests/net/lib/py/ksft.py:156:8: W0702: No exception type(s) specified (bare-except) -tools/testing/selftests/net/lib/py/ksft.py:174:29: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) -tools/testing/selftests/net/lib/py/ksft.py:193:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise Exception(f'failed to parse {name}') from exc' (raise-missing-from) -tools/testing/selftests/net/lib/py/ksft.py:193:12: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/testing/selftests/net/lib/py/ksft.py:196:8: W0603: Using the global statement (global-statement) -tools/testing/selftests/net/lib/py/ksft.py:205:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) -tools/testing/selftests/net/lib/py/ksft.py:206:4: E0602: Undefined variable 'term_cnt' (undefined-variable) -tools/testing/selftests/net/lib/py/ksft.py:207:4: R1720: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise) -tools/testing/selftests/net/lib/py/ksft.py:202:15: W0613: Unused argument 'signum' (unused-argument) -tools/testing/selftests/net/lib/py/ksft.py:202:23: W0613: Unused argument 'frame' (unused-argument) -tools/testing/selftests/net/lib/py/ksft.py:213:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/ksft.py:213:0: R0914: Too many local variables (18/15) (too-many-locals) -tools/testing/selftests/net/lib/py/ksft.py:225:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) -tools/testing/selftests/net/lib/py/ksft.py:234:4: W0603: Using the global statement (global-statement) -tools/testing/selftests/net/lib/py/ksft.py:253:15: W0718: Catching too general exception BaseException (broad-exception-caught) -tools/testing/selftests/net/lib/py/ksft.py:213:0: R0912: Too many branches (14/12) (too-many-branches) -tools/testing/selftests/net/lib/py/ksft.py:281:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/testing/selftests/net/lib/py/ksft.py:282:4: W0602: Using global for 'KSFT_RESULT_ALL' but no assignment is done (global-variable-not-assigned) +tools/testing/selftests/net/lib/py/ksft.py:100:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/ksft.py:105:0: C0115: Missing class docstring (missing-class-docstring) +tools/testing/selftests/net/lib/py/ksft.py:105:0: C0103: Class name "ksft_raises" doesn't conform to PascalCase naming style (invalid-name) +tools/testing/selftests/net/lib/py/ksft.py:123:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/ksft.py:134:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/ksft.py:135:4: W0603: Using the global statement (global-statement) +tools/testing/selftests/net/lib/py/ksft.py:151:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/ksft.py:152:4: W0603: Using the global statement (global-statement) +tools/testing/selftests/net/lib/py/ksft.py:161:8: W0702: No exception type(s) specified (bare-except) +tools/testing/selftests/net/lib/py/ksft.py:179:29: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) +tools/testing/selftests/net/lib/py/ksft.py:198:12: W0707: Consider explicitly re-raising using 'except Exception as exc' and 'raise Exception(f'failed to parse {name}') from exc' (raise-missing-from) +tools/testing/selftests/net/lib/py/ksft.py:198:12: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/testing/selftests/net/lib/py/ksft.py:201:8: W0603: Using the global statement (global-statement) +tools/testing/selftests/net/lib/py/ksft.py:210:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) +tools/testing/selftests/net/lib/py/ksft.py:211:4: E0602: Undefined variable 'term_cnt' (undefined-variable) +tools/testing/selftests/net/lib/py/ksft.py:212:4: R1720: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise) +tools/testing/selftests/net/lib/py/ksft.py:207:15: W0613: Unused argument 'signum' (unused-argument) +tools/testing/selftests/net/lib/py/ksft.py:207:23: W0613: Unused argument 'frame' (unused-argument) +tools/testing/selftests/net/lib/py/ksft.py:218:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/ksft.py:218:0: R0914: Too many local variables (18/15) (too-many-locals) +tools/testing/selftests/net/lib/py/ksft.py:230:4: W0601: Global variable 'term_cnt' undefined at the module level (global-variable-undefined) +tools/testing/selftests/net/lib/py/ksft.py:239:4: W0603: Using the global statement (global-statement) +tools/testing/selftests/net/lib/py/ksft.py:258:15: W0718: Catching too general exception BaseException (broad-exception-caught) +tools/testing/selftests/net/lib/py/ksft.py:218:0: R0912: Too many branches (14/12) (too-many-branches) +tools/testing/selftests/net/lib/py/ksft.py:286:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/testing/selftests/net/lib/py/ksft.py:287:4: W0602: Using global for 'KSFT_RESULT_ALL' but no assignment is done (global-variable-not-assigned) @@ -81 +81 @@ -Your code has been rated at 7.49/10 (previous run: 7.49/10, +0.00) +Your code has been rated at 7.47/10 (previous run: 7.49/10, -0.01)