ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.u01oplbLMB and /tmp/tmp.XZijSxDLKO
Tree base:
68c5d969f8a4 ("netconsole: resume previously deactivated target")
Now at:
c8db8ef4cec2 ("selftests: netconsole: validate target reactivation")
 ====== Checking before the patch ======
Checking tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh - bf920798bfe9ad648c492dab7e7cb69c49e9d7fc40353062d15ff0dc93f5036d


In lib_netcons.sh line 58:
	local SRCIF_IFIDX=$(cat /sys/class/net/"$SRCIF"/ifindex)
              ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib_netcons.sh line 59:
	local DSTIF_IFIDX=$(cat /sys/class/net/"$DSTIF"/ifindex)
              ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.

For more information:
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh - bf920798bfe9ad648c492dab7e7cb69c49e9d7fc40353062d15ff0dc93f5036d


In lib_netcons.sh line 58:
	local SRCIF_IFIDX=$(cat /sys/class/net/"$SRCIF"/ifindex)
              ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib_netcons.sh line 59:
	local DSTIF_IFIDX=$(cat /sys/class/net/"$DSTIF"/ifindex)
              ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib_netcons.sh line 71:
		cleanup
                ^-----^ SC2119 (info): Use cleanup "$@" if function's $1 should mean script's $1.


In lib_netcons.sh line 188:
function cleanup() {
^-- SC2120 (warning): cleanup references arguments, but none are ever passed.

For more information:
  https://www.shellcheck.net/wiki/SC2120 -- cleanup references arguments, but...
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
  https://www.shellcheck.net/wiki/SC2119 -- Use cleanup "$@" if function's $1...

Checking tools/testing/selftests/drivers/net/netcons_resume.sh - 0d892e98b523ab3cd61407b6550c98c1da8d1a82e6f1bab1e03a008e0a815570


In netcons_resume.sh line 38:
	set_network
        ^---------^ SC2119 (info): Use set_network "$@" if function's $1 should mean script's $1.


In netcons_resume.sh line 65:
	set_network
        ^---------^ SC2119 (info): Use set_network "$@" if function's $1 should mean script's $1.


In netcons_resume.sh line 92:
exit "${ksft_pass}"
      ^----------^ SC2154 (warning): ksft_pass is referenced but not assigned.

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- ksft_pass is referenced but not a...
  https://www.shellcheck.net/wiki/SC2119 -- Use set_network "$@" if function'...