WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #71: new file mode 100644 CHECK: struct mutex definition without comment #120: FILE: drivers/ptp/ptp_marvell_tai.c:45: + struct mutex mutex; CHECK: Please use a blank line after function/struct/union/enum declarations #623: FILE: drivers/ptp/ptp_marvell_ts.c:97: +}; +#define MARVELL_TS_CB(skb) ((struct marvell_ts_cb *)(skb)->cb) CHECK: Comparison to NULL could be written "cmpxchg" #986: FILE: drivers/ptp/ptp_marvell_ts.c:460: + if (cmpxchg(&ts->tx_skb, NULL, skb) != NULL) WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") #1304: FILE: drivers/ptp/ptp_marvell_ts.c:778: +MODULE_LICENSE("GPL v2"); ERROR: code indent should use tabs where possible #1403: FILE: include/linux/marvell_ptp.h:93: +^I^I^I u8 port, enum marvell_ts_reg ts_reg);$ CHECK: Alignment should match open parenthesis #1403: FILE: include/linux/marvell_ptp.h:93: + int (*ts_port_read_ts)(struct device *dev, struct marvell_hwts *ts, + u8 port, enum marvell_ts_reg ts_reg); CHECK: Alignment should match open parenthesis #1406: FILE: include/linux/marvell_ptp.h:96: + int (*ts_port_modify)(struct device *dev, u8 port, u8 reg, u16 mask, + u16 val); CHECK: struct mutex definition without comment #1420: FILE: include/linux/marvell_ptp.h:110: + struct mutex rx_mutex; total: 1 errors, 2 warnings, 6 checks, 1400 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit 8e6bec6fd6ad ("ptp: marvell: add core support for Marvell PTP") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.