CHECK: Please use a blank line after function/struct/union/enum declarations #62: FILE: include/linux/trace_events.h:811: } +static inline int bpf_probe_override(struct bpf_raw_event_map *btp, CHECK: Please use a blank line after function/struct/union/enum declarations #103: FILE: include/linux/tracepoint.h:53: } +extern int WARNING: line length of 85 exceeds 80 columns #163: FILE: kernel/bpf/syscall.c:4135: + if (strncpy_from_user(probe, user_probe_name, sizeof(probe) - 1) < 0) WARNING: line length of 86 exceeds 80 columns #215: FILE: kernel/bpf/syscall.c:5587: + attr->link_create.tracing.cookie, WARNING: line length of 86 exceeds 80 columns #262: FILE: kernel/trace/bpf_trace.c:2338: + return tracepoint_probe_override(tp, (void *)btp->bpf_func, link, probe_name); CHECK: Unnecessary parentheses around funcs[iter] #295: FILE: kernel/tracepoint.c:145: + return &(funcs[iter]); CHECK: Alignment should match open parenthesis #315: FILE: kernel/tracepoint.c:165: + if (shots[iter].override.func == func->func && + shots[iter].override.data == func->data) { CHECK: Unnecessary parentheses around shots[iter] #317: FILE: kernel/tracepoint.c:167: + return &(shots[iter]); CHECK: Alignment should match open parenthesis #321: FILE: kernel/tracepoint.c:171: + if (shots[iter].orig.func == func->func && + shots[iter].orig.data == func->data) { CHECK: Unnecessary parentheses around shots[iter] #323: FILE: kernel/tracepoint.c:173: + return &(shots[iter]); WARNING: line length of 81 exceeds 80 columns #342: FILE: kernel/tracepoint.c:192: + for (nr_snapshots = 0; old[nr_snapshots].override.func; nr_snapshots++) { CHECK: Unnecessary parentheses around old[nr_snapshots] #343: FILE: kernel/tracepoint.c:193: + if (&(old[nr_snapshots]) == drop) WARNING: line length of 95 exceeds 80 columns #353: FILE: kernel/tracepoint.c:203: + new = kmalloc_array(nr_snapshots, sizeof(struct tracepoint_func_snapshot), GFP_KERNEL); WARNING: line length of 93 exceeds 80 columns #357: FILE: kernel/tracepoint.c:207: + memset(&(old[nr_snapshots - 1]), 0, sizeof(struct tracepoint_func_snapshot)); CHECK: Unnecessary parentheses around old[nr_snapshots - 1] #357: FILE: kernel/tracepoint.c:207: + memset(&(old[nr_snapshots - 1]), 0, sizeof(struct tracepoint_func_snapshot)); WARNING: line length of 88 exceeds 80 columns #385: FILE: kernel/tracepoint.c:235: + new = kmalloc_array(total, sizeof(struct tracepoint_func_snapshot), GFP_KERNEL); CHECK: Unnecessary parentheses around tp->snapshot #442: FILE: kernel/tracepoint.c:567: + ret = save_func_snapshot(&(tp->snapshot), &tp_func, target_func); CHECK: Unnecessary parentheses around tp->snapshot #468: FILE: kernel/tracepoint.c:669: + shot = find_func_snapshot(&(tp->snapshot), &tp_func, &is_override); WARNING: line length of 83 exceeds 80 columns #479: FILE: kernel/tracepoint.c:680: + ret = tracepoint_restore_func(tp, &tp_func, &(shot->orig)); CHECK: Unnecessary parentheses around shot->orig #479: FILE: kernel/tracepoint.c:680: + ret = tracepoint_restore_func(tp, &tp_func, &(shot->orig)); CHECK: Unnecessary parentheses around shot->override #487: FILE: kernel/tracepoint.c:688: + ret = tracepoint_remove_func(tp, &(shot->override)); CHECK: Unnecessary parentheses around tp->snapshot #489: FILE: kernel/tracepoint.c:690: + drop_func_snapshot(&(tp->snapshot), shot); total: 0 errors, 8 warnings, 14 checks, 412 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 3403e7636af1 ("bpf: Introduce BPF_PROG_TYPE_RAW_TRACEPOINT_OVERRIDE") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 8 warnings, 14 checks, 412 lines checked