ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.YgeQFzGz4K and /tmp/tmp.oO9Uw7p9x5
Tree base:
ad8444bc5ef8 ("net: gro: remove unnecessary df checks")
Now at:
3f32c6406e68 ("selftests/net: test ipip packets in gro.sh")
 ====== Checking before the patch ======
Checking tools/testing/selftests/net/gro.sh - 6db706a86bb43425dd557294767b91c13d32b7cb45951485b4bdda96c2273d7c


In gro.sh line 24:
  for tries in {1..6}; do
  ^-^ SC2034 (warning): tries appears unused. Verify use (or export if used externally).


In gro.sh line 26:
    ip netns exec $server_ns ./gro "${ARGS[@]}" "--rx" "--iface" "server" \
                  ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    ip netns exec "$server_ns" ./gro "${ARGS[@]}" "--rx" "--iface" "server" \


In gro.sh line 30:
    ip netns exec $client_ns ./gro "${ARGS[@]}" "--iface" "client" \
                  ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    ip netns exec "$client_ns" ./gro "${ARGS[@]}" "--iface" "client" \


In gro.sh line 52:
      exit_code=$(run_test $proto $test)
                           ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
      exit_code=$(run_test "$proto" "$test")


In gro.sh line 104:
  exit $exit_code
       ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  exit "$exit_code"

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- tries appears unused. Verify use ...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/net/gro.sh - 6db706a86bb43425dd557294767b91c13d32b7cb45951485b4bdda96c2273d7c


In gro.sh line 24:
  for tries in {1..6}; do
  ^-^ SC2034 (warning): tries appears unused. Verify use (or export if used externally).


In gro.sh line 26:
    ip netns exec $server_ns ./gro "${ARGS[@]}" "--rx" "--iface" "server" \
                  ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    ip netns exec "$server_ns" ./gro "${ARGS[@]}" "--rx" "--iface" "server" \


In gro.sh line 30:
    ip netns exec $client_ns ./gro "${ARGS[@]}" "--iface" "client" \
                  ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
    ip netns exec "$client_ns" ./gro "${ARGS[@]}" "--iface" "client" \


In gro.sh line 52:
      exit_code=$(run_test $proto $test)
                           ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                  ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
      exit_code=$(run_test "$proto" "$test")


In gro.sh line 104:
  exit $exit_code
       ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean: 
  exit "$exit_code"

For more information:
  https://www.shellcheck.net/wiki/SC2034 -- tries appears unused. Verify use ...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...