====== Checking before the patch ====== ====== Checking the tree with the patch ====== New warnings added --- /tmp/tmp.cdu3qs7hui 2025-09-15 10:39:34.762208057 -0700 +++ /tmp/tmp.bN05B7pYVf 2025-09-15 10:39:38.689188810 -0700 @@ -14,11 +14,11 @@ -tools/net/ynl/pyynl/ynl_gen_c.py:2159:0: C0301: Line too long (116/100) (line-too-long) -tools/net/ynl/pyynl/ynl_gen_c.py:2193:0: C0301: Line too long (105/100) (line-too-long) -tools/net/ynl/pyynl/ynl_gen_c.py:2679:0: W0311: Bad indentation. Found 8 spaces, expected 4 (bad-indentation) -tools/net/ynl/pyynl/ynl_gen_c.py:2783:0: C0301: Line too long (120/100) (line-too-long) -tools/net/ynl/pyynl/ynl_gen_c.py:3016:0: C0301: Line too long (102/100) (line-too-long) -tools/net/ynl/pyynl/ynl_gen_c.py:3338:0: C0301: Line too long (103/100) (line-too-long) -tools/net/ynl/pyynl/ynl_gen_c.py:3376:0: C0301: Line too long (106/100) (line-too-long) -tools/net/ynl/pyynl/ynl_gen_c.py:3397:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) -tools/net/ynl/pyynl/ynl_gen_c.py:3580:0: C0301: Line too long (106/100) (line-too-long) -tools/net/ynl/pyynl/ynl_gen_c.py:3658:0: C0301: Line too long (106/100) (line-too-long) -tools/net/ynl/pyynl/ynl_gen_c.py:1:0: C0302: Too many lines in module (3678/1000) (too-many-lines) +tools/net/ynl/pyynl/ynl_gen_c.py:2165:0: C0301: Line too long (116/100) (line-too-long) +tools/net/ynl/pyynl/ynl_gen_c.py:2199:0: C0301: Line too long (105/100) (line-too-long) +tools/net/ynl/pyynl/ynl_gen_c.py:2685:0: W0311: Bad indentation. Found 8 spaces, expected 4 (bad-indentation) +tools/net/ynl/pyynl/ynl_gen_c.py:2789:0: C0301: Line too long (120/100) (line-too-long) +tools/net/ynl/pyynl/ynl_gen_c.py:3022:0: C0301: Line too long (102/100) (line-too-long) +tools/net/ynl/pyynl/ynl_gen_c.py:3344:0: C0301: Line too long (103/100) (line-too-long) +tools/net/ynl/pyynl/ynl_gen_c.py:3382:0: C0301: Line too long (106/100) (line-too-long) +tools/net/ynl/pyynl/ynl_gen_c.py:3403:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) +tools/net/ynl/pyynl/ynl_gen_c.py:3586:0: C0301: Line too long (106/100) (line-too-long) +tools/net/ynl/pyynl/ynl_gen_c.py:3664:0: C0301: Line too long (106/100) (line-too-long) +tools/net/ynl/pyynl/ynl_gen_c.py:1:0: C0302: Too many lines in module (3684/1000) (too-many-lines) @@ -240,20 +240,20 @@ -tools/net/ynl/pyynl/ynl_gen_c.py:2052:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2108:16: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/net/ynl/pyynl/ynl_gen_c.py:2122:16: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/net/ynl/pyynl/ynl_gen_c.py:2195:12: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/net/ynl/pyynl/ynl_gen_c.py:2232:12: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/net/ynl/pyynl/ynl_gen_c.py:2094:0: R0912: Too many branches (40/12) (too-many-branches) -tools/net/ynl/pyynl/ynl_gen_c.py:2094:0: R0915: Too many statements (127/50) (too-many-statements) -tools/net/ynl/pyynl/ynl_gen_c.py:2247:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2256:23: W0212: Access to a protected member _attr_get of a client class (protected-access) -tools/net/ynl/pyynl/ynl_gen_c.py:2270:35: W0212: Access to a protected member _attr_get of a client class (protected-access) -tools/net/ynl/pyynl/ynl_gen_c.py:2283:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2297:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2297:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) -tools/net/ynl/pyynl/ynl_gen_c.py:2317:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2340:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2340:0: R0912: Too many branches (15/12) (too-many-branches) -tools/net/ynl/pyynl/ynl_gen_c.py:2340:0: R0915: Too many statements (56/50) (too-many-statements) -tools/net/ynl/pyynl/ynl_gen_c.py:2415:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2471:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2475:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2057:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2066:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2114:16: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/net/ynl/pyynl/ynl_gen_c.py:2128:16: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/net/ynl/pyynl/ynl_gen_c.py:2201:12: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/net/ynl/pyynl/ynl_gen_c.py:2238:12: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/net/ynl/pyynl/ynl_gen_c.py:2100:0: R0912: Too many branches (40/12) (too-many-branches) +tools/net/ynl/pyynl/ynl_gen_c.py:2100:0: R0915: Too many statements (127/50) (too-many-statements) +tools/net/ynl/pyynl/ynl_gen_c.py:2253:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2262:23: W0212: Access to a protected member _attr_get of a client class (protected-access) +tools/net/ynl/pyynl/ynl_gen_c.py:2276:35: W0212: Access to a protected member _attr_get of a client class (protected-access) +tools/net/ynl/pyynl/ynl_gen_c.py:2289:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2303:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2303:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) +tools/net/ynl/pyynl/ynl_gen_c.py:2323:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2346:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2346:0: R0912: Too many branches (13/12) (too-many-branches) +tools/net/ynl/pyynl/ynl_gen_c.py:2346:0: R0915: Too many statements (54/50) (too-many-statements) +tools/net/ynl/pyynl/ynl_gen_c.py:2418:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2477:0: C0116: Missing function or method docstring (missing-function-docstring) @@ -261,7 +261,7 @@ -tools/net/ynl/pyynl/ynl_gen_c.py:2500:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2509:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2559:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2563:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2580:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2593:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2600:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2487:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2506:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2515:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2565:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2569:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2586:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2599:0: C0116: Missing function or method docstring (missing-function-docstring) @@ -269 +269 @@ -tools/net/ynl/pyynl/ynl_gen_c.py:2616:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2612:0: C0116: Missing function or method docstring (missing-function-docstring) @@ -272,6 +272,6 @@ -tools/net/ynl/pyynl/ynl_gen_c.py:2629:8: R1714: Consider merging these comparisons with 'in' by using 'ri.op_mode in ('do', 'dump')'. Use a set instead if elements are hashable. (consider-using-in) -tools/net/ynl/pyynl/ynl_gen_c.py:2638:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2642:9: R1714: Consider merging these comparisons with 'in' by using 'ri.op_mode in ('notify', 'event')'. Use a set instead if elements are hashable. (consider-using-in) -tools/net/ynl/pyynl/ynl_gen_c.py:2678:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2682:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2686:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2634:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2635:8: R1714: Consider merging these comparisons with 'in' by using 'ri.op_mode in ('do', 'dump')'. Use a set instead if elements are hashable. (consider-using-in) +tools/net/ynl/pyynl/ynl_gen_c.py:2644:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2648:9: R1714: Consider merging these comparisons with 'in' by using 'ri.op_mode in ('notify', 'event')'. Use a set instead if elements are hashable. (consider-using-in) +tools/net/ynl/pyynl/ynl_gen_c.py:2684:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2688:0: C0116: Missing function or method docstring (missing-function-docstring) @@ -279,42 +279,43 @@ -tools/net/ynl/pyynl/ynl_gen_c.py:2712:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2722:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2746:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2757:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2761:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2765:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2794:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2832:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2832:0: R0912: Too many branches (18/12) (too-many-branches) -tools/net/ynl/pyynl/ynl_gen_c.py:2899:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2903:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2905:7: R1714: Consider merging these comparisons with 'in' by using 'family.kernel_policy in ('global', 'per-op')'. Use a set instead if elements are hashable. (consider-using-in) -tools/net/ynl/pyynl/ynl_gen_c.py:2932:4: R1702: Too many nested blocks (6/5) (too-many-nested-blocks) -tools/net/ynl/pyynl/ynl_gen_c.py:2903:0: R0912: Too many branches (22/12) (too-many-branches) -tools/net/ynl/pyynl/ynl_gen_c.py:2903:0: R0915: Too many statements (59/50) (too-many-statements) -tools/net/ynl/pyynl/ynl_gen_c.py:2983:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:2995:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:3008:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:3020:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:3057:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:3067:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:3094:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:3148:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:3148:0: R0914: Too many local variables (22/15) (too-many-locals) -tools/net/ynl/pyynl/ynl_gen_c.py:3262:8: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/net/ynl/pyynl/ynl_gen_c.py:3148:0: R0912: Too many branches (35/12) (too-many-branches) -tools/net/ynl/pyynl/ynl_gen_c.py:3148:0: R0915: Too many statements (108/50) (too-many-statements) -tools/net/ynl/pyynl/ynl_gen_c.py:3304:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:3319:16: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/net/ynl/pyynl/ynl_gen_c.py:3304:0: R0912: Too many branches (14/12) (too-many-branches) -tools/net/ynl/pyynl/ynl_gen_c.py:3321:12: W0612: Unused variable 'op_name' (unused-variable) -tools/net/ynl/pyynl/ynl_gen_c.py:3347:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:3357:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:3367:0: C0116: Missing function or method docstring (missing-function-docstring) -tools/net/ynl/pyynl/ynl_gen_c.py:3367:0: R0914: Too many local variables (23/15) (too-many-locals) -tools/net/ynl/pyynl/ynl_gen_c.py:3395:8: W0101: Unreachable code (unreachable) -tools/net/ynl/pyynl/ynl_gen_c.py:3474:4: R1702: Too many nested blocks (6/5) (too-many-nested-blocks) -tools/net/ynl/pyynl/ynl_gen_c.py:3580:24: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/net/ynl/pyynl/ynl_gen_c.py:3658:24: W0719: Raising too general exception: Exception (broad-exception-raised) -tools/net/ynl/pyynl/ynl_gen_c.py:3367:0: R0912: Too many branches (83/12) (too-many-branches) -tools/net/ynl/pyynl/ynl_gen_c.py:3367:0: R0915: Too many statements (243/50) (too-many-statements) -tools/net/ynl/pyynl/ynl_gen_c.py:3493:20: W0612: Unused variable 'op_name' (unused-variable) +tools/net/ynl/pyynl/ynl_gen_c.py:2698:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2718:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2728:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2752:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2763:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2767:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2771:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2800:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2838:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2838:0: R0912: Too many branches (18/12) (too-many-branches) +tools/net/ynl/pyynl/ynl_gen_c.py:2905:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2909:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:2911:7: R1714: Consider merging these comparisons with 'in' by using 'family.kernel_policy in ('global', 'per-op')'. Use a set instead if elements are hashable. (consider-using-in) +tools/net/ynl/pyynl/ynl_gen_c.py:2938:4: R1702: Too many nested blocks (6/5) (too-many-nested-blocks) +tools/net/ynl/pyynl/ynl_gen_c.py:2909:0: R0912: Too many branches (22/12) (too-many-branches) +tools/net/ynl/pyynl/ynl_gen_c.py:2909:0: R0915: Too many statements (59/50) (too-many-statements) +tools/net/ynl/pyynl/ynl_gen_c.py:2989:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:3001:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:3014:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:3026:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:3063:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:3073:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:3100:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:3154:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:3154:0: R0914: Too many local variables (22/15) (too-many-locals) +tools/net/ynl/pyynl/ynl_gen_c.py:3268:8: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/net/ynl/pyynl/ynl_gen_c.py:3154:0: R0912: Too many branches (35/12) (too-many-branches) +tools/net/ynl/pyynl/ynl_gen_c.py:3154:0: R0915: Too many statements (108/50) (too-many-statements) +tools/net/ynl/pyynl/ynl_gen_c.py:3310:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:3325:16: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/net/ynl/pyynl/ynl_gen_c.py:3310:0: R0912: Too many branches (14/12) (too-many-branches) +tools/net/ynl/pyynl/ynl_gen_c.py:3327:12: W0612: Unused variable 'op_name' (unused-variable) +tools/net/ynl/pyynl/ynl_gen_c.py:3353:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:3363:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:3373:0: C0116: Missing function or method docstring (missing-function-docstring) +tools/net/ynl/pyynl/ynl_gen_c.py:3373:0: R0914: Too many local variables (23/15) (too-many-locals) +tools/net/ynl/pyynl/ynl_gen_c.py:3401:8: W0101: Unreachable code (unreachable) +tools/net/ynl/pyynl/ynl_gen_c.py:3480:4: R1702: Too many nested blocks (6/5) (too-many-nested-blocks) +tools/net/ynl/pyynl/ynl_gen_c.py:3586:24: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/net/ynl/pyynl/ynl_gen_c.py:3664:24: W0719: Raising too general exception: Exception (broad-exception-raised) +tools/net/ynl/pyynl/ynl_gen_c.py:3373:0: R0912: Too many branches (83/12) (too-many-branches) +tools/net/ynl/pyynl/ynl_gen_c.py:3373:0: R0915: Too many statements (243/50) (too-many-statements) +tools/net/ynl/pyynl/ynl_gen_c.py:3499:20: W0612: Unused variable 'op_name' (unused-variable) @@ -323 +324 @@ -Your code has been rated at 8.64/10 (previous run: 8.64/10, +0.00) +Your code has been rated at 8.64/10 (previous run: 8.64/10, -0.00)