WARNING: line length of 83 exceeds 80 columns #115: FILE: arch/x86/net/bpf_jit_comp.c:2726: + bpf_prog_update_insn_ptr(bpf_prog, abs_xlated_off, proglen, WARNING: line length of 103 exceeds 80 columns #177: FILE: include/linux/bpf_verifier.h:769: + struct bpf_map *insn_array_maps[MAX_USED_MAPS]; /* array of INSN_ARRAY map's to be relocated */ WARNING: line length of 97 exceeds 80 columns #180: FILE: include/linux/bpf_verifier.h:772: + u32 insn_array_map_cnt; /* number of used maps of type BPF_MAP_TYPE_INSN_ARRAY */ CHECK: Please don't use multiple blank lines #209: FILE: include/uapi/linux/bpf.h:7636: + + WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #225: new file mode 100644 CHECK: struct mutex definition without comment #239: FILE: kernel/bpf/bpf_insn_array.c:10: + struct mutex state_mutex; WARNING: line length of 82 exceeds 80 columns #309: FILE: kernel/bpf/bpf_insn_array.c:80: +static int insn_array_get_next_key(struct bpf_map *map, void *key, void *next_key) WARNING: line length of 94 exceeds 80 columns #338: FILE: kernel/bpf/bpf_insn_array.c:109: +static long insn_array_update_elem(struct bpf_map *map, void *key, void *value, u64 map_flags) CHECK: Alignment should match open parenthesis #383: FILE: kernel/bpf/bpf_insn_array.c:154: +static int insn_array_check_btf(const struct bpf_map *map, + const struct btf *btf, WARNING: line length of 84 exceeds 80 columns #438: FILE: kernel/bpf/bpf_insn_array.c:209: + if (prog->insnsi[off-1].code == (BPF_LD | BPF_DW | BPF_IMM)) CHECK: spaces preferred around that '-' (ctx:VxV) #438: FILE: kernel/bpf/bpf_insn_array.c:209: + if (prog->insnsi[off-1].code == (BPF_LD | BPF_DW | BPF_IMM)) ^ WARNING: line length of 96 exceeds 80 columns #471: FILE: kernel/bpf/bpf_insn_array.c:242: + insn_array->ptrs[i].user_value.xlated_off = insn_array->ptrs[i].orig_xlated_off; WARNING: Missing a blank line after declarations #479: FILE: kernel/bpf/bpf_insn_array.c:250: + struct bpf_insn_array *insn_array = cast_insn_array(map); + guard(mutex)(&insn_array->state_mutex); WARNING: Missing a blank line after declarations #502: FILE: kernel/bpf/bpf_insn_array.c:273: + struct bpf_insn_array *insn_array = cast_insn_array(map); + guard(mutex)(&insn_array->state_mutex); WARNING: line length of 81 exceeds 80 columns #536: FILE: kernel/bpf/bpf_insn_array.c:307: + insn_array->ptrs[i].user_value.xlated_off = INSN_DELETED; WARNING: line length of 86 exceeds 80 columns #558: FILE: kernel/bpf/bpf_insn_array.c:329: + if (insn_array->ptrs[j].user_value.xlated_off == xlated_off) { WARNING: line length of 87 exceeds 80 columns #561: FILE: kernel/bpf/bpf_insn_array.c:332: + insn_array->ptrs[j].user_value.jitted_off = jitted_off; WARNING: line length of 81 exceeds 80 columns #588: FILE: kernel/bpf/syscall.c:2771: + if (prog->aux->used_maps[i]->map_type != BPF_MAP_TYPE_INSN_ARRAY) WARNING: line length of 83 exceeds 80 columns #633: FILE: kernel/bpf/verifier.c:20525: + verbose(env, "Failed to properly initialize insn array\n"); WARNING: line length of 91 exceeds 80 columns #665: FILE: kernel/bpf/verifier.c:20796: +static void adjust_insn_arrays_after_remove(struct bpf_verifier_env *env, u32 off, u32 len) WARNING: line length of 86 exceeds 80 columns #670: FILE: kernel/bpf/verifier.c:20801: + bpf_insn_array_adjust_after_remove(env->insn_array_maps[i], off, len); CHECK: Please don't use multiple blank lines #727: FILE: tools/include/uapi/linux/bpf.h:7636: + + total: 0 errors, 17 warnings, 5 checks, 574 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit e016b3126265 ("bpf, x86: add new map type: instructions array") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 17 warnings, 5 checks, 574 lines checked