WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 WARNING: Statements should start on a tabstop #91: FILE: tools/testing/selftests/namespaces/file_handle_test.c:48: + return, "nsfs doesn't support file handles"); WARNING: Statements should start on a tabstop #100: FILE: tools/testing/selftests/namespaces/file_handle_test.c:57: + return, WARNING: Statements should start on a tabstop #105: FILE: tools/testing/selftests/namespaces/file_handle_test.c:62: + return, WARNING: Statements should start on a tabstop #146: FILE: tools/testing/selftests/namespaces/file_handle_test.c:103: + return, "nsfs doesn't support file handles"); WARNING: Statements should start on a tabstop #155: FILE: tools/testing/selftests/namespaces/file_handle_test.c:112: + return, WARNING: Statements should start on a tabstop #196: FILE: tools/testing/selftests/namespaces/file_handle_test.c:153: + return, "nsfs doesn't support file handles"); WARNING: Statements should start on a tabstop #205: FILE: tools/testing/selftests/namespaces/file_handle_test.c:162: + return, WARNING: Statements should start on a tabstop #246: FILE: tools/testing/selftests/namespaces/file_handle_test.c:203: + return, "nsfs doesn't support file handles"); WARNING: Statements should start on a tabstop #255: FILE: tools/testing/selftests/namespaces/file_handle_test.c:212: + return, WARNING: Statements should start on a tabstop #296: FILE: tools/testing/selftests/namespaces/file_handle_test.c:253: + return, "nsfs doesn't support file handles"); WARNING: Statements should start on a tabstop #305: FILE: tools/testing/selftests/namespaces/file_handle_test.c:262: + return, WARNING: Statements should start on a tabstop #346: FILE: tools/testing/selftests/namespaces/file_handle_test.c:303: + return, "nsfs doesn't support file handles"); WARNING: Statements should start on a tabstop #355: FILE: tools/testing/selftests/namespaces/file_handle_test.c:312: + return, WARNING: Statements should start on a tabstop #398: FILE: tools/testing/selftests/namespaces/file_handle_test.c:355: + return, "nsfs doesn't support file handles"); WARNING: Statements should start on a tabstop #407: FILE: tools/testing/selftests/namespaces/file_handle_test.c:364: + return, WARNING: Statements should start on a tabstop #450: FILE: tools/testing/selftests/namespaces/file_handle_test.c:407: + return, "nsfs doesn't support file handles"); WARNING: Statements should start on a tabstop #459: FILE: tools/testing/selftests/namespaces/file_handle_test.c:416: + return, WARNING: Statements should start on a tabstop #502: FILE: tools/testing/selftests/namespaces/file_handle_test.c:459: + return, "nsfs doesn't support file handles"); WARNING: Missing a blank line after declarations #540: FILE: tools/testing/selftests/namespaces/file_handle_test.c:497: + char mapping[64]; + snprintf(mapping, sizeof(mapping), "0 %d 1", getuid()); WARNING: line length of 95 exceeds 80 columns #557: FILE: tools/testing/selftests/namespaces/file_handle_test.c:514: + /* Try to open parent's network namespace handle from new user+net namespace */ WARNING: line length of 86 exceeds 80 columns #561: FILE: tools/testing/selftests/namespaces/file_handle_test.c:518: + /* Should NOT succeed - we're in a different user namespace */ WARNING: Statements should start on a tabstop #586: FILE: tools/testing/selftests/namespaces/file_handle_test.c:543: + return, "Cannot create new user namespace"); WARNING: Statements should start on a tabstop #590: FILE: tools/testing/selftests/namespaces/file_handle_test.c:547: + return, "Cannot set uid/gid mappings"); WARNING: Statements should start on a tabstop #594: FILE: tools/testing/selftests/namespaces/file_handle_test.c:551: + return, "Cannot create new network namespace"); WARNING: line length of 90 exceeds 80 columns #597: FILE: tools/testing/selftests/namespaces/file_handle_test.c:554: + /* Should fail with permission denied since we're in a different user namespace */ WARNING: Statements should start on a tabstop #631: FILE: tools/testing/selftests/namespaces/file_handle_test.c:588: + return, "nsfs doesn't support file handles"); WARNING: Missing a blank line after declarations #669: FILE: tools/testing/selftests/namespaces/file_handle_test.c:626: + char mapping[64]; + snprintf(mapping, sizeof(mapping), "0 %d 1", getuid()); WARNING: line length of 91 exceeds 80 columns #686: FILE: tools/testing/selftests/namespaces/file_handle_test.c:643: + /* Try to open parent's UTS namespace handle from new user+uts namespace */ WARNING: line length of 86 exceeds 80 columns #690: FILE: tools/testing/selftests/namespaces/file_handle_test.c:647: + /* Should NOT succeed - we're in a different user namespace */ WARNING: Statements should start on a tabstop #715: FILE: tools/testing/selftests/namespaces/file_handle_test.c:672: + return, "Cannot create new user namespace"); WARNING: Statements should start on a tabstop #719: FILE: tools/testing/selftests/namespaces/file_handle_test.c:676: + return, "Cannot set uid/gid mappings"); WARNING: Statements should start on a tabstop #723: FILE: tools/testing/selftests/namespaces/file_handle_test.c:680: + return, "Cannot create new UTS namespace"); WARNING: Statements should start on a tabstop #760: FILE: tools/testing/selftests/namespaces/file_handle_test.c:717: + return, "nsfs doesn't support file handles"); WARNING: Missing a blank line after declarations #798: FILE: tools/testing/selftests/namespaces/file_handle_test.c:755: + char mapping[64]; + snprintf(mapping, sizeof(mapping), "0 %d 1", getuid()); WARNING: line length of 91 exceeds 80 columns #815: FILE: tools/testing/selftests/namespaces/file_handle_test.c:772: + /* Try to open parent's IPC namespace handle from new user+ipc namespace */ WARNING: line length of 86 exceeds 80 columns #819: FILE: tools/testing/selftests/namespaces/file_handle_test.c:776: + /* Should NOT succeed - we're in a different user namespace */ WARNING: Statements should start on a tabstop #844: FILE: tools/testing/selftests/namespaces/file_handle_test.c:801: + return, "Cannot create new user namespace"); WARNING: Statements should start on a tabstop #848: FILE: tools/testing/selftests/namespaces/file_handle_test.c:805: + return, "Cannot set uid/gid mappings"); WARNING: Statements should start on a tabstop #852: FILE: tools/testing/selftests/namespaces/file_handle_test.c:809: + return, "Cannot create new IPC namespace"); WARNING: Statements should start on a tabstop #889: FILE: tools/testing/selftests/namespaces/file_handle_test.c:846: + return, "nsfs doesn't support file handles"); WARNING: Missing a blank line after declarations #927: FILE: tools/testing/selftests/namespaces/file_handle_test.c:884: + char mapping[64]; + snprintf(mapping, sizeof(mapping), "0 %d 1", getuid()); WARNING: line length of 93 exceeds 80 columns #944: FILE: tools/testing/selftests/namespaces/file_handle_test.c:901: + /* Try to open parent's mount namespace handle from new user+mnt namespace */ WARNING: line length of 86 exceeds 80 columns #948: FILE: tools/testing/selftests/namespaces/file_handle_test.c:905: + /* Should NOT succeed - we're in a different user namespace */ WARNING: Statements should start on a tabstop #973: FILE: tools/testing/selftests/namespaces/file_handle_test.c:930: + return, "Cannot create new user namespace"); WARNING: Statements should start on a tabstop #977: FILE: tools/testing/selftests/namespaces/file_handle_test.c:934: + return, "Cannot set uid/gid mappings"); WARNING: Statements should start on a tabstop #981: FILE: tools/testing/selftests/namespaces/file_handle_test.c:938: + return, "Cannot create new mount namespace"); WARNING: Statements should start on a tabstop #1013: FILE: tools/testing/selftests/namespaces/file_handle_test.c:970: + return, "cgroup namespace not available"); WARNING: Statements should start on a tabstop #1021: FILE: tools/testing/selftests/namespaces/file_handle_test.c:978: + return, "nsfs doesn't support file handles"); WARNING: Missing a blank line after declarations #1059: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1016: + char mapping[64]; + snprintf(mapping, sizeof(mapping), "0 %d 1", getuid()); WARNING: line length of 97 exceeds 80 columns #1076: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1033: + /* Try to open parent's cgroup namespace handle from new user+cgroup namespace */ WARNING: line length of 86 exceeds 80 columns #1080: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1037: + /* Should NOT succeed - we're in a different user namespace */ WARNING: Statements should start on a tabstop #1105: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1062: + return, "Cannot create new user namespace"); WARNING: Statements should start on a tabstop #1109: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1066: + return, "Cannot set uid/gid mappings"); WARNING: Statements should start on a tabstop #1113: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1070: + return, "Cannot create new cgroup namespace"); WARNING: Statements should start on a tabstop #1150: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1107: + return, "nsfs doesn't support file handles"); WARNING: Missing a blank line after declarations #1188: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1145: + char mapping[64]; + snprintf(mapping, sizeof(mapping), "0 %d 1", getuid()); WARNING: line length of 81 exceeds 80 columns #1196: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1153: + /* Now create new PID namespace - requires fork to take effect */ WARNING: Missing a blank line after declarations #1207: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1164: + pid_t child_pid = fork(); + if (child_pid < 0) { WARNING: line length of 99 exceeds 80 columns #1216: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1173: + /* Try to open parent's PID namespace handle from new user+pid namespace */ WARNING: line length of 94 exceeds 80 columns #1220: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1177: + /* Should NOT succeed - we're in a different user namespace */ WARNING: Statements should start on a tabstop #1251: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1208: + return, "Cannot create new user namespace"); WARNING: Statements should start on a tabstop #1255: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1212: + return, "Cannot set uid/gid mappings"); WARNING: Statements should start on a tabstop #1259: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1216: + return, "Cannot create new PID namespace"); WARNING: Statements should start on a tabstop #1291: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1248: + return, "time namespace not available"); WARNING: Statements should start on a tabstop #1299: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1256: + return, "nsfs doesn't support file handles"); WARNING: Missing a blank line after declarations #1337: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1294: + char mapping[64]; + snprintf(mapping, sizeof(mapping), "0 %d 1", getuid()); WARNING: line length of 82 exceeds 80 columns #1345: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1302: + /* Now create new time namespace - requires fork to take effect */ WARNING: Missing a blank line after declarations #1356: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1313: + pid_t child_pid = fork(); + if (child_pid < 0) { WARNING: line length of 101 exceeds 80 columns #1365: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1322: + /* Try to open parent's time namespace handle from new user+time namespace */ WARNING: line length of 94 exceeds 80 columns #1369: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1326: + /* Should NOT succeed - we're in a different user namespace */ WARNING: Statements should start on a tabstop #1400: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1357: + return, "Cannot create new user namespace"); WARNING: Statements should start on a tabstop #1404: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1361: + return, "Cannot set uid/gid mappings"); WARNING: Statements should start on a tabstop #1408: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1365: + return, "Cannot create new time namespace"); WARNING: Statements should start on a tabstop #1438: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1395: + return, "nsfs doesn't support file handles"); total: 0 errors, 75 warnings, 0 checks, 1439 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit a6435cbdd1b0 ("selftests/namespaces: add file handle selftests") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 75 warnings, 0 checks, 1439 lines checked