WARNING: externs should be avoided in .c files #72: FILE: net/ethtool/ioctl.c:41: +extern spinlock_t devmem_sockets_lock; WARNING: line length of 94 exceeds 80 columns #143: FILE: net/ethtool/ioctl.c:1240: + if (((v4_usr_spec->ip4src ^ dst4->sin_addr.s_addr) & v4_usr_m_spec->ip4src) || WARNING: line length of 92 exceeds 80 columns #144: FILE: net/ethtool/ioctl.c:1241: + (v4_usr_spec->ip4dst ^ src4->sin_addr.s_addr) & v4_usr_m_spec->ip4dst) { WARNING: line length of 86 exceeds 80 columns #156: FILE: net/ethtool/ioctl.c:1253: + if (((v4_spec->ip4src ^ dst4->sin_addr.s_addr) & v4_m_spec->ip4src) || WARNING: line length of 84 exceeds 80 columns #157: FILE: net/ethtool/ioctl.c:1254: + ((v4_spec->ip4dst ^ src4->sin_addr.s_addr) & v4_m_spec->ip4dst)) WARNING: line length of 83 exceeds 80 columns #173: FILE: net/ethtool/ioctl.c:1270: + return !ipv6_masked_addr_cmp(&saddr6, &smask6, &dst6->sin6_addr) && WARNING: line length of 81 exceeds 80 columns #174: FILE: net/ethtool/ioctl.c:1271: + !ipv6_masked_addr_cmp(&daddr6, &dmask6, &src6->sin6_addr); WARNING: line length of 83 exceeds 80 columns #187: FILE: net/ethtool/ioctl.c:1284: + return !ipv6_masked_addr_cmp(&daddr6, &dmask6, &src6->sin6_addr) && WARNING: line length of 81 exceeds 80 columns #188: FILE: net/ethtool/ioctl.c:1285: + !ipv6_masked_addr_cmp(&saddr6, &smask6, &dst6->sin6_addr); WARNING: externs should be avoided in .c files #263: FILE: net/ipv4/tcp_ipv4.c:96: +extern spinlock_t devmem_sockets_lock; total: 0 errors, 10 warnings, 0 checks, 211 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 59ea56d7c827 ("net: ethtool: prevent user from breaking devmem single-binding rule") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 10 warnings, 0 checks, 211 lines checked