WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #38: new file mode 100644 WARNING: Statements should start on a tabstop #88: FILE: tools/testing/selftests/namespaces/file_handle_test.c:46: + return, "nsfs doesn't support file handles"); WARNING: Statements should start on a tabstop #97: FILE: tools/testing/selftests/namespaces/file_handle_test.c:55: + return, WARNING: Statements should start on a tabstop #136: FILE: tools/testing/selftests/namespaces/file_handle_test.c:94: + return, "nsfs doesn't support file handles"); WARNING: Statements should start on a tabstop #145: FILE: tools/testing/selftests/namespaces/file_handle_test.c:103: + return, WARNING: Statements should start on a tabstop #184: FILE: tools/testing/selftests/namespaces/file_handle_test.c:142: + return, "nsfs doesn't support file handles"); WARNING: Statements should start on a tabstop #193: FILE: tools/testing/selftests/namespaces/file_handle_test.c:151: + return, WARNING: Statements should start on a tabstop #232: FILE: tools/testing/selftests/namespaces/file_handle_test.c:190: + return, "nsfs doesn't support file handles"); WARNING: Statements should start on a tabstop #241: FILE: tools/testing/selftests/namespaces/file_handle_test.c:199: + return, WARNING: Statements should start on a tabstop #280: FILE: tools/testing/selftests/namespaces/file_handle_test.c:238: + return, "nsfs doesn't support file handles"); WARNING: Statements should start on a tabstop #289: FILE: tools/testing/selftests/namespaces/file_handle_test.c:247: + return, WARNING: Statements should start on a tabstop #328: FILE: tools/testing/selftests/namespaces/file_handle_test.c:286: + return, "nsfs doesn't support file handles"); WARNING: Statements should start on a tabstop #337: FILE: tools/testing/selftests/namespaces/file_handle_test.c:295: + return, WARNING: Statements should start on a tabstop #378: FILE: tools/testing/selftests/namespaces/file_handle_test.c:336: + return, "nsfs doesn't support file handles"); WARNING: Statements should start on a tabstop #387: FILE: tools/testing/selftests/namespaces/file_handle_test.c:345: + return, WARNING: Statements should start on a tabstop #428: FILE: tools/testing/selftests/namespaces/file_handle_test.c:386: + return, "nsfs doesn't support file handles"); WARNING: Statements should start on a tabstop #437: FILE: tools/testing/selftests/namespaces/file_handle_test.c:395: + return, WARNING: Statements should start on a tabstop #480: FILE: tools/testing/selftests/namespaces/file_handle_test.c:438: + return, "nsfs doesn't support file handles"); WARNING: Missing a blank line after declarations #518: FILE: tools/testing/selftests/namespaces/file_handle_test.c:476: + char mapping[64]; + snprintf(mapping, sizeof(mapping), "0 %d 1", getuid()); WARNING: line length of 95 exceeds 80 columns #535: FILE: tools/testing/selftests/namespaces/file_handle_test.c:493: + /* Try to open parent's network namespace handle from new user+net namespace */ WARNING: line length of 86 exceeds 80 columns #539: FILE: tools/testing/selftests/namespaces/file_handle_test.c:497: + /* Should NOT succeed - we're in a different user namespace */ WARNING: Statements should start on a tabstop #564: FILE: tools/testing/selftests/namespaces/file_handle_test.c:522: + return, "Cannot create new user namespace"); WARNING: Statements should start on a tabstop #568: FILE: tools/testing/selftests/namespaces/file_handle_test.c:526: + return, "Cannot set uid/gid mappings"); WARNING: Statements should start on a tabstop #572: FILE: tools/testing/selftests/namespaces/file_handle_test.c:530: + return, "Cannot create new network namespace"); WARNING: line length of 90 exceeds 80 columns #575: FILE: tools/testing/selftests/namespaces/file_handle_test.c:533: + /* Should fail with permission denied since we're in a different user namespace */ WARNING: Statements should start on a tabstop #609: FILE: tools/testing/selftests/namespaces/file_handle_test.c:567: + return, "nsfs doesn't support file handles"); WARNING: Missing a blank line after declarations #647: FILE: tools/testing/selftests/namespaces/file_handle_test.c:605: + char mapping[64]; + snprintf(mapping, sizeof(mapping), "0 %d 1", getuid()); WARNING: line length of 91 exceeds 80 columns #664: FILE: tools/testing/selftests/namespaces/file_handle_test.c:622: + /* Try to open parent's UTS namespace handle from new user+uts namespace */ WARNING: line length of 86 exceeds 80 columns #668: FILE: tools/testing/selftests/namespaces/file_handle_test.c:626: + /* Should NOT succeed - we're in a different user namespace */ WARNING: Statements should start on a tabstop #693: FILE: tools/testing/selftests/namespaces/file_handle_test.c:651: + return, "Cannot create new user namespace"); WARNING: Statements should start on a tabstop #697: FILE: tools/testing/selftests/namespaces/file_handle_test.c:655: + return, "Cannot set uid/gid mappings"); WARNING: Statements should start on a tabstop #701: FILE: tools/testing/selftests/namespaces/file_handle_test.c:659: + return, "Cannot create new UTS namespace"); WARNING: Statements should start on a tabstop #738: FILE: tools/testing/selftests/namespaces/file_handle_test.c:696: + return, "nsfs doesn't support file handles"); WARNING: Missing a blank line after declarations #776: FILE: tools/testing/selftests/namespaces/file_handle_test.c:734: + char mapping[64]; + snprintf(mapping, sizeof(mapping), "0 %d 1", getuid()); WARNING: line length of 91 exceeds 80 columns #793: FILE: tools/testing/selftests/namespaces/file_handle_test.c:751: + /* Try to open parent's IPC namespace handle from new user+ipc namespace */ WARNING: line length of 86 exceeds 80 columns #797: FILE: tools/testing/selftests/namespaces/file_handle_test.c:755: + /* Should NOT succeed - we're in a different user namespace */ WARNING: Statements should start on a tabstop #822: FILE: tools/testing/selftests/namespaces/file_handle_test.c:780: + return, "Cannot create new user namespace"); WARNING: Statements should start on a tabstop #826: FILE: tools/testing/selftests/namespaces/file_handle_test.c:784: + return, "Cannot set uid/gid mappings"); WARNING: Statements should start on a tabstop #830: FILE: tools/testing/selftests/namespaces/file_handle_test.c:788: + return, "Cannot create new IPC namespace"); WARNING: Statements should start on a tabstop #867: FILE: tools/testing/selftests/namespaces/file_handle_test.c:825: + return, "nsfs doesn't support file handles"); WARNING: Missing a blank line after declarations #905: FILE: tools/testing/selftests/namespaces/file_handle_test.c:863: + char mapping[64]; + snprintf(mapping, sizeof(mapping), "0 %d 1", getuid()); WARNING: line length of 93 exceeds 80 columns #922: FILE: tools/testing/selftests/namespaces/file_handle_test.c:880: + /* Try to open parent's mount namespace handle from new user+mnt namespace */ WARNING: line length of 86 exceeds 80 columns #926: FILE: tools/testing/selftests/namespaces/file_handle_test.c:884: + /* Should NOT succeed - we're in a different user namespace */ WARNING: Statements should start on a tabstop #951: FILE: tools/testing/selftests/namespaces/file_handle_test.c:909: + return, "Cannot create new user namespace"); WARNING: Statements should start on a tabstop #955: FILE: tools/testing/selftests/namespaces/file_handle_test.c:913: + return, "Cannot set uid/gid mappings"); WARNING: Statements should start on a tabstop #959: FILE: tools/testing/selftests/namespaces/file_handle_test.c:917: + return, "Cannot create new mount namespace"); WARNING: Statements should start on a tabstop #991: FILE: tools/testing/selftests/namespaces/file_handle_test.c:949: + return, "cgroup namespace not available"); WARNING: Statements should start on a tabstop #999: FILE: tools/testing/selftests/namespaces/file_handle_test.c:957: + return, "nsfs doesn't support file handles"); WARNING: Missing a blank line after declarations #1037: FILE: tools/testing/selftests/namespaces/file_handle_test.c:995: + char mapping[64]; + snprintf(mapping, sizeof(mapping), "0 %d 1", getuid()); WARNING: line length of 97 exceeds 80 columns #1054: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1012: + /* Try to open parent's cgroup namespace handle from new user+cgroup namespace */ WARNING: line length of 86 exceeds 80 columns #1058: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1016: + /* Should NOT succeed - we're in a different user namespace */ WARNING: Statements should start on a tabstop #1083: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1041: + return, "Cannot create new user namespace"); WARNING: Statements should start on a tabstop #1087: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1045: + return, "Cannot set uid/gid mappings"); WARNING: Statements should start on a tabstop #1091: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1049: + return, "Cannot create new cgroup namespace"); WARNING: Statements should start on a tabstop #1128: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1086: + return, "nsfs doesn't support file handles"); WARNING: Missing a blank line after declarations #1166: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1124: + char mapping[64]; + snprintf(mapping, sizeof(mapping), "0 %d 1", getuid()); WARNING: line length of 81 exceeds 80 columns #1174: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1132: + /* Now create new PID namespace - requires fork to take effect */ WARNING: Missing a blank line after declarations #1185: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1143: + pid_t child_pid = fork(); + if (child_pid < 0) { WARNING: line length of 99 exceeds 80 columns #1194: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1152: + /* Try to open parent's PID namespace handle from new user+pid namespace */ WARNING: line length of 94 exceeds 80 columns #1198: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1156: + /* Should NOT succeed - we're in a different user namespace */ WARNING: Statements should start on a tabstop #1229: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1187: + return, "Cannot create new user namespace"); WARNING: Statements should start on a tabstop #1233: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1191: + return, "Cannot set uid/gid mappings"); WARNING: Statements should start on a tabstop #1237: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1195: + return, "Cannot create new PID namespace"); WARNING: Statements should start on a tabstop #1269: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1227: + return, "time namespace not available"); WARNING: Statements should start on a tabstop #1277: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1235: + return, "nsfs doesn't support file handles"); WARNING: Missing a blank line after declarations #1315: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1273: + char mapping[64]; + snprintf(mapping, sizeof(mapping), "0 %d 1", getuid()); WARNING: line length of 82 exceeds 80 columns #1323: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1281: + /* Now create new time namespace - requires fork to take effect */ WARNING: Missing a blank line after declarations #1334: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1292: + pid_t child_pid = fork(); + if (child_pid < 0) { WARNING: line length of 101 exceeds 80 columns #1343: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1301: + /* Try to open parent's time namespace handle from new user+time namespace */ WARNING: line length of 94 exceeds 80 columns #1347: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1305: + /* Should NOT succeed - we're in a different user namespace */ WARNING: Statements should start on a tabstop #1378: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1336: + return, "Cannot create new user namespace"); WARNING: Statements should start on a tabstop #1382: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1340: + return, "Cannot set uid/gid mappings"); WARNING: Statements should start on a tabstop #1386: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1344: + return, "Cannot create new time namespace"); WARNING: Statements should start on a tabstop #1418: FILE: tools/testing/selftests/namespaces/file_handle_test.c:1376: + return, "nsfs doesn't support file handles"); total: 0 errors, 74 warnings, 0 checks, 1420 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 8c020f469e73 ("selftests/namespaces: add file handle selftests") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 74 warnings, 0 checks, 1420 lines checked