====== Checking before the patch ====== ====== Checking the tree with the patch ====== New warnings added --- /tmp/tmp.iZsQs0XLBU 2025-09-09 20:01:32.030042968 -0700 +++ /tmp/tmp.yK6DqAkWY6 2025-09-09 20:01:36.969002530 -0700 @@ -7 +7 @@ -In bond_options.sh line 13: +In bond_options.sh line 14: @@ -15 +15 @@ -In bond_options.sh line 22: +In bond_options.sh line 23: @@ -23 +23 @@ -In bond_options.sh line 23: +In bond_options.sh line 24: @@ -28 +28 @@ -In bond_options.sh line 26: +In bond_options.sh line 27: @@ -36 +36 @@ -In bond_options.sh line 27: +In bond_options.sh line 28: @@ -41 +41 @@ -In bond_options.sh line 29: +In bond_options.sh line 30: @@ -49 +49 @@ -In bond_options.sh line 37: +In bond_options.sh line 38: @@ -58 +58 @@ -In bond_options.sh line 38: +In bond_options.sh line 39: @@ -63 +63 @@ -In bond_options.sh line 41: +In bond_options.sh line 42: @@ -71 +71 @@ -In bond_options.sh line 42: +In bond_options.sh line 43: @@ -76 +76 @@ -In bond_options.sh line 44: +In bond_options.sh line 45: @@ -84 +84 @@ -In bond_options.sh line 46: +In bond_options.sh line 47: @@ -92 +92 @@ -In bond_options.sh line 53: +In bond_options.sh line 54: @@ -97 +97 @@ -In bond_options.sh line 55: +In bond_options.sh line 56: @@ -102 +102 @@ -In bond_options.sh line 61: +In bond_options.sh line 62: @@ -110 +110 @@ -In bond_options.sh line 76: +In bond_options.sh line 77: @@ -118 +118 @@ -In bond_options.sh line 79: +In bond_options.sh line 80: @@ -126 +126 @@ -In bond_options.sh line 80: +In bond_options.sh line 81: @@ -134 +134 @@ -In bond_options.sh line 81: +In bond_options.sh line 82: @@ -142 +142 @@ -In bond_options.sh line 98: +In bond_options.sh line 99: @@ -151 +151 @@ -In bond_options.sh line 103: +In bond_options.sh line 104: @@ -160 +160 @@ -In bond_options.sh line 108: +In bond_options.sh line 109: @@ -168 +168 @@ -In bond_options.sh line 124: +In bond_options.sh line 125: @@ -176 +176 @@ -In bond_options.sh line 135: +In bond_options.sh line 136: @@ -185 +185 @@ -In bond_options.sh line 143: +In bond_options.sh line 144: @@ -193 +193 @@ -In bond_options.sh line 144: +In bond_options.sh line 145: @@ -201 +201 @@ -In bond_options.sh line 145: +In bond_options.sh line 146: @@ -209 +209 @@ -In bond_options.sh line 146: +In bond_options.sh line 147: @@ -217 +217 @@ -In bond_options.sh line 148: +In bond_options.sh line 149: @@ -225 +225 @@ -In bond_options.sh line 150: +In bond_options.sh line 151: @@ -233 +233 @@ -In bond_options.sh line 154: +In bond_options.sh line 155: @@ -242 +242 @@ -In bond_options.sh line 208: +In bond_options.sh line 209: @@ -250 +250 @@ -In bond_options.sh line 218: +In bond_options.sh line 219: @@ -258 +258 @@ -In bond_options.sh line 232: +In bond_options.sh line 233: @@ -267 +267 @@ -In bond_options.sh line 238: +In bond_options.sh line 239: @@ -275 +275 @@ -In bond_options.sh line 249: +In bond_options.sh line 250: @@ -280 +280 @@ -In bond_options.sh line 250: +In bond_options.sh line 251: @@ -285 +285 @@ -In bond_options.sh line 253: +In bond_options.sh line 254: @@ -294 +294 @@ -In bond_options.sh line 256: +In bond_options.sh line 257: @@ -302 +302 @@ -In bond_options.sh line 261: +In bond_options.sh line 262: @@ -310 +310 @@ -In bond_options.sh line 263: +In bond_options.sh line 264: @@ -315 +315 @@ -In bond_options.sh line 270: +In bond_options.sh line 271: @@ -324 +324 @@ -In bond_options.sh line 272: +In bond_options.sh line 273: @@ -332 +332 @@ -In bond_options.sh line 276: +In bond_options.sh line 277: @@ -341 +341 @@ -In bond_options.sh line 279: +In bond_options.sh line 280: @@ -349 +349 @@ -In bond_options.sh line 284: +In bond_options.sh line 285: @@ -357 +357 @@ -In bond_options.sh line 337: +In bond_options.sh line 338: @@ -365 +365 @@ -In bond_options.sh line 342: +In bond_options.sh line 343: @@ -374 +374 @@ -In bond_options.sh line 343: +In bond_options.sh line 344: @@ -383 +383 @@ -In bond_options.sh line 348: +In bond_options.sh line 349: @@ -392 +392 @@ -In bond_options.sh line 351: +In bond_options.sh line 352: @@ -400,2 +400,2 @@ -In bond_options.sh line 355: - slowwait_for_counter $((exp_num + 5)) $exp_num \ +In bond_options.sh line 356: + slowwait_for_counter $((exp_num + 5)) $exp_num tc_rule_handle_stats_get \ @@ -405 +405 @@ - slowwait_for_counter $((exp_num + 5)) "$exp_num" \ + slowwait_for_counter $((exp_num + 5)) "$exp_num" tc_rule_handle_stats_get \ @@ -408 +408 @@ -In bond_options.sh line 366: +In bond_options.sh line 367: @@ -416,0 +417,5 @@ +In bond_options.sh line 384: + local bond_mac=$(ip -n "$s_ns" -j link show bond0 | jq -r '.[]["address"]') + ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + + @@ -417,0 +423,71 @@ + local eth0_mac=$(ip -n "$s_ns" -j link show eth0 | jq -r '.[]["address"]') + ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + + +In bond_options.sh line 386: + local eth1_mac=$(ip -n "$s_ns" -j link show eth1 | jq -r '.[]["address"]') + ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + + +In bond_options.sh line 387: + local eth2_mac=$(ip -n "$s_ns" -j link show eth2 | jq -r '.[]["address"]') + ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + + +In bond_options.sh line 398: + local bond_mac=$(ip -n "$s_ns" -j link show bond0 | jq -r '.[]["address"]') + ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + + +In bond_options.sh line 408: + local bond_mac=$(ip -n "$s_ns" -j link show bond0 | jq -r '.[]["address"]') + ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + + +In bond_options.sh line 409: + local active_slave=$(cmd_jq "ip -n ${s_ns} -d -j link show bond0" ".[].linkinfo.info_data.active_slave") + ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + + +In bond_options.sh line 410: + local active_slave_mac=$(ip -n "$s_ns" -j link show "$active_slave" | jq -r '.[]["address"]') + ^--------------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + + +In bond_options.sh line 433: + local backup_macs=$(ip -n "$s_ns" -d -j link show type bond_slave | \ + ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + + +In bond_options.sh line 462: + local active_slave=$(cmd_jq "ip -n ${s_ns} -d -j link show bond0" ".[].linkinfo.info_data.active_slave") + ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values. + + +In bond_options.sh line 463: + ip -n ${s_ns} link set ${active_slave} down + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "${s_ns}" link set "${active_slave}" down + + +In bond_options.sh line 464: + slowwait 2 active_slave_changed $active_slave + ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + slowwait 2 active_slave_changed "$active_slave" + + +In bond_options.sh line 465: + ip -n ${s_ns} link set ${active_slave} up + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ip -n "${s_ns}" link set "${active_slave}" up + + +In bond_options.sh line 520: @@ -429 +505 @@ -In bond_topo_2d1c.sh line 45: +In bond_topo_2d1c.sh line 47: @@ -437 +513 @@ -In bond_topo_2d1c.sh line 46: +In bond_topo_2d1c.sh line 48: @@ -445 +521 @@ -In bond_topo_2d1c.sh line 47: +In bond_topo_2d1c.sh line 49: @@ -453 +529 @@ -In bond_topo_2d1c.sh line 48: +In bond_topo_2d1c.sh line 50: @@ -461 +537 @@ -In bond_topo_2d1c.sh line 49: +In bond_topo_2d1c.sh line 51: @@ -469 +545 @@ -In bond_topo_2d1c.sh line 54: +In bond_topo_2d1c.sh line 56: @@ -477 +553 @@ -In bond_topo_2d1c.sh line 55: +In bond_topo_2d1c.sh line 57: @@ -485 +561 @@ -In bond_topo_2d1c.sh line 60: +In bond_topo_2d1c.sh line 62: @@ -493 +569 @@ -In bond_topo_2d1c.sh line 61: +In bond_topo_2d1c.sh line 63: @@ -501 +577 @@ -In bond_topo_2d1c.sh line 64: +In bond_topo_2d1c.sh line 66: @@ -512 +588 @@ -In bond_topo_2d1c.sh line 66: +In bond_topo_2d1c.sh line 69: @@ -521 +597 @@ -In bond_topo_2d1c.sh line 67: +In bond_topo_2d1c.sh line 70: @@ -530 +606 @@ -In bond_topo_2d1c.sh line 68: +In bond_topo_2d1c.sh line 71: @@ -539 +615 @@ -In bond_topo_2d1c.sh line 70: +In bond_topo_2d1c.sh line 73: @@ -548 +624 @@ -In bond_topo_2d1c.sh line 73: +In bond_topo_2d1c.sh line 76: @@ -556 +632 @@ -In bond_topo_2d1c.sh line 74: +In bond_topo_2d1c.sh line 77: @@ -564 +640 @@ -In bond_topo_2d1c.sh line 75: +In bond_topo_2d1c.sh line 78: @@ -572 +648 @@ -In bond_topo_2d1c.sh line 83: +In bond_topo_2d1c.sh line 86: @@ -581 +657 @@ -In bond_topo_2d1c.sh line 87: +In bond_topo_2d1c.sh line 90: @@ -589 +665 @@ -In bond_topo_2d1c.sh line 88: +In bond_topo_2d1c.sh line 91: @@ -597 +673 @@ -In bond_topo_2d1c.sh line 90: +In bond_topo_2d1c.sh line 93: @@ -606 +682 @@ -In bond_topo_2d1c.sh line 92: +In bond_topo_2d1c.sh line 95: @@ -615 +691 @@ -In bond_topo_2d1c.sh line 95: +In bond_topo_2d1c.sh line 98: @@ -623 +699 @@ -In bond_topo_2d1c.sh line 96: +In bond_topo_2d1c.sh line 99: @@ -631 +707 @@ -In bond_topo_2d1c.sh line 97: +In bond_topo_2d1c.sh line 100: @@ -639 +715 @@ -In bond_topo_2d1c.sh line 99: +In bond_topo_2d1c.sh line 102: @@ -647 +723 @@ -In bond_topo_2d1c.sh line 106: +In bond_topo_2d1c.sh line 109: @@ -656 +732 @@ -In bond_topo_2d1c.sh line 109: +In bond_topo_2d1c.sh line 112: @@ -665 +741 @@ -In bond_topo_2d1c.sh line 111: +In bond_topo_2d1c.sh line 114: @@ -673 +749 @@ -In bond_topo_2d1c.sh line 116: +In bond_topo_2d1c.sh line 119: @@ -681 +757 @@ -In bond_topo_2d1c.sh line 117: +In bond_topo_2d1c.sh line 120: @@ -690 +766 @@ -In bond_topo_2d1c.sh line 119: +In bond_topo_2d1c.sh line 122: @@ -698 +774 @@ -In bond_topo_2d1c.sh line 120: +In bond_topo_2d1c.sh line 123: @@ -706 +782 @@ -In bond_topo_2d1c.sh line 122: +In bond_topo_2d1c.sh line 125: @@ -714 +790 @@ -In bond_topo_2d1c.sh line 123: +In bond_topo_2d1c.sh line 126: @@ -722 +798 @@ -In bond_topo_2d1c.sh line 124: +In bond_topo_2d1c.sh line 127: @@ -730 +806 @@ -In bond_topo_2d1c.sh line 129: +In bond_topo_2d1c.sh line 132: @@ -738 +814 @@ -In bond_topo_2d1c.sh line 130: +In bond_topo_2d1c.sh line 133: @@ -746 +822 @@ -In bond_topo_2d1c.sh line 153: +In bond_topo_2d1c.sh line 156: @@ -754 +830 @@ -In bond_topo_2d1c.sh line 154: +In bond_topo_2d1c.sh line 157: @@ -762 +838 @@ -In bond_topo_2d1c.sh line 156: +In bond_topo_2d1c.sh line 159: @@ -773 +849 @@ -In bond_topo_3d1c.sh line 38: +In bond_topo_3d1c.sh line 39: @@ -782 +858 @@ -In bond_topo_3d1c.sh line 39: +In bond_topo_3d1c.sh line 41: @@ -790 +866 @@ -In bond_topo_3d1c.sh line 40: +In bond_topo_3d1c.sh line 42: @@ -798 +874 @@ -In bond_topo_3d1c.sh line 41: +In bond_topo_3d1c.sh line 43: @@ -806 +882 @@ -In bond_topo_3d1c.sh line 42: +In bond_topo_3d1c.sh line 44: