ShellCheck - shell script analysis tool
version: 0.10.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
Redirect to /tmp/tmp.U7DhneXRj0 and /tmp/tmp.R9xDVemWDT
Tree base:
badefe26d3c4 ("netconsole: resume previously deactivated target")
Now at:
c147e9e4af74 ("selftests: netconsole: validate target reactivation")
 ====== Checking before the patch ======
Checking tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh - bf920798bfe9ad648c492dab7e7cb69c49e9d7fc40353062d15ff0dc93f5036d


In lib_netcons.sh line 58:
	local SRCIF_IFIDX=$(cat /sys/class/net/"$SRCIF"/ifindex)
              ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib_netcons.sh line 59:
	local DSTIF_IFIDX=$(cat /sys/class/net/"$DSTIF"/ifindex)
              ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.

For more information:
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...

 ====== Checking the tree with the patch ======
Checking tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh - bf920798bfe9ad648c492dab7e7cb69c49e9d7fc40353062d15ff0dc93f5036d


In lib_netcons.sh line 58:
	local SRCIF_IFIDX=$(cat /sys/class/net/"$SRCIF"/ifindex)
              ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib_netcons.sh line 59:
	local DSTIF_IFIDX=$(cat /sys/class/net/"$DSTIF"/ifindex)
              ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.


In lib_netcons.sh line 370:
	slowwait 2 sh -c 'test -n "$(grep '"'${ENABLED}'"' '"'${FILENAME}'"')"' || {
                         ^----------------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.

For more information:
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
  https://www.shellcheck.net/wiki/SC2016 -- Expressions don't expand in singl...

Checking tools/testing/selftests/drivers/net/netcons_resume.sh - 0d892e98b523ab3cd61407b6550c98c1da8d1a82e6f1bab1e03a008e0a815570


In netcons_resume.sh line 37:
set_network
^---------^ SC2119 (info): Use set_network "$@" if function's $1 should mean script's $1.


In netcons_resume.sh line 39:
create_dynamic_target
^-------------------^ SC2119 (info): Use create_dynamic_target "$@" if function's $1 should mean script's $1.


In netcons_resume.sh line 49:
set_network
^---------^ SC2119 (info): Use set_network "$@" if function's $1 should mean script's $1.


In netcons_resume.sh line 68:
exit "${ksft_pass}"
      ^----------^ SC2154 (warning): ksft_pass is referenced but not assigned.

For more information:
  https://www.shellcheck.net/wiki/SC2154 -- ksft_pass is referenced but not a...
  https://www.shellcheck.net/wiki/SC2119 -- Use create_dynamic_target "$@" if...