pylint 3.3.7 astroid 3.3.8 Python 3.13.5 (main, Jun 12 2025, 00:00:00) [GCC 15.1.1 20250521 (Red Hat 15.1.1-2)] Redirect to /tmp/tmp.WuaPlM9w9S and /tmp/tmp.p4Sw9avZgC Tree base: 7afacf65bec6 ("tools: ynl: remove unnecessary semicolons") Now at: e8d0cc5e37a9 ("tools: ynl: use 'cond is None'") ====== Checking before the patch ====== ************* Module pyynl.lib.ynl tools/net/ynl/pyynl/lib/ynl.py:103:0: W0311: Bad indentation. Found 2 spaces, expected 4 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:104:0: W0311: Bad indentation. Found 4 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:105:0: W0311: Bad indentation. Found 4 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:107:0: W0311: Bad indentation. Found 2 spaces, expected 4 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:108:0: W0311: Bad indentation. Found 4 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:275:0: C0301: Line too long (113/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:748:0: C0301: Line too long (114/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:769:0: C0301: Line too long (107/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:801:0: C0301: Line too long (101/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:816:0: C0301: Line too long (101/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:1016:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1020:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1021:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1022:0: W0311: Bad indentation. Found 8 spaces, expected 12 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1024:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1:0: C0302: Too many lines in module (1124/1000) (too-many-lines) tools/net/ynl/pyynl/lib/ynl.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/net/ynl/pyynl/lib/ynl.py:25:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:25:0: R0903: Too few public methods (0/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:102:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:111:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:115:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:137:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:138:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:144:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:145:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:148:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:152:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:150:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:155:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:158:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:161:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:161:25: W0622: Redefining built-in 'type' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:162:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:169:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:190:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:190:0: R0902: Too many instance attributes (10/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/ynl.py:214:26: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:239:16: W0622: Redefining built-in 'type' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:271:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:283:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:283:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:297:0: C0103: Constant name "genl_family_name_to_id" doesn't conform to UPPER_CASE naming style (invalid-name) tools/net/ynl/pyynl/lib/ynl.py:324:8: W0603: Using the global statement (global-statement) tools/net/ynl/pyynl/lib/ynl.py:325:33: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:338:22: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:347:39: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:327:8: R1702: Too many nested blocks (7/5) (too-many-nested-blocks) tools/net/ynl/pyynl/lib/ynl.py:327:8: R1702: Too many nested blocks (6/5) (too-many-nested-blocks) tools/net/ynl/pyynl/lib/ynl.py:313:0: R0912: Too many branches (15/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:362:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:368:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:374:17: E1101: Instance of 'GenlMsg' has no 'raw_attrs' member (no-member) tools/net/ynl/pyynl/lib/ynl.py:379:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:390:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:390:38: W0613: Unused argument 'version' (unused-argument) tools/net/ynl/pyynl/lib/ynl.py:396:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:400:28: W0212: Access to a protected member _struct_size of a client class (protected-access) tools/net/ynl/pyynl/lib/ynl.py:404:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:406:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:409:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:413:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:417:8: W0602: Using global for 'genl_family_name_to_id' but no assignment is done (global-variable-not-assigned) tools/net/ynl/pyynl/lib/ynl.py:434:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:441:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:449:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:455:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:457:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:441:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:465:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:465:0: R0902: Too many instance attributes (8/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/ynl.py:480:12: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Family '{self.yaml['name']}' not supported by the kernel") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:480:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:510:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:516:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:529:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:549:4: R0914: Too many local variables (19/15) (too-many-locals) tools/net/ynl/pyynl/lib/ynl.py:589:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:553:12: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Space '{space}' has no attribute '{name}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:553:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:592:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:618:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:620:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:549:4: R0912: Too many branches (28/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:549:4: R0915: Too many statements (64/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:688:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:702:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:708:11: C0121: Comparison 'is_multi == None' should be 'is_multi is None' (singleton-comparison) tools/net/ynl/pyynl/lib/ynl.py:709:31: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck) tools/net/ynl/pyynl/lib/ynl.py:725:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:731:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:748:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:752:14: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:762:20: W0707: Consider explicitly re-raising using 'except (KeyError, UnboundLocalError) as exc' and 'raise Exception(f"Space '{space}' has no attribute with value '{attr.type}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:762:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:769:94: E0606: Possibly using variable 'search_attrs' before assignment (possibly-used-before-assignment) tools/net/ynl/pyynl/lib/ynl.py:801:24: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:751:4: R0912: Too many branches (21/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:751:4: R0915: Too many statements (53/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:811:4: R0913: Too many arguments (6/5) (too-many-arguments) tools/net/ynl/pyynl/lib/ynl.py:811:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/net/ynl/pyynl/lib/ynl.py:816:16: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Space '{attr_set.name}' has no attribute with value '{attr.type}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:816:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:833:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:837:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:871:20: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:861:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:887:20: W0622: Redefining built-in 'len' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:895:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:879:16: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:926:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:916:32: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:932:33: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/net/ynl/pyynl/lib/ynl.py:954:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:958:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:959:14: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:971:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:996:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1040:4: R0914: Too many local variables (20/15) (too-many-locals) tools/net/ynl/pyynl/lib/ynl.py:1095:20: R1724: Unnecessary "else" after "continue", remove the "else" and de-indent the code inside it (no-else-continue) tools/net/ynl/pyynl/lib/ynl.py:1040:4: R0912: Too many branches (17/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:1040:4: R0915: Too many statements (54/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:1117:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1120:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1123:4: C0116: Missing function or method docstring (missing-function-docstring) ------------------------------------------------------------------ Your code has been rated at 8.46/10 (previous run: 8.46/10, +0.00) ************* Module pyynl.ynl_gen_c tools/net/ynl/pyynl/ynl_gen_c.py:308:0: C0301: Line too long (104/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:411:0: C0301: Line too long (125/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:434:0: C0301: Line too long (106/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:648:0: C0301: Line too long (107/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:652:0: C0301: Line too long (112/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:778:0: C0301: Line too long (133/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:850:0: C0301: Line too long (101/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:1021:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) tools/net/ynl/pyynl/ynl_gen_c.py:1023:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) tools/net/ynl/pyynl/ynl_gen_c.py:1207:0: C0301: Line too long (102/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:1965:0: C0301: Line too long (102/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:2152:0: C0301: Line too long (116/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:2186:0: C0301: Line too long (105/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:2672:0: W0311: Bad indentation. Found 8 spaces, expected 4 (bad-indentation) tools/net/ynl/pyynl/ynl_gen_c.py:2776:0: C0301: Line too long (120/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:3009:0: C0301: Line too long (102/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:3330:0: C0301: Line too long (103/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:3368:0: C0301: Line too long (106/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:3389:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) tools/net/ynl/pyynl/ynl_gen_c.py:3572:0: C0301: Line too long (106/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:3650:0: C0301: Line too long (106/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:1:0: C0302: Too many lines in module (3670/1000) (too-many-lines) tools/net/ynl/pyynl/ynl_gen_c.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:15:0: C0413: Import "from lib import SpecFamily, SpecAttrSet, SpecAttr, SpecOperation, SpecEnumSet, SpecEnumEntry" should be placed at the top of the module (wrong-import-position) tools/net/ynl/pyynl/ynl_gen_c.py:15:0: E0611: No name 'SpecFamily' in module 'lib' (no-name-in-module) tools/net/ynl/pyynl/ynl_gen_c.py:15:0: E0611: No name 'SpecAttrSet' in module 'lib' (no-name-in-module) tools/net/ynl/pyynl/ynl_gen_c.py:15:0: E0611: No name 'SpecAttr' in module 'lib' (no-name-in-module) tools/net/ynl/pyynl/ynl_gen_c.py:15:0: E0611: No name 'SpecOperation' in module 'lib' (no-name-in-module) tools/net/ynl/pyynl/ynl_gen_c.py:15:0: E0611: No name 'SpecEnumSet' in module 'lib' (no-name-in-module) tools/net/ynl/pyynl/ynl_gen_c.py:15:0: E0611: No name 'SpecEnumEntry' in module 'lib' (no-name-in-module) tools/net/ynl/pyynl/ynl_gen_c.py:16:0: C0413: Import "from lib import SpecSubMessage" should be placed at the top of the module (wrong-import-position) tools/net/ynl/pyynl/ynl_gen_c.py:16:0: E0611: No name 'SpecSubMessage' in module 'lib' (no-name-in-module) tools/net/ynl/pyynl/ynl_gen_c.py:19:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:23:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:42:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:43:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:42:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/ynl_gen_c.py:47:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:47:0: R0902: Too many instance attributes (13/7) (too-many-instance-attributes) tools/net/ynl/pyynl/ynl_gen_c.py:97:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:102:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:107:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:117:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:130:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:141:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:143:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:146:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:149:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:152:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:155:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:158:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:158:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) tools/net/ynl/pyynl/ynl_gen_c.py:170:35: W0613: Unused argument 'ri' (unused-argument) tools/net/ynl/pyynl/ynl_gen_c.py:173:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:176:26: W0613: Unused argument 'ri' (unused-argument) tools/net/ynl/pyynl/ynl_gen_c.py:181:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:186:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:187:8: E1128: Assigning result of a function call, where the function returns None (assignment-from-none) tools/net/ynl/pyynl/ynl_gen_c.py:189:25: E1136: Value 'member' is unsubscriptable (unsubscriptable-object) tools/net/ynl/pyynl/ynl_gen_c.py:194:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:196:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:197:8: E1128: Assigning result of a function call, where the function returns None (assignment-from-none) tools/net/ynl/pyynl/ynl_gen_c.py:202:25: E1136: Value 'member' is unsubscriptable (unsubscriptable-object) tools/net/ynl/pyynl/ynl_gen_c.py:212:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:222:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:224:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:238:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:239:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:242:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:244:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:246:11: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck) tools/net/ynl/pyynl/ynl_gen_c.py:248:11: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck) tools/net/ynl/pyynl/ynl_gen_c.py:275:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:277:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:277:4: R0913: Too many arguments (7/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:277:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:277:4: R0914: Too many local variables (16/15) (too-many-locals) tools/net/ynl/pyynl/ynl_gen_c.py:287:8: C0200: Consider using enumerate instead of iterating with range and len (consider-using-enumerate) tools/net/ynl/pyynl/ynl_gen_c.py:277:25: W0613: Unused argument 'space' (unused-argument) tools/net/ynl/pyynl/ynl_gen_c.py:311:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:333:4: R0913: Too many arguments (7/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:333:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:337:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:356:4: R0913: Too many arguments (7/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:356:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:360:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:400:15: C0121: Comparison 'low == None' should be 'low is None' (singleton-comparison) tools/net/ynl/pyynl/ynl_gen_c.py:400:31: C0121: Comparison 'high == None' should be 'high is None' (singleton-comparison) tools/net/ynl/pyynl/ynl_gen_c.py:411:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:417:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:422:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) tools/net/ynl/pyynl/ynl_gen_c.py:421:4: R0911: Too many return statements (7/6) (too-many-return-statements) tools/net/ynl/pyynl/ynl_gen_c.py:459:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:476:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:530:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:549:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:551:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:562:15: E0606: Possibly using variable 'mem' before assignment (possibly-used-before-assignment) tools/net/ynl/pyynl/ynl_gen_c.py:582:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:599:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:633:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:642:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:658:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:696:4: R0913: Too many arguments (7/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:696:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:706:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:707:4: R0913: Too many arguments (6/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:707:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:719:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) tools/net/ynl/pyynl/ynl_gen_c.py:729:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:759:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:763:15: W0212: Access to a protected member _attr_policy of a client class (protected-access) tools/net/ynl/pyynl/ynl_gen_c.py:766:15: W0212: Access to a protected member _attr_typol of a client class (protected-access) tools/net/ynl/pyynl/ynl_gen_c.py:787:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:794:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:802:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) tools/net/ynl/pyynl/ynl_gen_c.py:810:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:819:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) tools/net/ynl/pyynl/ynl_gen_c.py:850:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:858:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:888:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:911:21: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/net/ynl/pyynl/ynl_gen_c.py:920:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:933:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:936:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:940:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:940:0: R0902: Too many instance attributes (19/7) (too-many-instance-attributes) tools/net/ynl/pyynl/ynl_gen_c.py:941:4: R0913: Too many arguments (7/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:941:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:972:21: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ynl_gen_c.py:994:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:997:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:999:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:1002:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1004:12: W0612: Unused variable 'name' (unused-variable) tools/net/ynl/pyynl/ynl_gen_c.py:1009:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1016:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1017:33: W0621: Redefining name 'yaml' from outer scope (line 12) (redefined-outer-name) tools/net/ynl/pyynl/ynl_gen_c.py:1030:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1016:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/ynl_gen_c.py:1036:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1037:31: W0621: Redefining name 'yaml' from outer scope (line 12) (redefined-outer-name) tools/net/ynl/pyynl/ynl_gen_c.py:1060:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1063:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1064:14: R1728: Consider using a generator instead 'min(x.value for x in self.entries.values())' (consider-using-generator) tools/net/ynl/pyynl/ynl_gen_c.py:1065:15: R1728: Consider using a generator instead 'max(x.value for x in self.entries.values())' (consider-using-generator) tools/net/ynl/pyynl/ynl_gen_c.py:1073:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1074:31: W0621: Redefining name 'yaml' from outer scope (line 12) (redefined-outer-name) tools/net/ynl/pyynl/ynl_gen_c.py:1096:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1103:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1129:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:1135:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:1103:4: R0912: Too many branches (18/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:1143:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1144:31: W0621: Redefining name 'yaml' from outer scope (line 12) (redefined-outer-name) tools/net/ynl/pyynl/ynl_gen_c.py:1166:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1174:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1178:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1179:31: W0621: Redefining name 'yaml' from outer scope (line 12) (redefined-outer-name) tools/net/ynl/pyynl/ynl_gen_c.py:1184:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1178:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/ynl_gen_c.py:1188:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1188:0: R0902: Too many instance attributes (15/7) (too-many-instance-attributes) tools/net/ynl/pyynl/ynl_gen_c.py:1221:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1236:21: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ynl_gen_c.py:1238:31: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ynl_gen_c.py:1240:44: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ynl_gen_c.py:1245:25: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ynl_gen_c.py:1247:35: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ynl_gen_c.py:1262:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1265:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1268:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1271:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1274:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1293:12: W0612: Unused variable 'op_name' (unused-variable) tools/net/ynl/pyynl/ynl_gen_c.py:1354:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:1358:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:1409:14: C1802: Do not use `len(SEQUENCE)` without comparison to determine if a sequence is empty (use-implicit-booleaness-not-len) tools/net/ynl/pyynl/ynl_gen_c.py:1405:4: R0912: Too many branches (24/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:1507:24: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:1492:22: W0612: Unused variable 'struct' (unused-variable) tools/net/ynl/pyynl/ynl_gen_c.py:1521:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:1512:12: W0612: Unused variable 'op_name' (unused-variable) tools/net/ynl/pyynl/ynl_gen_c.py:1245:8: W0201: Attribute 'root_sets' defined outside __init__ (attribute-defined-outside-init) tools/net/ynl/pyynl/ynl_gen_c.py:1247:8: W0201: Attribute 'pure_nested_structs' defined outside __init__ (attribute-defined-outside-init) tools/net/ynl/pyynl/ynl_gen_c.py:1258:8: W0201: Attribute 'kernel_policy' defined outside __init__ (attribute-defined-outside-init) tools/net/ynl/pyynl/ynl_gen_c.py:1529:8: W0201: Attribute 'global_policy' defined outside __init__ (attribute-defined-outside-init) tools/net/ynl/pyynl/ynl_gen_c.py:1530:8: W0201: Attribute 'global_policy_set' defined outside __init__ (attribute-defined-outside-init) tools/net/ynl/pyynl/ynl_gen_c.py:1550:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1550:0: R0902: Too many instance attributes (13/7) (too-many-instance-attributes) tools/net/ynl/pyynl/ynl_gen_c.py:1551:4: R0913: Too many arguments (7/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:1551:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:1565:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:1595:22: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ynl_gen_c.py:1551:4: R0912: Too many branches (18/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:1611:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1615:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1619:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1619:0: R0902: Too many instance attributes (9/7) (too-many-instance-attributes) tools/net/ynl/pyynl/ynl_gen_c.py:1632:24: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) tools/net/ynl/pyynl/ynl_gen_c.py:1638:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1646:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) tools/net/ynl/pyynl/ynl_gen_c.py:1656:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1681:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1684:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1690:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1703:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1715:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1715:4: R0913: Too many arguments (6/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:1715:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:1757:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1761:11: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck) tools/net/ynl/pyynl/ynl_gen_c.py:1769:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1769:4: R0913: Too many arguments (6/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:1769:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:1778:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1781:12: R1731: Consider using 'longest = max(longest, len(define[0]))' instead of unnecessary if block (consider-using-max-builtin) tools/net/ynl/pyynl/ynl_gen_c.py:1787:15: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck) tools/net/ynl/pyynl/ynl_gen_c.py:1789:17: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck) tools/net/ynl/pyynl/ynl_gen_c.py:1793:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1794:18: R1728: Consider using a generator instead 'max(len(x[0]) for x in members)' (consider-using-generator) tools/net/ynl/pyynl/ynl_gen_c.py:1803:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1870:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1878:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1903:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1907:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1925:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1929:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1933:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1955:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1959:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1995:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1999:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2020:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2020:24: W0613: Unused argument 'family' (unused-argument) tools/net/ynl/pyynl/ynl_gen_c.py:2025:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2025:20: W0613: Unused argument 'family' (unused-argument) tools/net/ynl/pyynl/ynl_gen_c.py:2036:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2045:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2101:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:2115:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:2188:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:2225:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:2087:0: R0912: Too many branches (40/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:2087:0: R0915: Too many statements (127/50) (too-many-statements) tools/net/ynl/pyynl/ynl_gen_c.py:2240:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2249:23: W0212: Access to a protected member _attr_get of a client class (protected-access) tools/net/ynl/pyynl/ynl_gen_c.py:2263:35: W0212: Access to a protected member _attr_get of a client class (protected-access) tools/net/ynl/pyynl/ynl_gen_c.py:2276:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2290:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2290:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) tools/net/ynl/pyynl/ynl_gen_c.py:2310:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2333:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2333:0: R0912: Too many branches (15/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:2333:0: R0915: Too many statements (56/50) (too-many-statements) tools/net/ynl/pyynl/ynl_gen_c.py:2408:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2464:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2468:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2474:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2493:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2502:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2552:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2556:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2573:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2586:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2593:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2599:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2609:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2615:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2621:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2622:8: R1714: Consider merging these comparisons with 'in' by using 'ri.op_mode in ('do', 'dump')'. Use a set instead if elements are hashable. (consider-using-in) tools/net/ynl/pyynl/ynl_gen_c.py:2631:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2635:9: R1714: Consider merging these comparisons with 'in' by using 'ri.op_mode in ('notify', 'event')'. Use a set instead if elements are hashable. (consider-using-in) tools/net/ynl/pyynl/ynl_gen_c.py:2671:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2675:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2679:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2685:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2705:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2715:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2739:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2750:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2754:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2758:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2787:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2825:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2825:0: R0912: Too many branches (18/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:2892:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2896:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2898:7: R1714: Consider merging these comparisons with 'in' by using 'family.kernel_policy in ('global', 'per-op')'. Use a set instead if elements are hashable. (consider-using-in) tools/net/ynl/pyynl/ynl_gen_c.py:2925:4: R1702: Too many nested blocks (6/5) (too-many-nested-blocks) tools/net/ynl/pyynl/ynl_gen_c.py:2896:0: R0912: Too many branches (22/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:2896:0: R0915: Too many statements (59/50) (too-many-statements) tools/net/ynl/pyynl/ynl_gen_c.py:2976:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2988:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3001:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3013:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3050:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3060:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3087:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3141:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3141:0: R0914: Too many local variables (22/15) (too-many-locals) tools/net/ynl/pyynl/ynl_gen_c.py:3254:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:3141:0: R0912: Too many branches (35/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:3141:0: R0915: Too many statements (107/50) (too-many-statements) tools/net/ynl/pyynl/ynl_gen_c.py:3296:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3311:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:3296:0: R0912: Too many branches (14/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:3313:12: W0612: Unused variable 'op_name' (unused-variable) tools/net/ynl/pyynl/ynl_gen_c.py:3339:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3349:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3359:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3359:0: R0914: Too many local variables (23/15) (too-many-locals) tools/net/ynl/pyynl/ynl_gen_c.py:3387:8: W0101: Unreachable code (unreachable) tools/net/ynl/pyynl/ynl_gen_c.py:3466:4: R1702: Too many nested blocks (6/5) (too-many-nested-blocks) tools/net/ynl/pyynl/ynl_gen_c.py:3572:24: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:3650:24: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:3359:0: R0912: Too many branches (83/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:3359:0: R0915: Too many statements (243/50) (too-many-statements) tools/net/ynl/pyynl/ynl_gen_c.py:3485:20: W0612: Unused variable 'op_name' (unused-variable) ------------------------------------------------------------------ Your code has been rated at 8.63/10 (previous run: 8.63/10, +0.00) ====== Checking the tree with the patch ====== ************* Module pyynl.lib.ynl tools/net/ynl/pyynl/lib/ynl.py:103:0: W0311: Bad indentation. Found 2 spaces, expected 4 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:104:0: W0311: Bad indentation. Found 4 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:105:0: W0311: Bad indentation. Found 4 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:107:0: W0311: Bad indentation. Found 2 spaces, expected 4 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:108:0: W0311: Bad indentation. Found 4 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:275:0: C0301: Line too long (113/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:748:0: C0301: Line too long (114/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:769:0: C0301: Line too long (107/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:801:0: C0301: Line too long (101/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:816:0: C0301: Line too long (101/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:1016:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1020:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1021:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1022:0: W0311: Bad indentation. Found 8 spaces, expected 12 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1024:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1:0: C0302: Too many lines in module (1124/1000) (too-many-lines) tools/net/ynl/pyynl/lib/ynl.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/net/ynl/pyynl/lib/ynl.py:25:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:25:0: R0903: Too few public methods (0/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:102:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:111:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:115:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:137:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:138:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:144:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:145:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:148:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:152:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:150:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:155:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:158:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:161:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:161:25: W0622: Redefining built-in 'type' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:162:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:169:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:190:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:190:0: R0902: Too many instance attributes (10/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/ynl.py:214:26: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:239:16: W0622: Redefining built-in 'type' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:271:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:283:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:283:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:297:0: C0103: Constant name "genl_family_name_to_id" doesn't conform to UPPER_CASE naming style (invalid-name) tools/net/ynl/pyynl/lib/ynl.py:324:8: W0603: Using the global statement (global-statement) tools/net/ynl/pyynl/lib/ynl.py:325:33: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:338:22: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:347:39: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:327:8: R1702: Too many nested blocks (7/5) (too-many-nested-blocks) tools/net/ynl/pyynl/lib/ynl.py:327:8: R1702: Too many nested blocks (6/5) (too-many-nested-blocks) tools/net/ynl/pyynl/lib/ynl.py:313:0: R0912: Too many branches (15/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:362:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:368:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:374:17: E1101: Instance of 'GenlMsg' has no 'raw_attrs' member (no-member) tools/net/ynl/pyynl/lib/ynl.py:379:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:390:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:390:38: W0613: Unused argument 'version' (unused-argument) tools/net/ynl/pyynl/lib/ynl.py:396:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:400:28: W0212: Access to a protected member _struct_size of a client class (protected-access) tools/net/ynl/pyynl/lib/ynl.py:404:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:406:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:409:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:413:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:417:8: W0602: Using global for 'genl_family_name_to_id' but no assignment is done (global-variable-not-assigned) tools/net/ynl/pyynl/lib/ynl.py:434:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:441:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:449:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:455:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:457:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:441:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:465:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:465:0: R0902: Too many instance attributes (8/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/ynl.py:480:12: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Family '{self.yaml['name']}' not supported by the kernel") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:480:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:510:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:516:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:529:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:549:4: R0914: Too many local variables (19/15) (too-many-locals) tools/net/ynl/pyynl/lib/ynl.py:589:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:553:12: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Space '{space}' has no attribute '{name}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:553:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:592:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:618:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:620:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:549:4: R0912: Too many branches (28/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:549:4: R0915: Too many statements (64/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:688:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:702:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:709:31: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck) tools/net/ynl/pyynl/lib/ynl.py:725:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:731:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:748:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:752:14: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:762:20: W0707: Consider explicitly re-raising using 'except (KeyError, UnboundLocalError) as exc' and 'raise Exception(f"Space '{space}' has no attribute with value '{attr.type}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:762:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:769:94: E0606: Possibly using variable 'search_attrs' before assignment (possibly-used-before-assignment) tools/net/ynl/pyynl/lib/ynl.py:801:24: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:751:4: R0912: Too many branches (21/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:751:4: R0915: Too many statements (53/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:811:4: R0913: Too many arguments (6/5) (too-many-arguments) tools/net/ynl/pyynl/lib/ynl.py:811:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/net/ynl/pyynl/lib/ynl.py:816:16: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Space '{attr_set.name}' has no attribute with value '{attr.type}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:816:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:833:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:837:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:871:20: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:861:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:887:20: W0622: Redefining built-in 'len' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:895:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:879:16: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:926:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:916:32: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:932:33: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/net/ynl/pyynl/lib/ynl.py:954:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:958:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:959:14: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:971:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:996:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1040:4: R0914: Too many local variables (20/15) (too-many-locals) tools/net/ynl/pyynl/lib/ynl.py:1095:20: R1724: Unnecessary "else" after "continue", remove the "else" and de-indent the code inside it (no-else-continue) tools/net/ynl/pyynl/lib/ynl.py:1040:4: R0912: Too many branches (17/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:1040:4: R0915: Too many statements (54/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:1117:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1120:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1123:4: C0116: Missing function or method docstring (missing-function-docstring) ------------------------------------------------------------------ Your code has been rated at 8.47/10 (previous run: 8.46/10, +0.01) ************* Module pyynl.ynl_gen_c tools/net/ynl/pyynl/ynl_gen_c.py:308:0: C0301: Line too long (104/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:411:0: C0301: Line too long (125/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:434:0: C0301: Line too long (106/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:648:0: C0301: Line too long (107/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:652:0: C0301: Line too long (112/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:778:0: C0301: Line too long (133/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:850:0: C0301: Line too long (101/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:1021:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) tools/net/ynl/pyynl/ynl_gen_c.py:1023:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) tools/net/ynl/pyynl/ynl_gen_c.py:1207:0: C0301: Line too long (102/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:1965:0: C0301: Line too long (102/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:2152:0: C0301: Line too long (116/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:2186:0: C0301: Line too long (105/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:2672:0: W0311: Bad indentation. Found 8 spaces, expected 4 (bad-indentation) tools/net/ynl/pyynl/ynl_gen_c.py:2776:0: C0301: Line too long (120/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:3009:0: C0301: Line too long (102/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:3330:0: C0301: Line too long (103/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:3368:0: C0301: Line too long (106/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:3389:0: C0325: Unnecessary parens after '=' keyword (superfluous-parens) tools/net/ynl/pyynl/ynl_gen_c.py:3572:0: C0301: Line too long (106/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:3650:0: C0301: Line too long (106/100) (line-too-long) tools/net/ynl/pyynl/ynl_gen_c.py:1:0: C0302: Too many lines in module (3670/1000) (too-many-lines) tools/net/ynl/pyynl/ynl_gen_c.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:15:0: C0413: Import "from lib import SpecFamily, SpecAttrSet, SpecAttr, SpecOperation, SpecEnumSet, SpecEnumEntry" should be placed at the top of the module (wrong-import-position) tools/net/ynl/pyynl/ynl_gen_c.py:15:0: E0611: No name 'SpecFamily' in module 'lib' (no-name-in-module) tools/net/ynl/pyynl/ynl_gen_c.py:15:0: E0611: No name 'SpecAttrSet' in module 'lib' (no-name-in-module) tools/net/ynl/pyynl/ynl_gen_c.py:15:0: E0611: No name 'SpecAttr' in module 'lib' (no-name-in-module) tools/net/ynl/pyynl/ynl_gen_c.py:15:0: E0611: No name 'SpecOperation' in module 'lib' (no-name-in-module) tools/net/ynl/pyynl/ynl_gen_c.py:15:0: E0611: No name 'SpecEnumSet' in module 'lib' (no-name-in-module) tools/net/ynl/pyynl/ynl_gen_c.py:15:0: E0611: No name 'SpecEnumEntry' in module 'lib' (no-name-in-module) tools/net/ynl/pyynl/ynl_gen_c.py:16:0: C0413: Import "from lib import SpecSubMessage" should be placed at the top of the module (wrong-import-position) tools/net/ynl/pyynl/ynl_gen_c.py:16:0: E0611: No name 'SpecSubMessage' in module 'lib' (no-name-in-module) tools/net/ynl/pyynl/ynl_gen_c.py:19:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:23:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:42:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:43:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:42:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/ynl_gen_c.py:47:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:47:0: R0902: Too many instance attributes (13/7) (too-many-instance-attributes) tools/net/ynl/pyynl/ynl_gen_c.py:97:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:102:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:107:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:117:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:130:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:141:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:143:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:146:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:149:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:152:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:155:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:158:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:158:4: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) tools/net/ynl/pyynl/ynl_gen_c.py:170:35: W0613: Unused argument 'ri' (unused-argument) tools/net/ynl/pyynl/ynl_gen_c.py:173:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:176:26: W0613: Unused argument 'ri' (unused-argument) tools/net/ynl/pyynl/ynl_gen_c.py:181:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:186:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:187:8: E1128: Assigning result of a function call, where the function returns None (assignment-from-none) tools/net/ynl/pyynl/ynl_gen_c.py:189:25: E1136: Value 'member' is unsubscriptable (unsubscriptable-object) tools/net/ynl/pyynl/ynl_gen_c.py:194:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:196:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:197:8: E1128: Assigning result of a function call, where the function returns None (assignment-from-none) tools/net/ynl/pyynl/ynl_gen_c.py:202:25: E1136: Value 'member' is unsubscriptable (unsubscriptable-object) tools/net/ynl/pyynl/ynl_gen_c.py:212:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:222:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:224:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:238:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:239:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:242:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:244:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:246:11: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck) tools/net/ynl/pyynl/ynl_gen_c.py:248:11: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck) tools/net/ynl/pyynl/ynl_gen_c.py:275:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:277:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:277:4: R0913: Too many arguments (7/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:277:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:277:4: R0914: Too many local variables (16/15) (too-many-locals) tools/net/ynl/pyynl/ynl_gen_c.py:287:8: C0200: Consider using enumerate instead of iterating with range and len (consider-using-enumerate) tools/net/ynl/pyynl/ynl_gen_c.py:277:25: W0613: Unused argument 'space' (unused-argument) tools/net/ynl/pyynl/ynl_gen_c.py:311:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:333:4: R0913: Too many arguments (7/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:333:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:337:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:356:4: R0913: Too many arguments (7/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:356:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:360:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:411:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:417:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:422:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) tools/net/ynl/pyynl/ynl_gen_c.py:421:4: R0911: Too many return statements (7/6) (too-many-return-statements) tools/net/ynl/pyynl/ynl_gen_c.py:459:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:476:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:530:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:549:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:551:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:562:15: E0606: Possibly using variable 'mem' before assignment (possibly-used-before-assignment) tools/net/ynl/pyynl/ynl_gen_c.py:582:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:599:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:633:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:642:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:658:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:696:4: R0913: Too many arguments (7/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:696:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:706:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:707:4: R0913: Too many arguments (6/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:707:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:719:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) tools/net/ynl/pyynl/ynl_gen_c.py:729:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:759:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:763:15: W0212: Access to a protected member _attr_policy of a client class (protected-access) tools/net/ynl/pyynl/ynl_gen_c.py:766:15: W0212: Access to a protected member _attr_typol of a client class (protected-access) tools/net/ynl/pyynl/ynl_gen_c.py:787:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:794:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:802:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) tools/net/ynl/pyynl/ynl_gen_c.py:810:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:819:8: R1705: Unnecessary "elif" after "return", remove the leading "el" from "elif" (no-else-return) tools/net/ynl/pyynl/ynl_gen_c.py:850:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:858:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:888:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:911:21: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/net/ynl/pyynl/ynl_gen_c.py:920:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:933:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:936:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:940:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:940:0: R0902: Too many instance attributes (19/7) (too-many-instance-attributes) tools/net/ynl/pyynl/ynl_gen_c.py:941:4: R0913: Too many arguments (7/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:941:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:972:21: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ynl_gen_c.py:994:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:997:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:999:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:1002:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1004:12: W0612: Unused variable 'name' (unused-variable) tools/net/ynl/pyynl/ynl_gen_c.py:1009:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1016:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1017:33: W0621: Redefining name 'yaml' from outer scope (line 12) (redefined-outer-name) tools/net/ynl/pyynl/ynl_gen_c.py:1030:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1016:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/ynl_gen_c.py:1036:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1037:31: W0621: Redefining name 'yaml' from outer scope (line 12) (redefined-outer-name) tools/net/ynl/pyynl/ynl_gen_c.py:1060:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1063:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1064:14: R1728: Consider using a generator instead 'min(x.value for x in self.entries.values())' (consider-using-generator) tools/net/ynl/pyynl/ynl_gen_c.py:1065:15: R1728: Consider using a generator instead 'max(x.value for x in self.entries.values())' (consider-using-generator) tools/net/ynl/pyynl/ynl_gen_c.py:1073:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1074:31: W0621: Redefining name 'yaml' from outer scope (line 12) (redefined-outer-name) tools/net/ynl/pyynl/ynl_gen_c.py:1096:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1103:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1129:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:1135:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:1103:4: R0912: Too many branches (18/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:1143:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1144:31: W0621: Redefining name 'yaml' from outer scope (line 12) (redefined-outer-name) tools/net/ynl/pyynl/ynl_gen_c.py:1166:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1174:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1178:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1179:31: W0621: Redefining name 'yaml' from outer scope (line 12) (redefined-outer-name) tools/net/ynl/pyynl/ynl_gen_c.py:1184:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1178:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/ynl_gen_c.py:1188:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1188:0: R0902: Too many instance attributes (15/7) (too-many-instance-attributes) tools/net/ynl/pyynl/ynl_gen_c.py:1221:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1236:21: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ynl_gen_c.py:1238:31: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ynl_gen_c.py:1240:44: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ynl_gen_c.py:1245:25: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ynl_gen_c.py:1247:35: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ynl_gen_c.py:1262:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1265:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1268:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1271:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1274:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1293:12: W0612: Unused variable 'op_name' (unused-variable) tools/net/ynl/pyynl/ynl_gen_c.py:1354:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:1358:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:1409:14: C1802: Do not use `len(SEQUENCE)` without comparison to determine if a sequence is empty (use-implicit-booleaness-not-len) tools/net/ynl/pyynl/ynl_gen_c.py:1405:4: R0912: Too many branches (24/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:1507:24: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:1492:22: W0612: Unused variable 'struct' (unused-variable) tools/net/ynl/pyynl/ynl_gen_c.py:1521:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:1512:12: W0612: Unused variable 'op_name' (unused-variable) tools/net/ynl/pyynl/ynl_gen_c.py:1245:8: W0201: Attribute 'root_sets' defined outside __init__ (attribute-defined-outside-init) tools/net/ynl/pyynl/ynl_gen_c.py:1247:8: W0201: Attribute 'pure_nested_structs' defined outside __init__ (attribute-defined-outside-init) tools/net/ynl/pyynl/ynl_gen_c.py:1258:8: W0201: Attribute 'kernel_policy' defined outside __init__ (attribute-defined-outside-init) tools/net/ynl/pyynl/ynl_gen_c.py:1529:8: W0201: Attribute 'global_policy' defined outside __init__ (attribute-defined-outside-init) tools/net/ynl/pyynl/ynl_gen_c.py:1530:8: W0201: Attribute 'global_policy_set' defined outside __init__ (attribute-defined-outside-init) tools/net/ynl/pyynl/ynl_gen_c.py:1550:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1550:0: R0902: Too many instance attributes (13/7) (too-many-instance-attributes) tools/net/ynl/pyynl/ynl_gen_c.py:1551:4: R0913: Too many arguments (7/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:1551:4: R0917: Too many positional arguments (7/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:1565:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:1595:22: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/ynl_gen_c.py:1551:4: R0912: Too many branches (18/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:1611:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1615:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1619:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1619:0: R0902: Too many instance attributes (9/7) (too-many-instance-attributes) tools/net/ynl/pyynl/ynl_gen_c.py:1632:24: R1732: Consider using 'with' for resource-allocating operations (consider-using-with) tools/net/ynl/pyynl/ynl_gen_c.py:1638:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1646:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) tools/net/ynl/pyynl/ynl_gen_c.py:1656:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1681:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1684:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1690:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1703:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1715:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1715:4: R0913: Too many arguments (6/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:1715:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:1757:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1761:11: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck) tools/net/ynl/pyynl/ynl_gen_c.py:1769:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1769:4: R0913: Too many arguments (6/5) (too-many-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:1769:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/net/ynl/pyynl/ynl_gen_c.py:1778:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1781:12: R1731: Consider using 'longest = max(longest, len(define[0]))' instead of unnecessary if block (consider-using-max-builtin) tools/net/ynl/pyynl/ynl_gen_c.py:1787:15: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck) tools/net/ynl/pyynl/ynl_gen_c.py:1789:17: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck) tools/net/ynl/pyynl/ynl_gen_c.py:1793:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1794:18: R1728: Consider using a generator instead 'max(len(x[0]) for x in members)' (consider-using-generator) tools/net/ynl/pyynl/ynl_gen_c.py:1803:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1870:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1878:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1903:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1907:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1925:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1929:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1933:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1955:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1959:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1995:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:1999:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2020:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2020:24: W0613: Unused argument 'family' (unused-argument) tools/net/ynl/pyynl/ynl_gen_c.py:2025:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2025:20: W0613: Unused argument 'family' (unused-argument) tools/net/ynl/pyynl/ynl_gen_c.py:2036:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2045:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2101:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:2115:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:2188:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:2225:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:2087:0: R0912: Too many branches (40/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:2087:0: R0915: Too many statements (127/50) (too-many-statements) tools/net/ynl/pyynl/ynl_gen_c.py:2240:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2249:23: W0212: Access to a protected member _attr_get of a client class (protected-access) tools/net/ynl/pyynl/ynl_gen_c.py:2263:35: W0212: Access to a protected member _attr_get of a client class (protected-access) tools/net/ynl/pyynl/ynl_gen_c.py:2276:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2290:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2290:0: R1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements) tools/net/ynl/pyynl/ynl_gen_c.py:2310:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2333:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2333:0: R0912: Too many branches (15/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:2333:0: R0915: Too many statements (56/50) (too-many-statements) tools/net/ynl/pyynl/ynl_gen_c.py:2408:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2464:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2468:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2474:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2493:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2502:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2552:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2556:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2573:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2586:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2593:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2599:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2609:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2615:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2621:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2622:8: R1714: Consider merging these comparisons with 'in' by using 'ri.op_mode in ('do', 'dump')'. Use a set instead if elements are hashable. (consider-using-in) tools/net/ynl/pyynl/ynl_gen_c.py:2631:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2635:9: R1714: Consider merging these comparisons with 'in' by using 'ri.op_mode in ('notify', 'event')'. Use a set instead if elements are hashable. (consider-using-in) tools/net/ynl/pyynl/ynl_gen_c.py:2671:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2675:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2679:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2685:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2705:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2715:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2739:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2750:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2754:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2758:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2787:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2825:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2825:0: R0912: Too many branches (18/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:2892:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2896:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2898:7: R1714: Consider merging these comparisons with 'in' by using 'family.kernel_policy in ('global', 'per-op')'. Use a set instead if elements are hashable. (consider-using-in) tools/net/ynl/pyynl/ynl_gen_c.py:2925:4: R1702: Too many nested blocks (6/5) (too-many-nested-blocks) tools/net/ynl/pyynl/ynl_gen_c.py:2896:0: R0912: Too many branches (22/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:2896:0: R0915: Too many statements (59/50) (too-many-statements) tools/net/ynl/pyynl/ynl_gen_c.py:2976:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:2988:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3001:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3013:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3050:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3060:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3087:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3141:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3141:0: R0914: Too many local variables (22/15) (too-many-locals) tools/net/ynl/pyynl/ynl_gen_c.py:3254:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:3141:0: R0912: Too many branches (35/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:3141:0: R0915: Too many statements (107/50) (too-many-statements) tools/net/ynl/pyynl/ynl_gen_c.py:3296:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3311:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:3296:0: R0912: Too many branches (14/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:3313:12: W0612: Unused variable 'op_name' (unused-variable) tools/net/ynl/pyynl/ynl_gen_c.py:3339:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3349:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3359:0: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/ynl_gen_c.py:3359:0: R0914: Too many local variables (23/15) (too-many-locals) tools/net/ynl/pyynl/ynl_gen_c.py:3387:8: W0101: Unreachable code (unreachable) tools/net/ynl/pyynl/ynl_gen_c.py:3466:4: R1702: Too many nested blocks (6/5) (too-many-nested-blocks) tools/net/ynl/pyynl/ynl_gen_c.py:3572:24: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:3650:24: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/ynl_gen_c.py:3359:0: R0912: Too many branches (83/12) (too-many-branches) tools/net/ynl/pyynl/ynl_gen_c.py:3359:0: R0915: Too many statements (243/50) (too-many-statements) tools/net/ynl/pyynl/ynl_gen_c.py:3485:20: W0612: Unused variable 'op_name' (unused-variable) ------------------------------------------------------------------ Your code has been rated at 8.64/10 (previous run: 8.63/10, +0.01)