pylint 3.3.7 astroid 3.3.8 Python 3.13.5 (main, Jun 12 2025, 00:00:00) [GCC 15.1.1 20250521 (Red Hat 15.1.1-2)] Redirect to /tmp/tmp.5WgWUIGTjG and /tmp/tmp.dccVSteYML Tree base: 995989f8d97d ("tools: ynl: remove unused imports") Now at: 7afacf65bec6 ("tools: ynl: remove unnecessary semicolons") ====== Checking before the patch ====== ************* Module pyynl.lib.nlspec tools/net/ynl/pyynl/lib/nlspec.py:504:0: W0301: Unnecessary semicolon (unnecessary-semicolon) tools/net/ynl/pyynl/lib/nlspec.py:570:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/nlspec.py:573:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/nlspec.py:574:0: W0311: Bad indentation. Found 8 spaces, expected 12 (bad-indentation) tools/net/ynl/pyynl/lib/nlspec.py:575:0: W0311: Bad indentation. Found 10 spaces, expected 16 (bad-indentation) tools/net/ynl/pyynl/lib/nlspec.py:576:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/nlspec.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/net/ynl/pyynl/lib/nlspec.py:10:0: C0103: Constant name "jsonschema" doesn't conform to UPPER_CASE naming style (invalid-name) tools/net/ynl/pyynl/lib/nlspec.py:31:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:48:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:51:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:56:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:72:33: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:87:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:90:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:93:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:94:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/nlspec.py:113:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:120:23: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/nlspec.py:121:30: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/nlspec.py:128:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:131:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:136:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:142:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:149:0: R0902: Too many instance attributes (12/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/nlspec.py:170:41: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:185:30: R1714: Consider merging these comparisons with 'in' by using 'self.type in ('sint', 'uint')'. Use a set instead if elements are hashable. (consider-using-in) tools/net/ynl/pyynl/lib/nlspec.py:201:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:229:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:241:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:259:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:277:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:284:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:290:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:291:15: E1101: Instance of 'list' has no 'items' member (no-member) tools/net/ynl/pyynl/lib/nlspec.py:304:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:309:12: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/nlspec.py:312:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:312:33: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/nlspec.py:326:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:334:0: R0902: Too many instance attributes (9/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/nlspec.py:353:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:381:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/nlspec.py:401:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:406:0: R0902: Too many instance attributes (16/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/nlspec.py:432:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) tools/net/ynl/pyynl/lib/nlspec.py:436:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/nlspec.py:454:12: W0603: Using the global statement (global-statement) tools/net/ynl/pyynl/lib/nlspec.py:456:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) tools/net/ynl/pyynl/lib/nlspec.py:494:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:497:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:500:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:503:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:506:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:509:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:512:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:551:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/nlspec.py:567:22: E0606: Possibly using variable 'op' before assignment (possibly-used-before-assignment) tools/net/ynl/pyynl/lib/nlspec.py:578:4: R0912: Too many branches (15/12) (too-many-branches) tools/net/ynl/pyynl/lib/nlspec.py:516:8: W0201: Attribute 'fixed_header' defined outside __init__ (attribute-defined-outside-init) tools/net/ynl/pyynl/lib/nlspec.py:528:8: W0201: Attribute 'fixed_header' defined outside __init__ (attribute-defined-outside-init) ----------------------------------- Your code has been rated at 7.92/10 ************* Module pyynl.lib.ynl tools/net/ynl/pyynl/lib/ynl.py:103:0: W0311: Bad indentation. Found 2 spaces, expected 4 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:104:0: W0311: Bad indentation. Found 4 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:105:0: W0311: Bad indentation. Found 4 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:107:0: W0311: Bad indentation. Found 2 spaces, expected 4 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:108:0: W0311: Bad indentation. Found 4 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:275:0: C0301: Line too long (113/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:741:0: W0301: Unnecessary semicolon (unnecessary-semicolon) tools/net/ynl/pyynl/lib/ynl.py:748:0: C0301: Line too long (114/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:769:0: C0301: Line too long (107/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:801:0: C0301: Line too long (101/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:816:0: C0301: Line too long (101/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:1016:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1020:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1021:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1022:0: W0311: Bad indentation. Found 8 spaces, expected 12 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1024:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1:0: C0302: Too many lines in module (1124/1000) (too-many-lines) tools/net/ynl/pyynl/lib/ynl.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/net/ynl/pyynl/lib/ynl.py:25:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:25:0: R0903: Too few public methods (0/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:102:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:111:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:115:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:137:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:138:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:144:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:145:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:148:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:152:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:150:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:155:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:158:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:161:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:161:25: W0622: Redefining built-in 'type' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:162:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:169:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:190:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:190:0: R0902: Too many instance attributes (10/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/ynl.py:214:26: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:239:16: W0622: Redefining built-in 'type' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:271:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:283:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:283:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:297:0: C0103: Constant name "genl_family_name_to_id" doesn't conform to UPPER_CASE naming style (invalid-name) tools/net/ynl/pyynl/lib/ynl.py:324:8: W0603: Using the global statement (global-statement) tools/net/ynl/pyynl/lib/ynl.py:325:33: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:338:22: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:347:39: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:327:8: R1702: Too many nested blocks (7/5) (too-many-nested-blocks) tools/net/ynl/pyynl/lib/ynl.py:327:8: R1702: Too many nested blocks (6/5) (too-many-nested-blocks) tools/net/ynl/pyynl/lib/ynl.py:313:0: R0912: Too many branches (15/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:362:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:368:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:374:17: E1101: Instance of 'GenlMsg' has no 'raw_attrs' member (no-member) tools/net/ynl/pyynl/lib/ynl.py:379:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:390:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:390:38: W0613: Unused argument 'version' (unused-argument) tools/net/ynl/pyynl/lib/ynl.py:396:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:400:28: W0212: Access to a protected member _struct_size of a client class (protected-access) tools/net/ynl/pyynl/lib/ynl.py:404:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:406:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:409:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:413:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:417:8: W0602: Using global for 'genl_family_name_to_id' but no assignment is done (global-variable-not-assigned) tools/net/ynl/pyynl/lib/ynl.py:434:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:441:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:449:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:455:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:457:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:441:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:465:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:465:0: R0902: Too many instance attributes (8/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/ynl.py:480:12: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Family '{self.yaml['name']}' not supported by the kernel") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:480:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:510:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:516:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:529:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:549:4: R0914: Too many local variables (19/15) (too-many-locals) tools/net/ynl/pyynl/lib/ynl.py:589:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:553:12: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Space '{space}' has no attribute '{name}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:553:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:592:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:618:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:620:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:549:4: R0912: Too many branches (28/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:549:4: R0915: Too many statements (64/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:688:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:702:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:708:11: C0121: Comparison 'is_multi == None' should be 'is_multi is None' (singleton-comparison) tools/net/ynl/pyynl/lib/ynl.py:709:31: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck) tools/net/ynl/pyynl/lib/ynl.py:725:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:731:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:748:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:752:14: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:762:20: W0707: Consider explicitly re-raising using 'except (KeyError, UnboundLocalError) as exc' and 'raise Exception(f"Space '{space}' has no attribute with value '{attr.type}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:762:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:769:94: E0606: Possibly using variable 'search_attrs' before assignment (possibly-used-before-assignment) tools/net/ynl/pyynl/lib/ynl.py:801:24: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:751:4: R0912: Too many branches (21/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:751:4: R0915: Too many statements (53/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:811:4: R0913: Too many arguments (6/5) (too-many-arguments) tools/net/ynl/pyynl/lib/ynl.py:811:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/net/ynl/pyynl/lib/ynl.py:816:16: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Space '{attr_set.name}' has no attribute with value '{attr.type}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:816:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:833:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:837:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:871:20: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:861:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:887:20: W0622: Redefining built-in 'len' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:895:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:879:16: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:926:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:916:32: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:932:33: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/net/ynl/pyynl/lib/ynl.py:954:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:958:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:959:14: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:971:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:996:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1040:4: R0914: Too many local variables (20/15) (too-many-locals) tools/net/ynl/pyynl/lib/ynl.py:1095:20: R1724: Unnecessary "else" after "continue", remove the "else" and de-indent the code inside it (no-else-continue) tools/net/ynl/pyynl/lib/ynl.py:1040:4: R0912: Too many branches (17/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:1040:4: R0915: Too many statements (54/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:1117:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1120:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1123:4: C0116: Missing function or method docstring (missing-function-docstring) ------------------------------------------------------------------ Your code has been rated at 8.45/10 (previous run: 8.45/10, +0.00) ====== Checking the tree with the patch ====== ************* Module pyynl.lib.nlspec tools/net/ynl/pyynl/lib/nlspec.py:570:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/nlspec.py:573:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/nlspec.py:574:0: W0311: Bad indentation. Found 8 spaces, expected 12 (bad-indentation) tools/net/ynl/pyynl/lib/nlspec.py:575:0: W0311: Bad indentation. Found 10 spaces, expected 16 (bad-indentation) tools/net/ynl/pyynl/lib/nlspec.py:576:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/nlspec.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/net/ynl/pyynl/lib/nlspec.py:10:0: C0103: Constant name "jsonschema" doesn't conform to UPPER_CASE naming style (invalid-name) tools/net/ynl/pyynl/lib/nlspec.py:31:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:48:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:51:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:56:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:72:33: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:87:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:90:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:93:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:94:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/nlspec.py:113:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:120:23: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/nlspec.py:121:30: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/nlspec.py:128:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:131:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:136:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:142:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:149:0: R0902: Too many instance attributes (12/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/nlspec.py:170:41: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:185:30: R1714: Consider merging these comparisons with 'in' by using 'self.type in ('sint', 'uint')'. Use a set instead if elements are hashable. (consider-using-in) tools/net/ynl/pyynl/lib/nlspec.py:201:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:229:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:241:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:259:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:277:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:284:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:290:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:291:15: E1101: Instance of 'list' has no 'items' member (no-member) tools/net/ynl/pyynl/lib/nlspec.py:304:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:309:12: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/nlspec.py:312:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:312:33: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/nlspec.py:326:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:334:0: R0902: Too many instance attributes (9/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/nlspec.py:353:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:381:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/nlspec.py:401:31: W0621: Redefining name 'yaml' from outer scope (line 6) (redefined-outer-name) tools/net/ynl/pyynl/lib/nlspec.py:406:0: R0902: Too many instance attributes (16/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/nlspec.py:432:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) tools/net/ynl/pyynl/lib/nlspec.py:436:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/nlspec.py:454:12: W0603: Using the global statement (global-statement) tools/net/ynl/pyynl/lib/nlspec.py:456:17: W1514: Using open without explicitly specifying an encoding (unspecified-encoding) tools/net/ynl/pyynl/lib/nlspec.py:494:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:497:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:500:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:503:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:506:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:509:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:512:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/nlspec.py:551:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/nlspec.py:567:22: E0606: Possibly using variable 'op' before assignment (possibly-used-before-assignment) tools/net/ynl/pyynl/lib/nlspec.py:578:4: R0912: Too many branches (15/12) (too-many-branches) tools/net/ynl/pyynl/lib/nlspec.py:516:8: W0201: Attribute 'fixed_header' defined outside __init__ (attribute-defined-outside-init) tools/net/ynl/pyynl/lib/nlspec.py:528:8: W0201: Attribute 'fixed_header' defined outside __init__ (attribute-defined-outside-init) ------------------------------------------------------------------ Your code has been rated at 7.95/10 (previous run: 7.92/10, +0.03) ************* Module pyynl.lib.ynl tools/net/ynl/pyynl/lib/ynl.py:103:0: W0311: Bad indentation. Found 2 spaces, expected 4 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:104:0: W0311: Bad indentation. Found 4 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:105:0: W0311: Bad indentation. Found 4 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:107:0: W0311: Bad indentation. Found 2 spaces, expected 4 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:108:0: W0311: Bad indentation. Found 4 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:275:0: C0301: Line too long (113/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:748:0: C0301: Line too long (114/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:769:0: C0301: Line too long (107/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:801:0: C0301: Line too long (101/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:816:0: C0301: Line too long (101/100) (line-too-long) tools/net/ynl/pyynl/lib/ynl.py:1016:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1020:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1021:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1022:0: W0311: Bad indentation. Found 8 spaces, expected 12 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1024:0: W0311: Bad indentation. Found 6 spaces, expected 8 (bad-indentation) tools/net/ynl/pyynl/lib/ynl.py:1:0: C0302: Too many lines in module (1124/1000) (too-many-lines) tools/net/ynl/pyynl/lib/ynl.py:1:0: C0114: Missing module docstring (missing-module-docstring) tools/net/ynl/pyynl/lib/ynl.py:25:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:25:0: R0903: Too few public methods (0/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:102:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:111:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:115:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:137:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:138:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:144:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:145:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:148:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:152:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:150:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:155:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:158:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:161:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:161:25: W0622: Redefining built-in 'type' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:162:8: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:169:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:190:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:190:0: R0902: Too many instance attributes (10/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/ynl.py:214:26: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:239:16: W0622: Redefining built-in 'type' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:271:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:283:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:283:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:297:0: C0103: Constant name "genl_family_name_to_id" doesn't conform to UPPER_CASE naming style (invalid-name) tools/net/ynl/pyynl/lib/ynl.py:324:8: W0603: Using the global statement (global-statement) tools/net/ynl/pyynl/lib/ynl.py:325:33: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:338:22: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:347:39: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:327:8: R1702: Too many nested blocks (7/5) (too-many-nested-blocks) tools/net/ynl/pyynl/lib/ynl.py:327:8: R1702: Too many nested blocks (6/5) (too-many-nested-blocks) tools/net/ynl/pyynl/lib/ynl.py:313:0: R0912: Too many branches (15/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:362:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:368:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:374:17: E1101: Instance of 'GenlMsg' has no 'raw_attrs' member (no-member) tools/net/ynl/pyynl/lib/ynl.py:379:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:390:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:390:38: W0613: Unused argument 'version' (unused-argument) tools/net/ynl/pyynl/lib/ynl.py:396:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:400:28: W0212: Access to a protected member _struct_size of a client class (protected-access) tools/net/ynl/pyynl/lib/ynl.py:404:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:406:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:409:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:413:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:417:8: W0602: Using global for 'genl_family_name_to_id' but no assignment is done (global-variable-not-assigned) tools/net/ynl/pyynl/lib/ynl.py:434:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:441:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:449:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:455:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:457:8: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:441:0: R0903: Too few public methods (1/2) (too-few-public-methods) tools/net/ynl/pyynl/lib/ynl.py:465:0: C0115: Missing class docstring (missing-class-docstring) tools/net/ynl/pyynl/lib/ynl.py:465:0: R0902: Too many instance attributes (8/7) (too-many-instance-attributes) tools/net/ynl/pyynl/lib/ynl.py:480:12: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Family '{self.yaml['name']}' not supported by the kernel") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:480:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:510:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:516:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:529:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:549:4: R0914: Too many local variables (19/15) (too-many-locals) tools/net/ynl/pyynl/lib/ynl.py:589:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:553:12: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Space '{space}' has no attribute '{name}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:553:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:592:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:618:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:620:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:549:4: R0912: Too many branches (28/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:549:4: R0915: Too many statements (64/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:688:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:702:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:708:11: C0121: Comparison 'is_multi == None' should be 'is_multi is None' (singleton-comparison) tools/net/ynl/pyynl/lib/ynl.py:709:31: C0123: Use isinstance() rather than type() for a typecheck. (unidiomatic-typecheck) tools/net/ynl/pyynl/lib/ynl.py:725:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:731:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:748:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:752:14: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:762:20: W0707: Consider explicitly re-raising using 'except (KeyError, UnboundLocalError) as exc' and 'raise Exception(f"Space '{space}' has no attribute with value '{attr.type}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:762:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:769:94: E0606: Possibly using variable 'search_attrs' before assignment (possibly-used-before-assignment) tools/net/ynl/pyynl/lib/ynl.py:801:24: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:751:4: R0912: Too many branches (21/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:751:4: R0915: Too many statements (53/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:811:4: R0913: Too many arguments (6/5) (too-many-arguments) tools/net/ynl/pyynl/lib/ynl.py:811:4: R0917: Too many positional arguments (6/5) (too-many-positional-arguments) tools/net/ynl/pyynl/lib/ynl.py:816:16: W0707: Consider explicitly re-raising using 'except KeyError as exc' and 'raise Exception(f"Space '{attr_set.name}' has no attribute with value '{attr.type}'") from exc' (raise-missing-from) tools/net/ynl/pyynl/lib/ynl.py:816:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:833:20: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:837:16: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:871:20: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:861:8: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return) tools/net/ynl/pyynl/lib/ynl.py:887:20: W0622: Redefining built-in 'len' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:895:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:879:16: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:926:16: W0622: Redefining built-in 'format' (redefined-builtin) tools/net/ynl/pyynl/lib/ynl.py:916:32: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:932:33: C0209: Formatting a regular string which could be an f-string (consider-using-f-string) tools/net/ynl/pyynl/lib/ynl.py:954:12: W0719: Raising too general exception: Exception (broad-exception-raised) tools/net/ynl/pyynl/lib/ynl.py:958:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:959:14: R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal) tools/net/ynl/pyynl/lib/ynl.py:971:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:996:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1040:4: R0914: Too many local variables (20/15) (too-many-locals) tools/net/ynl/pyynl/lib/ynl.py:1095:20: R1724: Unnecessary "else" after "continue", remove the "else" and de-indent the code inside it (no-else-continue) tools/net/ynl/pyynl/lib/ynl.py:1040:4: R0912: Too many branches (17/12) (too-many-branches) tools/net/ynl/pyynl/lib/ynl.py:1040:4: R0915: Too many statements (54/50) (too-many-statements) tools/net/ynl/pyynl/lib/ynl.py:1117:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1120:4: C0116: Missing function or method docstring (missing-function-docstring) tools/net/ynl/pyynl/lib/ynl.py:1123:4: C0116: Missing function or method docstring (missing-function-docstring) ------------------------------------------------------------------ Your code has been rated at 8.46/10 (previous run: 8.45/10, +0.01)