====== Checking before the patch ====== ====== Checking the tree with the patch ====== New warnings added --- /tmp/tmp.Fk4SRQpaf1 2025-09-09 10:27:23.833617352 -0700 +++ /tmp/tmp.iFg8LdyzrP 2025-09-09 10:27:25.767603960 -0700 @@ -2 +2 @@ -In openvswitch.sh line 33: +In openvswitch.sh line 34: @@ -11 +11 @@ -In openvswitch.sh line 34: +In openvswitch.sh line 35: @@ -21 +21 @@ -In openvswitch.sh line 38: +In openvswitch.sh line 39: @@ -26 +26 @@ -In openvswitch.sh line 61: +In openvswitch.sh line 62: @@ -34 +34 @@ -In openvswitch.sh line 68: +In openvswitch.sh line 69: @@ -39 +39 @@ -In openvswitch.sh line 72: +In openvswitch.sh line 73: @@ -47 +47 @@ -In openvswitch.sh line 77: +In openvswitch.sh line 78: @@ -55 +55 @@ -In openvswitch.sh line 81: +In openvswitch.sh line 82: @@ -64 +64 @@ -In openvswitch.sh line 85: +In openvswitch.sh line 86: @@ -72 +72 @@ -In openvswitch.sh line 86: +In openvswitch.sh line 87: @@ -81 +81 @@ -In openvswitch.sh line 87: +In openvswitch.sh line 88: @@ -90 +90 @@ -In openvswitch.sh line 91: +In openvswitch.sh line 92: @@ -95 +95 @@ -In openvswitch.sh line 95: +In openvswitch.sh line 96: @@ -104 +104 @@ -In openvswitch.sh line 100: +In openvswitch.sh line 101: @@ -112 +112 @@ -In openvswitch.sh line 101: +In openvswitch.sh line 102: @@ -121 +121 @@ -In openvswitch.sh line 103: +In openvswitch.sh line 104: @@ -129 +129 @@ -In openvswitch.sh line 111: +In openvswitch.sh line 112: @@ -139,2 +139,2 @@ -In openvswitch.sh line 118: - ovs_sbx "$1" python3 $ovs_base/ovs-dpctl.py add-if "$2" "$3" \ +In openvswitch.sh line 119: + ovs_sbx "$1" python3 $ovs_base/ovs-dpctl.py add-if \ @@ -144 +144 @@ - ovs_sbx "$1" python3 "$ovs_base"/ovs-dpctl.py add-if "$2" "$3" \ + ovs_sbx "$1" python3 "$ovs_base"/ovs-dpctl.py add-if \ @@ -147 +147 @@ -In openvswitch.sh line 121: +In openvswitch.sh line 122: @@ -155,6 +155,6 @@ -In openvswitch.sh line 122: - -u "$2" "$3" >$ovs_dir/$3.out 2>$ovs_dir/$3.err & - ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. - ^-- SC2086 (info): Double quote to prevent globbing and word splitting. - ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. - ^-- SC2086 (info): Double quote to prevent globbing and word splitting. +In openvswitch.sh line 123: + -u -t "$2" "$3" "$4" >$ovs_dir/$4.out 2>$ovs_dir/$4.err & + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-- SC2086 (info): Double quote to prevent globbing and word splitting. + ^------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-- SC2086 (info): Double quote to prevent globbing and word splitting. @@ -163 +163 @@ - -u "$2" "$3" >"$ovs_dir"/"$3".out 2>"$ovs_dir"/"$3".err & + -u -t "$2" "$3" "$4" >"$ovs_dir"/"$4".out 2>"$ovs_dir"/"$4".err & @@ -166 +166 @@ -In openvswitch.sh line 130: +In openvswitch.sh line 131: @@ -174 +174 @@ -In openvswitch.sh line 139: +In openvswitch.sh line 140: @@ -184 +184 @@ -In openvswitch.sh line 141: +In openvswitch.sh line 142: @@ -196 +196 @@ -In openvswitch.sh line 150: +In openvswitch.sh line 151: @@ -206 +206 @@ -In openvswitch.sh line 174: +In openvswitch.sh line 175: @@ -214 +214 @@ -In openvswitch.sh line 176: +In openvswitch.sh line 177: @@ -222 +222 @@ -In openvswitch.sh line 184: +In openvswitch.sh line 185: @@ -230 +230 @@ -In openvswitch.sh line 185: +In openvswitch.sh line 186: @@ -235 +235 @@ -In openvswitch.sh line 194: +In openvswitch.sh line 195: @@ -243 +243 @@ -In openvswitch.sh line 202: +In openvswitch.sh line 203: @@ -253 +253 @@ -In openvswitch.sh line 203: +In openvswitch.sh line 204: @@ -262 +262 @@ -In openvswitch.sh line 211: +In openvswitch.sh line 212: @@ -272 +272 @@ -In openvswitch.sh line 214: +In openvswitch.sh line 215: @@ -282 +282 @@ -In openvswitch.sh line 221: +In openvswitch.sh line 222: @@ -288 +288 @@ -In openvswitch.sh line 265: +In openvswitch.sh line 266: @@ -296 +296 @@ -In openvswitch.sh line 279: +In openvswitch.sh line 280: @@ -304 +304 @@ -In openvswitch.sh line 280: +In openvswitch.sh line 281: @@ -313 +313 @@ -In openvswitch.sh line 304: +In openvswitch.sh line 305: @@ -321 +321 @@ -In openvswitch.sh line 311: +In openvswitch.sh line 312: @@ -329 +329 @@ -In openvswitch.sh line 312: +In openvswitch.sh line 313: @@ -337 +337 @@ -In openvswitch.sh line 318: +In openvswitch.sh line 319: @@ -345 +345 @@ -In openvswitch.sh line 322: +In openvswitch.sh line 323: @@ -353 +353 @@ -In openvswitch.sh line 324: +In openvswitch.sh line 325: @@ -361 +361 @@ -In openvswitch.sh line 332: +In openvswitch.sh line 333: @@ -369 +369 @@ -In openvswitch.sh line 333: +In openvswitch.sh line 334: @@ -377 +377 @@ -In openvswitch.sh line 363: +In openvswitch.sh line 364: @@ -385 +385 @@ -In openvswitch.sh line 381: +In openvswitch.sh line 382: @@ -393 +393 @@ -In openvswitch.sh line 398: +In openvswitch.sh line 399: @@ -401 +401 @@ -In openvswitch.sh line 406: +In openvswitch.sh line 407: @@ -409 +409 @@ -In openvswitch.sh line 421: +In openvswitch.sh line 422: @@ -417 +417 @@ -In openvswitch.sh line 436: +In openvswitch.sh line 437: @@ -425 +425 @@ -In openvswitch.sh line 442: +In openvswitch.sh line 443: @@ -433 +433 @@ -In openvswitch.sh line 462: +In openvswitch.sh line 463: @@ -441 +441 @@ -In openvswitch.sh line 513: +In openvswitch.sh line 514: @@ -446 +446 @@ -In openvswitch.sh line 567: +In openvswitch.sh line 568: @@ -454 +454 @@ -In openvswitch.sh line 615: +In openvswitch.sh line 616: @@ -459 +459 @@ -In openvswitch.sh line 629: +In openvswitch.sh line 630: @@ -467 +467 @@ -In openvswitch.sh line 706: +In openvswitch.sh line 707: @@ -477 +477 @@ -In openvswitch.sh line 710: +In openvswitch.sh line 711: @@ -487 +487 @@ -In openvswitch.sh line 749: +In openvswitch.sh line 750: @@ -495 +495 @@ -In openvswitch.sh line 753: +In openvswitch.sh line 754: @@ -504 +504 @@ -In openvswitch.sh line 755: +In openvswitch.sh line 756: @@ -512 +512,101 @@ -In openvswitch.sh line 782: +In openvswitch.sh line 768: + ovs_sbx "${sbxname}" ip -netns ${ns} link add dev ${name} type ${tnl_type} $* || return 1 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-- SC2048 (warning): Use "$@" (with quotes) to prevent whitespace problems. + ^-- SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ovs_sbx "${sbxname}" ip -netns "${ns}" link add dev "${name}" type "${tnl_type}" "$*" || return 1 + + +In openvswitch.sh line 770: + ovs_sbx "${sbxname}" ip -netns ${ns} addr add dev ${name} ${addr} || return 1 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ovs_sbx "${sbxname}" ip -netns "${ns}" addr add dev "${name}" "${addr}" || return 1 + + +In openvswitch.sh line 771: + ovs_sbx "${sbxname}" ip -netns ${ns} link set dev ${name} mtu 1450 up || return 1 + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ovs_sbx "${sbxname}" ip -netns "${ns}" link set dev "${name}" mtu 1450 up || return 1 + + +In openvswitch.sh line 775: + which arping >/dev/null 2>&1 || return $ksft_skip + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + which arping >/dev/null 2>&1 || return "$ksft_skip" + + +In openvswitch.sh line 804: + ovs_add_kernel_tunnel "${sbxname}" tns vxlan vxlan${i} ${addr} \ + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ovs_add_kernel_tunnel "${sbxname}" tns vxlan vxlan"${i}" "${addr}" \ + + +In openvswitch.sh line 805: + remote 172.31.110.2 id ${id} dstport 4789 \ + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + remote 172.31.110.2 id "${id}" dstport 4789 \ + + +In openvswitch.sh line 806: + ttl ${ttl} df ${df} ${csum} || return 1 + ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^---^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + ttl "${ttl}" df "${df}" "${csum}" || return 1 + + +In openvswitch.sh line 810: + ${ovs_dir}/ovs-vxlan0.out || return 1 + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + "${ovs_dir}"/ovs-vxlan0.out || return 1 + + +In openvswitch.sh line 815: + arping -I vxlan${i} 172.31.22${i}.2 -c 1 \ + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + arping -I vxlan"${i}" 172.31.22"${i}".2 -c 1 \ + + +In openvswitch.sh line 816: + >${ovs_dir}/arping.stdout 2>${ovs_dir}/arping.stderr + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + >"${ovs_dir}"/arping.stdout 2>"${ovs_dir}"/arping.stderr + + +In openvswitch.sh line 827: + ${ovs_dir}/ovs-vxlan0.out || return 1 + ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting. + +Did you mean: + "${ovs_dir}"/ovs-vxlan0.out || return 1 + + +In openvswitch.sh line 856: @@ -520 +620 @@ -In openvswitch.sh line 794: +In openvswitch.sh line 868: @@ -526 +626 @@ -In openvswitch.sh line 802: +In openvswitch.sh line 876: @@ -534 +634 @@ -In openvswitch.sh line 811: +In openvswitch.sh line 885: @@ -539 +639 @@ -In openvswitch.sh line 814: +In openvswitch.sh line 888: @@ -544 +644 @@ -In openvswitch.sh line 845: +In openvswitch.sh line 919: