========== checkpatch - FAILED WARNING: line length of 136 exceeds 80 columns #62: FILE: net/ax25/af_ax25.c:1963: + * magic dev src_addr dest_addr,digi1,digi2,.. st vs vr va t1/t1 t2/t2 t3/t3 idle/idle n2/n2 rtt window paclen Snd-Q Rcv-Q inode CHECK: Alignment should match open parenthesis #68: FILE: net/ax25/af_ax25.c:1968: + seq_printf(seq, + "magic dev src_addr dest_addr digi1 \ WARNING: Avoid line continuations in quoted strings #68: FILE: net/ax25/af_ax25.c:1968: + "magic dev src_addr dest_addr digi1 \ CHECK: Unbalanced braces around else statement #71: FILE: net/ax25/af_ax25.c:1971: + else { CHECK: Alignment should match open parenthesis #73: FILE: net/ax25/af_ax25.c:1973: + seq_printf(seq, "%p %s %-9s%s", ax25, ERROR: spaces required around that '?' (ctx:VxW) #78: FILE: net/ax25/af_ax25.c:1976: + ax25->iamdigi? "*":" "); ^ CHECK: spaces required around that ':' (ctx:VxV) #78: FILE: net/ax25/af_ax25.c:1976: + ax25->iamdigi? "*":" "); ^ CHECK: Comparison to NULL could be written "!ax25->digipeat" #86: FILE: net/ax25/af_ax25.c:1979: + if (ax25->digipeat == NULL) { ERROR: space required after that ',' (ctx:VxV) #87: FILE: net/ax25/af_ax25.c:1980: + strcpy(buf,"-"); ^ WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #87: FILE: net/ax25/af_ax25.c:1980: + strcpy(buf,"-"); ERROR: space required after that ',' (ctx:VxV) #88: FILE: net/ax25/af_ax25.c:1981: + seq_printf(seq, " %-9s %-9s ", buf,buf); ^ ERROR: else should follow close brace '}' #90: FILE: net/ax25/af_ax25.c:1983: + } + else { CHECK: Unbalanced braces around else statement #90: FILE: net/ax25/af_ax25.c:1983: + else { ERROR: spaces required around that '=' (ctx:VxV) #91: FILE: net/ax25/af_ax25.c:1984: + for (k=0; k < ax25->digipeat->ndigi; k++) { ^ CHECK: Alignment should match open parenthesis #93: FILE: net/ax25/af_ax25.c:1986: + seq_printf(seq, "%-9s%s", + ax2asc(buf, &ax25->digipeat->calls[k]), ERROR: spaces required around that '?' (ctx:VxW) #94: FILE: net/ax25/af_ax25.c:1987: + ax25->digipeat->repeated[k]? "*":" "); ^ CHECK: spaces required around that ':' (ctx:VxV) #94: FILE: net/ax25/af_ax25.c:1987: + ax25->digipeat->repeated[k]? "*":" "); ^ CHECK: Alignment should match open parenthesis #100: FILE: net/ax25/af_ax25.c:1992: + seq_printf(seq, "%d %d %d %d %2lu/%02lu %lu/%lu %3lu/%lu %lu/%lu %2d/%2d %3lu %3d %3d", ax25->state, CHECK: braces {} should be used on all arms of this statement #109: FILE: net/ax25/af_ax25.c:2004: + if (ax25->sk != NULL) { [...] - } else { [...] CHECK: Comparison to NULL could be written "ax25->sk" #109: FILE: net/ax25/af_ax25.c:2004: + if (ax25->sk != NULL) { CHECK: Alignment should match open parenthesis #111: FILE: net/ax25/af_ax25.c:2006: + seq_printf(seq, " %-3d %-3d %lu\n", sk_wmem_alloc_get(ax25->sk), CHECK: Unbalanced braces around else statement #116: FILE: net/ax25/af_ax25.c:2009: + } else CHECK: From:/Signed-off-by: email comments mismatch: 'From: Bernard Pidoux ' != 'Signed-off-by: Bernard Pidoux ' total: 6 errors, 3 warnings, 14 checks, 72 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit ba9ae19619e2 ("fix lack of /proc/net/ax25 labels header") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.