========== checkpatch - FAILED WARNING: line length of 118 exceeds 80 columns #39: FILE: tools/testing/selftests/bpf/progs/bpf_misc.h:149: +#define __stderr(msg) __attribute__((btf_decl_tag("comment:test_expect_stderr=" XSTR(__COUNTER__) "=" msg))) WARNING: line length of 125 exceeds 80 columns #40: FILE: tools/testing/selftests/bpf/progs/bpf_misc.h:150: +#define __stderr_unpriv(msg) __attribute__((btf_decl_tag("comment:test_expect_stderr_unpriv=" XSTR(__COUNTER__) "=" msg))) WARNING: line length of 118 exceeds 80 columns #41: FILE: tools/testing/selftests/bpf/progs/bpf_misc.h:151: +#define __stdout(msg) __attribute__((btf_decl_tag("comment:test_expect_stdout=" XSTR(__COUNTER__) "=" msg))) WARNING: line length of 125 exceeds 80 columns #42: FILE: tools/testing/selftests/bpf/progs/bpf_misc.h:152: +#define __stdout_unpriv(msg) __attribute__((btf_decl_tag("comment:test_expect_stdout_unpriv=" XSTR(__COUNTER__) "=" msg))) WARNING: line length of 85 exceeds 80 columns #96: FILE: tools/testing/selftests/bpf/test_loader.c:615: + } else if ((msg = skip_dynamic_pfx(s, TEST_TAG_EXPECT_STDERR_PFX))) { ERROR: do not use assignment in if condition #96: FILE: tools/testing/selftests/bpf/test_loader.c:615: + } else if ((msg = skip_dynamic_pfx(s, TEST_TAG_EXPECT_STDERR_PFX))) { WARNING: line length of 92 exceeds 80 columns #101: FILE: tools/testing/selftests/bpf/test_loader.c:620: + } else if ((msg = skip_dynamic_pfx(s, TEST_TAG_EXPECT_STDERR_PFX_UNPRIV))) { ERROR: do not use assignment in if condition #101: FILE: tools/testing/selftests/bpf/test_loader.c:620: + } else if ((msg = skip_dynamic_pfx(s, TEST_TAG_EXPECT_STDERR_PFX_UNPRIV))) { WARNING: line length of 85 exceeds 80 columns #106: FILE: tools/testing/selftests/bpf/test_loader.c:625: + } else if ((msg = skip_dynamic_pfx(s, TEST_TAG_EXPECT_STDOUT_PFX))) { ERROR: do not use assignment in if condition #106: FILE: tools/testing/selftests/bpf/test_loader.c:625: + } else if ((msg = skip_dynamic_pfx(s, TEST_TAG_EXPECT_STDOUT_PFX))) { WARNING: line length of 92 exceeds 80 columns #111: FILE: tools/testing/selftests/bpf/test_loader.c:630: + } else if ((msg = skip_dynamic_pfx(s, TEST_TAG_EXPECT_STDOUT_PFX_UNPRIV))) { ERROR: do not use assignment in if condition #111: FILE: tools/testing/selftests/bpf/test_loader.c:630: + } else if ((msg = skip_dynamic_pfx(s, TEST_TAG_EXPECT_STDOUT_PFX_UNPRIV))) { WARNING: line length of 81 exceeds 80 columns #145: FILE: tools/testing/selftests/bpf/test_loader.c:764: + fprintf(stdout, "STDOUT:\n=============\n%s=============\n", bpf_stdout); WARNING: line length of 99 exceeds 80 columns #180: FILE: tools/testing/selftests/bpf/test_loader.c:1181: + PRINT_FAIL("Unexpected retval from get_stream(): %d, errno = %d\n", WARNING: line length of 86 exceeds 80 columns #185: FILE: tools/testing/selftests/bpf/test_loader.c:1186: + validate_msgs(tester->log_buf, &subspec->stderr, emit_stderr); WARNING: line length of 99 exceeds 80 columns #192: FILE: tools/testing/selftests/bpf/test_loader.c:1193: + PRINT_FAIL("Unexpected retval from get_stream(): %d, errno = %d\n", WARNING: line length of 86 exceeds 80 columns #197: FILE: tools/testing/selftests/bpf/test_loader.c:1198: + validate_msgs(tester->log_buf, &subspec->stdout, emit_stdout); total: 4 errors, 13 warnings, 0 checks, 166 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 8358f3f9a0b3 ("selftests: bpf: introduce __stderr and __stdout") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.